facio 0.1.15 → 0.1.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b6480a8cab348b66eb9f4987d4c56ee773faf649d9cfd937434a6afd3f822ac3
-  data.tar.gz: 4f2bc2289286be83807973409daee4f845faca070abaae9f383326b38cef5f4e
+  metadata.gz: d340a59ed3ac5e635d5eb4f0ffd36dba7c9f48ac6e46eb2ef9f3b9d1b83c01b2
+  data.tar.gz: 056cdd8cbc0b68be37615c9077510ec506a7ac89fb18f27072ff9f8a63ad61e9
 SHA512:
-  metadata.gz: b685cee0737c95408dd2a5199e76f510f525339464dc104a5d97706c5d0309222b5bc2bb205cea818be77ec2358deb817d54bafa26e4ba389840f020f164c7e3
-  data.tar.gz: 544bff591787982d6249968921a919a3396cc13d8c56197b94aaceb32a2a9f7ebc656b5530db112dd7ef6dc42c602502fb8992b465f1de6bbe3149c3d274b5e2
+  metadata.gz: 10e473dbee725d09d3ae2a661aaaaf865941452a49131206b5828401ab0a3d62f45a2d378b7b56a796d981d4d4803c4848399b90f75136b2446beb0fa3cd6584
+  data.tar.gz: 7178d9571ad1ef46ef5ecc0bdef1574871b872476ff2392cc54da2ddc77abb92b7f7bb76770ff6eb1b6ac9dc164a91204c4f84e0a599ff8b77de34537d01925f

data/README.md

@@ -76,14 +76,22 @@ In this case, once the service is done, you should see the Message's text being
 
 Services are subclasses of ActiveJob::Base, which basically gives you things like concurrency control and retry logic.
 
+As a Facio::Service is just an ActiveJob, perform_later will return the service if enqueued successfully, or false if the context is invalid. If you want to inspect the context you can do so by passing a block to perform_later:
+
+```ruby
+SimpleService.perform_later(value: "no lemon, no melon") do |job|
+  puts job.context.errors.full_messages
+end
+
 ### Context
 
 A context is just an PORO, which includes the ActiveModel::API, which includes validation. You can add validation to the context, 
 Facio will check the validity of the context before performing the service. Context can be created in separate files, but also inline in the service. 
 
-It has some useful extra's allowing for associations (has_one/has_many), it also has a type caster for models, so that you can pass the id or the model itself into an attribute.
+It has some useful extras allowing for associations (has_one/has_many), it also has a type caster for models, so that you can pass the id or the model itself into an attribute.
 
 Using context like below (inline) will then construct a Class, with Facio::Context as a base_class. You can also use external context classes and refer to the in the inline class using the base_class.
+
 ```ruby
 # some_context.rb
 class SomeContext < Facio::Context
@@ -135,9 +143,16 @@ class InlineResultService < Facio::Service
     result.text = context.value.to_s.reverse
   end
 end
-
 ```
 
+## Notes
+
+Facio uses two around callbacks, one for the enqueue and one for the perform.
+The `around_enqueue` callback will check the validity of the context, and if it's invalid, it will not enqueue the job.
+The `around_perform` callback will again check the validity of the context, and if it's invalid, it will not perform the job.
+
+If you use callbacks yourself in your service, in some cases you might want to inspect the callback ordering.
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/facio/concerns/callbacks.rb

@@ -16,7 +16,6 @@ module Callbacks
             # This is the most close to expected behaviour this can get.
             raise ActiveRecord::Rollback if context.failed?
           end
-
         else
           result = block.call
         end
@@ -27,10 +26,12 @@ module Callbacks
       end
     end
 
-    before_enqueue do |job|
+    around_enqueue do |job, block|
       @performed = false
       @context = self.class.context_class.new(arguments.first)
       @result = self.class.result_class&.new
+
+      block.call if @context.valid?
     end
   end
 end

data/lib/facio/concerns/execution.rb

@@ -4,29 +4,7 @@ module Execution
   # Facio doesn't support arguments in the perform method, that's done with the context object.
   # This is why we override perform here.
   def facio_perform_with_arguments(*args)
-    @context = self.class.context_class.new(arguments.first)
-    @result = self.class.result_class&.new
-    @performed = false
-
-    if @context.valid?
-      result = nil
-      if transactional && defined?(ActiveRecord::Base)
-        ActiveRecord::Base.transaction(requires_new: true) do
-          # result = block.call
-          result = facio_perform_without_arguments
-          # This will only rollback the changes of the service, SILENTLY, however the context will be failed? already.
-          # This is the most close to expected behaviour this can get.
-          raise ActiveRecord::Rollback if context.failed?
-        end
-
-      else
-        result = facio_perform_without_arguments
-      end
-
-      @performed = true
-      # Purely as a convenience, but also to enforce a standard
-      context.result ||= result if @result.nil?
-    end
+    facio_perform_without_arguments
   end
 
   included do
@@ -35,7 +13,10 @@ module Execution
         if method_name == :perform
           # Avoid reentrance
           unless method_defined?(:facio_perform_without_arguments)
+            # We copy the user defined perform method on the job and set it aside
             alias_method :facio_perform_without_arguments, :perform
+            # We take or method above and set that as the new perform method
+            # This way we can pass the arguments to the context object
             alias_method :perform, :facio_perform_with_arguments # This invokes method_added(:perform)
           end
         end

data/lib/facio/service.rb

@@ -11,6 +11,7 @@ module Facio
     include ServiceResult
     include Transactional
     include Translations
+    include Callbacks
     include Execution
 
     class << self
@@ -20,20 +21,6 @@ module Facio
         job
       end
 
-      def perform_later(...)
-        job = job_or_instantiate(...)
-
-        enqueue_result = job.enqueue
-
-        job.instance_variable_set(:@performed, false)
-        job.instance_variable_set(:@context, context_class.new(job.arguments.first))
-        job.instance_variable_set(:@result, result_class&.new)
-
-        yield job if block_given?
-
-        enqueue_result
-      end
-
       alias_method :perform_now, :perform
     end
 

data/lib/facio/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Facio
-  VERSION = "0.1.15"
+  VERSION = "0.1.16"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: facio
 version: !ruby/object:Gem::Version
-  version: 0.1.15
+  version: 0.1.16
 platform: ruby
 authors:
 - Tom de Grunt
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-15 00:00:00.000000000 Z
+date: 2026-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack