faces 0.6.0 → 0.6.1

data/VERSION

@@ -1 +1 @@
-0.6.0
+0.6.1

data/faces.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{faces}
-  s.version = "0.6.0"
+  s.version = "0.6.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Nick Pellant"]
-  s.date = %q{2010-03-18}
+  s.date = %q{2010-03-29}
   s.description = %q{Avatars made super simple.}
   s.email = %q{nick@silentale.com}
   s.extra_rdoc_files = [

data/lib/faces.rb

@@ -4,6 +4,7 @@ require 'net/http'
 require 'net/https'
 require 'rexml/document'
 require 'digest/md5'
+require 'cgi'
 
 module Faces
   module Configuration
@@ -101,7 +102,7 @@ module Faces
     end
     # Builds a url query parameter string
     def build_param(key, value, first = false)
-      value.present? ? (first == true ? "?#{key}=#{value}" : "&#{key}=#{value}") : ''
+      value.present? ? (first == true ? "?#{key}=#{CGI.escape(value.to_s)}" : "&#{key}=#{CGI.escape(value.to_s)}") : ''
     end
     
     module_function :merge_configurations, :build_param

data/test/test_faces.rb

@@ -70,4 +70,16 @@ class FacesTest < Test::Unit::TestCase
     result = ::Faces::Public.provider_supports_ssl?('twitter')  
     assert !result
   end
+  
+  ################################
+  #--- build_params_string ---#
+  ################################
+  def test_build_params_should_accept_a_first_parameter
+    assert_match /\A\?.*/, Faces::Common.build_param('a', 'b', first = true)
+    assert_match /\A&.*/, Faces::Common.build_param('a', 'b', first = false)
+  end
+  
+  def test_build_params_should_encode_values
+    assert_equal '?url=http%3A%2F%2Fx.y.com%3Fa%3Db', Faces::Common.build_param('url', 'http://x.y.com?a=b', first = true)
+  end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 6
-  - 0
-  version: 0.6.0
+  - 1
+  version: 0.6.1
 platform: ruby
 authors: 
 - Nick Pellant
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-18 00:00:00 +01:00
+date: 2010-03-29 00:00:00 +02:00
 default_executable: 
 dependencies: []