facebooker 1.0.66 → 1.0.67

data/facebooker.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{facebooker}
-  s.version = "1.0.66"
+  s.version = "1.0.67"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Chad Fowler", "Patrick Ewing", "Mike Mangino", "Shane Vitarana", "Corey Innis", "Mike Mangino"]
-  s.date = %q{2010-03-24}
+  s.date = %q{2010-03-30}
   s.description = %q{Facebooker is a Ruby wrapper over the Facebook[http://facebook.com] {REST API}[http://wiki.developers.facebook.com/index.php/API].  Its goals are:
 
 * Idiomatic Ruby

data/lib/facebooker/parser.rb

@@ -84,7 +84,12 @@ module Facebooker
       if element.children.size == 1 && element.children.first.text?
         element.content.strip
       else
-        hashinate(element)
+        # We can have lists in not list item
+        if element['list'] == 'true'
+          element.children.reject{|c| c.text? }.map { |subchild| hash_or_value_for(subchild)}
+        else
+          hashinate(element)
+        end
       end
     end
 

data/lib/facebooker/rails/helpers/fb_connect.rb

@@ -47,6 +47,7 @@ module Facebooker
              #{case options[:js]
                when :jquery then "jQuery(document).ready("
                when :dojo then "dojo.addOnLoad("
+               when :mootools then "window.addEvent('domready',"
                else "Element.observe(window,'load',"
                end} function() {
                 FB_RequireFeatures(#{required_features.to_json}, function() {

data/lib/facebooker/version.rb

@@ -2,7 +2,7 @@ module Facebooker #:nodoc:
   module VERSION #:nodoc:
     MAJOR = 1
     MINOR = 0
-    TINY  = 66
+    TINY  = 67
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/test/facebooker_test.rb

@@ -418,7 +418,14 @@ class TestFacebooker < Test::Unit::TestCase
     assert_equal false, @session.remove_comment('pete_comments',123)
   end
   
-  
+  # We can have lists in not list item, see ewample_with_list_in_none_list_item_xml : there is comment_list in comments node
+  def test_parser_with_list_item_in_not_list_item
+    expect_http_posts_with_responses(ewample_with_list_in_none_list_item_xml)
+    response = @session.fql_query('Lets be frank. We are not testing the query here')
+    assert_equal 3, response.first["comments"]['comment_list'].size
+    assert_equal "ahahhahaha\n    i don't know the original one, but this is awesome (without waiting for it)", response.first["comments"]['comment_list'].first['text']
+  end
+
   
   private
   def populate_user_info
@@ -1200,4 +1207,57 @@ class TestFacebooker < Test::Unit::TestCase
     "0"
   end
   
+  def ewample_with_list_in_none_list_item_xml
+    <<-XML
+    <?xml version="1.0" encoding="UTF-8"?>
+    <fql_query_response xmlns="http://api.facebook.com/1.0/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" list="true">
+      <stream_post>
+        <post_id>12345678_901234</post_id>
+        <actor_id>12345</actor_id>
+        <comments>
+          <can_remove>1</can_remove>
+          <can_post>1</can_post>
+          <count>3</count>
+          <comment_list list="true">
+            <comment>
+              <fromid>6667785</fromid>
+              <time>2223332</time>
+              <text>ahahhahaha
+    i don't know the original one, but this is awesome (without waiting for it)</text>
+              <id>12345678_901234_23456</id>
+            </comment>
+            <comment>
+              <fromid>6667785</fromid>
+              <time>1268732285</time>
+              <text>héhé :)
+    Have you listen their Mickeal Jackson's cover ?</text>
+              <id>785637999_368045444730_12404854</id>
+            </comment>
+            <comment>
+              <fromid>1345267</fromid>
+              <time>1268733276</time>
+              <text>not yet!
+    unfortunately i'm at work so i can't go through all of them..
+    but yes, i saw it
+    brilliant!</text>
+              <id>12345678_901234_234567</id>
+            </comment>
+          </comment_list>
+        </comments>
+        <likes>
+          <href>http://www.facebook.com/social_graph.php?node_id=23546&amp;class=LikeManager</href>
+          <count>1</count>
+          <sample list="true"/>
+          <friends list="true">
+            <uid>234567</uid>
+          </friends>
+          <user_likes>0</user_likes>
+          <can_like>1</can_like>
+        </likes>
+      </stream_post>
+    </fql_query_response>
+    XML
+  end
+  
+  
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: facebooker
 version: !ruby/object:Gem::Version 
-  version: 1.0.66
+  version: 1.0.67
 platform: ruby
 authors: 
 - Chad Fowler
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-24 00:00:00 -04:00
+date: 2010-03-30 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency