facebook_share 0.0.3 → 0.0.4

data/.gitignore

@@ -1,3 +1,4 @@
 pkg/*
 *.gem
 .bundle
+.rspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    facebook_share (0.0.2)
+    facebook_share (0.0.4)
 
 GEM
   remote: http://rubygems.org/

data/README.md

@@ -38,7 +38,7 @@ Default facebook Share options can be changed with the above code snippet
 
 * *appid* - your Facebook application ID that will connect your site to Facebook
 * *status*. *cookie* and *xfbml* - as described at [FB.init JS SDK](http://developers.facebook.com/docs/reference/javascript/fb.init/)
-* *locale* - Facebook locale code representations, ie. en_US, de_DE, pl_PL, etc. The full list of Facebook supported languages is available in http://www.facebook.com/translations/FacebookLocales.xml or at [Facebook Developer Wiki](http://fbdevwiki.com/wiki/Locales)
+* *locale* - Facebook locale code representations, ie. en_US, de_DE, pl_PL, etc. The full list of Facebook supported languages is available in http://www.facebook.com/translations/FacebookLocales.xml or at [Facebook Developer Wiki](http://fbdevwiki.com/wiki/Locales). If your locale has both parts of the string the same, for example "de_DE", "pl_PL", since version 0.0.4 you can put just "de" or "pl", etc. The script **does not** check for validity of given locale.
 * *selector* - a selector to target Facebook share binding, ".fb_share" by default
 * any other parameter will be passed to Facebook's **[FB.ui](http://developers.facebook.com/docs/reference/javascript/fb.ui/)** function, so you can use whichever parameters you need, except for *method*, which defaults always to *publish.stream*
 
@@ -51,6 +51,25 @@ The simplest usage (given you specified your project's Facebook Application ID)
 
 That will produce a link "Share on Facebook" with a class of "fb_share" and a corresponding JavaScript script tags initializing Facebook app and sharing method bind to click on that link. By default gem passes ".fb_share" selector to jQuery.
 
+## Changelog
+
+v0.0.4
+
+* Locale guessing, if necessary
+
+v0.0.3
+
+* Added basic tests
+
+v0.0.2
+
+* Added global settings
+* Replaced *url* param with *link* to be consistent with Facebook API
+
+v0.0.1
+
+* First public release
+
 ## Note on patches/pull requests
 
 * Fork the project.

data/lib/facebook_share.rb

@@ -7,10 +7,16 @@ module FacebookShare
   end
 
   def default_facebook_share_options
+    # usually you might want to provide your own link anyway
+    if defined? request
+      link = request.url
+    else
+      link = "http://railslove.com"
+    end
     {
       :app_id => "0",
       :selector => ".fb_share",
-      :link => request.url,
+      :link => link,
       :locale => "en_US",
       :display => "popup"
     }.merge(FacebookShare.default_facebook_share_options || {})
@@ -47,6 +53,7 @@ JS
 
   def facebook_connect_js_tag(options = {})
     options = default_facebook_share_options.merge(options)
+    options[:locale] = "#{options[:locale]}_#{options[:locale].upcase}" if /^[a-z]{2}$/.match(options[:locale])
     html_safe_string("<script type=\"text/javascript\" src=\"https://connect.facebook.net/#{options[:locale]}/all.js\"></script>")
   end
 

data/lib/facebook_share/version.rb

@@ -1,3 +1,3 @@
 module FacebookShare
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/facebook_share/facebook_share_spec.rb

@@ -46,4 +46,27 @@ describe FacebookShare do
       it { should_not match(/selector: "/) }
     end
   end
+
+  describe "creating init script" do
+    context "when vanilla locale" do
+      subject { facebook_connect_js_tag( :locale => "en_US" ) }
+      
+      it { should match(/\/en_US\/all\.js/) }
+      it { should_not match(/\/en\/all\.js/) }
+    end
+
+    context "when shortened locale" do
+      subject { facebook_connect_js_tag( :locale => "en" ) }
+      
+      it { should match(/\/en_EN\/all\.js/) }
+      it { should_not match(/\/en\/all\.js/) }
+    end
+
+    context "when shortened locale 2" do
+      subject { facebook_connect_js_tag( :locale => "pl" ) }
+      
+      it { should match(/\/pl_PL\/all\.js/) }
+      it { should_not match(/\/pl\/all\.js/) }
+    end
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: facebook_share
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: false
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - "Mike Po\xC5\x82tyn"
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-16 00:00:00 +01:00
+date: 2011-02-17 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency