facebook_share 0.0.2 → 0.0.3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    facebook_share (0.0.1)
+    facebook_share (0.0.2)
 
 GEM
   remote: http://rubygems.org/

data/README.md

@@ -51,10 +51,6 @@ The simplest usage (given you specified your project's Facebook Application ID)
 
 That will produce a link "Share on Facebook" with a class of "fb_share" and a corresponding JavaScript script tags initializing Facebook app and sharing method bind to click on that link. By default gem passes ".fb_share" selector to jQuery.
 
-## Todo
-
-* add tests
-
 ## Note on patches/pull requests
 
 * Fork the project.

data/lib/facebook_share/version.rb

@@ -1,3 +1,3 @@
 module FacebookShare
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/facebook_share.rb

@@ -47,7 +47,7 @@ JS
 
   def facebook_connect_js_tag(options = {})
     options = default_facebook_share_options.merge(options)
-    html_safe_string("<script type=\"text/javascript\" src=\"https://connect.facebook.net/#{default_facebook_share_options.merge(options)[:locale]}/all.js\"></script>")
+    html_safe_string("<script type=\"text/javascript\" src=\"https://connect.facebook.net/#{options[:locale]}/all.js\"></script>")
   end
 
   def facebook_init_script(options = {})
@@ -64,7 +64,7 @@ JS
       param_check = ( for_init ) ? FacebookShare::INIT_PARAMS.include?(key.to_s) : !(FacebookShare::REMOVE_PARAMS.include?(key.to_s))
 
       if value && param_check
-        value_sanitized = value.gsub(/"/, '\"')
+        value_sanitized = value.to_s.gsub(/"/, '\"')
         script << ", #{key}: \"#{value_sanitized}\""
       end
     end

data/spec/facebook_share/facebook_share_spec.rb

@@ -0,0 +1,49 @@
+require File.expand_path(File.dirname(File.dirname(__FILE__)) + '/spec_helper')
+
+describe FacebookShare do
+  include FacebookShare
+
+  describe "building params" do
+    before(:all) do
+      @options = {
+        :app_id => "123123123",
+
+        :selector => "#some_fancy > .selector",
+        :display => "popup",
+        :link => "http://railslove.com/",
+        :caption => "Railslove",
+        
+        :status => "true",
+        :xfbml => "true",
+        :cookie => "false"
+      }
+    end
+    context "when not for_init" do
+      subject { build_params(@options) }
+
+      it { should_not match(/app_id/) }
+      it { should_not match(/cookies/) }
+      it { should_not match(/xfbml/) }
+
+      it { should match(/display: "popup"/) }
+      it { should match(/link: "http:\/\/railslove.com\/"/) }
+      it { should match(/caption: "Railslove"/) }
+
+      it { should_not match(/selector: "/) }
+    end
+
+    context "when for_init" do
+      subject { build_params(@options, true) }
+
+      it { should_not match(/app_id/) }
+      it { should match(/cookie: "false"/) }
+      it { should match(/xfbml: "true"/) }
+
+      it { should_not match(/display: "popup"/) }
+      it { should_not match(/link: "http:\/\/railslove.com\/"/) }
+      it { should_not match(/caption: "Railslove"/) }
+
+      it { should_not match(/selector: "/) }
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -13,4 +13,4 @@ def fixture_path(file_name)
 end
 
 RSpec.configure do |config|
-end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: facebook_share
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: false
   segments: 
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  - 3
+  version: 0.0.3
 platform: ruby
 authors: 
 - "Mike Po\xC5\x82tyn"
@@ -50,6 +50,7 @@ files:
 - facebook_share.gemspec
 - lib/facebook_share.rb
 - lib/facebook_share/version.rb
+- spec/facebook_share/facebook_share_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
 homepage: http://github.com/Holek/facebook_share