facebook_canvas 0.4.0 → 0.5.0

data/test/facebook_canvas/middleware_test.rb

@@ -0,0 +1,160 @@
+require 'test_helper'
+
+class FacebookCanvas::MiddlewareTest < ActiveSupport::TestCase
+  let(:middleware) { FacebookCanvas::Middleware.new(app, request_host, custom_filter, **kwargs) }
+  let(:request_host) { %r{.*} }
+  let(:custom_filter) { proc { |_env| true } }
+  let(:kwargs) { {} }
+  let(:app) { proc { |env| [200, {}, env] } }
+  let(:env) {
+    {
+      "SERVER_NAME" => "test.host",
+      "REQUEST_METHOD" => original_request_method,
+    }
+  }
+  let(:original_request_method) { "POST" }
+
+  describe "request_host" do
+    describe "matching via regexp" do
+      describe "matching any host" do
+        let(:request_host) { %r{.*} }
+
+        test "modifies request method to GET" do
+          env["SERVER_NAME"] = "anything"
+          assert_request_method "GET"
+        end
+      end
+
+      describe "matching speficic host" do
+        let(:request_host) { %r{\.fb\.} }
+
+        test "modifies request method to GET if matched" do
+          env["SERVER_NAME"] = "test.fb.host"
+          assert_request_method "GET"
+        end
+
+        test "does not change request method" do
+          env["SERVER_NAME"] = "test.facebook.host"
+          refute_request_method_change
+        end
+      end
+    end
+
+    describe "matching via proc" do
+      let(:request_host) do
+        proc { |env| env[:pass_server_name] }
+      end
+
+      test "modifies request method to GET" do
+        env[:pass_server_name] = true
+        assert_request_method "GET"
+      end
+
+      test "does not change request method" do
+        env[:pass_server_name] = false
+        refute_request_method_change
+      end
+    end
+
+    describe "matching via other objects" do
+      let(:request_host) { :something }
+
+      test "fails initialization with ArgumentError" do
+        e = assert_raises ArgumentError do
+          middleware
+        end
+        assert_equal "Expected Regexp or Proc for `request_host` but got: :something", e.message
+      end
+    end
+  end
+
+  describe "custom_filter" do
+    let(:custom_filter) do
+      proc { |env| env[:pass_custom_filter] }
+    end
+
+    test "modifies request method to GET if matched" do
+      env[:pass_custom_filter] = true
+      assert_request_method "GET"
+    end
+
+    test "prevents change of request method" do
+      env[:pass_custom_filter] = false
+      refute_request_method_change
+    end
+  end
+
+  describe "with Rails' POST request" do
+    before do
+      env["rack.request.form_hash"] = {
+        "utf8" => "✓"
+      }
+    end
+
+    test "does not change request method" do
+      refute_request_method_change
+    end
+  end
+
+  describe "with Rails' XHR requests" do
+    before do
+      env["HTTP_X_REQUESTED_WITH"] = "XMLHttpRequest"
+    end
+
+    test "does not change request method" do
+      refute_request_method_change
+    end
+  end
+
+  describe "inside_filter" do
+    describe "is optional" do
+      test "modifies request method to GET if matched" do
+        # no kwargs
+        assert_request_method "GET"
+      end
+    end
+
+    describe "is set" do
+      before do
+        kwargs[:inside_filter] = proc { |env| env[:pass_inside_filter] }
+      end
+
+      describe "accepted by the filter" do
+        before do
+          env[:pass_inside_filter] = true
+        end
+
+        test ".inside?(env) returns true" do
+          _, _, new_env = middleware.call(env)
+          assert FacebookCanvas::Middleware.inside?(new_env)
+        end
+
+        test "modifies request method to GET if matched" do
+          assert_request_method "GET"
+        end
+      end
+
+      describe "denied by the filter" do
+        before do
+          env[:pass_inside_filter] = false
+        end
+        test "does not change request method" do
+          refute_request_method_change
+        end
+      end
+    end
+  end
+
+  private
+
+  def assert_request_method(expected)
+    status, headers, body = middleware.call(env)
+
+    assert_instance_of Hash, body
+    assert_equal expected, body.fetch("REQUEST_METHOD")
+  end
+
+  def refute_request_method_change
+    assert_request_method original_request_method
+  end
+end

data/test/integration/middleware_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class FacebookCanvas::MiddlewareTest < ActionDispatch::IntegrationTest
+class FacebookCanvas::IntegrationMiddlewareTest < ActionDispatch::IntegrationTest
   test 'convert post to get request' do
     post '/foo/index'
     assert_response :success

data/test/test_helper.rb

@@ -1,7 +1,5 @@
-if ENV['CODECLIMATE_REPO_TOKEN']
-  require "codeclimate-test-reporter"
-  CodeClimate::TestReporter.start
-end
+require "simplecov"
+SimpleCov.start
 
 # Configure Rails Environment
 ENV["RAILS_ENV"] = "test"
@@ -10,6 +8,7 @@ require File.expand_path("../../test/dummy/config/environment.rb",  __FILE__)
 require "rails/test_help"
 
 require "minitest/rails"
+require "minitest/focus" unless ENV["CI"]
 
 # Filter out Minitest backtrace while allowing backtrace from other libraries
 # to be shown.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: facebook_canvas
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - André Stuhrmann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-06 00:00:00.000000000 Z
+date: 2017-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-focus
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - as@neopoly.de
@@ -92,6 +106,7 @@ files:
 - test/dummy/public/422.html
 - test/dummy/public/500.html
 - test/dummy/public/favicon.ico
+- test/facebook_canvas/middleware_test.rb
 - test/facebook_canvas/signed_request_test.rb
 - test/facebook_canvas_test.rb
 - test/fixtures/signed_request.txt
@@ -118,51 +133,52 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Rails engine for Facebook's canvas integration.
 test_files:
-- test/facebook_canvas/signed_request_test.rb
 - test/integration/middleware_test.rb
-- test/dummy/config/application.rb
+- test/facebook_canvas_test.rb
+- test/test_helper.rb
+- test/facebook_canvas/middleware_test.rb
+- test/facebook_canvas/signed_request_test.rb
+- test/dummy/log/test.log
+- test/dummy/Rakefile
+- test/dummy/bin/setup
+- test/dummy/bin/rails
+- test/dummy/bin/bundle
+- test/dummy/bin/rake
+- test/dummy/README.rdoc
+- test/dummy/config/environment.rb
+- test/dummy/config/boot.rb
+- test/dummy/config/secrets.yml
 - test/dummy/config/routes.rb
-- test/dummy/config/database.yml
+- test/dummy/config/initializers/inflections.rb
+- test/dummy/config/initializers/filter_parameter_logging.rb
+- test/dummy/config/initializers/session_store.rb
 - test/dummy/config/initializers/cookies_serializer.rb
 - test/dummy/config/initializers/backtrace_silencers.rb
 - test/dummy/config/initializers/mime_types.rb
-- test/dummy/config/initializers/assets.rb
 - test/dummy/config/initializers/wrap_parameters.rb
-- test/dummy/config/initializers/session_store.rb
-- test/dummy/config/initializers/inflections.rb
-- test/dummy/config/initializers/filter_parameter_logging.rb
+- test/dummy/config/initializers/assets.rb
+- test/dummy/config/database.yml
+- test/dummy/config/locales/en.yml
+- test/dummy/config/environments/development.rb
 - test/dummy/config/environments/production.rb
 - test/dummy/config/environments/test.rb
-- test/dummy/config/environments/development.rb
-- test/dummy/config/locales/en.yml
-- test/dummy/config/environment.rb
-- test/dummy/config/boot.rb
-- test/dummy/config/secrets.yml
-- test/dummy/config.ru
-- test/dummy/bin/bundle
-- test/dummy/bin/rake
-- test/dummy/bin/rails
-- test/dummy/bin/setup
-- test/dummy/Rakefile
-- test/dummy/README.rdoc
-- test/dummy/app/assets/stylesheets/application.css
-- test/dummy/app/assets/javascripts/application.js
-- test/dummy/app/helpers/application_helper.rb
-- test/dummy/app/controllers/foo_controller.rb
-- test/dummy/app/controllers/application_controller.rb
-- test/dummy/app/views/foo/create.haml
-- test/dummy/app/views/layouts/application.html.erb
-- test/dummy/log/test.log
-- test/dummy/public/favicon.ico
-- test/dummy/public/404.html
+- test/dummy/config/application.rb
 - test/dummy/public/500.html
 - test/dummy/public/422.html
-- test/test_helper.rb
-- test/facebook_canvas_test.rb
-- test/fixtures/signed_request_with_user_id.txt
+- test/dummy/public/404.html
+- test/dummy/public/favicon.ico
+- test/dummy/app/views/foo/create.haml
+- test/dummy/app/views/layouts/application.html.erb
+- test/dummy/app/assets/javascripts/application.js
+- test/dummy/app/assets/stylesheets/application.css
+- test/dummy/app/controllers/application_controller.rb
+- test/dummy/app/controllers/foo_controller.rb
+- test/dummy/app/helpers/application_helper.rb
+- test/dummy/config.ru
 - test/fixtures/signed_request.txt
+- test/fixtures/signed_request_with_user_id.txt