RubyGems - facebook_ads - Versions diffs - 0.1.7 → 0.1.8 - Mend

facebook_ads 0.1.7 → 0.1.8

Files changed (8) hide show

checksums.yaml +4 -4
data/Gemfile.lock +2 -2
data/README.md +2 -2
data/facebook_ads.gemspec +2 -2
data/lib/facebook_ads/base.rb +7 -9
data/test/ad_set_test.rb +5 -1
data/test/vcr_cassettes/AdSetTest-test_update.yml +134 -0
metadata +3 -2

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f8117b9273b5c021539acebd28147725fc64aa5b
-  data.tar.gz: 9896c67db75495e96eddcce3e0a26740223fd1a4
+  metadata.gz: 61b7ae96792b4405ed2bffbe93924ab38f8df935
+  data.tar.gz: 453fe5ce1681754ceea78981ca341404352e72ac
 SHA512:
-  metadata.gz: 30e04d2e719a14ba63d7886acb557d05061f997e00d09fe0b566af53d772867b4f3100c944c7bc3e7db0ad220225ee42502f0afa6385c158c6b5a399bffbe069
-  data.tar.gz: 167e49f93ac8c9d18cf13aa2b753a3b57795aabd172030490baabdf9fd61df2b2ab99a2b85f322a905be33dca78b926d44affc1f916534f9a9564636cb8c5764
+  metadata.gz: 11b7686efbfd515073db8feaecd384ddc8a3e51fbf15ce9b000775fb77654d5aa8a2ca0456b98d7586fe702204bff0e5289646b726d8ae4b01783bbe7e1a80dd
+  data.tar.gz: a64588d63ce45b8bef1ebd064d6ec2acb263b030a3426c5a9e6c06b4fc82cafefe847600e62834b8357844229437c9ecfb45abafa4e3a5dc2f8fa9ba5bc94af7

data/Gemfile.lock CHANGED Viewed

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    facebook_ads (0.1.7)
+    facebook_ads (0.1.8)
       hashie (~> 3.4)
       rest-client (>= 1.6)
@@ -78,4 +78,4 @@ DEPENDENCIES
   webmock
 BUNDLED WITH
-   1.13.6
+   1.13.7

data/README.md CHANGED Viewed

@@ -1,6 +1,6 @@
 [![Gem Version](https://badge.fury.io/rb/facebook_ads.svg)](https://badge.fury.io/rb/facebook_ads)
-[![Build Status](https://travis-ci.org/cte/facebook-ads-sdk-ruby.svg?branch=master)](https://travis-ci.org/cte/facebook-ads-sdk-ruby)
-[![Coverage Status](https://coveralls.io/repos/github/cte/facebook-ads-sdk-ruby/badge.svg)](https://coveralls.io/github/cte/facebook-ads-sdk-ruby)
+[![Build Status](https://travis-ci.org/cte/facebook-ruby-ads-sdk.svg?branch=master)](https://travis-ci.org/cte/facebook-ruby-ads-sdk)
+[![Coverage Status](https://coveralls.io/repos/github/cte/facebook-ruby-ads-sdk/badge.svg?branch=master)](https://coveralls.io/github/cte/facebook-ruby-ads-sdk?branch=master)
 # [Facebook Marketing API](https://developers.facebook.com/docs/marketing-apis) SDK for Ruby

data/facebook_ads.gemspec CHANGED Viewed

@@ -1,9 +1,9 @@
 # To release a new version:
 # gem build facebook_ads.gemspec
-# gem push facebook_ads-0.1.7.gem
+# gem push facebook_ads-0.1.8.gem
 Gem::Specification.new do |s|
   s.name        = 'facebook_ads'
-  s.version     = '0.1.7'
+  s.version     = '0.1.8'
   s.platform    = Gem::Platform::RUBY
   s.licenses    = ['MIT']
   s.authors     = ['Chris Estreich']

data/lib/facebook_ads/base.rb CHANGED Viewed

@@ -99,7 +99,7 @@ module FacebookAds
           end
         end
-        raise Exception, "Invalid response: #{response.inspect}" unless response.is_a?(Hash)
+        raise Exception, "Invalid response: #{response.class.name} #{response.inspect}" unless response.is_a?(Hash)
         raise Exception, "[#{response['error']['code']}] #{response['error']['message']} - raw response: #{response.inspect}" unless response['error'].nil?
         return response unless objectify
@@ -147,13 +147,6 @@ module FacebookAds
       end
     end
-    def update(data)
-      return false if data.nil?
-      response = self.class.post("/#{id}", query: data, objectify: false)
-      raise Exception, "Invalid response from update: #{response.inspect}" unless @response.is_a?(Hash) && response.key?('success')
-      response['success']
-    end
     def save
       return nil if changes.nil? || changes.length.zero?
       data = {}
@@ -162,9 +155,14 @@ module FacebookAds
       self.class.find(id)
     end
+    def update(data)
+      return false if data.nil?
+      response = self.class.post("/#{id}", query: data, objectify: false)
+      response['success']
+    end
     def destroy(path: nil, query: {})
       response = self.class.delete(path || "/#{id}", query: query)
-      raise Exception, "Invalid response from destroy: #{response.inspect}" unless response.key?('success')
       response['success']
     end

data/test/ad_set_test.rb CHANGED Viewed

@@ -2,6 +2,10 @@ require 'test_helper'
 # rake test TEST=test/ad_set_test.rb
 class AdSetTest < BaseTest
-  def test_foo
+  def test_update
+    vcr do
+      ad_set = FacebookAds::AdSet.find('6078462927057')
+      assert ad_set.update(daily_budget: 149900)
+    end
   end
 end

data/test/vcr_cassettes/AdSetTest-test_update.yml ADDED Viewed

@@ -0,0 +1,134 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://graph.facebook.com/v2.8/6078462927057?access_token=TEST_ACCESS_TOKEN&fields=id,account_id,campaign_id,adlabels,adset_schedule,bid_amount,bid_info,billing_event,configured_status,created_time,creative_sequence,effective_status,end_time,frequency_cap,frequency_cap_reset_period,frequency_control_specs,is_autobid,lifetime_frequency_cap,lifetime_imps,name,optimization_goal,promoted_object,rf_prediction_id,rtb_flag,start_time,targeting,updated_time,use_new_app_click,pacing_type,budget_remaining,daily_budget,lifetime_budget
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*"
+      Accept-Encoding:
+      - gzip, deflate
+      User-Agent:
+      - rest-client/2.0.0 (darwin16.3.0 x86_64) ruby/2.2.6p396
+      Host:
+      - graph.facebook.com
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Access-Control-Allow-Origin:
+      - "*"
+      Etag:
+      - '"8601e585e51a79f062fca560a52d6ba20e8851b7"'
+      Pragma:
+      - no-cache
+      Cache-Control:
+      - private, no-cache, no-store, must-revalidate
+      Facebook-Api-Version:
+      - v2.8
+      Expires:
+      - Sat, 01 Jan 2000 00:00:00 GMT
+      Content-Type:
+      - application/json; charset=UTF-8
+      X-Fb-Trace-Id:
+      - FYcH7oOq7ZO
+      X-Fb-Rev:
+      - '2768927'
+      Vary:
+      - Accept-Encoding
+      Content-Encoding:
+      - gzip
+      X-Fb-Debug:
+      - CL6Z+QJWxmHr07ulS7RrqdZdh78jeQvyOfW5Ir+rvu8wXWB70O9Fxhr3flqxI79ZaZHtjEJGlQ340bvOE1CK4A==
+      Date:
+      - Mon, 09 Jan 2017 12:06:46 GMT
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '820'
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        H4sIAAAAAAAAA41UwW7jNhD9FYGnLmAtKMqSJd1crxc12iaL2M4etgFBS5TC
+        miJZisrGDfLvHVK2kW23aG8SZ/jmzbw3fEGiQRXK8aKY56QkC5wt0Ayxutaj
+        cjQEE5wlZVokSZEUpMA+XrPeMNEperkNkZzgbLp9EFIK1VH+xJWD+ObXT3fr
+        7XZze7P1d7VqRTda3tDBMTcOkLFc7Tb3ax+0nDmIONFzOCc4yeMkiUm6S5IK
+        LyqSxLjAGDJ52/LaiSf+HZTW8j9GruoTrZmhlg/cUcOt0MAWz5AYKBudPnjy
+        zo58hqRouS9JRW+GkKNYIPCZH6KlMcxyGZHfRoxJFpEszsroc3Sv5djz6EfR
+        NNwO0aZnHR+iJHlP0vdJDjS0AUzxJ3NCK9ppJgHw9uPH7Wa3pqvbm/v13WUm
+        xupe+7714XfoClUvyIhnLs8CzBekKEqCvUBp4buvx8HpfpowdSfjuW5uNrvN
+        crf+QFc/rVc/3+536HWGrDvQVrIOVS2TA/QK47LufwwY0joYiuo8G2iN9uwZ
+        VVk5m36EQhXJ4McYKhSAShmU8KhKu8sZb7xWz7UcG2jvTJuNjQB5OIz6y8vk
+        QJIWc5KRsiyzHKacZOiqwYcTfIh6OTZRHC2l9IJEd7wTg+Pgomg/wPih1X8g
+        kTT7DyQv778j5TgvynK+KAkJvj6jwMU4ZMbT9EiME/T6cBXlO935/UrLDOfp
+        /C3SL1ofmRRHHv2w384uBnsH5PbbaBXQvLPiKMVRw06TuYg3ly/XceWNB1VI
+        +NNU6jqYbfCShQ22ItBA+y2CnEs8OCacP0IF4GN57Vf14XXKkSFI5rP84Y0P
+        6Fs/A3v+bJgaPBzo7E08HqQYHrmlRjLXatuHEi2r+QEa9c/KeTJUcfdV26Pn
+        dAlTowdxJg+XeDCOFd2jo49MgXX8tik4C8YC14OLRS25x2j4kwDUb8r2sN/S
+        99bw4ei0Cc2Npvnb87IA8WJc7vC8wqRK0ov7x8Gz/Eq9vWsp6uN1fwyr/TCm
+        pfvi10k1zDaex2FsYFTw4PRMqLA5sLtpPveSN0zIE50y/HmGcSh0fXquIYxe
+        /wJPAx7ClwUAAA==
+    http_version:
+  recorded_at: Mon, 09 Jan 2017 12:06:46 GMT
+- request:
+    method: post
+    uri: https://graph.facebook.com/v2.8/6078462927057
+    body:
+      encoding: UTF-8
+      string: daily_budget=149900&access_token=TEST_ACCESS_TOKEN
+    headers:
+      Accept:
+      - "*/*"
+      Accept-Encoding:
+      - gzip, deflate
+      User-Agent:
+      - rest-client/2.0.0 (darwin16.3.0 x86_64) ruby/2.2.6p396
+      Content-Length:
+      - '205'
+      Content-Type:
+      - application/x-www-form-urlencoded
+      Host:
+      - graph.facebook.com
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      P3p:
+      - 'CP="Facebook does not have a P3P policy. Learn why here: http://fb.me/p3p"'
+      Access-Control-Allow-Origin:
+      - "*"
+      Pragma:
+      - no-cache
+      Cache-Control:
+      - private, no-cache, no-store, must-revalidate
+      Facebook-Api-Version:
+      - v2.8
+      Expires:
+      - Sat, 01 Jan 2000 00:00:00 GMT
+      Content-Type:
+      - application/json; charset=UTF-8
+      X-Fb-Trace-Id:
+      - CHyrZMQDmsR
+      X-Fb-Rev:
+      - '2768887'
+      Set-Cookie:
+      - sW=1483963606%3AAaDLso7ysP8SWvGp; path=/; domain=.graph.facebook.com; secure
+      X-Fb-Debug:
+      - "+T+Zyg61PIrzSH8uyxzxPAUJ6qDnUStygRBXef+Sl6eja/viNiHOnYXRHsxb9z1vrXx8JlB9Ab5bumH7iC+hmw=="
+      Date:
+      - Mon, 09 Jan 2017 12:06:47 GMT
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '16'
+    body:
+      encoding: UTF-8
+      string: '{"success":true}'
+    http_version:
+  recorded_at: Mon, 09 Jan 2017 12:06:47 GMT
+recorded_with: VCR 3.0.3

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: facebook_ads
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Chris Estreich
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-01-06 00:00:00.000000000 Z
+date: 2017-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -95,6 +95,7 @@ files:
 - test/vcr_cassettes/AdProductCatalogTest-test_all.yml
 - test/vcr_cassettes/AdProductCatalogTest-test_create.yml
 - test/vcr_cassettes/AdProductTest-test_list.yml
+- test/vcr_cassettes/AdSetTest-test_update.yml
 homepage: https://github.com/cte/facebook-ruby-ads-sdk
 licenses:
 - MIT