face_control 0.8.6 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 325aba4c4fdce156c0dae24d9c5cf10b2993b4b70e0fcf184d3645cea22f5563
-  data.tar.gz: 700af54ea35e67f76d9245acb0fc5e63dfaa766295b357d27d71cf5e0a7de3a2
+SHA1:
+  metadata.gz: c1715692f36c358683ee2c9cd0d87f58725036f2
+  data.tar.gz: b41cc0e5f1be6758ffb5739316b4993c62cdfe38
 SHA512:
-  metadata.gz: d5df85b4788e83c52f3cb051fee19d5137794b3ae9096e2bcc626b0585783515bb1479d52bf9c1cc2fab1d0cd829cbbc69120ccdf48f95e9e686144e4a047163
-  data.tar.gz: 308cb4a0b3d91dc19b1da72b537ed7dbd17f327554bbbc091e7ef16cd895f4828391490843ae3e63c554e0c73d4ce7935bb86131120d176b094f2390a70c9f0f
+  metadata.gz: 8b525aa7fbbfb00efa31ed3ac73fca109b334794ae5dfc72ad56521d38d20e517fe651943cc9cba2107fa7ad5147b119d39d6547de309050381505c777286f71
+  data.tar.gz: b24793e5d9cd918eafd9de312353e78665dcf7b896ef0ec0b4fde0bd6618042946e2ead8af0ea450a944c3d5b689fdab701d70edf7d4d4b11313690275946b58

data/README.md

@@ -1,11 +1,11 @@
-# Face Control
-
 [![Gem Version](https://img.shields.io/gem/v/face_control.svg)](https://rubygems.org/gems/face_control)
 [![Code Climate](https://img.shields.io/codeclimate/github/vassilevsky/face_control.svg)](https://codeclimate.com/github/vassilevsky/face_control/code)
 [![Vexor](https://ci.vexor.io/projects/126da196-c8e6-46f0-8bc7-b5f8f4b49732/status.svg)](https://ci.vexor.io/ui/projects/126da196-c8e6-46f0-8bc7-b5f8f4b49732/builds)
 [![Coveralls](https://img.shields.io/coveralls/vassilevsky/face_control.svg)](https://coveralls.io/github/vassilevsky/face_control)
 [![VersionEye](https://img.shields.io/versioneye/d/ruby/face_control.svg)](https://www.versioneye.com/ruby/face_control)
 
+# Face Control
+
 Run static analysis of pull requests in [Bitbucket Server][] (formerly Stash)
 and comment on problems in added lines.
 
@@ -16,75 +16,61 @@ Inspired by [Hound][].
 
 ## Installation
 
-```bash
-gem install face_control
-```
+    gem install face_control
 
-You also need to have CoffeeLint installed and available in `PATH`.
+You also need to have CoffeeLint installed and available in PATH.
 
 ## Usage
 
-```bash
-face-control <project> <repository> <pull_request_id>
-```
-
-It's natural to run this on a continuous integration server (see “[Example](#example)” below).
+    face-control <project> <repository> <pull_request_id>
 
-If you don't want to receive RuboCop comments with certain severity level,
-pass the severity in the `--skip-severity` option like so:
-
-```bash
-face-control --skip-severity convention <project> <repository> <pull_request_id>
-```
+It's natural to run this on a continuous integration server.
+For example, here's a [Jenkins][] project setup:
 
-Instead of `--skip-severity` you can use just `-S`.
-
-You can also pass multiple severity levels as a comma-separated list:
+* Source Code Management
+  * Git
+    * Repositories
+      * Refspec:
 
-```bash
-face-control -S convention,refactor <project> <repository> <pull_request_id>
-```
+              +refs/pull-requests/*:refs/remotes/origin/pull-requests/*
 
-`face-control` uses the same configuration file (`~/.stashconfig.yml`)
-as the official [Bitbucket Server Command Line Tools][]
-to connect to your Stash instance.
+        (make Jenkins fetch otherwise ignored Stash-created branches)
 
-## Example
+    * Branches to build
+      * Branch Specifier:
 
-Here's a [Jenkins][] project setup as an example:
+              origin/pull-requests/*/merge
 
-_Source Code Management → Git → Repositories → Refspec:_
+        (merge results of open non-conflicting pull requests)
 
-```
-+refs/pull-requests/*:refs/remotes/origin/pull-requests/*
-```
+* Build
+  * Execute shell
+    * Command
 
-It makes Jenkins fetch otherwise ignored Stash-created branches.
+            export PULL_REQUEST_ID=`echo $GIT_BRANCH | cut -d / -f 3`
 
-_Source Code Management → Git → Branches to build → Branch Specifier:_
+            gem install rubocop face_control
+            npm install -g coffeelint
 
-```
-origin/pull-requests/*/merge
-```
+            face-control <project> <repository> $PULL_REQUEST_ID
 
-Merge results of open non-conflicting pull requests.
+If you don't want to receive RuboCop comments with certain severity level,
+pass the severity in the `--skip-severity` option like so:
 
-_Build → Execute shell → Command:_
+    face-control --skip-severity convention <project> <repository> <pull_request_id>
 
-```bash
-export PULL_REQUEST_ID=`echo $GIT_BRANCH | cut -d / -f 3`
+You can use just `-S`.
+You can also pass multiple severity levels as a comma-separated list:
 
-gem install rubocop face_control
-npm install -g coffeelint
+    face-control -S convention,refactor <project> <repository> <pull_request_id>
 
-face-control <project> <repository> $PULL_REQUEST_ID
-```
+`face-control` uses the same configuration file (`~/.stashconfig.yml`)
+as the official [Bitbucket Server Command Line Tools][]
+to connect to your Stash instance.
 
 ## Etymology
 
-[Face control][] in Wikipedia.
-
-[![Sponsored by FunBox](https://funbox.ru/badges/sponsored_by_funbox_centered.svg)](https://funbox.ru)
+[Face control][] in Wikipedia
 
 [Hound]: https://houndci.com
 [Bitbucket Server]: https://www.atlassian.com/software/bitbucket/server

data/Rakefile

@@ -1,3 +1,4 @@
+require 'bundler/gem_tasks'
 require 'rake/testtask'
 
 Rake::TestTask.new(:test) do |t|

data/face_control.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'face_control'
-  spec.version       = '0.8.6'
+  spec.version       = '0.9.0'
   spec.authors       = ['Ilya Vassilevsky']
   spec.email         = ['vassilevsky@gmail.com']
 
@@ -16,6 +16,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'rubocop'
   spec.add_runtime_dependency 'httparty'
 
+  spec.add_development_dependency 'bundler', '~> 1.8'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'minitest', '~> 5.8'
   spec.add_development_dependency 'minitest-reporters', '~> 1.0'

data/lib/face_control/checkers/rubocop.rb

@@ -58,7 +58,7 @@ module FaceControl
       def style_guide_url(offense)
         cop_name = offense['cop_name']
         config = ::RuboCop::ConfigLoader.default_configuration
-        ::RuboCop::Cop::MessageAnnotator.new(config, cop_name, config.for_cop(cop_name), {}).urls.first
+        ::RuboCop::Cop::MessageAnnotator.new(config, config.for_cop(cop_name), {}).urls.first
       end
     end
   end

data/lib/stash/server.rb

@@ -3,8 +3,6 @@ require 'stash/repository'
 
 module Stash
   class Server
-    class CommunicationError < StandardError; end
-
     attr_accessor :root_uri, :user, :password, :logger
 
     def initialize(root_uri, user, password, logger = nil)
@@ -21,18 +19,14 @@ module Stash
     end
 
     def get(path)
-      with_error_handling do
-        logged('Response') do
-          HTTParty.get(endpoint + path, auth.merge(logging))
-        end
+      logged('Response') do
+        HTTParty.get(endpoint + path, auth.merge(logging))
       end
     end
 
     def post(path, data)
-      with_error_handling do
-        logged('Response') do
-          HTTParty.post(endpoint + path, auth.merge(content_type).merge(body: data.to_json).merge(logging))
-        end
+      logged('Response') do
+        HTTParty.post(endpoint + path, auth.merge(content_type).merge(body: data.to_json).merge(logging))
       end
     end
 
@@ -79,13 +73,5 @@ module Stash
         {}
       end
     end
-
-    def with_error_handling
-      yield.tap do |response|
-        unless response.success?
-          fail CommunicationError, 'Stash responded with an error'
-        end
-      end
-    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: face_control
 version: !ruby/object:Gem::Version
-  version: 0.8.6
+  version: 0.9.0
 platform: ruby
 authors:
 - Ilya Vassilevsky
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-09-10 00:00:00.000000000 Z
+date: 2017-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: docopt
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -122,7 +136,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
-description:
+description: 
 email:
 - vassilevsky@gmail.com
 executables:
@@ -160,7 +174,7 @@ files:
 homepage: https://github.com/vassilevsky/face_control
 licenses: []
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -175,8 +189,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key:
+rubyforge_project: 
+rubygems_version: 2.6.12
+signing_key: 
 specification_version: 4
 summary: Checks Atlassian Stash pull requests and comments on issues in added code
 test_files: []