face_control 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4a232c3cf9da606837421e0f388819373c6aa46b
-  data.tar.gz: 07bedda93cc95dba9c5ea6b716c1f2c5e894506a
+  metadata.gz: be4497607119db9bc65a83c2b7d33a23285098a6
+  data.tar.gz: 7bbe96f55858e7006ae44865f6b8b6196fdadd7e
 SHA512:
-  metadata.gz: 54fe2769b81e249dc71c9aac26bb8311b4f522999a4d181af30322c30e0e6dedaa1e2f2fc869bb13421bde49df9877728e38a16fbe8e9d1370dbbbf1e2b65bad
-  data.tar.gz: d7511c518230fa2200e9ec6da57522fbc3c23e5f049ff8e4207350f1df8017e187d4074e71ab8680d332ab8a048f708ca20dff06cd3cdec830cb3b10d52dc5d8
+  metadata.gz: bc75588340a640a422005198455f6146e0a1b80007164554ae2a1da265e4becdcb77b2e42840a04689a95c00538bbda8c37388e41e9104adfa57b2280e8b761d
+  data.tar.gz: 6837e6f79ff30fdfec2fa7bca03db1c3da62f1d684c99b883230faed98ca434e47add43f231eca953fee6e01b0d9dacc704d8672386d1161f4036ac3a904a109

data/README.md

@@ -1,5 +1,8 @@
+[![Gem Version](https://img.shields.io/gem/v/face_control.svg)](https://rubygems.org/gems/face_control)
+[![Code Climate](https://img.shields.io/codeclimate/github/vassilevsky/face_control.svg)](https://codeclimate.com/github/vassilevsky/face_control/code)
 [![Vexor](https://ci.vexor.io/projects/126da196-c8e6-46f0-8bc7-b5f8f4b49732/status.svg)](https://ci.vexor.io/ui/projects/126da196-c8e6-46f0-8bc7-b5f8f4b49732/builds)
 [![Coveralls](https://img.shields.io/coveralls/vassilevsky/face_control.svg)](https://coveralls.io/github/vassilevsky/face_control)
+[![VersionEye](https://img.shields.io/versioneye/d/ruby/face_control.svg)](https://www.versioneye.com/ruby/face_control)
 
 # Face Control
 
@@ -41,6 +44,7 @@ For example, here's a [Jenkins][] project setup:
     * Command
 
             export PULL_REQUEST_ID=`echo $GIT_BRANCH | cut -d / -f 3`
+
             gem install rubocop face_control
             npm install -g coffeelint
 

data/face_control.gemspec

@@ -1,11 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'face_control/version'
-
 Gem::Specification.new do |spec|
   spec.name          = 'face_control'
-  spec.version       = FaceControl::VERSION
+  spec.version       = '0.8.0'
   spec.authors       = ['Ilya Vassilevsky']
   spec.email         = ['vassilevsky@gmail.com']
 

data/lib/face_control/checker_runner.rb

@@ -12,12 +12,17 @@ module FaceControl
     def comments
       return [] if relevant_filenames.empty?
 
-      @checker.parse(`#{@checker.command(relevant_filenames.join(' '))}`)
+      report = `#{@checker.command(relevant_filenames.join(' '))}`
+      return [] if report.strip.empty?
+
+      @checker.parse(report)
     end
 
     private
 
     def relevant_filenames
+      return @filenames unless @checker.respond_to?(:relevant_globs)
+
       @relevant_filenames ||= @checker.relevant_globs.map do |glob|
         @filenames.select do |filename|
           File.fnmatch?(glob, filename)

data/lib/face_control/checkers/_example.rb

@@ -7,6 +7,7 @@ module FaceControl
       # Define only if you use @options in the following methods
       attr_writer :options
 
+      # @optional
       # @return [Array<String>] Shell globs to filter only files relevant to this checker
       #                         out of all files with added lines in the pull request
       def relevant_globs
@@ -29,7 +30,7 @@ module FaceControl
           mode = fields.first
           file = fields.last
 
-          if mode != '-rwxr-xr-x'
+          unless mode == '-rwxr-xr-x'
             Comment.new(file: file, line: 1, text: 'Invalid file mode')
           end
         end

data/lib/face_control/checkers/comments.rb

@@ -0,0 +1,23 @@
+require 'face_control/comment'
+
+module FaceControl
+  module Checkers
+    class Comments
+
+      def command(filenames)
+        "grep -inEH '(todo|fixme)' #{filenames}"
+      end
+
+      def parse(command_output)
+        command_output.lines.map do |line|
+          file, line_num = line.split(":", 3)
+          Comment.new(
+            file: file,
+            line: line_num,
+            text: "Do not bury this task in code. Do it now or create a JIRA issue."
+          )
+        end
+      end
+    end
+  end
+end

data/lib/face_control/checkers/rubocop.rb

@@ -11,6 +11,7 @@ module FaceControl
 
       def relevant_globs
         %w(
+          *.gemspec
           *.rb
           *.rake
           Capfile

data/lib/face_control/checkers.rb

@@ -1,2 +1,3 @@
 require 'face_control/checkers/rubocop'
 require 'face_control/checkers/coffeelint'
+require 'face_control/checkers/comments'

data/lib/face_control/cli.rb

@@ -15,7 +15,7 @@ module FaceControl
       comments = check(pull_request, ignored_severities, logger)
       return if comments.empty?
 
-      logger.info("Posting #{comments.size} comments...")
+      logger.info("#{comments.size} comments have been created. Posting only those for added lines...")
       add_comments(pull_request, comments)
     end
 
@@ -28,7 +28,8 @@ module FaceControl
 
       checkers = [
         FaceControl::CheckerRunner.new(FaceControl::Checkers::RuboCop, filenames, ignored_severities: ignored_severities),
-        FaceControl::CheckerRunner.new(FaceControl::Checkers::CoffeeLint, filenames)
+        FaceControl::CheckerRunner.new(FaceControl::Checkers::CoffeeLint, filenames),
+        FaceControl::CheckerRunner.new(FaceControl::Checkers::Comments, filenames)
       ]
 
       checkers.map(&:comments).flatten

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: face_control
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Ilya Vassilevsky
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-08-11 00:00:00.000000000 Z
+date: 2016-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: docopt
@@ -161,10 +161,10 @@ files:
 - lib/face_control/checkers.rb
 - lib/face_control/checkers/_example.rb
 - lib/face_control/checkers/coffeelint.rb
+- lib/face_control/checkers/comments.rb
 - lib/face_control/checkers/rubocop.rb
 - lib/face_control/cli.rb
 - lib/face_control/comment.rb
-- lib/face_control/version.rb
 - lib/stash.rb
 - lib/stash/config.rb
 - lib/stash/pull_request.rb
@@ -190,7 +190,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Checks Atlassian Stash pull requests and comments on issues in added code

data/lib/face_control/version.rb

@@ -1,3 +0,0 @@
-module FaceControl
-  VERSION = '0.7.0'
-end