facade 1.2.0 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6717943e139c8af4bb62fc7403ec46f4539820dde024a56b14bf7d3433e77d1b
-  data.tar.gz: fa4c4ed14f9369a422417a2bd688e44c7a0b6f5143e4b12f82ffbd0219e443fa
+  metadata.gz: 5e4a3d5ec80c68a69aa30d40587d8107e37458dee62192b0d2f678a4a42ab66f
+  data.tar.gz: 60d20595449e828bc62c1c635b34aad152a8ac8d8e0873bfac6a3a8433c566cf
 SHA512:
-  metadata.gz: b376fc1f69f81c881772f6bccc4fad631af784d9b9f05865cc481b807ec6bf6cc03de603d62fca414e949c3c6b2e86ad17e5b83acd25085f93b84852408ee0aa
-  data.tar.gz: 8602a3a44236e99b90e10a38a59145f9f03f5469fd0782cbe60226b8b38a2d42f3160872e26d7585ba9e65c73efba752c79b42522bfc0c7db6be533dd555c96c
+  metadata.gz: 8b62c6fdc06d9ca5aefd0f3eaf3fccf9ad5fa5c6ad2e541a090bb2169e2c1bf6c3ed2cb7c1faf89b6bd47f2f9efc50f91ed899a5885177ba1ba5c19c64da52ea
+  data.tar.gz: 8043f0294e36f4af47dcca481498b6c34263237447a1c1432825f36614521be46a65ed14f86d35459f38ece8dc608ea0be7f42be1c6f6b86e3bc88948b4417bc

data/CHANGES.md

@@ -1,3 +1,11 @@
+## 1.2.2 - 24-Nov-2025
+* Cache an extended object internally to avoid unnecessary, repeated calls.
+* Minor spec update.
+
+## 1.2.1 - 16-Feb-2024
+* Mainly rubocop cleanup.
+* Apparently I forgot to bump the version when I did this, oops.
+
 ## 1.2.0 - 30-Sep-2020
 * Switched from test-unit to rspec, and added a Gemfile.
 * Use markdown for text files.

data/Gemfile

@@ -1,6 +1,2 @@
-source 'https://rubygems.org' do
-  gem 'rake'
-  group 'test' do
-    gem 'rspec', '~> 3.9'
-  end
-end
+source 'https://rubygems.org'
+gemspec

data/README.md

@@ -1,3 +1,5 @@
+[![Ruby](https://github.com/djberg96/facade/actions/workflows/ruby.yml/badge.svg)](https://github.com/djberg96/facade/actions/workflows/ruby.yml)
+
 ## Synopsis
 An easy way to implement the facade pattern in your classes. In short,
 this library wraps singleton methods from another class as instance
@@ -5,9 +7,12 @@ methods of the current class.
 
 ## Installation
 `gem install facade`
+
+## Adding the trusted cert
+`gem cert --add <(curl -Ls https://raw.githubusercontent.com/djberg96/facade/main/certs/djberg96_pub.pem)`
    
 ## Usage
-```
+```ruby
 require 'facade'
 
 class MyString < String
@@ -26,7 +31,7 @@ Eero Saynatkari, Eric Hodel and Michael Granger for ideas and code which I
 shamelessly plagiarized.
 
 ## Copyright
-Copyright (c) 2005-2020 Daniel J. Berger
+Copyright (c) 2005-2023 Daniel J. Berger
    
 ## License
 Apache-2.0

data/Rakefile

@@ -8,7 +8,7 @@ namespace :gem do
   desc 'Create the facade gem'
   task :create => [:clean] do
     require 'rubygems/package'
-    spec = eval(IO.read('facade.gemspec'))
+    spec = Gem::Specification.load('facade.gemspec')
     spec.signing_key = File.join(Dir.home, '.ssh', 'gem-private_key.pem') 
     Gem::Package.build(spec)
   end
@@ -21,6 +21,8 @@ namespace :gem do
 end
 
 desc "Run the test suite"
-RSpec::Core::RakeTask.new(:spec)
+RSpec::Core::RakeTask.new(:spec) do |t|
+  t.rspec_opts = "-f documentation"
+end
 
 task :default => :spec

data/facade.gemspec

@@ -2,7 +2,7 @@ require 'rubygems'
 
 Gem::Specification.new do |spec|
   spec.name       = 'facade'
-  spec.version    = '1.2.0'
+  spec.version    = '1.2.2'
   spec.author     = 'Daniel J. Berger'
   spec.license    = 'Apache-2.0'
   spec.email      = 'djberg96@gmail.com'
@@ -16,12 +16,13 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency('rspec', '~> 3.9')
 
   spec.metadata = {
-    'homepage_uri'      => 'https://github.com/djberg96/facade',
-    'bug_tracker_uri'   => 'https://github.com/djberg96/facade/issues',
-    'changelog_uri'     => 'https://github.com/djberg96/facade/blob/master/CHANGES',
-    'documentation_uri' => 'https://github.com/djberg96/facade/wiki',
-    'source_code_uri'   => 'https://github.com/djberg96/facade',
-    'wiki_uri'          => 'https://github.com/djberg96/facade/wiki'
+    'homepage_uri'          => 'https://github.com/djberg96/facade',
+    'bug_tracker_uri'       => 'https://github.com/djberg96/facade/issues',
+    'changelog_uri'         => 'https://github.com/djberg96/facade/blob/main/CHANGES.md',
+    'documentation_uri'     => 'https://github.com/djberg96/facade/wiki',
+    'source_code_uri'       => 'https://github.com/djberg96/facade',
+    'wiki_uri'              => 'https://github.com/djberg96/facade/wiki',
+    'rubygems_mfa_required' => 'true'
   } 
 
   spec.description = <<-EOF

data/lib/facade.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module Facade
   # The version of the facade library
-  FACADE_VERSION = '1.2.0'.freeze
+  FACADE_VERSION = '1.2.2'
 
   # The facade method will forward a singleton method as an instance
   # method of the extending class. If no arguments are provided, then all
@@ -13,8 +15,8 @@ module Facade
   #  require 'facade'
   #
   #  class MyString < String
-  #     extend Facade
-  #     facade File, :dirname, :basename
+  #    extend Facade
+  #    facade File, :dirname, :basename
   #  end
   #
   #  s = MyString.new('/home/djberge')
@@ -25,31 +27,24 @@ module Facade
     methods = methods.flatten
 
     if methods.empty? # Default to all methods
-      if klass.kind_of?(Class)
-        methods = klass.methods(false)
-      else
-        methods = klass.public_instance_methods(false)
-      end
+      methods = klass.is_a?(Class) ? klass.methods(false) : klass.public_instance_methods(false)
     end
 
-    # Convert all strings to symbols to stay sane between 1.8.x and 1.9.x
-    methods = methods.map{ |m| m.to_sym }
-    methods -= self.instance_methods.map{ |m| m.to_sym } # No clobber
+    methods -= instance_methods.map(&:to_sym) # No clobber
 
-    methods.each do |methname|
-      define_method(methname){
-        if klass.kind_of?(Class)
-          meth = klass.method(methname)
-        else
-          meth = Object.new.extend(klass).method(methname)
-        end
+    # Cache the extended object for modules to avoid creating it on every call
+    mod_proxy = klass.is_a?(Module) && !klass.is_a?(Class) ? Object.new.extend(klass) : nil
+
+    methods.each do |method_name|
+      define_method(method_name) do
+        meth = klass.is_a?(Class) ? klass.method(method_name) : mod_proxy.method(method_name)
 
-        if meth.arity.zero? # Zero or one argument
+        if meth.arity.zero?
           meth.call
         else
           meth.call(self)
         end
-      }
+      end
     end
   end
 end

data/spec/facade_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe Facade do
   let(:string) { facade.new('/home/whatever') }
 
   example "facade module has expected version set and it's frozen" do
-    expect(Facade::FACADE_VERSION).to eq('1.2.0')
+    expect(Facade::FACADE_VERSION).to eq('1.2.2')
     expect(Facade::FACADE_VERSION).to be_frozen
   end
 
@@ -54,7 +54,7 @@ RSpec.describe Facade do
     expect(string.blockdev?).to eq('test')
   end
 
-  example "module_methods" do
+  example "module methods behave as expected" do
     expect(string).to respond_to(:testme)
     expect(string.testme).to eq('/home/whatever')
   end

metadata

@@ -1,11 +1,10 @@
 --- !ruby/object:Gem::Specification
 name: facade
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.2
 platform: ruby
 authors:
 - Daniel J. Berger
-autorequire:
 bindir: bin
 cert_chain:
 - |
@@ -35,7 +34,7 @@ cert_chain:
   ORVCZpRuCPpmC8qmqxUnARDArzucjaclkxjLWvCVHeFa9UP7K3Nl9oTjJNv+7/jM
   WZs4eecIcUc4tKdHxcAJ0MO/Dkqq7hGaiHpwKY76wQ1+8xAh
   -----END CERTIFICATE-----
-date: 2020-09-30 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -83,18 +82,17 @@ files:
 - facade.gemspec
 - lib/facade.rb
 - spec/facade_spec.rb
-- test/test_facade.rb
 homepage: https://github.com/djberg96/facade
 licenses:
 - Apache-2.0
 metadata:
   homepage_uri: https://github.com/djberg96/facade
   bug_tracker_uri: https://github.com/djberg96/facade/issues
-  changelog_uri: https://github.com/djberg96/facade/blob/master/CHANGES
+  changelog_uri: https://github.com/djberg96/facade/blob/main/CHANGES.md
   documentation_uri: https://github.com/djberg96/facade/wiki
   source_code_uri: https://github.com/djberg96/facade
   wiki_uri: https://github.com/djberg96/facade/wiki
-post_install_message:
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -109,8 +107,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: An easy way to implement the facade pattern in your class
 test_files:

data/test/test_facade.rb

@@ -1,67 +0,0 @@
-#########################################################################
-# test_facade.rb
-#
-# Test suite for the Facade module. This test suite should be run via
-# the 'rake test' task.
-#########################################################################
-require 'test/unit'
-require 'facade'
-
-module Baz
-  def testme(str)
-    str
-  end
-end
-
-class FooString < String
-  extend Facade
-  facade File, :basename, 'dirname'
-  facade Dir
-  facade Baz
-
-  def blockdev?
-    'test'
-  end
-end
-
-class TC_Facade < Test::Unit::TestCase
-  def setup
-    @str = FooString.new('/home/djberge')
-  end
-
-  def test_facade_version
-    assert_equal('1.1.1', Facade::FACADE_VERSION)
-    assert_true(Facade::FACADE_VERSION.frozen?)
-  end
-
-  def test_file_methods
-    assert_respond_to(@str, :basename)
-    assert_respond_to(@str, :dirname)
-    assert_raises(NoMethodError){ @str.executable? }
-    assert_raises(NoMethodError){ @str.chardev? }
-  end
-
-  def test_file_method_return_values
-    assert_equal('djberge', @str.basename)
-    assert_equal('/home', @str.dirname)
-  end
-
-  def test_dir_methods
-    assert_respond_to(@str, :pwd)
-    assert_respond_to(@str, :entries)
-  end
-
-  def test_no_clobber
-    assert_respond_to(@str, :blockdev?)
-    assert_equal('test', @str.blockdev?)
-  end
-
-  def test_module_methods
-    assert_respond_to(@str, :testme)
-    assert_equal('/home/djberge', @str.testme)
-  end
-
-  def teardown
-    @str = nil
-  end
-end