fabrication 2.29.0 → 2.30.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c81aec7d3bdf1fd43d6b18d57edeb83b408f099eb403eb31b2caa17c715fa32e
-  data.tar.gz: 5945e9f77ced15f5de56749ae48c3b6f121ae4e3d941784ada4640d774957a08
+  metadata.gz: 38d9550f8e85412ca21c540ad7f850a61f9f511dce7048487c8cfc49f965922d
+  data.tar.gz: a2e732f74342b3342584483af9b2a446f4bf42fea8af50edbf1d792203e4d16b
 SHA512:
-  metadata.gz: 85ae12f9d4e95529411053591e8b80792afd639a32c9de705859f259e3c97725bb3b146c736381ec00a9b1daa16dd678466babc883e2eba797f50322deeac20b
-  data.tar.gz: cb07e8bf44438241f9500654755f2b350b5646b8e4fbf24b1d840147ffb074103e11bf230ca7e03d92f77c1d2c26d30ab292b70f96186e11a8098f7c230595f8
+  metadata.gz: bc4ed3c24fcd1d18ffff850a98d35fafe5408e2b166d234944a82d34e272a9a1fa1da1dff5df6677f7d083ac7cade969f10dcdc95e2fe8cb2b45d3f1719096e8
+  data.tar.gz: 28ad7426b1426f3b1f284bf1cf172397b83734b3865f91d64e755995da846f5bf4efc4629e90ee7a800c309e9f39898fac5ff3c87ab2607e7c0a6290d57490f8

data/lib/fabrication/generator/base.rb

@@ -11,6 +11,9 @@ module Fabrication
         if callbacks[:initialize_with]
           build_instance_with_constructor_override(callbacks[:initialize_with])
         elsif callbacks[:on_init]
+          Fabrication::Support.log_deprecation(
+            'The on_init callback has been replaced by initialize_with. Please see the documentation for usage'
+          )
           build_instance_with_init_callback(callbacks[:on_init])
         else
           build_instance
@@ -19,18 +22,29 @@ module Fabrication
         _instance
       end
 
-      def create(attributes = [], callbacks = [])
+      def create(attributes = [], callbacks = {})
         build(attributes, callbacks)
-        execute_callbacks(callbacks[:before_validation])
-        execute_callbacks(callbacks[:after_validation])
-        execute_callbacks(callbacks[:before_save])
+        execute_deprecated_callbacks(callbacks, :before_validation, :before_create)
+        execute_deprecated_callbacks(callbacks, :after_validation, :before_create)
+        execute_deprecated_callbacks(callbacks, :before_save, :before_create)
         execute_callbacks(callbacks[:before_create])
         persist
         execute_callbacks(callbacks[:after_create])
-        execute_callbacks(callbacks[:after_save])
+        execute_deprecated_callbacks(callbacks, :after_save, :after_create)
         _instance
       end
 
+      def execute_deprecated_callbacks(callbacks, callback_type, replacement_callback)
+        if callbacks[callback_type]
+          Fabrication::Support.log_deprecation(
+            "Using #{callback_type} is deprecated but you can replace it " \
+            "with #{replacement_callback} with the same result."
+          )
+        end
+
+        execute_callbacks(callbacks[callback_type])
+      end
+
       def execute_callbacks(callbacks)
         callbacks&.each { |callback| _instance.instance_exec(_instance, _transient_attributes, &callback) }
       end
@@ -96,18 +110,21 @@ module Fabrication
 
       protected
 
-      attr_accessor :resolved_class, :_instance, :_transient_attributes
+      attr_accessor :resolved_class, :_instance
 
       def _attributes
         @_attributes ||= {}
       end
 
+      def _transient_attributes
+        @_transient_attributes ||= {}
+      end
+
       def persist
         _instance.save! if _instance.respond_to?(:save!)
       end
 
       def process_attributes(attributes)
-        self._transient_attributes = ({})
         attributes.each do |attribute|
           _attributes[attribute.name] = attribute.processed_value(_attributes)
           _transient_attributes[attribute.name] = _attributes[attribute.name] if attribute.transient?

data/lib/fabrication/generator/sequel.rb

@@ -11,14 +11,11 @@ module Fabrication
       end
 
       def set_attributes
-        _attributes.each do |key, value|
-          if (reflection = resolved_class.association_reflections[key]) && value.is_a?(Array)
-            _instance.associations[key] = value
-            _instance.after_save_hook do
-              value.each { |o| _instance.send(reflection.add_method, o) }
-            end
+        _attributes.each do |field_name, value|
+          if value.is_a?(Array) && (association = association_for(field_name))
+            set_association(association, field_name, value)
           else
-            _instance.send("#{key}=", value)
+            set_attribute(field_name, value)
           end
         end
       end
@@ -29,6 +26,21 @@ module Fabrication
 
       private
 
+      def association_for(field_name)
+        resolved_class.association_reflections[field_name]
+      end
+
+      def set_attribute(field_name, value)
+        _instance.send("#{field_name}=", value)
+      end
+
+      def set_association(association, field_name, value)
+        _instance.associations[field_name] = value
+        _instance.after_save_hook do
+          value.each { |o| _instance.send(association.add_method, o) }
+        end
+      end
+
       def load_instance_hooks
         klass = resolved_class.respond_to?(:cti_base_model) ? resolved_class.cti_models.first : resolved_class
         klass.plugin :instance_hooks unless klass.new.respond_to? :after_save_hook

data/lib/fabrication/support.rb

@@ -34,9 +34,9 @@ module Fabrication
       if name_string.respond_to?(:camelize)
         name_string.camelize
       else
-        name_string.gsub(%r{/(.?)}) do
-          "::#{Regexp.last_match(1).upcase}"
-        end.gsub(/(?:^|_)(.)/) { Regexp.last_match(1).upcase }
+        name_string
+          .gsub(%r{/(.?)}) { "::#{Regexp.last_match(1).upcase}" }
+          .gsub(/(?:^|_)(.)/) { Regexp.last_match(1).upcase }
       end
     end
 

data/lib/fabrication/version.rb

@@ -1,3 +1,3 @@
 module Fabrication
-  VERSION = '2.29.0'.freeze
+  VERSION = '2.30.0'.freeze
 end

data/lib/fabrication.rb

@@ -51,7 +51,7 @@ module Fabrication
   end
 
   def self.schematics
-    Support.log_deprecation('Fabrication.schematics has been replaced by '\
+    Support.log_deprecation('Fabrication.schematics has been replaced by ' \
                             'Fabrication.manager and will be removed in 3.0.0.')
     manager
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fabrication
 version: !ruby/object:Gem::Version
-  version: 2.29.0
+  version: 2.30.0
 platform: ruby
 authors:
 - Paul Elliott
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-06-22 00:00:00.000000000 Z
+date: 2022-07-25 00:00:00.000000000 Z
 dependencies: []
 description: Fabrication is an object generation framework for ActiveRecord, Mongoid,
   DataMapper, Sequel, or any other Ruby object.
@@ -77,7 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Generates object instances for test suites, seed files, etc.