fabrication 0.2.1 → 0.2.2

data/README.markdown

@@ -52,4 +52,4 @@ So you already have a company fabricator, but you need one that specifically gen
       type "LLC"
     end
 
-Setting the :from option will inherit the class and all the attributes from the named Fabricator.
+Setting the :from option will inherit the class and all the attributes from the named Fabricator. Even if you haven't defined a :company Fabricator yet, it will still work as long as it references an actual class name.

data/lib/fabrication.rb

@@ -12,6 +12,7 @@ module Fabrication
   class << self
 
     def schematic(name, options, &block)
+      raise DuplicateFabricatorError if fabricators.has_key?(name)
       parent = fabricators[options[:from]]
       if parent
         class_name = parent.class_name
@@ -53,6 +54,7 @@ module Fabrication
 
     private
 
+    @@fabricators = nil
     def fabricators
       @@fabricators ||= {}
     end

data/lib/fabrication/errors.rb

@@ -1,5 +1,7 @@
 module Fabrication
 
+  class DuplicateFabricatorError < StandardError; end
+
   class UnknownFabricatorError < StandardError; end
 
 end

data/lib/fabrication/version.rb

@@ -1,3 +1,3 @@
 module Fabrication
-  VERSION = '0.2.1'
+  VERSION = '0.2.2'
 end

data/spec/fabrication_spec.rb

@@ -117,7 +117,7 @@ describe Fabrication do
     before(:all) { TestMigration.up }
     after(:all) { TestMigration.down }
 
-    before do
+    before(:all) do
       Fabricator(:company) do
         name { Faker::Company.name }
         divisions(:force => true, :count => 4) { Fabricate(:division) }
@@ -151,13 +151,15 @@ describe Fabrication do
 
   context 'with a mongoid document' do
 
-    let(:author) do
+    before(:all) do
       Fabricator(:author) do
         name "George Orwell"
         books(:count => 4) { |author, i| "book title #{i}" }
-      end.fabricate
+      end
     end
 
+    let(:author) { Fabricate(:author) }
+
     it "sets the author name" do
       author.name.should == "George Orwell"
     end
@@ -197,7 +199,6 @@ describe Fabrication do
     context 'and a class name as a parent' do
 
       before(:all) do
-        Fabrication.clear_definitions
         Fabricator(:hemingway, :from => :author) do
           name 'Ernest Hemingway'
         end
@@ -230,4 +231,30 @@ describe Fabrication do
 
   end
 
+  context 'when defining a fabricator twice' do
+
+    before(:all) do
+      Fabricator(:author) {}
+    end
+
+    it 'throws an error' do
+      lambda { Fabricator(:author) {} }.should raise_error(Fabrication::DuplicateFabricatorError)
+    end
+
+  end
+
+  context 'when generating from a non-existant fabricator' do
+
+    it 'throws an error' do
+      lambda { Fabricate(:author) }.should raise_error(Fabrication::UnknownFabricatorError)
+    end
+
+  end
+
+  context 'defining a fabricator without a block' do
+
+    it 'works fine'
+
+  end
+
 end

data/spec/spec_helper.rb

@@ -11,6 +11,7 @@ require 'mongoid'
 
 Spec::Runner.configure do |config|
   config.before(:all) do
+    Fabrication.clear_definitions
     Author.delete_all
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: fabrication
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: false
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Paul Elliott