fablicop 1.1.1 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6569d42b358ee7df8ca5eabfa95d57750e05dd57cb80f2994f54b9cab6658816
-  data.tar.gz: 36dbc034a61fe4c3d972d3b5fdfc53603cfc1fed4bdf1ae58f22c64ab3c98977
+  metadata.gz: 1da5be309dccb18d67bc391f16abb3ebd46082e6c86d09de815bf315d3c55451
+  data.tar.gz: bf2e87b986ee9a0ffdadc8fbf07b6b1b6a9e5684bc0197cba4df486bf01aff86
 SHA512:
-  metadata.gz: dc26ed8cebee6f4bbbe62e7d34f42a244badecafcbae9c58c63a011e50a2b612d431f51d8202351031594ca55e2e48d4d2ef8c1eb9daca52c065801f39c31204
-  data.tar.gz: ecb8d33f436d7b3c4e1d657b57438785952a6038d8eb055ca777a9ddf04bf091f734d7d32447364eccddcd58871363a7d24b15b16da2ebcf88d9828c6b3a4f4b
+  metadata.gz: ca1d101129fe52739eeb75a4b8834688ed8aa49661b0b5b64f6561a43158439b311634f54490f6f15f82d0ec864ed6fc8d69c07858d64686968610bf2de52f9f
+  data.tar.gz: 94079ae388b96daf77a1c24ffa4c779f15f56ca6492a2d0d98824dd468b57dfd057e572b4c379e482ae011bbd6d192f94077e0fbe788879d8ca738c8927af5d2

data/.github/dependabot.yml

@@ -0,0 +1,17 @@
+version: 2
+updates:
+  - package-ecosystem: bundler
+    directory: "/"
+    schedule:
+      interval: daily
+      time: "09:00"
+      timezone: Asia/Tokyo
+  - package-ecosystem: github-actions
+    directory: "/"
+    schedule:
+      interval: weekly
+      time: "09:00"
+      timezone: Asia/Tokyo
+    ignore:
+      - dependency-name: "*"
+        update-types: ["version-update:semver-minor", "version-update:semver-patch"]

data/.github/workflows/run-ci.yml

@@ -14,7 +14,7 @@ jobs:
       matrix:
         ruby: ["2.5", "2.6", "2.7", "3.0"]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
@@ -28,7 +28,7 @@ jobs:
       matrix:
         ruby: ["2.5", "2.6", "2.7", "3.0"]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}

data/CHANGELOG.md

@@ -0,0 +1,12 @@
+# Changelog
+
+## [Unreleased](https://github.com/Fablic/fablicop/tree/HEAD)
+
+[Full Changelog](https://github.com/Fablic/fablicop/compare/v1.2.1...HEAD)
+
+## [v1.2.1](https://github.com/Fablic/fablicop/tree/v1.2.1) (2022-04-15)
+
+[Full Changelog](https://github.com/Fablic/fablicop/compare/v0.1.0...v0.2.0)
+
+- Update rubocop requirement from ~> 1.14.0 to >= 1.14, < 1.28 [\#71](https://github.com/Fablic/fablicop/pull/71) ([dependabot](https://github.com/apps/dependabot))
+- disable `RSpec/ExampleLength` and `RSpec/NamedSubject` [\#70](https://github.com/Fablic/fablicop/pull/70) ([tana2034](https://github.com/tana2034))

data/README.md

@@ -1,7 +1,9 @@
+![fablicop](https://img.shields.io/gem/v/fablicop?label=fablicop)
+
 # fablicop
 
 fablicop is a RuboCop configration gem.
-It assumes your project is using Ruby on Rails, so some Cops prefixed with `Rails` are enabled out of the box.
+It assumes your project is using Ruby on Rails and RSpec, so some Cops prefixed with `Rails` and `RSpec` are enabled out of the box.
 In other words, it's not appropriate to use it with non-Rails projects.
 
 ## Installation

data/config/.base_rubocop.yml

@@ -210,7 +210,10 @@ Metrics/BlockLength:
     - "app/admin/*.rb"
     - "config/**/*.rb"
 
+# We discussed internally about this parameter and decided to follow this configuration.
+# https://github.com/onk/onkcop/blob/8066859d3d00328146c1da9e57bdd4a951974ef2/config/rubocop.yml#L113-L116
 Metrics/AbcSize:
+  Max: 20
   Exclude:
     - "test/**/*.rb"
 
@@ -222,3 +225,17 @@ Metrics/ClassLength:
 # There are many things to think about before taking care of it.
 Naming/RescuedExceptionsVariableName:
   Enabled: false
+
+##################### RSpec ##################################
+
+# disabling to not to show errors if there is no when/with/without in the context
+RSpec/ContextWording:
+  Enabled: false
+
+# controller specs and request specs are hard to name reasonably
+RSpec/NamedSubject:
+  Enabled: false
+
+# because response validation in `request spec` is expected to result in large rows
+RSpec/ExampleLength:
+  Enabled: false

data/fablicop.gemspec

@@ -30,10 +30,11 @@ Gem::Specification.new do |spec|
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
+  spec.metadata['rubygems_mfa_required'] = 'true'
 
   spec.required_ruby_version = '>= 2.5.0'
 
-  spec.add_dependency 'rubocop', '~> 1.14.0'
+  spec.add_dependency 'rubocop', '>= 1.14', '< 1.28'
   spec.add_dependency 'rubocop-rspec', '>= 1.15.1'
   spec.add_dependency 'rubocop-rails'
   spec.add_development_dependency 'bundler'

data/lib/fablicop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Fablicop
-  VERSION = '1.1.1'
+  VERSION = '1.2.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fablicop
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.1
 platform: ruby
 authors:
 - tommy
@@ -10,22 +10,28 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-09-01 00:00:00.000000000 Z
+date: 2022-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.14'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.14.0
+        version: '1.28'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.14'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.14.0
+        version: '1.28'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -120,10 +126,12 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
 - ".github/workflows/run-ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -141,7 +149,8 @@ files:
 homepage: https://github.com/Fablic/fablicop
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -157,7 +166,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: fablicop is a RuboCop configration gem.