fablicop 1.0.5 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3bc4d692f130353295d26cb6fa68f40f807d1979
-  data.tar.gz: 2625e6a6435135bb9cdf36664cdb29013d6bef7a
+SHA256:
+  metadata.gz: 6b5caa1ee8828550cee968cb6207cc13bed218e6807a40411856ba69a43cb534
+  data.tar.gz: 8cb4ecff9101a1e21e308b7bb72614c1f85311dd5a089bf8802c2d14b9907f50
 SHA512:
-  metadata.gz: 169b5712345819a2f7e6f0ab3757c833ea094e091be1c64a3fa0e7ee9e46c9f40d7f0c2d0d67de8316481288e3373fdcaf04ff44e52e951cfa783b29d8a463f5
-  data.tar.gz: 3f86995b09726eba27128e6e429252aa9d7e5c6d6b96b6e4e91d6e2515a213e1def13386e14e4f0e67944204b7bb1142c8500e5198489152dc959186541ab6d5
+  metadata.gz: af21d0e9d4474a040648c2163ae72555c5c10d887793a4c5cbb7337ef59039355b00eb6223bc13a2d2f24e00a02524991a63bd2ea01d00039cd7fdbac1618d0d
+  data.tar.gz: 4c3bc61b9626a3b899e84cc6cfeedcf1971cc9d8ca048e9332d6fcd9813fc5d82fa9be4e97d3fbdac17b0a15e14c52cef252cde9a158a8de1fe00e4d57cba03d

data/.github/workflows/run-ci.yml

@@ -0,0 +1,17 @@
+name: Run CI
+
+on: push
+
+jobs:
+  'run-ci':
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+      uses: ruby/setup-ruby@v1
+      with:
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run rspecs
+      run: bundle exec rspec

data/.rspec

@@ -0,0 +1,3 @@
+--format documentation
+--color
+--require spec_helper

data/.rubocop.yml

@@ -1,2 +1 @@
-inherit_gem:
-  fablicop: "config/base_rubocop.yml"
+inherit_from: config/.base_rubocop.yml

data/.ruby-version

@@ -1 +1 @@
-2.3.1
+2.5.5

data/README.md

@@ -20,9 +20,6 @@ inherit_gem:
     # - "config/rails.yml"
     # uncomment if use rspec cops
     # - "config/rspec.yml"
-
-AllCops:
-  TargetRubyVersion: 2.3
 ```
 
 ```sh

data/config/.base_rubocop.yml

@@ -1,3 +1,6 @@
+require:
+  - rubocop-rails
+
 # 自動生成されるものやテストデータはチェック対象から除外する
 AllCops:
   Exclude:
@@ -10,13 +13,29 @@ AllCops:
     - "spec/test_app/db/*"
 
   DisplayCopNames: true
-  TargetRubyVersion: 2.3
+  NewCops: enable # 新しい規約も随時取り入れる
+
 Rails:
   Enabled: true
+
 # rails >= 5 の設定のため
 Rails/HttpPositionalArguments:
   Enabled: false
 
+Rails/InverseOf:
+  Enabled: false
+
+Rails/UnknownEnv:
+  Environments:
+    - production
+    - staging
+    - development
+    - local
+    - test
+
+Gemspec/OrderedDependencies:
+  Enabled: false
+
 ##################### Style ##################################
 
 # 日本語のコメントを許可する
@@ -63,6 +82,43 @@ Style/MultilineBlockChain:
   Enabled: false
 Style/EmptyMethod:
   Enabled: false
+
+# 候補が多いときはcondみたいに使いたい
+Style/EmptyCaseCondition:
+  Enabled: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/MethodCallWithoutArgsParentheses:
+  Enabled: false
+
+Style/DefWithParentheses:
+  Enabled: false
+
+# classが入れ子になった場合、テストの順番によってはエラーになりうる
+Style/ClassAndModuleChildren:
+  Exclude:
+    - "test/**/*.rb"
+    - "spec/**/*.rb"
+
+# 3桁ごとに_を入れるとSQLの表示方法と乖離するためfixtureは対象外
+Style/NumericLiterals:
+  Exclude:
+    - "db/fixtures/*.rb"
+
+##################### Layout ##################################
+# 引数前のスペースは複数許可
+Layout/SpaceBeforeFirstArg:
+  Enabled: false
+Layout/SpaceInLambdaLiteral:
+  Enabled: false
+Layout/HeredocIndentation:
+  Enabled: false
+
 # 引数の書き方の多様性を許可
 # foo(a,
 #  b
@@ -104,25 +160,6 @@ Layout/MultilineMethodCallIndentation:
 Layout/FirstParameterIndentation:
   Enabled: false
 
-# 候補が多いときはcondみたいに使いたい
-Style/EmptyCaseCondition:
-  Enabled: false
-
-Style/DoubleNegation:
-  Enabled: false
-
-Style/ParallelAssignment:
-  Enabled: false
-
-Style/BracesAroundHashParameters:
-  Enabled: false
-
-Style/MethodCallWithoutArgsParentheses:
-  Enabled: false
-
-Style/DefWithParentheses:
-  Enabled: false
-
 # 以下の両方を許容
 #   aaa.
 #     bb().
@@ -135,24 +172,23 @@ Style/DefWithParentheses:
 Layout/DotPosition:
   Enabled: false
 
-# classが入れ子になった場合、テストの順番によってはエラーになりうる
-Style/ClassAndModuleChildren:
+# fixtureファイルの1行 -> DBの1レコードとして記述している
+# 複数行にまたがると直感的でなくなるため無効化
+Layout/ClosingParenthesisIndentation:
   Exclude:
-    - "test/**/*.rb"
-    - "spec/**/*.rb"
+    - "db/fixtures/*.rb"
+Layout/ParameterAlignment:
+  Exclude:
+    - "db/fixtures/*.rb"
 
-##################### Layout ##################################
-# 引数前のスペースは複数許可
-Layout/SpaceBeforeFirstArg:
-  Enabled: false
-Layout/SpaceInLambdaLiteral:
-  Enabled: false
-Layout/IndentHeredoc:
-  Enabled: false
-Layout/MultilineMethodCallBraceLayout:
-  Enabled: false
-Layout/MultilineMethodCallIndentation:
-  Enabled: false
+# * 警告 120文字
+# * 禁止 160文字
+# のイメージ
+Layout/LineLength:
+  Max: 160
+  Exclude:
+    - "db/migrate/*.rb"
+    - "db/fixtures/*.rb" # カラムが多い、もしくは文章が含まれるfixtureは一行が長くなってしまうため無効化
 
 ##################### Lint ##################################
 
@@ -162,14 +198,6 @@ Lint/ParenthesesAsGroupedExpression:
 
 ##################### Metrics ##################################
 
-# * 警告 120文字
-# * 禁止 160文字
-# のイメージ
-Metrics/LineLength:
-  Max: 160
-  Exclude:
-    - "db/migrate/*.rb"
-
 # 20 行超えるのは migration ファイル以外滅多に無い
 Metrics/MethodLength:
   Max: 20
@@ -177,7 +205,7 @@ Metrics/MethodLength:
     - "db/migrate/*.rb"
 
 # キーワード引数は引数の数に含めない
-ParameterLists:
+Metrics/ParameterLists:
   CountKeywordArgs: false
 
 Metrics/BlockLength:
@@ -188,27 +216,15 @@ Metrics/BlockLength:
     - "app/admin/*.rb"
     - "config/**/*.rb"
 
-# Explicitly set the default value 15
 Metrics/AbcSize:
-  Max: 15
   Exclude:
     - "test/**/*.rb"
 
-# キーワード引数は引数の数に含めない
-ParameterLists:
-  CountKeywordArgs: false
-
 Metrics/ClassLength:
   Exclude:
     - "test/**/*.rb"
 
-Rails/UnknownEnv:
-  Environments:
-    - production
-    - staging
-    - development
-    - local
-    - test
-
-Gemspec/OrderedDependencies:
+# Does the variable name for an exception object really matter?
+# There are many things to think about before taking care of it.
+Naming/RescuedExceptionsVariableName:
   Enabled: false

data/fablicop.gemspec

@@ -30,8 +30,11 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.53.0"
+  spec.add_dependency "rubocop", "~> 1.14.0"
   spec.add_dependency "rubocop-rspec", ">= 1.15.1"
+  spec.add_dependency "rubocop-rails"
   spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rspec"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency 'byebug'
 end

data/lib/fablicop/version.rb

@@ -1,3 +1,3 @@
 module Fablicop
-  VERSION = '1.0.5'
+  VERSION = '1.1.0'
 end

data/templates/.rubocop.yml

@@ -5,6 +5,3 @@ inherit_gem:
     # - "config/rails.yml"
     # uncomment if use rspec cops
     # - "config/rspec.yml"
-
-AllCops:
-  TargetRubyVersion: 2.3

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: fablicop
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.1.0
 platform: ruby
 authors:
 - tommy
 - ujihisa
 - sinamon129
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2018-08-20 00:00:00.000000000 Z
+date: 2021-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.53.0
+        version: 1.14.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.53.0
+        version: 1.14.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -40,6 +40,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.15.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -54,6 +68,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -68,6 +96,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: fablicop is a RuboCop configration gem.
 email:
 - kazushige_tominaga@fablic.co.jp
@@ -78,7 +120,9 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/run-ci.yml"
 - ".gitignore"
+- ".rspec"
 - ".rubocop.yml"
 - ".ruby-version"
 - CODE_OF_CONDUCT.md
@@ -99,7 +143,7 @@ homepage: https://github.com/Fablic/fablicop
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -114,9 +158,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.7.6.2
+signing_key:
 specification_version: 4
 summary: fablicop is a RuboCop configration gem.
 test_files: []