ezmetrics 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6dca2c75bfaae789d33af8f319e5c6ff86772f480d4d2f6549f044f4bfe12586
-  data.tar.gz: 259881b87a073eaceb729b402166d185b3d66ee48af1727e27cc78a8ae5c226c
+  metadata.gz: df2d108f37b4f0a5988f72ad465c531d0559ef651c78e3f58aa72f7c9fcc0a3c
+  data.tar.gz: a1b871a56189e2035289a976e508dd437125c8a6bc9fa29dfbb47402096faf1b
 SHA512:
-  metadata.gz: 119325aef351ecbb8cf54a80941474904b727207ed658298f04e225bb54c99f2e47509a42f076fd1ddbe034f86d48db2b9692dbd5498c1e594903253aa4f65d6
-  data.tar.gz: fe97199f23bfac6eddf90755bfbcf74ff524b6735cf340b1dcbb625c9f66dfa4bd021733dccb7ba0d7c63aca6cb6ae6dd5523ba478fbd7ca22f1f91b33c3d661
+  metadata.gz: ad8ce6744522f55b65029bffeb8d56491ce188c29870a5560389ea44795131999bbe6f9d11d3a444831c49c2c0aad2f2b8bca448cdd2c18c5a11ba8d04216889
+  data.tar.gz: 80c76c1709db877c71063650db012b423116232a32f6ff5d9c17262e43e80e8696d4a0fc687b798291551ca5f0f6b84f3f7ae7a635ecad644f09628daf842cd1

data/lib/ezmetrics.rb

@@ -176,16 +176,16 @@ class EZmetrics
 
     percentile = aggregation_function.match(/percentile_(?<value>\d+)/)
 
-    if percentile && percentile["value"]
+    if percentile && percentile["value"].to_i.between?(1, 99)
       sorted_values = send("sorted_#{metrics}_values")
-      percentile(sorted_values, percentile["value"].to_i)&.round
+      percentile(sorted_values, percentile["value"].to_i)
     end
   end
 
   METRICS.each do |metrics|
     define_method "sorted_#{metrics}_values" do
       instance_variable_get("@sorted_#{metrics}_values") || instance_variable_set(
-        "@sorted_#{metrics}_values", interval_metrics.map { |array| array[schema["#{metrics}_values"]] }.flatten.compact
+        "@sorted_#{metrics}_values", interval_metrics.map { |array| array[schema["#{metrics}_values"]] }.flatten.compact.sort
       )
     end
   end
@@ -234,12 +234,12 @@ class EZmetrics
     interval_metrics.max { |array| array[schema[metrics]] }[schema[metrics]].round
   end
 
-  def percentile(array, pcnt)
-    sorted_array = array.sort
+  def percentile(sorted_array, pcnt)
+    array_length = sorted_array.length
 
-    return nil if array.length == 0
+    return "not enough data (requests: #{array_length}, required: #{pcnt})" if array_length < pcnt
 
-    rank  = (pcnt.to_f / 100) * (array.length + 1)
+    rank  = (pcnt.to_f / 100) * (array_length + 1)
     whole = rank.truncate
 
     # if has fractional part
@@ -249,9 +249,9 @@ class EZmetrics
 
       f = (rank - rank.truncate).abs
 
-      return (f * (s1 - s0)) + s0
+      return ((f * (s1 - s0)) + s0)&.round
     else
-      return sorted_array[whole - 1]
+      return (sorted_array[whole - 1])&.round
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ezmetrics
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Nicolae Rotaru