ezid-client 1.4.3 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8ea959d0a4ad802fe303de44bb8c29e1965f5a48
-  data.tar.gz: 57fe107c3f5ad349b0a5346373aaacbf34327002
+  metadata.gz: 5e7662a25f1a8f0b0c027298428ed9ee5714137c
+  data.tar.gz: ae70777a70f7ffb50fb00e49e3c86c305e0721d0
 SHA512:
-  metadata.gz: 8ac268c722275e747f5911820fdc21aaee8b73a7dc91018d302b7ee8c58936ba59ac5a9facfdf3365d4b62ff1c860af590872b8a78dc72ccc5be423a7d9f1909
-  data.tar.gz: d87305f706278ce48b428b515d9dd1d397d2fc2b28d7278236695596d9f5fc08c74999fa1fef9d994f4b8f7d62e1bd7108a391893babc076d91b714213dea82d
+  metadata.gz: 68d2a8953cdf238fb34fbb861129b2a34a1e42e1aded1f3a56e3ed720507a67f4313ca67ed6ffe5e59567769c5556fedcf52ebdd69a9e500c0fb1e0893db9bf2
+  data.tar.gz: 8a0763e0ff8922e9ae2b0c946acf16c8da5f9b64296235efc9f5a5aac2204bd234cf897cecb3af4d87a363f7aba2d95571ce8f15f7557f6ef21d02eed49aaba9

data/VERSION

@@ -1 +1 @@
-1.4.3
+1.5.0

data/ezid-client.gemspec

@@ -19,10 +19,10 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = "~> 2.0"
 
-  spec.add_dependency "hashie"
+  spec.add_dependency "hashie", "~> 3.4", ">= 3.4.3"
 
   spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 3.1"
-  spec.add_development_dependency "rspec-its"
+  spec.add_development_dependency "rake", "~> 10.5"
+  spec.add_development_dependency "rspec", "~> 3.4"
+  spec.add_development_dependency "rspec-its", "~> 1.2"
 end

data/lib/ezid/metadata.rb

@@ -54,14 +54,21 @@ module Ezid
       CREATED, DATACENTER, OWNER, OWNERGROUP, SHADOWEDBY, SHADOWS, UPDATED
     ].freeze
 
-    def initialize(data=nil)
+    # @param data [String, Hash, Ezid::Metadata] the initial data
+    # @param default [Object] DO NOT USE!
+    #   This param is included for compatibility with Hashie::Mash
+    #   and will raise a NotImplementedError if passed a non-nil value.
+    def initialize(data=nil, default=nil)
+      unless default.nil?
+        raise ::NotImplementedError, "ezid-client does not support default metadata values."
+      end
       super()
       update(data) if data
     end
 
     def elements
-      warn "[DEPRECATION] `elements` is deprecated and will be removed in ezid-client 2.0." \
-           " Use the Ezid::Metadata instance itself instead."
+      warn "[DEPRECATION] `Ezid::Metadata#elements` is deprecated and will be removed in ezid-client 2.0." \
+           " Use the `Ezid::Metadata` instance itself instead. (called from #{caller.first})"
       self
     end
 
@@ -112,6 +119,15 @@ module Ezid
       end
     end
 
+    # Overrides Hashie::Mash
+    def convert_value(value, duping=false)
+      if [self.class, Hash, Array].include?(value.class)
+        raise Error, "ezid-client does not support instances of #{value.class} as metadata values." \
+                     " Convert an enumerable such as an array to an appropriate string representation first."
+      end
+      value.to_s
+    end
+
     private
 
     def to_time(value)

data/spec/unit/metadata_spec.rb

@@ -1,12 +1,42 @@
 module Ezid
   RSpec.describe Metadata do
+    describe "initializer" do
+      it "raises an exception when called with a default value" do
+        expect { described_class.new(nil, 1) }.to raise_error(::NotImplementedError)
+      end
+    end
 
     describe "metadata accessors and aliases" do
       shared_examples "a metadata writer" do |writer|
+        let(:method) { "#{writer}=" }
         it "writes the \"#{writer}\" element" do
-          subject.send("#{writer}=", "value")
+          subject.send(method, "value")
           expect(subject[writer.to_s]).to eq("value")
         end
+        describe "when the value is a Metadata instance" do
+          it "raises an exception" do
+            expect { subject.send(method, Metadata.new({foo: "value1", bar: "value2"})) }
+              .to raise_error(Error)
+          end
+        end
+        describe "when the value is a Hash" do
+          it "raises an exception" do
+            expect { subject.send(method, {foo: "value1", bar: "value2"}) }
+              .to raise_error(Error)
+          end
+        end
+        describe "when the value is an Array" do
+          it "raises an exception" do
+            expect { subject.send(method, ["value1", "value2"]) }
+              .to raise_error(Error)
+          end
+        end
+        describe "when the value is another type" do
+          it "coerces to a string" do
+            subject.send(method, 1)
+            expect(subject[writer.to_s]).to eq "1"
+          end
+        end
       end
 
       shared_examples "a metadata reader" do |reader|
@@ -231,6 +261,5 @@ EOS
         end
       end
     end
-
   end
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: ezid-client
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.5.0
 platform: ruby
 authors:
 - David Chandek-Stark
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-21 00:00:00.000000000 Z
+date: 2016-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.4.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.4.3
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -42,44 +48,44 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.5'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.4'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.2'
 description: Ruby client for EZID API Version 2 (http://ezid.cdlib.org/doc/apidoc.html)
 email:
 - dchandekstark@gmail.com