ezcater_rubocop 9.0.0 → 11.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 337bff593d9c3f7c40060dadfa14b7539dd516b415099a032f0aaa3fa21cbc1a
-  data.tar.gz: 476b7cad539b35fbc6c72b007c7d1f6f2ea018d5ee5362c025388970c9fd6c98
+  metadata.gz: d963fafacbe84e6226ef7e2aaeead40880fe600a634cbaa382d7e1910819867f
+  data.tar.gz: 587b8aec48165ac29886b424deb5363f2fdef84e357dc6232793bdbda42227bb
 SHA512:
-  metadata.gz: 0d549c1553f5c45af6736b5687a1d2bb3e5adbc93b48a104686b5cc398e9d659336f1004eacc740b913d7214a07685c45b087af3db018b0535d5e5a236f6ffed
-  data.tar.gz: 432153e688f0fc386dfa4979c8443a96453f8a0f16d8be22a32683c98643e378854936084afa5f28ced2f36490396f79de853e822fad5e8d039e615a25d72e83
+  metadata.gz: be6f13204a46e8a977490b27d34d611b275a323400de01426b37b8605e7cef2542dc7a3d9ec936db0b39310ec4f7e3acde2467b6726b67950d21397cc1dd1e0c
+  data.tar.gz: 2c5097fff15d19754a457a025d60805d800e9a8bc7943f00af65ed5a1d540115133df6f98252fd1eed352f50224f5618746742863d83a72734addc30973855ac

data/.github/workflows/release.yml

@@ -0,0 +1,23 @@
+name: Release Gem
+on: workflow_dispatch
+
+jobs:
+  push:
+    name: Push gem to RubyGems.org
+    runs-on: ubuntu-latest
+
+    permissions:
+      id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
+      contents: write # IMPORTANT: this permission is required for `rake release` to push the release tag
+
+    steps:
+      # Set up
+      - uses: actions/checkout@v4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+          ruby-version: ruby
+
+      # Release
+      - uses: rubygems/release-gem@v1

data/CHANGELOG.md

@@ -6,6 +6,18 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
+## 11.0.0 (September 23, 2025)
+
+- Update all gem dependencies to the latest version
+
+## 10.1.0 (September 23, 2025)
+
+- Update deprecated syntax `max` to `exclude_limit` for the `MultipleExpectations` rule.
+
+## 10.0.0 (August 20, 2025)
+
+- Add `Ezcater/RspecNoResolveClassField` cop, which prevents using the deprecated GraphQL testing interface `resolve_class_field`.
+
 ## 9.0.0 (February 24, 2025)
 
 - Add support for `plugin` architecture in `rubocop >= 1.72.0` and `rubocop-rails >= 2.28.0`

data/Gemfile.lock

@@ -1,17 +1,19 @@
 PATH
   remote: .
   specs:
-    ezcater_rubocop (9.0.0)
+    ezcater_rubocop (11.0.0)
       parser (>= 2.6)
-      rubocop (>= 1.72.0, < 2.0)
-      rubocop-graphql (>= 0.14.0, < 1.0)
-      rubocop-rails (>= 2.28.0, < 3.0)
-      rubocop-rspec (>= 2.22.0, < 2.28.0)
+      rubocop (~> 1.80)
+      rubocop-capybara (~> 2.22)
+      rubocop-factory_bot (~> 2.27)
+      rubocop-graphql (~> 1.5)
+      rubocop-rails (~> 2.33)
+      rubocop-rspec (~> 3.7)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.2.2.1)
+    activesupport (7.2.2.2)
       base64
       benchmark (>= 0.3)
       bigdecimal
@@ -23,29 +25,30 @@ GEM
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
-    ast (2.4.2)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
+    ast (2.4.3)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.3)
     byebug (11.1.3)
     coderay (1.1.3)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.0)
+    connection_pool (2.5.4)
     diff-lcs (1.6.0)
     docile (1.4.1)
-    drb (2.2.1)
+    drb (2.2.3)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.10.1)
-    language_server-protocol (3.17.0.4)
+    json (2.15.0)
+    language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
-    logger (1.6.6)
+    logger (1.7.0)
     method_source (1.1.0)
-    minitest (5.25.4)
-    parallel (1.26.3)
-    parser (3.3.7.1)
+    minitest (5.25.5)
+    parallel (1.27.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
+    prism (1.5.1)
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -53,10 +56,10 @@ GEM
       byebug (~> 11.0)
       pry (>= 0.13, < 0.15)
     racc (1.8.1)
-    rack (3.1.10)
+    rack (3.2.1)
     rainbow (3.1.1)
     rake (13.2.1)
-    regexp_parser (2.10.0)
+    regexp_parser (2.11.3)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -72,7 +75,7 @@ GEM
     rspec-support (3.13.2)
     rspec_junit_formatter (0.6.0)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (1.72.2)
+    rubocop (1.80.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -80,27 +83,30 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.0)
-      parser (>= 3.3.1.0)
-    rubocop-capybara (2.21.0)
-      rubocop (~> 1.41)
-    rubocop-factory_bot (2.26.1)
-      rubocop (~> 1.61)
-    rubocop-graphql (0.19.0)
-      rubocop (>= 0.87, < 2)
-    rubocop-rails (2.30.2)
+    rubocop-ast (1.47.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-capybara (2.22.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-factory_bot (2.27.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-graphql (1.5.6)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1, < 2)
+    rubocop-rails (2.33.3)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.72.1, < 2.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rspec (2.27.1)
-      rubocop (~> 1.40)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    rubocop-rspec (3.7.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
     ruby-progressbar (1.13.0)
     securerandom (0.4.1)
     simplecov (0.22.0)
@@ -111,19 +117,20 @@ GEM
     simplecov_json_formatter (0.1.4)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
 
 PLATFORMS
   arm64-darwin-24
+  x86_64-linux
 
 DEPENDENCIES
   bundler
   ezcater_rubocop!
   pry-byebug
   rake (~> 13.0)
-  rspec (~> 3.11)
+  rspec (~> 3.13)
   rspec_junit_formatter
   simplecov
 

data/README.md

@@ -92,6 +92,7 @@ not add cops with `enabled: false` unless you want that cop to always be disable
 * [RequireGqlErrorHelpers](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/require_gql_error_helpers.rb) - Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.
 * [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" and "::<class method>" for example group description.
 * [RspecMatchOrderedArray](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb) - Enforce use of `match_ordered_array` matcher instead of `eq` matcher. This matcher comes from the [ezcater_matchers](https://github.com/ezcater/ezcater_matchers) gem.
+* [RspecNoResolveClassField](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_no_resolve_class_field.rb) - Do not use deprecated GraphQL testing interface `resolve_class_field`.
 * [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
 * [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.
 * [RspecRequireHttpStatusMatcher](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb) - Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`
@@ -108,7 +109,7 @@ To install this gem onto your local machine, run `bundle exec rake install`.
 
 ### Releasing a New Version
 
-To release a new version, update the version number in `version.rb`, merge your PR to `main`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To release a new version, update the version number in `version.rb`, merge your PR to `main`, and then manually run the "Release Gem" GitHub Action, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 

data/conf/rubocop.yml

@@ -1,7 +1,12 @@
-require: ezcater_rubocop
+require:
+  - ezcater_rubocop
 
 plugins:
+  - rubocop-capybara
+  - rubocop-factory_bot
+  - rubocop-graphql
   - rubocop-rails
+  - rubocop-rspec
 
 AllCops:
   DisplayCopNames: true
@@ -245,7 +250,7 @@ Capybara/CurrentPathExpectation:
 Capybara/VisibilityMatcher:
   Enabled: true
 
-RSpec/Capybara/FeatureMethods:
+RSpec/Dialect:
   Enabled: true
 
 RSpec/EmptyHook:
@@ -266,9 +271,6 @@ RSpec/MultipleMemoizedHelpers:
 RSpec/NotToNot:
   Enabled: true
 
-RSpec/Rails/HttpStatus:
-  Enabled: true
-
 RSpec/RepeatedIncludeExample:
   Enabled: true
 

data/config/default.yml

@@ -75,6 +75,12 @@ GraphQL/ExtractInputType:
   Exclude:
     - "**/input_objects/**/*.rb"
 
+Ezcater/RspecNoResolveClassField:
+  Description: "Do not use `resolve_class_field` in spec files."
+  Enabled: true
+  Include:
+    - "**/*_spec.rb"
+
 Ezcater/Migration/BigintForeignKey:
   Description: "Use `bigint` instead of `integer` for all foreign keys."
   Include:

data/ezcater_rubocop.gemspec

@@ -47,13 +47,15 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "rake", "~> 13.0"
-  spec.add_development_dependency "rspec", "~> 3.11"
+  spec.add_development_dependency "rspec", "~> 3.13"
   spec.add_development_dependency "rspec_junit_formatter"
   spec.add_development_dependency "simplecov"
 
   spec.add_runtime_dependency "parser", ">= 2.6"
-  spec.add_runtime_dependency "rubocop", ">= 1.72.0", "< 2.0"
-  spec.add_runtime_dependency "rubocop-graphql", ">= 0.14.0", "< 1.0"
-  spec.add_runtime_dependency "rubocop-rails", ">= 2.28.0", "< 3.0"
-  spec.add_runtime_dependency "rubocop-rspec", ">= 2.22.0", "< 2.28.0"
+  spec.add_runtime_dependency "rubocop", "~> 1.80"
+  spec.add_runtime_dependency "rubocop-capybara", "~> 2.22"
+  spec.add_runtime_dependency "rubocop-factory_bot", "~> 2.27"
+  spec.add_runtime_dependency "rubocop-graphql", "~> 1.5"
+  spec.add_runtime_dependency "rubocop-rails", "~> 2.33"
+  spec.add_runtime_dependency "rubocop-rspec", "~> 3.7"
 end

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "9.0.0"
+  VERSION = "11.0.0"
 end

data/lib/ezcater_rubocop.rb

@@ -31,5 +31,6 @@ require_relative "rubocop/cop/ezcater/rspec_require_browser_mock"
 require_relative "rubocop/cop/ezcater/rspec_require_feature_flag_mock"
 require_relative "rubocop/cop/ezcater/rspec_require_http_status_matcher"
 require_relative "rubocop/cop/ezcater/rspec_dot_not_self_dot"
+require_relative "rubocop/cop/ezcater/rspec_no_resolve_class_field"
 require_relative "rubocop/cop/ezcater/style_dig"
 require_relative "rubocop/cop/ezcater/migration/bigint_foreign_key"

data/lib/rubocop/cop/ezcater/migration/bigint_foreign_key.rb

@@ -192,8 +192,8 @@ module RuboCop
             # There's no hash argument or it has only one pair
             if node.arguments.size == 1 ||
                (node.arguments.size == 2 &&
-                (node.arguments[1].hash_type? &&
-                 node.arguments[1].pairs.size == 1))
+                node.arguments[1].hash_type? &&
+                node.arguments[1].pairs.size == 1)
 
               corrector.replace(
                 range_for_method_and_optional_limit(node),
@@ -223,8 +223,8 @@ module RuboCop
             # There's no hash argument or it has only one pair (:limit)
             if node.arguments.size == 3 ||
                (node.arguments.size == 4 &&
-                (node.arguments[3].hash_type? &&
-                 node.arguments[3].pairs.size == 1))
+                node.arguments[3].hash_type? &&
+                node.arguments[3].pairs.size == 1)
 
               corrector.replace(
                 range_for_method_and_optional_limit(node),

data/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb

@@ -25,7 +25,7 @@ module RuboCop
 
       class RspecDotNotSelfDot < Base
         include RuboCop::RSpec::Language
-        extend RuboCop::RSpec::Language::NodePattern
+        extend RuboCop::NodePattern::Macros
         extend RuboCop::Cop::AutoCorrector
 
         RSPEC_EXAMPLE_PREFIXES = ["", "x", "f"].freeze

data/lib/rubocop/cop/ezcater/rspec_no_resolve_class_field.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Ezcater
+      # Do not use `resolve_class_field`.
+      #
+      # @example
+      #
+      #   # bad
+      #   resolve_class_field(:user, :name)
+      #   resolve_class_field(:user, [:name])
+      #   obj.resolve_class_field(:user, :name)
+      #
+      #   # good
+      #   execute(EzrailsSchema, query, variables: { id: }, context: graphql_context)
+      #
+      #   More information: https://engportal.ezcater.com/docs/default/component/dev-handbook/technology/graphql/backend_implementation/testing/#recommendation
+      #
+      class RspecNoResolveClassField < Base
+        MSG = "Do not use `resolve_class_field`. Use a query instead."
+
+        def_node_matcher :resolve_class_field_call?, <<~PATTERN
+          {
+            (send nil? :resolve_class_field ...)
+            (send _ :resolve_class_field ...)
+          }
+        PATTERN
+
+        def on_send(node)
+          return unless resolve_class_field_call?(node)
+
+          add_offense(node, message: MSG)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 9.0.0
+  version: 11.0.0
 platform: ruby
 authors:
 - ezCater, Inc
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-02-24 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,14 +57,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.11'
+        version: '3.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.11'
+        version: '3.13'
 - !ruby/object:Gem::Dependency
   name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
@@ -112,82 +111,86 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.72.0
-    - - "<"
+        version: '1.80'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.80'
+- !ruby/object:Gem::Dependency
+  name: rubocop-capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.22'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.22'
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.72.0
-    - - "<"
+        version: '2.27'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.27'
 - !ruby/object:Gem::Dependency
   name: rubocop-graphql
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.14.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.14.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.28.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '2.33'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.28.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '2.33'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.22.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.28.0
+        version: '3.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.22.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.28.0
+        version: '3.7'
 description: ezCater custom cops and shared configuration
 email:
 - engineering@ezcater.com
@@ -200,6 +203,7 @@ files:
 - ".github/PULL_REQUEST_TEMPLATE.md"
 - ".github/workflows/codeql.yml"
 - ".github/workflows/dependency-review.yml"
+- ".github/workflows/release.yml"
 - ".tool-versions"
 - CHANGELOG.md
 - Gemfile
@@ -227,6 +231,7 @@ files:
 - lib/rubocop/cop/ezcater/require_gql_error_helpers.rb
 - lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb
 - lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb
+- lib/rubocop/cop/ezcater/rspec_no_resolve_class_field.rb
 - lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb
@@ -238,7 +243,6 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -253,8 +257,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: ezCater custom cops and shared configuration
 test_files: []