ezcater_rubocop 8.1.0 → 10.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2a15bcc812b70fc80eeec6fc23e6e42f3ab5083292e558721b93096af34db61
-  data.tar.gz: c03044d686ebd1eb695988ab440eb80ca1efe929b91f96a87615a9683596883e
+  metadata.gz: 71c0339727c6e2f10a7feb608f5ddeeb1a6c1300fd10e2bffac5f930c60c1f16
+  data.tar.gz: 9493e102e561b4421bdf0251c2ea94340b29f663eec2b472c71de7f7945c1cad
 SHA512:
-  metadata.gz: 75618a8349b879090e8f7ef1a83c923fb15742db3f6975ade39bd4402ade7532724197d6dae3f6fe336348136ef5596e5bceb16f0dea41489a5fc923ba75563e
-  data.tar.gz: 119974969557ec72d6ad84f061b99714ea085a9f2547252813f572c5ce7573569ca2f45517b703945941320bf07029e2459939e9ffa877e80504693e8ba68b48
+  metadata.gz: 7f499de02f76fe35e019a2e1a7d417ecdbb52c5ae91ea947d3771870d7af3df5b4aefe107e52567101cf6cb6c8f36633e016951eca235320551430f2d37b0d94
+  data.tar.gz: b2d058f36bbabbff2658cbba0ec6a586c45c9fa5ac4ef80f898de8688353bd791a655cbb6014dce474ee47ca198fa1c3c885f2ae5d3b8acb464ffb51eb02ddd2

data/.github/workflows/release.yml

@@ -0,0 +1,23 @@
+name: Release Gem
+on: workflow_dispatch
+
+jobs:
+  push:
+    name: Push gem to RubyGems.org
+    runs-on: ubuntu-latest
+
+    permissions:
+      id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
+      contents: write # IMPORTANT: this permission is required for `rake release` to push the release tag
+
+    steps:
+      # Set up
+      - uses: actions/checkout@v4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+          ruby-version: ruby
+
+      # Release
+      - uses: rubygems/release-gem@v1

data/CHANGELOG.md

@@ -6,7 +6,19 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
-## 8.0.1 (February 20, 2025)
+## 10.1.0 (September 23, 2025)
+
+- Update deprecated syntax `max` to `exclude_limit` for the `MultipleExpectations` rule.
+
+## 10.0.0 (August 20, 2025)
+
+- Add `Ezcater/RspecNoResolveClassField` cop, which prevents using the deprecated GraphQL testing interface `resolve_class_field`.
+
+## 9.0.0 (February 24, 2025)
+
+- Add support for `plugin` architecture in `rubocop >= 1.72.0` and `rubocop-rails >= 2.28.0`
+
+## 8.1.0 (February 20, 2025)
 
 - Pin maximum versions of `rubocop` and `rubocop-rails` to the versions before they moved to the `plugin` architecture in 1.72 and 2.28, respectively
 

data/Gemfile.lock

@@ -1,11 +1,11 @@
 PATH
   remote: .
   specs:
-    ezcater_rubocop (8.1.0)
+    ezcater_rubocop (10.1.0)
       parser (>= 2.6)
-      rubocop (>= 1.16.0, < 1.72.0)
+      rubocop (>= 1.72.0, < 2.0)
       rubocop-graphql (>= 0.14.0, < 1.0)
-      rubocop-rails (>= 2.10.1, < 2.28.0)
+      rubocop-rails (>= 2.28.0, < 3.0)
       rubocop-rspec (>= 2.22.0, < 2.28.0)
 
 GEM
@@ -36,8 +36,9 @@ GEM
     drb (2.2.1)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.10.1)
+    json (2.10.2)
     language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
     logger (1.6.6)
     method_source (1.1.0)
     minitest (5.25.4)
@@ -52,7 +53,7 @@ GEM
       byebug (~> 11.0)
       pry (>= 0.13, < 0.15)
     racc (1.8.1)
-    rack (3.1.10)
+    rack (3.1.16)
     rainbow (3.1.1)
     rake (13.2.1)
     regexp_parser (2.10.0)
@@ -71,9 +72,10 @@ GEM
     rspec-support (3.13.2)
     rspec_junit_formatter (0.6.0)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (1.71.2)
+    rubocop (1.72.2)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
@@ -89,11 +91,12 @@ GEM
       rubocop (~> 1.61)
     rubocop-graphql (0.19.0)
       rubocop (>= 0.87, < 2)
-    rubocop-rails (2.27.0)
+    rubocop-rails (2.30.2)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.52.0, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
     rubocop-rspec (2.27.1)
       rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
@@ -114,6 +117,7 @@ GEM
 
 PLATFORMS
   arm64-darwin-24
+  x86_64-linux
 
 DEPENDENCIES
   bundler

data/README.md

@@ -92,6 +92,7 @@ not add cops with `enabled: false` unless you want that cop to always be disable
 * [RequireGqlErrorHelpers](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/require_gql_error_helpers.rb) - Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.
 * [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" and "::<class method>" for example group description.
 * [RspecMatchOrderedArray](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb) - Enforce use of `match_ordered_array` matcher instead of `eq` matcher. This matcher comes from the [ezcater_matchers](https://github.com/ezcater/ezcater_matchers) gem.
+* [RspecNoResolveClassField](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_no_resolve_class_field.rb) - Do not use deprecated GraphQL testing interface `resolve_class_field`.
 * [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
 * [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.
 * [RspecRequireHttpStatusMatcher](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb) - Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`
@@ -108,7 +109,7 @@ To install this gem onto your local machine, run `bundle exec rake install`.
 
 ### Releasing a New Version
 
-To release a new version, update the version number in `version.rb`, merge your PR to `main`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To release a new version, update the version number in `version.rb`, merge your PR to `main`, and then manually run the "Release Gem" GitHub Action, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 

data/conf/rubocop.yml

@@ -1,5 +1,8 @@
 require: ezcater_rubocop
 
+plugins:
+  - rubocop-rails
+
 AllCops:
   DisplayCopNames: true
   NewCops: disable
@@ -82,7 +85,7 @@ RSpec/MessageExpectation:
   EnforcedStyle: allow
 
 RSpec/MultipleExpectations:
-  Max: 5
+  exclude_limit: 5
 
 RSpec/NestedGroups:
   Max: 5

data/config/default.yml

@@ -75,6 +75,12 @@ GraphQL/ExtractInputType:
   Exclude:
     - "**/input_objects/**/*.rb"
 
+Ezcater/RspecNoResolveClassField:
+  Description: "Do not use `resolve_class_field` in spec files."
+  Enabled: true
+  Include:
+    - "**/*_spec.rb"
+
 Ezcater/Migration/BigintForeignKey:
   Description: "Use `bigint` instead of `integer` for all foreign keys."
   Include:

data/ezcater_rubocop.gemspec

@@ -52,8 +52,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "simplecov"
 
   spec.add_runtime_dependency "parser", ">= 2.6"
-  spec.add_runtime_dependency "rubocop", ">= 1.16.0", "< 1.72.0"
+  spec.add_runtime_dependency "rubocop", ">= 1.72.0", "< 2.0"
   spec.add_runtime_dependency "rubocop-graphql", ">= 0.14.0", "< 1.0"
-  spec.add_runtime_dependency "rubocop-rails", ">= 2.10.1", "< 2.28.0"
+  spec.add_runtime_dependency "rubocop-rails", ">= 2.28.0", "< 3.0"
   spec.add_runtime_dependency "rubocop-rspec", ">= 2.22.0", "< 2.28.0"
 end

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "8.1.0"
+  VERSION = "10.1.0"
 end

data/lib/ezcater_rubocop.rb

@@ -31,5 +31,6 @@ require_relative "rubocop/cop/ezcater/rspec_require_browser_mock"
 require_relative "rubocop/cop/ezcater/rspec_require_feature_flag_mock"
 require_relative "rubocop/cop/ezcater/rspec_require_http_status_matcher"
 require_relative "rubocop/cop/ezcater/rspec_dot_not_self_dot"
+require_relative "rubocop/cop/ezcater/rspec_no_resolve_class_field"
 require_relative "rubocop/cop/ezcater/style_dig"
 require_relative "rubocop/cop/ezcater/migration/bigint_foreign_key"

data/lib/rubocop/cop/ezcater/rspec_no_resolve_class_field.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Ezcater
+      # Do not use `resolve_class_field`.
+      #
+      # @example
+      #
+      #   # bad
+      #   resolve_class_field(:user, :name)
+      #   resolve_class_field(:user, [:name])
+      #   obj.resolve_class_field(:user, :name)
+      #
+      #   # good
+      #   execute(EzrailsSchema, query, variables: { id: }, context: graphql_context)
+      #
+      #   More information: https://engportal.ezcater.com/docs/default/component/dev-handbook/technology/graphql/backend_implementation/testing/#recommendation
+      #
+      class RspecNoResolveClassField < Base
+        MSG = "Do not use `resolve_class_field`. Use a query instead."
+
+        def_node_matcher :resolve_class_field_call?, <<~PATTERN
+          {
+            (send nil? :resolve_class_field ...)
+            (send _ :resolve_class_field ...)
+          }
+        PATTERN
+
+        def on_send(node)
+          return unless resolve_class_field_call?(node)
+
+          add_offense(node, message: MSG)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 8.1.0
+  version: 10.1.0
 platform: ruby
 authors:
 - ezCater, Inc
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-02-20 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -114,20 +113,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.16.0
+        version: 1.72.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.72.0
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.16.0
+        version: 1.72.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.72.0
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rubocop-graphql
   requirement: !ruby/object:Gem::Requirement
@@ -154,20 +153,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.10.1
+        version: 2.28.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.28.0
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.10.1
+        version: 2.28.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.28.0
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -200,6 +199,7 @@ files:
 - ".github/PULL_REQUEST_TEMPLATE.md"
 - ".github/workflows/codeql.yml"
 - ".github/workflows/dependency-review.yml"
+- ".github/workflows/release.yml"
 - ".tool-versions"
 - CHANGELOG.md
 - Gemfile
@@ -227,6 +227,7 @@ files:
 - lib/rubocop/cop/ezcater/require_gql_error_helpers.rb
 - lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb
 - lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb
+- lib/rubocop/cop/ezcater/rspec_no_resolve_class_field.rb
 - lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb
@@ -238,7 +239,6 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -253,8 +253,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: ezCater custom cops and shared configuration
 test_files: []