ezcater_rubocop 6.0.3 → 6.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 144220e45db4ba03e7754c0f656cafe7650da1669157b65396c818762e7d9185
-  data.tar.gz: b1e19818de9418e2a822ef0d1a3c067870ed36d26c7addb6d831776b4590a25d
+  metadata.gz: 26eaaa7f867ad999360777e40da32e1a0e591e4906e4fadc9b23a4fb70189b94
+  data.tar.gz: 8d9fa27414f264d03cc0f5a15146aa563d23bbfdc9eddfb031fbddbe7557a617
 SHA512:
-  metadata.gz: 6da4228e123e62619f9ac2e66f53e766cd8a15160f6362fc7e33009b39749028a6e1dd4d835caa8fa101afe71dc743f6947622e43d2d3530b1ee23b3e539fadc
-  data.tar.gz: 6cbe86a738c2567d5829b58b18cc23e13f05125b4c19ebd7ad41ddbcc5945cc08774740353708488e9c88235bdf85dc5f317f7654322255c8e9bcc10c4489076
+  metadata.gz: 3fa02d546b7ce79d540d1d079937d36622635e3c2ddf800544ade72924ea9520ec1f592957653d20ec156fea1f042c49519487999a2da00ddcdfc7b15b46fcfe
+  data.tar.gz: f3869c5b24b6b8ae92878a10185e6403ce937d027c9b7eb8bd52f2a97fd6f402e443c86119039b44444d70ac2a1ebcb889f851ca589c34499b12503939e5ab56

data/CHANGELOG.md

@@ -6,6 +6,15 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
+## 6.1.1
+
+- Lock `rubocop-rspec` below `v2.28.0` to avoid an upstream namespacing issue.
+
+## 6.1.0
+
+- Add `Ezcater/GraphQL/NotAuthorizedScalarField` Cop which enforces the use
+  of authorization for scalar GraphQL fields. Not enforced by default.
+
 ## 6.0.3
 - Fix `FeatureFlagActive` cop so that it allows feature flag names to be constants and dot method calls in addition to strings.
 

data/README.md

@@ -81,6 +81,9 @@ not add cops with `enabled: false` unless you want that cop to always be disable
 
 * [FeatureFlagActive](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/feature_flag_active.rb) - Enforce the proper arguments are given to `EzcaterFeatureFlag.active?`
 * [FeatureFlagNameValid](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/feature_flag_name_valid.rb) - Enforce correct flag name format is being used.
+* [GraphQL/NotAuthorizedScalarField] - Enforces the use of
+  authorization (pundit or, optionally, the guard pattern) for scalar
+  fields. See examples within class comment for additional configuration.
 * [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.
 * [RequireGqlErrorHelpers](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/require_gql_error_helpers.rb) - Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.
 * [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" and "::<class method>" for example group description.
@@ -90,6 +93,8 @@ not add cops with `enabled: false` unless you want that cop to always be disable
 * [RspecRequireHttpStatusMatcher](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb) - Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`
 * [StyleDig](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/style_dig.rb) - Recommend `dig` for deeply nested access.
 
+[GraphQL/NotAuthorizedScalarField]: https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/graphql/not_authorized_scalar_field.rb)
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -104,6 +109,47 @@ To release a new version, update the version number in `version.rb`, merge your
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/ezcater/ezcater_rubocop.
 
+### Adding New Cops
+
+New cops can be generated via the `new_cop` rake task which generates
+the cop, the spec, updates imports, and adds configuration. Example:
+
+``` shell
+rake 'new_cop[Ezcater/foo_bar]'
+```
+
+Follow the instructions after the task executes and update code as
+necessary for consistency.
+
+
+In addition, you need to:
+
+1. Add the cop to the "Custom Cops" section of this README
+2. Bump the version.
+3. Add a CHANGELOG entry.
+
+
+### Version Bumps & Changelog Entries
+
+The version for this gem follows [Semantic Versioning]:
+
+1. Bump the MAJOR version for breaking changes. Example: new cop,
+   enabled by default and which cannot be safely autofixed.
+
+2. Bump the MINOR version for new functionality which will not disrupt
+   projects which depend on this gem. Example: new cop, not enabled by
+   default or which can safely be autofixed.
+
+3. Bump the PATCH version for backwards compatible bugfixes.
+
+[Semantic Versioning]: https://semver.org/
+
+The version does not need to be bumped and the changelog does not need
+to be updated for chores which do not affect users of this
+gem. Example: updating CI. Omitting these details helps keep the
+signal-to-noise ratio high for people upgrading the gem as these types
+of changes will not affect them.
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/config/default.yml

@@ -18,6 +18,14 @@ Ezcater/FeatureFlagNameValid:
   Description: "Enforce correct flag name format is being used."
   Enabled: true
 
+Ezcater/GraphQL/NotAuthorizedScalarField:
+  Description: 'Enforce the use of authorization for scalar GraphQL fields.'
+  Include:
+    - 'app/graphql/**/*.rb'
+    - 'packs/**/graphql/**/*.rb'
+  Enabled: false
+  VersionAdded: '6.1.0'
+
 Ezcater/RspecDotNotSelfDot:
   Description: 'Enforce ".<class method>" instead of "self.<class method>" for example group description.'
   Enabled: true

data/ezcater_rubocop.gemspec

@@ -55,5 +55,5 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "rubocop", ">= 1.16.0", "< 2.0"
   spec.add_runtime_dependency "rubocop-graphql", ">= 0.14.0", "< 1.0"
   spec.add_runtime_dependency "rubocop-rails", ">= 2.10.1", "< 3.0"
-  spec.add_runtime_dependency "rubocop-rspec", ">= 2.22.0", "< 3.0"
+  spec.add_runtime_dependency "rubocop-rspec", ">= 2.22.0", "< 2.28.0"
 end

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "6.0.3"
+  VERSION = "6.1.1"
 end

data/lib/ezcater_rubocop.rb

@@ -19,6 +19,7 @@ RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 require "rubocop/cop/ezcater/direct_env_check"
 require "rubocop/cop/ezcater/feature_flag_active"
 require "rubocop/cop/ezcater/feature_flag_name_valid"
+require "rubocop/cop/ezcater/graphql/not_authorized_scalar_field"
 require "rubocop/cop/ezcater/rails_configuration"
 require "rubocop/cop/ezcater/rails_env"
 require "rubocop/cop/ezcater/ruby_timeout"

data/lib/rubocop/cop/ezcater/graphql/not_authorized_scalar_field.rb

@@ -0,0 +1,198 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Ezcater
+      module GraphQL
+        # Enforces authorization for scalar GraphQL fields. It
+        # identifies scalar fields by matching against the standard
+        # [graphql-ruby scalar types] by default.
+        #
+        # [graphql-ruby scalar types]: https://graphql-ruby.org/type_definitions/scalars.html
+        #
+        # @safety
+        #   This cop is unable to autocorrect violations as decision making is
+        #   required on the part of the developer.
+        #
+        # @example AllowGuards: false (default)
+        #   # Requires that pundit authorization is used on scalar fields.
+        #   # @see https://graphql-ruby.org/authorization/pundit_integration.html#authorizing-fields
+        #
+        #   # bad
+        #   field :secret_name, String
+        #
+        #   # bad
+        #   field :secret_name, String
+        #
+        #   def secret_name
+        #     SecretNameGuard.new(context, object).guard do |person|
+        #       person.secret_name
+        #     end
+        #   end
+
+        #   # good
+        #   field :name, String, pundit_role: :owner
+        #
+        #   # good
+        #   field :name, String, pundit_role: :view, pundit_policy_class: "SecretNamePolicy"
+        #
+        # @example AllowGuards: true
+        #   # In addition to the pundit enforcement demonstrated in the previous
+        #   # example, guard-style authentication is allowed for scalar fields
+        #   # when a resolver is defined in the same class.
+        #
+        #   # bad
+        #   field :secret_name, String
+        #
+        #   def secret_name
+        #     "Rumplestiltskin"
+        #   end
+        #
+        #   # good
+        #   field :secret_name, String
+        #
+        #   def secret_name
+        #     SecretNameGuard.new(context, object).guard do |person|
+        #       person.secret_name
+        #     end
+        #   end
+        #
+        # @example AdditionalScalarTypes: [] (default)
+        #   # This option specifies additional scalar types for this cop to pay
+        #   # attention to. By default, this list is empty.
+        #
+        #   # bad
+        #   field :secret_id, ID
+        #
+        #   # good (i.e. the cop doesn't pay attention to UUID by default)
+        #   field :secret_id, UUID
+        #
+        # @example AdditionalScalarTypes: ["UUID"]
+        #   # This example adds UUID to the types to observe.
+        #
+        #   # bad
+        #   field :secret_id, UUID
+        #
+        #   # good
+        #   field :secret_id, pundit_role: owner
+        #
+        # @example IgnoredFieldNames: [] (default)
+        #   # This option specifies field names to ignore.
+        #
+        #   # bad (the field name is not in the ignore list)
+        #   field :id, ID
+        #
+        # @example IgnoredFieldNames: ["id"]
+        #   # This examples adds "id" to the list of ignored field names.
+        #
+        #   # good
+        #   field :id, ID
+        #
+        class NotAuthorizedScalarField < Base
+          include RuboCop::GraphQL::NodePattern
+
+          MSG = "Ezcater/GraphQL/NotAuthorizedScalarFields: must be authorized."
+
+          # https://graphql-ruby.org/type_definitions/scalars.html
+          STANDARD_SCALAR_TYPES = %w(BigInt Boolean Float Int ID ISO8601Date ISO8601DateTime ISO8601Duration JSON
+                                     String).freeze
+
+          # @!method field_type(node)
+          def_node_matcher :field_type, <<~PATTERN
+            (send nil? :field _ (:const nil? $_) ...)
+          PATTERN
+
+          # @!method field_with_body_type(node)
+          def_node_matcher :field_with_body_type, <<~PATTERN
+            (block (send nil? :field _ (:const nil? $_) ...) ...)
+          PATTERN
+
+          # @!method field_with_guard_in_body?(node)
+          def_node_matcher :field_with_guard_in_body?, <<~PATTERN
+            (block
+              (send nil? :field ...)
+              _?
+              (block
+                (send
+                  (send
+                    (:const ...) :new
+                    (send nil? :context)
+                    (send nil? :object)) :guard)
+                ...) ...)
+          PATTERN
+
+          # @!method field_with_pundit?(node)
+          def_node_matcher :field_with_pundit?, <<~PATTERN
+            (send nil? :field _ _ (hash <(pair (sym :pundit_role) _) ...>))
+          PATTERN
+
+          # @!method field_with_pundit_with_body?(node)
+          def_node_matcher :field_with_pundit_with_body?, <<~PATTERN
+            (block (send nil? :field _ _ (hash <(pair (sym :pundit_role) _) ...>)) ...)
+          PATTERN
+
+          # @!method contains_resolver_method_with_guard?(node)
+          def_node_search :contains_resolver_method_with_guard?, <<~PATTERN
+            (def %1
+              (args)
+              (block
+                (send
+                  (send
+                    (:const ...) :new
+                    (send nil? :context)
+                    (send nil? :object)) :guard)
+                ...) ...)
+          PATTERN
+
+          def on_class(node)
+            body = RuboCop::GraphQL::SchemaMember.new(node).body
+
+            each_field_node(body) do |field_node|
+              check_field_for_offense(field_node, node)
+            end
+          end
+
+          private
+
+          def allow_guards?
+            @_allow_guards ||= !!cop_config["AllowGuards"]
+          end
+
+          def check_field_for_offense(field, class_node)
+            return if field_with_pundit?(field.node) || field_with_pundit_with_body?(field.node)
+            return if ignored_field_names.include?(field.underscore_name)
+
+            type = field_type(field.node) || field_with_body_type(field.node)
+            return unless scalar_types.include?(type.to_s)
+
+            return if allow_guards? && (
+                        field_with_guard_in_body?(field.node) ||
+                        contains_resolver_method_with_guard?(class_node, field.underscore_name.to_sym)
+                      )
+
+            add_offense(field.node)
+          end
+
+          def each_field_node(body)
+            return unless body
+
+            body.each do |node|
+              yield RuboCop::GraphQL::Field.new(node) if field?(node)
+            end
+          end
+
+          def ignored_field_names
+            @_ignored_field_names ||= (cop_config["IgnoredFieldNames"] || []).to_set
+          end
+
+          def scalar_types
+            return @_scalar_types if defined?(@_scalar_types)
+
+            additional_scalar_types = cop_config["AdditionalScalarTypes"] || []
+            @_scalar_types = STANDARD_SCALAR_TYPES.to_set.merge(additional_scalar_types)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 6.0.3
+  version: 6.1.1
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-21 00:00:00.000000000 Z
+date: 2024-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -177,7 +177,7 @@ dependencies:
         version: 2.22.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 2.28.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -187,7 +187,7 @@ dependencies:
         version: 2.22.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 2.28.0
 description: ezCater custom cops and shared configuration
 email:
 - engineering@ezcater.com
@@ -216,6 +216,7 @@ files:
 - lib/rubocop/cop/ezcater/direct_env_check.rb
 - lib/rubocop/cop/ezcater/feature_flag_active.rb
 - lib/rubocop/cop/ezcater/feature_flag_name_valid.rb
+- lib/rubocop/cop/ezcater/graphql/not_authorized_scalar_field.rb
 - lib/rubocop/cop/ezcater/rails_configuration.rb
 - lib/rubocop/cop/ezcater/rails_env.rb
 - lib/rubocop/cop/ezcater/rails_top_level_sql_execute.rb