ezcater_rubocop 6.0.0 → 6.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8e412cd3e88f3c5e18b537a9a81beec0396f8882aba05f3f09c87464510bd9a6
-  data.tar.gz: 8786ebe582591fde680b7846e9be9783d84a402f6066cd22c1f5f379dd468b80
+  metadata.gz: 74dad3c36b4474ebb1ed730e204ed1256715708736a388dc809ae106256b3b08
+  data.tar.gz: 34751bbd4b890ba18a534bc5f47860cc6e00121d43ce3b398ddcb921c56afbb0
 SHA512:
-  metadata.gz: 3394769cce8e62507578b3fc55b943536ba79825ed30de348e538030c96129f2f923652682087467ade43c15a0847dce7faa8bcf5d7e6bd19d98d6b810b3fc3a
-  data.tar.gz: 4f79ad7d080b3c8a64e85cb9521226809c9dc1d558fa334cc0146dce879c1f836e8e10766db1aef2af922f82dafa715680f8af3d0c93537912843a9fc926ff2f
+  metadata.gz: c9762748a349377a1f673572a21e5fd71ad80f4a5213f4fb1b95670c65b6cb7093e77b7d01168d0cd8e2bc6947321ebcf8d888f6f9fe945e9d70daee1ad019b1
+  data.tar.gz: e8da642c516edf9dd7a916ae664261aab3db90873fd68247012a017b22d5affac97f806bc4dbd3a5a2721ab3ebf64d97ade3bf75bc6a872e59b34d01bcfa9d5e

data/CHANGELOG.md

@@ -6,11 +6,18 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
+## 6.0.2
+- Upgrade rubocop-rspec to v2.22.0 to use the new FactoryBot namespaces.
+- Fix the following wrong namespaces related to `FactoryBot`: `RSpec/FactoryBot/AttributeDefinedStatically`, `RSpec/FactoryBot/CreateList` and `RSpec/FactoryBot/FactoryClassName`.
+
+## 6.0.1
+- Fix a bug in the `FeatureFlagNameValid` cop where the titlecase regex matcher was incorrectly finding offenses.
+
 ## 6.0.0
 - Add `FeatureFlagNameValid` cop to validate correct feature flag name format, [adopted from the cop](https://github.com/ezcater/ez-rails/blob/2d9272eb3d2c71dc5ebc2aa01a849cf9cfae3df2/cops/rubocop/cops/feature_flags_flag_name.rb_) in `ez-rails`.
 
 ## 5.2.1
-- Fix the has the wrong namespace for `RSpec/Capybara/CurrentPathExpectation` and `RSpec/Capybara/VisibilityMatcher` cops, since [they've been extracted](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md#2180-2023-01-16) into a separate repo [rubocop-capybara](https://github.com/rubocop/rubocop-capybara).
+- Fix the wrong namespace for `RSpec/Capybara/CurrentPathExpectation` and `RSpec/Capybara/VisibilityMatcher` cops, since [they've been extracted](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md#2180-2023-01-16) into a separate repo [rubocop-capybara](https://github.com/rubocop/rubocop-capybara).
 
 ## 5.2.0
 

data/conf/rubocop.yml

@@ -245,13 +245,13 @@ RSpec/Capybara/FeatureMethods:
 RSpec/EmptyHook:
   Enabled: true
 
-RSpec/FactoryBot/AttributeDefinedStatically:
+FactoryBot/AttributeDefinedStatically:
   Enabled: true
 
-RSpec/FactoryBot/CreateList:
+FactoryBot/CreateList:
   Enabled: true
 
-RSpec/FactoryBot/FactoryClassName:
+FactoryBot/FactoryClassName:
   Enabled: true
 
 RSpec/MultipleMemoizedHelpers:

data/ezcater_rubocop.gemspec

@@ -55,5 +55,5 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "rubocop", ">= 1.16.0", "< 2.0"
   spec.add_runtime_dependency "rubocop-graphql", ">= 0.14.0", "< 1.0"
   spec.add_runtime_dependency "rubocop-rails", ">= 2.10.1", "< 3.0"
-  spec.add_runtime_dependency "rubocop-rspec", ">= 2.3.0", "< 3.0"
+  spec.add_runtime_dependency "rubocop-rspec", ">= 2.22.0", "< 3.0"
 end

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "6.0.0"
+  VERSION = "6.0.2"
 end

data/lib/rubocop/cop/ezcater/feature_flag_name_valid.rb

@@ -22,11 +22,11 @@ module RuboCop
       #   EzFF.active?("foo::bar", identifiers: ["user:1"])
       #   MY_FLAG="Foo:bar"
       class FeatureFlagNameValid < Cop
-        WHITESPACE = /\s/.freeze
-        ISOLATED_COLON = /(?<!:):(?!:)/.freeze
-        TRIPLE_COLON = /:::/.freeze
-        INVALID_CHARACTERS = /[^a-zA-Z0-9:]/.freeze
-        TITLECASE_SEGMENT = /"^([A-Z][a-z0-9]*)+$"/.freeze
+        WHITESPACE = /\s/
+        ISOLATED_COLON = /(?<!:):(?!:)/
+        TRIPLE_COLON = /:::/
+        INVALID_CHARACTERS = /[^a-zA-Z0-9:]/
+        TITLECASE_SEGMENT = /^([A-Z][a-z0-9]*)+$/
 
         WHITESPACE_MSG = "Feature flag names must not contain whitespace."
         DOUBLE_COLON_MSG = "Feature flag names must use double colons (::) as namespace separators."
@@ -39,7 +39,7 @@ module RuboCop
 
         def_node_matcher :feature_flag_method_call, <<~PATTERN
           (send
-            (_ _ {:EzFF :EzcaterFeatureFlag}) {:active? | :at_100? | :random_sample_active?} (str $_ ...))
+            (_ _ {:EzFF :EzcaterFeatureFlag}) {:active? | :at_100? | :random_sample_active?} <(str $_) ...>)
         PATTERN
 
         def on_casgn(node)
@@ -53,7 +53,7 @@ module RuboCop
 
         def on_send(node)
           return unless feature_flag_method_call(node)
-            
+
           feature_flag_method_call(node) do |flag_name|
             errors = find_name_violations(flag_name)
             add_offense(node, location: :expression, message: errors.join(", ")) if errors.any?
@@ -88,5 +88,5 @@ module RuboCop
         end
       end
     end
-  end 
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 6.0.0
+  version: 6.0.2
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-01 00:00:00.000000000 Z
+date: 2023-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -174,7 +174,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.22.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
@@ -184,7 +184,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.22.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'