ezcater_rubocop 4.0.0 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e4ab0e968f3876d0ce517e56e4f4d4f85d4a512148d76eddc3b90afb27b030e
-  data.tar.gz: 1222c65a574b4aeab13b5372a4e2fc0c4c3af89e6f611dcfd82a41879343e198
+  metadata.gz: 3dbb408ffa690e48915809b4f55644601682034469f8b59d0f73624b2a1a225f
+  data.tar.gz: 75aa569d52eb164cc9ded5d5c1c776bb658dca665fb6c5c013ca9b0607d71db2
 SHA512:
-  metadata.gz: 173c89e6a3c9eb6b022b90ccc0d28c49b44331d42617e082d5fcd1380e0c2b2ad834250608a87556c9dd5e664d770009d1499a77fa002ad4270740b1069f2b44
-  data.tar.gz: 924a0d9ed141df769723ed76ab30aae9625da0f1890ab75125c94f74ca1fa9e0cb6c31b0b4f8c74d0418031890c07f6f4dad1eadedbc1424e314fff32c16bc0f
+  metadata.gz: 374a5e16b853aabf25af23c4860c6a00f1b457682499fda3f84937d764d5398ab8ae3c34cbcb4c948da51fc7795fe6a7ab14d3686bfe03f8613ffc3663bebc5c
+  data.tar.gz: 880dd4bea07e44db41452388715c763f5a608d3875ff767a3a2c689f69321a076004e71e211e6b60de5b90806a6886a8342336e422f35063ade3c4c76d40854e

data/.github/CODEOWNERS

@@ -1 +1 @@
-* @ezcater/ruby-style-group
+* @ezcater/developer-experience @ezcater/ruby-style-group

data/CHANGELOG.md

@@ -6,6 +6,12 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
+## 5.1.0
+- Change paths to exclude for various cops to be agnostic of directory structure prior to the matching string. This is to allow apps to have greater flexibility in where files live, but still have them excluded from certain cops. The need for this arose when implementing Stimpack, which moves specs and other files under app/packs/[pack_name].
+
+## 5.0.0
+- Enable all added cops since 0.8. There are a lot of new cops now, be sure to use `--regenerate-todo` if you're on a large project that can't be updated easily.
+
 ## 4.0.0
 
 - Add the [rubcop-graphql](https://github.com/DmitryTsepelev/rubocop-graphql) helpers and enable

data/README.md

@@ -1,4 +1,4 @@
-# ezcater_rubocop
+# ezcater_rubocop [![CircleCI](https://circleci.com/gh/ezcater/ezcater_rubocop/tree/main.svg?style=svg)](https://circleci.com/gh/ezcater/ezcater_rubocop/tree/main)
 
 ezCater custom cops and shared RuboCop configuration.
 
@@ -72,6 +72,11 @@ running rubocop.
 
 This gem is using [Semantic Versioning](https://semver.org/). All version bumps should increment using `MAJOR.MINOR.PATCH` based on changes.
 
+When adding a new cop, please enable the cop and release a new major version. This allows us to
+constantly roll out improvements without clients having their suite break unknowingly. When a
+breaking change is released, users can opt to use `--regenerate-todo` to update their TODO file. Do
+not add cops with `enabled: false` unless you want that cop to always be disabled.
+
 ## Custom Cops
 
 1. [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.

data/conf/rubocop.yml

@@ -23,7 +23,7 @@ Metrics/AbcSize:
 Metrics/BlockLength:
   Exclude:
     - "*.gemspec"
-    - "spec/**/*.rb"
+    - "/**/spec/**/*.rb"
 
 Metrics/CyclomaticComplexity:
   Enabled: false
@@ -61,12 +61,12 @@ RSpec/ContextWording:
 
 RSpec/DescribeClass:
   Exclude:
-    - "spec/requests/**/*.rb"
-    - "spec/features/**/*.rb"
-    - "spec/routing/**/*.rb"
-    - "spec/views/**/*.rb"
-    - "spec/system/**/*.rb"
-    - "spec/integrations/**/*.rb"
+    - "/**/spec/features/**/*.rb"
+    - "/**/spec/requests/**/*.rb"
+    - "/**/spec/routing/**/*.rb"
+    - "/**/spec/views/**/*.rb"
+    - "/**/spec/system/**/*.rb"
+    - "/**/spec/integrations/**/*.rb"
 
 RSpec/ExampleLength:
   Max: 25
@@ -148,191 +148,183 @@ Style/TrailingCommaInArrayLiteral:
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: consistent_comma
 
-### New Cops
 
-# Cops are now introduced in a "pending" state and must be explicitly
-# enabled or disabled. New cops are not enabled by default until the
-# next major release.
-
-# New cops introduced between 0.81.0 and 1.16.0
 Layout/BeginEndAlignment:
-  Enabled: false
+  Enabled: true
 
 Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: false
+  Enabled: true
 
 Layout/IndentationStyle:
-  Enabled: false
+  Enabled: true
 
 Layout/SpaceAroundMethodCallOperator:
-  Enabled: false
+  Enabled: true
 
 Lint/BinaryOperatorWithIdenticalOperands:
-  Enabled: false
+  Enabled: true
 
 Lint/ConstantDefinitionInBlock:
-  Enabled: false
+  Enabled: true
 
 Lint/DeprecatedOpenSSLConstant:
-  Enabled: false
+  Enabled: true
 
 Lint/DuplicateElsifCondition:
-  Enabled: false
+  Enabled: true
 
 Lint/DuplicateRequire:
-  Enabled: false
+  Enabled: true
 
 Lint/DuplicateRescueException:
-  Enabled: false
+  Enabled: true
 
 Lint/EmptyConditionalBody:
-  Enabled: false
+  Enabled: true
 
 Lint/EmptyFile:
-  Enabled: false
+  Enabled: true
 
 Lint/FloatComparison:
-  Enabled: false
+  Enabled: true
 
 Lint/HashCompareByIdentity:
-  Enabled: false
+  Enabled: true
 
 Lint/IdentityComparison:
-  Enabled: false
+  Enabled: true
 
 Lint/MissingSuper:
-  Enabled: false
+  Enabled: true
 
 Lint/MixedRegexpCaptureTypes:
-  Enabled: false
+  Enabled: true
 
 Lint/OutOfRangeRegexpRef:
-  Enabled: false
+  Enabled: true
 
 Lint/RedundantSafeNavigation:
-  Enabled: false
+  Enabled: true
 
 Lint/SelfAssignment:
-  Enabled: false
+  Enabled: true
 
 Lint/TopLevelReturnWithArgument:
-  Enabled: false
+  Enabled: true
 
 Lint/TrailingCommaInAttributeDeclaration:
-  Enabled: false
+  Enabled: true
 
 Lint/UnreachableLoop:
-  Enabled: false
+  Enabled: true
 
 Lint/UselessMethodDefinition:
-  Enabled: false
+  Enabled: true
 
 Lint/UselessTimes:
-  Enabled: false
+  Enabled: true
 
 Rails/ArelStar:
-  Enabled: false
+  Enabled: true
 
 Rails/Pick:
-  Enabled: false
+  Enabled: true
 
 Rails/RedundantForeignKey:
-  Enabled: false
+  Enabled: true
 
 RSpec/Capybara/CurrentPathExpectation:
-  Enabled: false
+  Enabled: true
 
 RSpec/Capybara/FeatureMethods:
-  Enabled: false
+  Enabled: true
 
 RSpec/Capybara/VisibilityMatcher:
-  Enabled: false
+  Enabled: true
 
 RSpec/EmptyHook:
-  Enabled: false
+  Enabled: true
 
 RSpec/FactoryBot/AttributeDefinedStatically:
-  Enabled: false
+  Enabled: true
 
 RSpec/FactoryBot/CreateList:
-  Enabled: false
+  Enabled: true
 
 RSpec/FactoryBot/FactoryClassName:
-  Enabled: false
+  Enabled: true
 
 RSpec/MultipleMemoizedHelpers:
-  Enabled: false
+  Enabled: true
 
 RSpec/NotToNot:
-  Enabled: false
+  Enabled: true
 
 RSpec/Rails/HttpStatus:
-  Enabled: false
+  Enabled: true
 
 RSpec/RepeatedIncludeExample:
-  Enabled: false
+  Enabled: true
 
 RSpec/StubbedMock:
-  Enabled: false
+  Enabled: true
 
 RSpec/VariableDefinition:
-  Enabled: false
+  Enabled: true
 
 RSpec/VariableName:
-  Enabled: false
+  Enabled: true
 
 Style/AccessorGrouping:
-  Enabled: false
+  Enabled: true
 
 Style/BisectedAttrAccessor:
-  Enabled: false
+  Enabled: true
 
 Style/CaseLikeIf:
-  Enabled: false
+  Enabled: true
 
 Style/CombinableLoops:
-  Enabled: false
+  Enabled: true
 
 Style/ExponentialNotation:
-  Enabled: false
+  Enabled: true
 
 Style/GlobalStdStream:
-  Enabled: false
+  Enabled: true
 
 Style/HashAsLastArrayItem:
-  Enabled: false
+  Enabled: true
 
 Style/HashLikeCase:
-  Enabled: false
+  Enabled: true
 
 Style/KeywordParametersOrder:
-  Enabled: false
+  Enabled: true
 
 Style/OptionalBooleanParameter:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantAssignment:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantRegexpCharacterClass:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantRegexpEscape:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantSelfAssignment:
-  Enabled: false
+  Enabled: true
 
 Style/SingleArgumentDig:
-  Enabled: false
+  Enabled: true
 
 Style/SlicingWithRange:
-  Enabled: false
+  Enabled: true
 
 Style/SoleNestedConditional:
-  Enabled: false
-
-#### New cops in v0.81
+  Enabled: true
 
 Lint/RaiseException:
   Enabled: true
@@ -340,8 +332,6 @@ Lint/RaiseException:
 Lint/StructNewOverride:
   Enabled: true
 
-#### New cops in v0.80
-
 Style/HashEachMethods:
   Enabled: true
 

data/conf/rubocop_rails.yml

@@ -17,8 +17,8 @@ Metrics/BlockLength:
       - Exclude
   Exclude:
   - "app/graphql/**/*.rb"
-  - "config/environments/*.rb"
-  - "lib/tasks/**/*.rake"
+  - "/**/config/environments/*.rb"
+  - "/**/lib/tasks/**/*.rake"
 
 Rails:
   Enabled: true
@@ -63,19 +63,19 @@ Ezcater/RailsEnv:
   Description: 'Enforce the use of `Rails.configuration.x.<foo>` instead of checking `Rails.env`.'
   Enabled: true
   Exclude:
-    - "config/**/*"
-    - "spec/rails_helper.rb"
+    - "/**/config/**/*"
+    - "/**/spec/rails_helper.rb"
     - "db/**/*"
-    - "lib/tasks/**/*"
-    - "spec/lib/tasks/**/*"
+    - "/**/lib/tasks/**/*"
+    - "/**/spec/lib/tasks/**/*"
 
 Ezcater/DirectEnvCheck:
   Description: 'Enforce the use of `Rails.configuration.x.<foo>` instead of checking `ENV`.'
   Enabled: true
   Exclude:
     - "bin/**/*"
-    - "config/**/*"
-    - "spec/rails_helper.rb"
+    - "/**/config/**/*"
+    - "/**/spec/rails_helper.rb"
     - "db/**/*"
-    - "lib/tasks/**/*"
-    - "spec/lib/tasks/**/*"
+    - "/**/lib/tasks/**/*"
+    - "/**/spec/lib/tasks/**/*"

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "4.0.0"
+  VERSION = "5.1.0"
 end

data/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb

@@ -36,7 +36,7 @@ module RuboCop
         end.flatten + %w(its focus skip)).freeze
 
         SELF_DOT_REGEXP = /\Aself\./.freeze # rubocop:disable Style/RedundantFreeze
-        COLON_COLON_REGEXP = /\A(\:\:)/.freeze # rubocop:disable Style/RedundantFreeze
+        COLON_COLON_REGEXP = /\A(::)/.freeze # rubocop:disable Style/RedundantFreeze
 
         SELF_DOT_MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'
         COLON_COLON_MSG = 'Use ".<class method>" instead of "::<class method>" for example group description.'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 5.1.0
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-19 00:00:00.000000000 Z
+date: 2022-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler