ezcater_rubocop 4.0.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e4ab0e968f3876d0ce517e56e4f4d4f85d4a512148d76eddc3b90afb27b030e
-  data.tar.gz: 1222c65a574b4aeab13b5372a4e2fc0c4c3af89e6f611dcfd82a41879343e198
+  metadata.gz: 8d5368b75099f59a900d7c2b9805ea045e3dc0e8150612b4a455d0aa4bf661fe
+  data.tar.gz: 96200ba4b7ee03b2781ad4b3bb8c202eab19a54600ec135d2d422cde96caef1f
 SHA512:
-  metadata.gz: 173c89e6a3c9eb6b022b90ccc0d28c49b44331d42617e082d5fcd1380e0c2b2ad834250608a87556c9dd5e664d770009d1499a77fa002ad4270740b1069f2b44
-  data.tar.gz: 924a0d9ed141df769723ed76ab30aae9625da0f1890ab75125c94f74ca1fa9e0cb6c31b0b4f8c74d0418031890c07f6f4dad1eadedbc1424e314fff32c16bc0f
+  metadata.gz: fc5992ee8b6cb9facd94ef7fa312271352d405f6617375cb2fa9eae60e76f5d74930bc2aff46218a934268558fbc3374e46730d16209fdc3f68d6cd3c98f7879
+  data.tar.gz: 6d240eca17afb70b3072dfb92f50773bb48c9d207ce316cd0223a56b04ac6ff5d0196784387a524063c976e10d1d1270ae0ad7eddd248e384dc6a31b893eed59

data/CHANGELOG.md

@@ -6,6 +6,9 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
+## 5.0.0
+- Enable all added cops since 0.8. There are a lot of new cops now, be sure to use `--regenerate-todo` if you're on a large project that can't be updated easily.
+
 ## 4.0.0
 
 - Add the [rubcop-graphql](https://github.com/DmitryTsepelev/rubocop-graphql) helpers and enable

data/README.md

@@ -1,4 +1,4 @@
-# ezcater_rubocop
+# ezcater_rubocop [![CircleCI](https://circleci.com/gh/ezcater/ezcater_rubocop/tree/main.svg?style=svg)](https://circleci.com/gh/ezcater/ezcater_rubocop/tree/main)
 
 ezCater custom cops and shared RuboCop configuration.
 
@@ -72,6 +72,11 @@ running rubocop.
 
 This gem is using [Semantic Versioning](https://semver.org/). All version bumps should increment using `MAJOR.MINOR.PATCH` based on changes.
 
+When adding a new cop, please enable the cop and release a new major version. This allows us to
+constantly roll out improvements without clients having their suite break unknowingly. When a
+breaking change is released, users can opt to use `--regenerate-todo` to update their TODO file. Do
+not add cops with `enabled: false` unless you want that cop to always be disabled.
+
 ## Custom Cops
 
 1. [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.

data/conf/rubocop.yml

@@ -148,191 +148,183 @@ Style/TrailingCommaInArrayLiteral:
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: consistent_comma
 
-### New Cops
 
-# Cops are now introduced in a "pending" state and must be explicitly
-# enabled or disabled. New cops are not enabled by default until the
-# next major release.
-
-# New cops introduced between 0.81.0 and 1.16.0
 Layout/BeginEndAlignment:
-  Enabled: false
+  Enabled: true
 
 Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: false
+  Enabled: true
 
 Layout/IndentationStyle:
-  Enabled: false
+  Enabled: true
 
 Layout/SpaceAroundMethodCallOperator:
-  Enabled: false
+  Enabled: true
 
 Lint/BinaryOperatorWithIdenticalOperands:
-  Enabled: false
+  Enabled: true
 
 Lint/ConstantDefinitionInBlock:
-  Enabled: false
+  Enabled: true
 
 Lint/DeprecatedOpenSSLConstant:
-  Enabled: false
+  Enabled: true
 
 Lint/DuplicateElsifCondition:
-  Enabled: false
+  Enabled: true
 
 Lint/DuplicateRequire:
-  Enabled: false
+  Enabled: true
 
 Lint/DuplicateRescueException:
-  Enabled: false
+  Enabled: true
 
 Lint/EmptyConditionalBody:
-  Enabled: false
+  Enabled: true
 
 Lint/EmptyFile:
-  Enabled: false
+  Enabled: true
 
 Lint/FloatComparison:
-  Enabled: false
+  Enabled: true
 
 Lint/HashCompareByIdentity:
-  Enabled: false
+  Enabled: true
 
 Lint/IdentityComparison:
-  Enabled: false
+  Enabled: true
 
 Lint/MissingSuper:
-  Enabled: false
+  Enabled: true
 
 Lint/MixedRegexpCaptureTypes:
-  Enabled: false
+  Enabled: true
 
 Lint/OutOfRangeRegexpRef:
-  Enabled: false
+  Enabled: true
 
 Lint/RedundantSafeNavigation:
-  Enabled: false
+  Enabled: true
 
 Lint/SelfAssignment:
-  Enabled: false
+  Enabled: true
 
 Lint/TopLevelReturnWithArgument:
-  Enabled: false
+  Enabled: true
 
 Lint/TrailingCommaInAttributeDeclaration:
-  Enabled: false
+  Enabled: true
 
 Lint/UnreachableLoop:
-  Enabled: false
+  Enabled: true
 
 Lint/UselessMethodDefinition:
-  Enabled: false
+  Enabled: true
 
 Lint/UselessTimes:
-  Enabled: false
+  Enabled: true
 
 Rails/ArelStar:
-  Enabled: false
+  Enabled: true
 
 Rails/Pick:
-  Enabled: false
+  Enabled: true
 
 Rails/RedundantForeignKey:
-  Enabled: false
+  Enabled: true
 
 RSpec/Capybara/CurrentPathExpectation:
-  Enabled: false
+  Enabled: true
 
 RSpec/Capybara/FeatureMethods:
-  Enabled: false
+  Enabled: true
 
 RSpec/Capybara/VisibilityMatcher:
-  Enabled: false
+  Enabled: true
 
 RSpec/EmptyHook:
-  Enabled: false
+  Enabled: true
 
 RSpec/FactoryBot/AttributeDefinedStatically:
-  Enabled: false
+  Enabled: true
 
 RSpec/FactoryBot/CreateList:
-  Enabled: false
+  Enabled: true
 
 RSpec/FactoryBot/FactoryClassName:
-  Enabled: false
+  Enabled: true
 
 RSpec/MultipleMemoizedHelpers:
-  Enabled: false
+  Enabled: true
 
 RSpec/NotToNot:
-  Enabled: false
+  Enabled: true
 
 RSpec/Rails/HttpStatus:
-  Enabled: false
+  Enabled: true
 
 RSpec/RepeatedIncludeExample:
-  Enabled: false
+  Enabled: true
 
 RSpec/StubbedMock:
-  Enabled: false
+  Enabled: true
 
 RSpec/VariableDefinition:
-  Enabled: false
+  Enabled: true
 
 RSpec/VariableName:
-  Enabled: false
+  Enabled: true
 
 Style/AccessorGrouping:
-  Enabled: false
+  Enabled: true
 
 Style/BisectedAttrAccessor:
-  Enabled: false
+  Enabled: true
 
 Style/CaseLikeIf:
-  Enabled: false
+  Enabled: true
 
 Style/CombinableLoops:
-  Enabled: false
+  Enabled: true
 
 Style/ExponentialNotation:
-  Enabled: false
+  Enabled: true
 
 Style/GlobalStdStream:
-  Enabled: false
+  Enabled: true
 
 Style/HashAsLastArrayItem:
-  Enabled: false
+  Enabled: true
 
 Style/HashLikeCase:
-  Enabled: false
+  Enabled: true
 
 Style/KeywordParametersOrder:
-  Enabled: false
+  Enabled: true
 
 Style/OptionalBooleanParameter:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantAssignment:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantRegexpCharacterClass:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantRegexpEscape:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantSelfAssignment:
-  Enabled: false
+  Enabled: true
 
 Style/SingleArgumentDig:
-  Enabled: false
+  Enabled: true
 
 Style/SlicingWithRange:
-  Enabled: false
+  Enabled: true
 
 Style/SoleNestedConditional:
-  Enabled: false
-
-#### New cops in v0.81
+  Enabled: true
 
 Lint/RaiseException:
   Enabled: true
@@ -340,8 +332,6 @@ Lint/RaiseException:
 Lint/StructNewOverride:
   Enabled: true
 
-#### New cops in v0.80
-
 Style/HashEachMethods:
   Enabled: true
 

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "4.0.0"
+  VERSION = "5.0.0"
 end

data/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb

@@ -36,7 +36,7 @@ module RuboCop
         end.flatten + %w(its focus skip)).freeze
 
         SELF_DOT_REGEXP = /\Aself\./.freeze # rubocop:disable Style/RedundantFreeze
-        COLON_COLON_REGEXP = /\A(\:\:)/.freeze # rubocop:disable Style/RedundantFreeze
+        COLON_COLON_REGEXP = /\A(::)/.freeze # rubocop:disable Style/RedundantFreeze
 
         SELF_DOT_MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'
         COLON_COLON_MSG = 'Use ".<class method>" instead of "::<class method>" for example group description.'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 5.0.0
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-19 00:00:00.000000000 Z
+date: 2022-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler