ezcater_rubocop 3.0.1 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 32ed01c4904b105bcd1ac2b3b8871485448284bffe06dc6b90fda19775748175
-  data.tar.gz: 19755e3e83359f473ff961e1679c39b1bdb5f6d78a9c78e3ca6118be344c8400
+  metadata.gz: 8d5368b75099f59a900d7c2b9805ea045e3dc0e8150612b4a455d0aa4bf661fe
+  data.tar.gz: 96200ba4b7ee03b2781ad4b3bb8c202eab19a54600ec135d2d422cde96caef1f
 SHA512:
-  metadata.gz: c215237f6c8fc40398c3947944261a457a2fc3efbebb51bc3e01ba743a3a4ad099a1a3ecfcc2782c056a78df6231b5bc0c258e0fa0f7ab8fd04e13be9ad26f79
-  data.tar.gz: f5066524144f916ff5d56c4aa320d916d4ed383b4eee01d20db2809a67eb2ed65bdf541709b8c0c9cec36a977a6ff9c92704564dacd7e9726a5b99bf02c0fffc
+  metadata.gz: fc5992ee8b6cb9facd94ef7fa312271352d405f6617375cb2fa9eae60e76f5d74930bc2aff46218a934268558fbc3374e46730d16209fdc3f68d6cd3c98f7879
+  data.tar.gz: 6d240eca17afb70b3072dfb92f50773bb48c9d207ce316cd0223a56b04ac6ff5d0196784387a524063c976e10d1d1270ae0ad7eddd248e384dc6a31b893eed59

data/.tool-versions

@@ -1 +1 @@
-ruby 2.7.3
+ruby 3.1.1

data/CHANGELOG.md

@@ -6,7 +6,21 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
+## 5.0.0
+- Enable all added cops since 0.8. There are a lot of new cops now, be sure to use `--regenerate-todo` if you're on a large project that can't be updated easily.
+
+## 4.0.0
+
+- Add the [rubcop-graphql](https://github.com/DmitryTsepelev/rubocop-graphql) helpers and enable
+    them by default
+- Remove `Ezcater/GraphqlFieldsNaming` cop. The same rule exists in `rubocop-graphql`.
+
+## v3.0.2
+
+- Loosen restrictions to allow for Ruby 3.1 and latest dependency gems
+
 ## v3.0.1
+
 - Fix the RspecDotNotSelfDot cop to work with rubocop-rspec
 - Exclude appraisal generated gemfiles for possible embedded gems in rails apps
 
@@ -37,101 +51,128 @@ Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of R
   - Enabled pending cop (`RSpec/StubbedMock`).
 
 ## v2.4.0
+
 - Fix `FeatureFlagActive` cop so that it allows feature flag names to be variables in addition to strings.
 - Add check to `FeatureFlagActive` that the first parameter is a string or a variable, and use the appropriate messaging.
 
 ## v2.3.0
+
 - Add `FeatureFlagActive` cop. This provides confidence that upgrading to `ezcater_feature_flag-client` v2.0.0, which
-    contains breaking API changes, can be done safely.
+  contains breaking API changes, can be done safely.
 
 ## v2.2.0
+
 - Require Ruby 2.6 or later.
 - Set `TargetRubyVersion` to 2.6 in `rubocop_gem` configuration.
 
 ## v2.1.0
+
 - Enable `Rails/SaveBang` with `AllowImplicitReturn: false`, and with autocorrection disabled.
 
 ## v2.0.0
+
 - Update to `rubocop` v0.81.0, `rubocop-rspec` v1.38.1 and `rubocop-rails` v2.5.2.
 - This is being released as a major update because cops have been renamed so this is unlikely to be
   a drop-in replacement.
 - This is the first release to support Ruby 2.7.
 
 ## v1.4.1
+
 - Correct a matching syntax issue with `Ezcater/RubyTimeout` so that it applies in the expected cases.
 
 ## v1.4.0
+
 - Add `Ezcater/RubyTimeout` cop.
 
 ## v1.3.0
+
 - Add `Ezcater/GraphqlFieldsNaming` cop.
 
 ## v1.2.0
+
 - Add `Ezcater/RailsTopLevelSqlExecute` to replace `ActiveRecord::Base.connection.execute` with `execute` in `db/migrate/`.
 
 ## v1.1.1
+
 - Exclude `lib/tasks/` for `Ezcater/RailsEnv` and `Ezcater/DirectEnvCheck`.
 
 ## v1.1.0
+
 - Add `Ezcater/RailsEnv` cop.
 - Add `Ezcater/DirectEnvCheck` cop.
 
 ## v1.0.2
+
 - Exclude bootsnap cache directory (`tmp/cache`).
 
 ## v1.0.1
+
 - Disable `Rails/HasAndBelongsToMany` cop.
 - Disable `Style/DoubleNegation` cop.
 
 ## v1.0.0
+
 - Begin using Semantic Versioning
 - Delete `Ezcater/PrivateAttr`
 
 ## v0.61.1
+
 - `Layout/IndentHash` enforces consistent style
 - `Layout/IndentArray` enforces consistent style
 
 ## v0.61.0
+
 - Update to `rubocop` v0.61.1.
 - Update to `rubocop-rspec` v1.30.1
 
 ## v0.59.0
+
 - Disable `Style/NegatedIf`.
 
 ## v0.58.4
+
 - Update `Metrics/BlockLength` to exclude `app/graphql/**/*.rb`
 - Move `Metrics/BlockLength` exclusions for `lib/tasks/**/*.rake` and
   `config/environments/*.rb` into rubocop_rails.yml
 
 ## v0.58.3
+
 - Updated `Layout/MultilineMethodCallIndentation` to `indented`.
 
 ## v0.58.2
+
 - Updated `Ezcater/RspecDotNotSelfDot` to flag offenses for `::class_method`.
 
 ## v0.58.1
+
 - Update to `rubocop-rspec` v1.28.0.
 - Remove configuration for removed `FactoryBot/DynamicAttributeDefinedStatically` cop.
 
 ## v0.58.0
+
 - Update to rubocop v0.58.1.
 - Enable `Naming/MemoizedInstanceVariableName` with required leading
   underscore.
 
 ## v0.57.4
+
 - Configure `Rspec/MessageExpectation` with the `allow` style.
 
 ## v0.57.3
+
 - Do not use broken parser v2.5.1.1.
 
 ## v0.57.2
+
 - Fix `Ezcater/RspecRequireHttpStatusMatcher` cop.
 
 ## v0.57.1
+
 - Add `Ezcater/RspecRequireHttpStatusMatcher` cop.
 - Enable `Rails/HttpStatus` cop and enforce symbols.
 
 ## v0.57.0
+
 - Update to rubocop v0.57.2 and rubocop-rspec v1.27.0.
 - Disable new cop `Naming/MemoizedInstanceVariableName` until configuration
   options are available.
@@ -142,100 +183,128 @@ Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of R
 - Exclude appraisal generated gemfiles for gems.
 
 ## v0.52.8
+
 - Add new configuration `rubocop_gem` for use with gems.
 
 ## v0.52.7
+
 - Enable `Style/FrozenStringLiteralComment` with the `when_needed` style.
 
 ## v0.52.6
+
 - Configure `Style/TrailingCommaInLiteral` with `consistent_comma` style.
 
 ## v0.52.5
+
 - Add `Ezcater/RspecMatchOrderedArray` cop.
 - Fix array equality matcher violations in specs.
 
 ## v0.52.4
+
 - Configure `Style/RegexpLiteral` cop with the `AllowInnerSlashes: true` option.
 
 ## v0.52.3
+
 - Disable `Style/GuardClause` cop.
 - Exclude `spec/integrations` for `RSpec/DescribeClass`.
 
 ## v0.52.2
+
 - Disable `Style/IfUnlessModifier` cop.
 
 ## v0.52.1
+
 - Allow staging as a rails environment for the Rails/UnknownEnv cop.
 
 ## v0.52.0
+
 - Update to rubocop v0.52.1 and rubocop-rspec v1.22.2.
 
 ## v0.51.8
+
 - Disable `RSpec/LetSetup` cop.
 
 ## v0.51.7
+
 - Rename `Ezcater/RspecRequireGqlErrorHelpers` cop to `Ezcater/RequireGqlErrorHelpers`.
 
 ## v0.51.6
+
 - Add `Ezcater/RailsConfiguration` cop.
 - Exclude `config/environments/*.rb` for the `Metrics/BlockLength` cop.
 
 ## v0.51.5
+
 - Add `Ezcater/RspecRequireGqlErrorHelpers` cop.
 
 ## v0.51.4
+
 - Exclude `Gemfile` for the `Metrics/LineLength` cop.
 - Add `system` to the excluded spec directories for `RSpec/DescribeClass`.
 
 ## v0.51.3
+
 - Configure `RSpec/DescribeClass` to exclude the spec directories which
   are excluded by explicit metadata.
 - Exclude `lib/tasks` for the `Metrics/BlockLength` cop.
 
 ## v0.51.2
+
 - Configure `Style/RaiseArgs` to use the `compact` style.
 
 ## v0.51.1
+
 - Disable `Rails/FilePath` cop.
 - Disable `Style/EmptyLiteral` cop.
 
 ## v0.51.0
+
 - Update to rubocop v0.51.0 and rubocop-rspec v1.20.0.
 - Disable new cop `RSpec/ContextWording`.
 - Disable `Style/StderrPuts` for `bin/yarn`.
 
 ## v0.50.5
+
 - Configure `RSpec/NestedGroups` with a `Max` value of 5.
 
 ## v0.50.4
+
 - Configure `Style/PercentLiteralDelimiters` to prefer parentheses.
 
 ## v0.50.3
+
 - Configure `RSpec/MultipleExpectations` with a `Max` value of 5.
 
 ## v0.50.2
+
 - Add `Ezcater/PrivateAttr` custom cop.
 - Configure `RSpec/ExampleLength` with a `Max` value of 25.
 - Add `circle_rubocop.rb` script.
 
 ## v0.50.1
+
 - Add shared configuration.
 - Do not apply `Ezcater/StyleDig` to access using a range.
 
 ## v0.50.0
+
 - Update to rubocop v0.50.0 and rubocop-rspec v1.18.0.
 - Do not apply `Ezcater/StyleDig` to assignments with nested access.
 
 # v0.49.3
+
 - Do not apply `Ezcater/StyleDig` to access using a range.
 
 # v0.49.2
+
 - Do not apply `Ezcater/StyleDig` to assignments to with nested access.
 
 ## v0.49.1
+
 - Add `Ezcater/RspecRequireBrowserMock` cop.
 
 ## v0.49.0
+
 - Initial release.
 - Add `Ezcater/RspecRequireFeatureFlagMock` cop.
 - Add `Ezcater/RspecDotNotSelfDot` cop.

data/README.md

@@ -1,4 +1,4 @@
-# ezcater_rubocop
+# ezcater_rubocop [![CircleCI](https://circleci.com/gh/ezcater/ezcater_rubocop/tree/main.svg?style=svg)](https://circleci.com/gh/ezcater/ezcater_rubocop/tree/main)
 
 ezCater custom cops and shared RuboCop configuration.
 
@@ -61,28 +61,32 @@ configuration for existing offenses and auto-correction.
 
 This gem contains a script, `circle_rubocop.rb`, that can be used to run RuboCop in CI.
 
-The behavior of the script is that all files are checked on master or if the rubocop
-configuration has changed. On non-master branches, only the files added or changed on
+The behavior of the script is that all files are checked on main or if the rubocop
+configuration has changed. On non-main branches, only the files added or changed on
 the branch are checked.
 
-For non-master branches, `[rubocop skip]` can be included in the commit message to skip
+For non-main branches, `[rubocop skip]` can be included in the commit message to skip
 running rubocop.
 
 ## Versioning
 
 This gem is using [Semantic Versioning](https://semver.org/). All version bumps should increment using `MAJOR.MINOR.PATCH` based on changes.
 
+When adding a new cop, please enable the cop and release a new major version. This allows us to
+constantly roll out improvements without clients having their suite break unknowingly. When a
+breaking change is released, users can opt to use `--regenerate-todo` to update their TODO file. Do
+not add cops with `enabled: false` unless you want that cop to always be disabled.
+
 ## Custom Cops
 
-1. [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.
-1. [RequireGqlErrorHelpers](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/require_gql_error_helpers.rb) - Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.
-1. [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" and "::<class method>" for example group description.
-1. [RspecMatchOrderedArray](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb) - Enforce use of `match_ordered_array` matcher instead of `eq` matcher. This matcher comes from the [ezcater_matchers](https://github.com/ezcater/ezcater_matchers) gem.
-1. [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
-1. [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.
-1. [RspecRequireHttpStatusMatcher](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb) - Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`
-1. [StyleDig](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/style_dig.rb) - Recommend `dig` for deeply nested access.
-1. [GraphqlFieldsNaming](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/graphql_fields_naming.rb) - Enforce the configured style when naming graphQL fields and arguments.
+1. [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.
+1. [RequireGqlErrorHelpers](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/require_gql_error_helpers.rb) - Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.
+1. [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" and "::<class method>" for example group description.
+1. [RspecMatchOrderedArray](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_match_ordered_array.rb) - Enforce use of `match_ordered_array` matcher instead of `eq` matcher. This matcher comes from the [ezcater_matchers](https://github.com/ezcater/ezcater_matchers) gem.
+1. [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
+1. [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.
+1. [RspecRequireHttpStatusMatcher](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb) - Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`
+1. [StyleDig](https://github.com/ezcater/ezcater_rubocop/blob/main/lib/rubocop/cop/ezcater/style_dig.rb) - Recommend `dig` for deeply nested access.
 
 ## Development
 

data/bin/circle_rubocop.rb

@@ -4,10 +4,10 @@
 require "English"
 
 # This script is used to run Rubocop in CircleCI so that on branches only
-# the changed files are checked and on master all files are checked.
+# the changed files are checked and on main all files are checked.
 #
 # Additionally if rubocop configuration is changed, all files are checked, and
-# if the commit description on a non-master branch includes [rubocop skip]
+# if the commit description on a non-main branch includes [rubocop skip]
 # then rubocop is skipped.
 
 def run(command)
@@ -20,7 +20,7 @@ def rubocop_everything
 end
 
 begin
-  if ENV["CIRCLE_BRANCH"] == "master"
+  if ENV["CIRCLE_BRANCH"] == "main"
     rubocop_everything
   else
     git_commit_desc = `git log --format=%B -n 1 $CIRCLE_SHA1`
@@ -30,7 +30,7 @@ begin
       exit 0
     end
 
-    changed_files = `git diff --diff-filter=d --name-only origin/master...$CIRCLE_BRANCH`.split("\n").join(" ")
+    changed_files = `git diff --diff-filter=d --name-only origin/main...$CIRCLE_BRANCH`.split("\n").join(" ")
     raise "Failed to identify changed files" unless $CHILD_STATUS.success?
 
     if changed_files.strip.empty? || changed_files.include?(".rubocop")

data/conf/rubocop.yml

@@ -148,191 +148,183 @@ Style/TrailingCommaInArrayLiteral:
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: consistent_comma
 
-### New Cops
 
-# Cops are now introduced in a "pending" state and must be explicitly
-# enabled or disabled. New cops are not enabled by default until the
-# next major release.
-
-# New cops introduced between 0.81.0 and 1.16.0
 Layout/BeginEndAlignment:
-  Enabled: false
+  Enabled: true
 
 Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: false
+  Enabled: true
 
 Layout/IndentationStyle:
-  Enabled: false
+  Enabled: true
 
 Layout/SpaceAroundMethodCallOperator:
-  Enabled: false
+  Enabled: true
 
 Lint/BinaryOperatorWithIdenticalOperands:
-  Enabled: false
+  Enabled: true
 
 Lint/ConstantDefinitionInBlock:
-  Enabled: false
+  Enabled: true
 
 Lint/DeprecatedOpenSSLConstant:
-  Enabled: false
+  Enabled: true
 
 Lint/DuplicateElsifCondition:
-  Enabled: false
+  Enabled: true
 
 Lint/DuplicateRequire:
-  Enabled: false
+  Enabled: true
 
 Lint/DuplicateRescueException:
-  Enabled: false
+  Enabled: true
 
 Lint/EmptyConditionalBody:
-  Enabled: false
+  Enabled: true
 
 Lint/EmptyFile:
-  Enabled: false
+  Enabled: true
 
 Lint/FloatComparison:
-  Enabled: false
+  Enabled: true
 
 Lint/HashCompareByIdentity:
-  Enabled: false
+  Enabled: true
 
 Lint/IdentityComparison:
-  Enabled: false
+  Enabled: true
 
 Lint/MissingSuper:
-  Enabled: false
+  Enabled: true
 
 Lint/MixedRegexpCaptureTypes:
-  Enabled: false
+  Enabled: true
 
 Lint/OutOfRangeRegexpRef:
-  Enabled: false
+  Enabled: true
 
 Lint/RedundantSafeNavigation:
-  Enabled: false
+  Enabled: true
 
 Lint/SelfAssignment:
-  Enabled: false
+  Enabled: true
 
 Lint/TopLevelReturnWithArgument:
-  Enabled: false
+  Enabled: true
 
 Lint/TrailingCommaInAttributeDeclaration:
-  Enabled: false
+  Enabled: true
 
 Lint/UnreachableLoop:
-  Enabled: false
+  Enabled: true
 
 Lint/UselessMethodDefinition:
-  Enabled: false
+  Enabled: true
 
 Lint/UselessTimes:
-  Enabled: false
+  Enabled: true
 
 Rails/ArelStar:
-  Enabled: false
+  Enabled: true
 
 Rails/Pick:
-  Enabled: false
+  Enabled: true
 
 Rails/RedundantForeignKey:
-  Enabled: false
+  Enabled: true
 
 RSpec/Capybara/CurrentPathExpectation:
-  Enabled: false
+  Enabled: true
 
 RSpec/Capybara/FeatureMethods:
-  Enabled: false
+  Enabled: true
 
 RSpec/Capybara/VisibilityMatcher:
-  Enabled: false
+  Enabled: true
 
 RSpec/EmptyHook:
-  Enabled: false
+  Enabled: true
 
 RSpec/FactoryBot/AttributeDefinedStatically:
-  Enabled: false
+  Enabled: true
 
 RSpec/FactoryBot/CreateList:
-  Enabled: false
+  Enabled: true
 
 RSpec/FactoryBot/FactoryClassName:
-  Enabled: false
+  Enabled: true
 
 RSpec/MultipleMemoizedHelpers:
-  Enabled: false
+  Enabled: true
 
 RSpec/NotToNot:
-  Enabled: false
+  Enabled: true
 
 RSpec/Rails/HttpStatus:
-  Enabled: false
+  Enabled: true
 
 RSpec/RepeatedIncludeExample:
-  Enabled: false
+  Enabled: true
 
 RSpec/StubbedMock:
-  Enabled: false
+  Enabled: true
 
 RSpec/VariableDefinition:
-  Enabled: false
+  Enabled: true
 
 RSpec/VariableName:
-  Enabled: false
+  Enabled: true
 
 Style/AccessorGrouping:
-  Enabled: false
+  Enabled: true
 
 Style/BisectedAttrAccessor:
-  Enabled: false
+  Enabled: true
 
 Style/CaseLikeIf:
-  Enabled: false
+  Enabled: true
 
 Style/CombinableLoops:
-  Enabled: false
+  Enabled: true
 
 Style/ExponentialNotation:
-  Enabled: false
+  Enabled: true
 
 Style/GlobalStdStream:
-  Enabled: false
+  Enabled: true
 
 Style/HashAsLastArrayItem:
-  Enabled: false
+  Enabled: true
 
 Style/HashLikeCase:
-  Enabled: false
+  Enabled: true
 
 Style/KeywordParametersOrder:
-  Enabled: false
+  Enabled: true
 
 Style/OptionalBooleanParameter:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantAssignment:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantRegexpCharacterClass:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantRegexpEscape:
-  Enabled: false
+  Enabled: true
 
 Style/RedundantSelfAssignment:
-  Enabled: false
+  Enabled: true
 
 Style/SingleArgumentDig:
-  Enabled: false
+  Enabled: true
 
 Style/SlicingWithRange:
-  Enabled: false
+  Enabled: true
 
 Style/SoleNestedConditional:
-  Enabled: false
-
-#### New cops in v0.81
+  Enabled: true
 
 Lint/RaiseException:
   Enabled: true
@@ -340,8 +332,6 @@ Lint/RaiseException:
 Lint/StructNewOverride:
   Enabled: true
 
-#### New cops in v0.80
-
 Style/HashEachMethods:
   Enabled: true
 

data/config/default.yml

@@ -1,12 +1,3 @@
-Ezcater/GraphqlFieldsNaming:
-  EnforcedStyle: snake_case
-  Enabled: true
-  SupportedStyles:
-    - snake_case
-    - camelCase
-  Include:
-    - "app/graphql/**/*.rb"
-
 Ezcater/RailsConfiguration:
   Description: "Enforce the use of `Rails.configuration` instead of `Rails.application.config`."
   Enabled: true
@@ -59,3 +50,15 @@ Ezcater/StyleDig:
 Ezcater/RubyTimeout:
   Description: "Disallow use of `Timeout.timeout` because it is unsafe and can cause unexpected behavior."
   Enabled: true
+
+GraphQL/FieldDescription:
+  Enabled: false
+GraphQL/ArgumentDescription:
+  Enabled: false
+GraphQL/ObjectDescription:
+  Include:
+    - "**/types/**/*.rb"
+    - "**/mutations/**/*.rb"
+GraphQL/ExtractInputType:
+  Exclude:
+    - "**/input_objects/**/*.rb"

data/ezcater_rubocop.gemspec

@@ -44,15 +44,16 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = ">= 2.6"
 
-  spec.add_development_dependency "bundler", "~> 2.1"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "pry-byebug"
-  spec.add_development_dependency "rake", "~> 12.3"
-  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rspec", "~> 3.11"
   spec.add_development_dependency "rspec_junit_formatter"
-  spec.add_development_dependency "simplecov", "< 0.18.0"
+  spec.add_development_dependency "simplecov"
 
-  spec.add_runtime_dependency "parser", "!= 2.5.1.1"
-  spec.add_runtime_dependency "rubocop", "~> 1.16.0"
-  spec.add_runtime_dependency "rubocop-rails", "~> 2.10.1"
-  spec.add_runtime_dependency "rubocop-rspec", "~> 2.3.0"
+  spec.add_runtime_dependency "parser", ">= 2.6"
+  spec.add_runtime_dependency "rubocop", ">= 1.16.0", "< 2.0"
+  spec.add_runtime_dependency "rubocop-graphql", ">= 0.14.0", "< 1.0"
+  spec.add_runtime_dependency "rubocop-rails", ">= 2.10.1", "< 3.0"
+  spec.add_runtime_dependency "rubocop-rspec", ">= 2.3.0", "< 3.0"
 end

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "3.0.1"
+  VERSION = "5.0.0"
 end

data/lib/ezcater_rubocop.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "ezcater_rubocop/version"
+require "rubocop-graphql"
 require "rubocop-rails"
 require "rubocop-rspec"
 
@@ -17,7 +18,6 @@ RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 
 require "rubocop/cop/ezcater/direct_env_check"
 require "rubocop/cop/ezcater/feature_flag_active"
-require "rubocop/cop/ezcater/graphql_fields_naming"
 require "rubocop/cop/ezcater/rails_configuration"
 require "rubocop/cop/ezcater/rails_env"
 require "rubocop/cop/ezcater/ruby_timeout"

data/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb

@@ -35,8 +35,8 @@ module RuboCop
           %w(it specify example scenario).map { |identifier| "#{prefix}#{identifier}" }
         end.flatten + %w(its focus skip)).freeze
 
-        SELF_DOT_REGEXP = /\Aself\./.freeze
-        COLON_COLON_REGEXP = /\A(\:\:)/.freeze
+        SELF_DOT_REGEXP = /\Aself\./.freeze # rubocop:disable Style/RedundantFreeze
+        COLON_COLON_REGEXP = /\A(::)/.freeze # rubocop:disable Style/RedundantFreeze
 
         SELF_DOT_MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'
         COLON_COLON_MSG = 'Use ".<class method>" instead of "::<class method>" for example group description.'

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 5.0.0
 platform: ruby
 authors:
 - ezCater, Inc
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-23 00:00:00.000000000 Z
+date: 2022-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -44,28 +44,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.11'
 - !ruby/object:Gem::Dependency
   name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
@@ -84,72 +84,110 @@ dependencies:
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.18.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.18.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "!="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.5.1.1
+        version: '2.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "!="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.5.1.1
+        version: '2.6'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.16.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.16.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-graphql
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.14.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.14.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.10.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.10.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: ezCater custom cops and shared configuration
 email:
 - engineering@ezcater.com
@@ -175,7 +213,6 @@ files:
 - lib/ezcater_rubocop/version.rb
 - lib/rubocop/cop/ezcater/direct_env_check.rb
 - lib/rubocop/cop/ezcater/feature_flag_active.rb
-- lib/rubocop/cop/ezcater/graphql_fields_naming.rb
 - lib/rubocop/cop/ezcater/rails_configuration.rb
 - lib/rubocop/cop/ezcater/rails_env.rb
 - lib/rubocop/cop/ezcater/rails_top_level_sql_execute.rb
@@ -193,7 +230,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -208,8 +245,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: ezCater custom cops and shared configuration
 test_files: []

data/lib/rubocop/cop/ezcater/graphql_fields_naming.rb

@@ -1,74 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Ezcater
-      # This cop makes sure that GraphQL fields & arguments match the supported style
-      # https://git.io/JeofW
-      #
-      # The cop also ignores when users provide a :camelize option, because
-      # the user is manually requesting to override the value
-      #
-      # @example
-      #   # bad
-      #   field :fooBar, ID, null: false
-      #   argument :barBaz, ID, required: true
-      #
-      #   # good
-      #   field :foo_bar, ID, null: true
-      #   field :foo_bar, ID, null: true do
-      #     argument :bar_baz, ID, required: true
-      #   end
-      #
-      #   field :fooBar, ID, null: true, camelize: true
-      #
-      class GraphqlFieldsNaming < Cop
-        include ConfigurableNaming
-
-        MSG = "Use %<style>s for GraphQL fields & arguments names. " \
-              "See https://git.io/JeofW for our guide. " \
-              "This can be overridden with camelize."
-        FIELD_ADDING_METHODS = %i(field argument).freeze
-        PROCESSABLE_TYPES = %i(sym string).freeze
-
-        def on_send(node)
-          method = method_name(node)
-          first_arg = node.first_argument
-
-          return unless FIELD_ADDING_METHODS.include? method
-          return unless PROCESSABLE_TYPES.include?(first_arg&.type)
-
-          return if includes_camelize?(node)
-
-          check_name(node, first_arg.value, node.first_argument)
-        end
-
-        alias on_super on_send
-        alias on_yield on_send
-
-        private
-
-        def includes_camelize?(node)
-          results = []
-          node.last_argument.each_child_node { |arg| results << args_include_camelize?(arg) }
-          results.any?
-        end
-
-        def args_include_camelize?(arg_pair)
-          key_node = arg_pair.key
-          _value_node = arg_pair.value
-
-          key_node.value.match?(/camelize/)
-        end
-
-        def method_name(node)
-          node.children[1]
-        end
-
-        def message(style)
-          format(MSG, style: style) # Rubocop:disable Style/HashSyntax
-        end
-      end
-    end
-  end
-end