ezcater_rubocop 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 511f81e30ff5765d51a825d7b8606ebfa3c05d34e8c567dc7876ea7140e63d8a
-  data.tar.gz: f01eb84d2556225ac5be3e2c0ec206b6c1f5f8dc3fa8f6ad5bf6de400b474514
+  metadata.gz: 32ed01c4904b105bcd1ac2b3b8871485448284bffe06dc6b90fda19775748175
+  data.tar.gz: 19755e3e83359f473ff961e1679c39b1bdb5f6d78a9c78e3ca6118be344c8400
 SHA512:
-  metadata.gz: 6283449ed5c2181a90557d786e074e285841c8fc8ea5f0d693fd40d52c536121b50267d0352d266e60ed3bb62e1d2aae0be87f64024cb9418cf65daf7311993f
-  data.tar.gz: 5385a45fb8dfb260eda7d3fdaf8adaf3dc2b05f6ab6532c622744f4c2c4fab06ac3909b71d74ba7bc4a68fc87bf311f7d69246afcbb84c62f12912c6f215c3f3
+  metadata.gz: c215237f6c8fc40398c3947944261a457a2fc3efbebb51bc3e01ba743a3a4ad099a1a3ecfcc2782c056a78df6231b5bc0c258e0fa0f7ab8fd04e13be9ad26f79
+  data.tar.gz: f5066524144f916ff5d56c4aa320d916d4ed383b4eee01d20db2809a67eb2ed65bdf541709b8c0c9cec36a977a6ff9c92704564dacd7e9726a5b99bf02c0fffc

data/.tool-versions

@@ -0,0 +1 @@
+ruby 2.7.3

data/CHANGELOG.md

@@ -6,11 +6,16 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
+## v3.0.1
+- Fix the RspecDotNotSelfDot cop to work with rubocop-rspec
+- Exclude appraisal generated gemfiles for possible embedded gems in rails apps
+
 ## v3.0.0
-- Upgrade rubocop:       1.16.0
+
+- Upgrade rubocop: 1.16.0
 - Upgrade rubocop-rails: 2.10.1
 - Upgrade rubocop-rspec: 2.3.0
-- This is a major upgrade because a large number of cops have been introduced, tweaked, or renamed.  Here is an aggregate of the breaking changes introduced
+- This is a major upgrade because a large number of cops have been introduced, tweaked, or renamed. Here is an aggregate of the breaking changes introduced
   - RuboCop assumes that Cop classes do not define new `on_<type>` methods at runtime (e.g. via `extend` in `initialize`).
   - Enable all pending cops for RuboCop 1.0.
   - Change logic for cop department name computation. Cops inside deep namespaces (5 or more levels deep) now belong to departments with names that are calculated by joining module names starting from the third one with slashes as separators. For example, cop `Rubocop::Cop::Foo::Bar::Baz` now belongs to `Foo/Bar` department (previously it was `Bar`).

data/conf/rubocop.yml

@@ -3,6 +3,7 @@ require: ezcater_rubocop
 AllCops:
   DisplayCopNames: true
   NewCops: disable
+  SuggestExtensions: false
 
 Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
@@ -21,8 +22,8 @@ Metrics/AbcSize:
 
 Metrics/BlockLength:
   Exclude:
-  - "*.gemspec"
-  - "spec/**/*.rb"
+    - "*.gemspec"
+    - "spec/**/*.rb"
 
 Metrics/CyclomaticComplexity:
   Enabled: false
@@ -30,7 +31,7 @@ Metrics/CyclomaticComplexity:
 Layout/LineLength:
   Max: 120
   Exclude:
-  - "Gemfile"
+    - "Gemfile"
 
 Metrics/MethodLength:
   Enabled: true
@@ -45,9 +46,9 @@ Naming/MemoizedInstanceVariableName:
 
 Naming/MethodParameterName:
   AllowedNames:
-  - e
-  - ex
-  - id
+    - e
+    - ex
+    - id
 
 Naming/VariableNumber:
   Enabled: false
@@ -60,12 +61,12 @@ RSpec/ContextWording:
 
 RSpec/DescribeClass:
   Exclude:
-  - "spec/requests/**/*.rb"
-  - "spec/features/**/*.rb"
-  - "spec/routing/**/*.rb"
-  - "spec/views/**/*.rb"
-  - "spec/system/**/*.rb"
-  - "spec/integrations/**/*.rb"
+    - "spec/requests/**/*.rb"
+    - "spec/features/**/*.rb"
+    - "spec/routing/**/*.rb"
+    - "spec/views/**/*.rb"
+    - "spec/system/**/*.rb"
+    - "spec/integrations/**/*.rb"
 
 RSpec/ExampleLength:
   Max: 25
@@ -113,12 +114,12 @@ Style/NumericLiterals:
 
 Style/PercentLiteralDelimiters:
   PreferredDelimiters:
-    default: '()'
-    '%i': '()'
-    '%I': '()'
-    '%r': '{}'
-    '%w': '()'
-    '%W': '()'
+    default: "()"
+    "%i": "()"
+    "%I": "()"
+    "%r": "{}"
+    "%w": "()"
+    "%W": "()"
 
 Style/RaiseArgs:
   EnforcedStyle: compact

data/conf/rubocop_rails.yml

@@ -9,6 +9,7 @@ AllCops:
   TargetRailsVersion: 5.2
   Exclude:
     - tmp/cache/**/*
+    - '**/gemfiles/*.gemfile'
 
 Metrics/BlockLength:
   inherit_mode:

data/config/default.yml

@@ -5,57 +5,57 @@ Ezcater/GraphqlFieldsNaming:
     - snake_case
     - camelCase
   Include:
-    - 'app/graphql/**/*.rb'
+    - "app/graphql/**/*.rb"
 
 Ezcater/RailsConfiguration:
-  Description: 'Enforce the use of `Rails.configuration` instead of `Rails.application.config`.'
+  Description: "Enforce the use of `Rails.configuration` instead of `Rails.application.config`."
   Enabled: true
 
 Ezcater/RailsEnv:
-  Description: 'Enforce the use of `Rails.configuration.x.<foo>` instead of checking `Rails.env`.'
+  Description: "Enforce the use of `Rails.configuration.x.<foo>` instead of checking `Rails.env`."
   Enabled: false
 
 Ezcater/DirectEnvCheck:
-  Description: 'Enforce the use of `Rails.configuration.x.<foo>` instead of checking `ENV`.'
+  Description: "Enforce the use of `Rails.configuration.x.<foo>` instead of checking `ENV`."
   Enabled: false
 
 Ezcater/FeatureFlagActive:
-  Description: 'Enforce the proper arguments are given to EzcaterFeatureFlag.active?'
+  Description: "Enforce the proper arguments are given to EzcaterFeatureFlag.active?"
   Enabled: true
 
 Ezcater/RspecDotNotSelfDot:
   Description: 'Enforce ".<class method>" instead of "self.<class method>" for example group description.'
   Enabled: true
   Include:
-    - '**/*_spec.rb'
+    - "**/*_spec.rb"
 
 Ezcater/RspecRequireBrowserMock:
-  Description: 'Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.'
+  Description: "Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly."
   Enabled: true
   Include:
-    - '**/*_spec.rb'
+    - "**/*_spec.rb"
 
 Ezcater/RspecRequireFeatureFlagMock:
-  Description: 'Enforce use of `mock_feature_flag` helpers instead of mocking `FeatureFlag.is_active?` directly.'
+  Description: "Enforce use of `mock_feature_flag` helpers instead of mocking `FeatureFlag.is_active?` directly."
   Enabled: true
   Include:
-    - '**/*_spec.rb'
+    - "**/*_spec.rb"
 
 Ezcater/RspecRequireHttpStatusMatcher:
-  Description: 'Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`'
+  Description: "Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`"
   Enabled: true
   Include:
-    - '**/*_spec.rb'
+    - "**/*_spec.rb"
 
 Ezcater/RequireGqlErrorHelpers:
-  Description: 'Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.'
+  Description: "Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly."
   Enabled: true
 
 Ezcater/StyleDig:
-  Description: 'Recommend `dig` for deeply nested access.'
+  Description: "Recommend `dig` for deeply nested access."
   Enabled: true
   AutoCorrect: false
 
 Ezcater/RubyTimeout:
-  Description: 'Disallow use of `Timeout.timeout` because it is unsafe and can cause unexpected behavior.'
+  Description: "Disallow use of `Timeout.timeout` because it is unsafe and can cause unexpected behavior."
   Enabled: true

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "3.0.0"
+  VERSION = "3.0.1"
 end

data/lib/rubocop/cop/ezcater/graphql_fields_naming.rb

@@ -66,7 +66,7 @@ module RuboCop
         end
 
         def message(style)
-          format(MSG, style: style)
+          format(MSG, style: style) # Rubocop:disable Style/HashSyntax
         end
       end
     end

data/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb

@@ -25,26 +25,44 @@ module RuboCop
 
       class RspecDotNotSelfDot < Cop
         include RuboCop::RSpec::Language
+        extend RuboCop::RSpec::Language::NodePattern
 
-        SELF_DOT_REGEXP = /["']self\./.freeze
-        COLON_COLON_REGEXP = /["'](\:\:)/.freeze
+        RSPEC_EXAMPLE_PREFIXES = ["", "x", "f"].freeze
+        EXAMPLE_GROUP_IDENTIFIERS = (RSPEC_EXAMPLE_PREFIXES.map do |prefix|
+          %w(describe context feature).map { |identifier| "#{prefix}#{identifier}" }
+        end.flatten + %w(example_group)).freeze
+        EXAMPLE_IDENTIFIERS = (RSPEC_EXAMPLE_PREFIXES.map do |prefix|
+          %w(it specify example scenario).map { |identifier| "#{prefix}#{identifier}" }
+        end.flatten + %w(its focus skip)).freeze
+
+        SELF_DOT_REGEXP = /\Aself\./.freeze
+        COLON_COLON_REGEXP = /\A(\:\:)/.freeze
 
         SELF_DOT_MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'
         COLON_COLON_MSG = 'Use ".<class method>" instead of "::<class method>" for example group description.'
 
-        def on_send(node)
-          example_group?(node) do |doc|
-            if doc.source.match?(SELF_DOT_REGEXP)
-              add_offense(doc, location: :expression, message: SELF_DOT_MSG)
-            elsif doc.source.match?(COLON_COLON_REGEXP)
-              add_offense(doc, location: :expression, message: COLON_COLON_MSG)
-            end
+        def_node_matcher :example_group?, <<~PATTERN
+          (block
+            (send #rspec? {#{EXAMPLE_GROUP_IDENTIFIERS.map { |i| ":#{i}" }.join(' ')}}
+              (str ...) ...
+            ) ...
+          )
+        PATTERN
+
+        def on_block(node)
+          return unless example_group?(node)
+
+          str_node = node.send_node.arguments[0]
+          if str_node.value.match?(SELF_DOT_REGEXP)
+            add_offense(str_node, location: :expression, message: SELF_DOT_MSG)
+          elsif str_node.value.match?(COLON_COLON_REGEXP)
+            add_offense(str_node, location: :expression, message: COLON_COLON_MSG)
           end
         end
 
         def autocorrect(node)
           lambda do |corrector|
-            experession_end = node.source.match?(COLON_COLON_REGEXP) ? 3 : 6
+            experession_end = node.source.match?("::") ? 3 : 6
             corrector.replace(Parser::Source::Range.new(node.source_range.source_buffer,
                                                         node.source_range.begin_pos + 1,
                                                         node.source_range.begin_pos + experession_end), ".")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - ezCater, Inc
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-06-09 00:00:00.000000000 Z
+date: 2022-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -160,6 +160,7 @@ extra_rdoc_files: []
 files:
 - ".github/CODEOWNERS"
 - ".github/PULL_REQUEST_TEMPLATE.md"
+- ".tool-versions"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -192,7 +193,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -208,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.6
-signing_key:
+signing_key: 
 specification_version: 4
 summary: ezCater custom cops and shared configuration
 test_files: []