ezcater_rubocop 2.5.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e4c9156d1f1e5ccdc48028b627a413ae3ff87a7bf47ec574943d2d755efe5aa
-  data.tar.gz: 490b59709998f04a6c873d210f028ddb6d045dabccce60e4a962f38f2ac1584d
+  metadata.gz: 511f81e30ff5765d51a825d7b8606ebfa3c05d34e8c567dc7876ea7140e63d8a
+  data.tar.gz: f01eb84d2556225ac5be3e2c0ec206b6c1f5f8dc3fa8f6ad5bf6de400b474514
 SHA512:
-  metadata.gz: 5645db771b9fd242d08b92eb300f29c57a51bb089466e5f3c4f269261972e786a8cf0a3f9b051eb401acfb001d2cacc024e292b6291243c9b086ebafb90fe392
-  data.tar.gz: f9b580d5a79630d70c77d06fb3f5922f39a2a2fafd70ec587f162409553ccc8e4bf28ed55d1f68ae0b6daa279faed0f7f88c69c4c6998bec039cd29a8b27210f
+  metadata.gz: 6283449ed5c2181a90557d786e074e285841c8fc8ea5f0d693fd40d52c536121b50267d0352d266e60ed3bb62e1d2aae0be87f64024cb9418cf65daf7311993f
+  data.tar.gz: 5385a45fb8dfb260eda7d3fdaf8adaf3dc2b05f6ab6532c622744f4c2c4fab06ac3909b71d74ba7bc4a68fc87bf311f7d69246afcbb84c62f12912c6f215c3f3

data/CHANGELOG.md

@@ -6,8 +6,30 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
-## v2.5.0
-- Update rubocop to 0.90.0
+## v3.0.0
+- Upgrade rubocop:       1.16.0
+- Upgrade rubocop-rails: 2.10.1
+- Upgrade rubocop-rspec: 2.3.0
+- This is a major upgrade because a large number of cops have been introduced, tweaked, or renamed.  Here is an aggregate of the breaking changes introduced
+  - RuboCop assumes that Cop classes do not define new `on_<type>` methods at runtime (e.g. via `extend` in `initialize`).
+  - Enable all pending cops for RuboCop 1.0.
+  - Change logic for cop department name computation. Cops inside deep namespaces (5 or more levels deep) now belong to departments with names that are calculated by joining module names starting from the third one with slashes as separators. For example, cop `Rubocop::Cop::Foo::Bar::Baz` now belongs to `Foo/Bar` department (previously it was `Bar`).
+  - `RegexpNode#parsed_tree` now processes regexps including interpolation (by blanking the interpolation before parsing, rather than skipping).
+  - Cop `Metrics/AbcSize` now counts ||=, &&=, multiple assignments, for, yield, iterating blocks. `&.` now count as conditions too (unless repeated on the same variable). Default bumped from 15 to 17. Consider using `rubocop -a --disable-uncorrectable` to ease transition.
+  - Cop `Metrics/PerceivedComplexity` now counts `else` in `case` statements, `&.`, `||=`, `&&=` and blocks known to iterate. Default bumped from 7 to 8. Consider using `rubocop -a --disable-uncorrectable` to ease transition.
+  - Extensive refactoring of internal classes `Team`, `Commissioner`, `Corrector`. `Cop::Cop#corrections` not completely compatible. See Upgrade Notes.
+  - `rubocop -a / --autocorrect` no longer run unsafe corrections; `rubocop -A / --autocorrect-all` run both safe and unsafe corrections. Options `--safe-autocorrect` is deprecated.
+  - Order for gems names now disregards underscores and dashes unless `ConsiderPunctuation` setting is set to `true`.
+  - Cop `Metrics/CyclomaticComplexity` now counts `&.`, `||=`, `&&=` and blocks known to iterate. Default bumped from 6 to 7. Consider using `rubocop -a --disable-uncorrectable` to ease transition.
+  - Remove support for unindent/active_support/powerpack from `Layout/HeredocIndentation`, so it only recommends using squiggy heredoc.
+  - Change the max line length of `Layout/LineLength` to 120 by default.
+  - Inspect all files given on command line unless `--only-recognized-file-types` is given.
+  - Enabling a cop overrides disabling its department.
+  - Renamed `Layout/Tab` cop to `Layout/IndentationStyle`.
+  - Drop support for Ruby 2.3.
+  - Drop support for ruby 2.4.
+  - Retire `RSpec/InvalidPredicateMatcher` cop.
+  - Enabled pending cop (`RSpec/StubbedMock`).
 
 ## v2.4.0
 - Fix `FeatureFlagActive` cop so that it allows feature flag names to be variables in addition to strings.

data/conf/rubocop.yml

@@ -2,6 +2,7 @@ require: ezcater_rubocop
 
 AllCops:
   DisplayCopNames: true
+  NewCops: disable
 
 Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
@@ -48,6 +49,9 @@ Naming/MethodParameterName:
   - ex
   - id
 
+Naming/VariableNumber:
+  Enabled: false
+
 Rails:
   Enabled: false
 
@@ -131,6 +135,9 @@ Style/StderrPuts:
   Exclude:
     - "bin/yarn"
 
+Style/StringConcatenation:
+  Enabled: false
+
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 
@@ -146,6 +153,184 @@ Style/TrailingCommaInHashLiteral:
 # enabled or disabled. New cops are not enabled by default until the
 # next major release.
 
+# New cops introduced between 0.81.0 and 1.16.0
+Layout/BeginEndAlignment:
+  Enabled: false
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: false
+
+Layout/IndentationStyle:
+  Enabled: false
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: false
+
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: false
+
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: false
+
+Lint/DuplicateElsifCondition:
+  Enabled: false
+
+Lint/DuplicateRequire:
+  Enabled: false
+
+Lint/DuplicateRescueException:
+  Enabled: false
+
+Lint/EmptyConditionalBody:
+  Enabled: false
+
+Lint/EmptyFile:
+  Enabled: false
+
+Lint/FloatComparison:
+  Enabled: false
+
+Lint/HashCompareByIdentity:
+  Enabled: false
+
+Lint/IdentityComparison:
+  Enabled: false
+
+Lint/MissingSuper:
+  Enabled: false
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: false
+
+Lint/OutOfRangeRegexpRef:
+  Enabled: false
+
+Lint/RedundantSafeNavigation:
+  Enabled: false
+
+Lint/SelfAssignment:
+  Enabled: false
+
+Lint/TopLevelReturnWithArgument:
+  Enabled: false
+
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: false
+
+Lint/UnreachableLoop:
+  Enabled: false
+
+Lint/UselessMethodDefinition:
+  Enabled: false
+
+Lint/UselessTimes:
+  Enabled: false
+
+Rails/ArelStar:
+  Enabled: false
+
+Rails/Pick:
+  Enabled: false
+
+Rails/RedundantForeignKey:
+  Enabled: false
+
+RSpec/Capybara/CurrentPathExpectation:
+  Enabled: false
+
+RSpec/Capybara/FeatureMethods:
+  Enabled: false
+
+RSpec/Capybara/VisibilityMatcher:
+  Enabled: false
+
+RSpec/EmptyHook:
+  Enabled: false
+
+RSpec/FactoryBot/AttributeDefinedStatically:
+  Enabled: false
+
+RSpec/FactoryBot/CreateList:
+  Enabled: false
+
+RSpec/FactoryBot/FactoryClassName:
+  Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
+RSpec/NotToNot:
+  Enabled: false
+
+RSpec/Rails/HttpStatus:
+  Enabled: false
+
+RSpec/RepeatedIncludeExample:
+  Enabled: false
+
+RSpec/StubbedMock:
+  Enabled: false
+
+RSpec/VariableDefinition:
+  Enabled: false
+
+RSpec/VariableName:
+  Enabled: false
+
+Style/AccessorGrouping:
+  Enabled: false
+
+Style/BisectedAttrAccessor:
+  Enabled: false
+
+Style/CaseLikeIf:
+  Enabled: false
+
+Style/CombinableLoops:
+  Enabled: false
+
+Style/ExponentialNotation:
+  Enabled: false
+
+Style/GlobalStdStream:
+  Enabled: false
+
+Style/HashAsLastArrayItem:
+  Enabled: false
+
+Style/HashLikeCase:
+  Enabled: false
+
+Style/KeywordParametersOrder:
+  Enabled: false
+
+Style/OptionalBooleanParameter:
+  Enabled: false
+
+Style/RedundantAssignment:
+  Enabled: false
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: false
+
+Style/RedundantRegexpEscape:
+  Enabled: false
+
+Style/RedundantSelfAssignment:
+  Enabled: false
+
+Style/SingleArgumentDig:
+  Enabled: false
+
+Style/SlicingWithRange:
+  Enabled: false
+
+Style/SoleNestedConditional:
+  Enabled: false
+
 #### New cops in v0.81
 
 Lint/RaiseException:

data/ezcater_rubocop.gemspec

@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "simplecov", "< 0.18.0"
 
   spec.add_runtime_dependency "parser", "!= 2.5.1.1"
-  spec.add_runtime_dependency "rubocop", "~> 0.90.0"
-  spec.add_runtime_dependency "rubocop-rails", "~> 2.5.2"
-  spec.add_runtime_dependency "rubocop-rspec", "~> 1.38.1"
+  spec.add_runtime_dependency "rubocop", "~> 1.16.0"
+  spec.add_runtime_dependency "rubocop-rails", "~> 2.10.1"
+  spec.add_runtime_dependency "rubocop-rspec", "~> 2.3.0"
 end

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "2.5.0"
+  VERSION = "3.0.0"
 end

data/lib/rubocop/cop/ezcater/graphql_fields_naming.rb

@@ -40,7 +40,7 @@ module RuboCop
 
           return if includes_camelize?(node)
 
-          check_name(node, first_arg.value, node.first_argument.loc.expression)
+          check_name(node, first_arg.value, node.first_argument)
         end
 
         alias on_super on_send

data/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb

@@ -24,18 +24,16 @@ module RuboCop
       #   end
 
       class RspecDotNotSelfDot < Cop
+        include RuboCop::RSpec::Language
+
         SELF_DOT_REGEXP = /["']self\./.freeze
         COLON_COLON_REGEXP = /["'](\:\:)/.freeze
 
         SELF_DOT_MSG = 'Use ".<class method>" instead of "self.<class method>" for example group description.'
         COLON_COLON_MSG = 'Use ".<class method>" instead of "::<class method>" for example group description.'
 
-        def_node_matcher :example_group_match, <<-PATTERN
-          (send _ #{RuboCop::RSpec::Language::ExampleGroups::ALL.node_pattern_union} $_ ...)
-        PATTERN
-
         def on_send(node)
-          example_group_match(node) do |doc|
+          example_group?(node) do |doc|
             if doc.source.match?(SELF_DOT_REGEXP)
               add_offense(doc, location: :expression, message: SELF_DOT_MSG)
             elsif doc.source.match?(COLON_COLON_REGEXP)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 3.0.0
 platform: ruby
 authors:
 - ezCater, Inc
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-13 00:00:00.000000000 Z
+date: 2021-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -114,42 +114,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.90.0
+        version: 1.16.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.90.0
+        version: 1.16.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.2
+        version: 2.10.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.2
+        version: 2.10.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.38.1
+        version: 2.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.38.1
+        version: 2.3.0
 description: ezCater custom cops and shared configuration
 email:
 - engineering@ezcater.com
@@ -192,7 +192,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -208,7 +208,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.6
-signing_key: 
+signing_key:
 specification_version: 4
 summary: ezCater custom cops and shared configuration
 test_files: []