ezcater_rubocop 1.4.0 → 2.1.0.pre1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 59363f6017a9e7c83ac703824a241234009c10ded26a608b576342dcae476beb
-  data.tar.gz: 70ede1534ff0563c74b4c221053a9f97fccf6af899291a39e6ec366aa20fec48
+SHA1:
+  metadata.gz: dc53c113d14af04b42efb7dfefc2b412bc9b5083
+  data.tar.gz: 7d59fa7723d049a41c577cdfb5f3fc1c37632298
 SHA512:
-  metadata.gz: 8fd92f50f269a93990759237b7260d1872675297ed80d37dfca8bdaac2ce9be26280663a69c3ad3beefa54010ca7b0b64d5b128a6c53bcdee7b164adc98f214c
-  data.tar.gz: a4a660828cd2df9b9c86313fc8f763f9aa127746fa2bd80ab52f7c4262bd0317b282e5aa6b95b128ea9691fb9f9abb38fb510e23f269a44c975e4340b245d997
+  metadata.gz: e5f42422a9d4b7a39188d5ccb727cc3721491fd11ec96045aa9aac6f77eb71cded8805dce11acc9680f77191477e691553df93568f9fc0cf012b332895e71574
+  data.tar.gz: 395f0846f7f3f8fce5b123f74ed11f7efc828144d36dde7adc63ca205d3c087b691a57336aa08c4f002045368f6cd3b2f828ecf5a858c34c8688e1f4b7775766

data/CHANGELOG.md

@@ -6,6 +6,18 @@ This gem is moving onto its own [Semantic Versioning](https://semver.org/) schem
 
 Prior to v1.0.0 this gem was versioned based on the `MAJOR`.`MINOR` version of RuboCop. The first release of the ezcater_rubocop gem was `v0.49.0`.
 
+## Unreleased
+- Enable `Rails/SaveBang` with `AllowImplicitReturn: false`, and with autocorrection disabled.
+
+## v2.0.0
+- Update to `rubocop` v0.81.0, `rubocop-rspec` v1.38.1 and `rubocop-rails` v2.5.2.
+- This is being released as a major update because cops have been renamed so this is unlikely to be
+  a drop-in replacement.
+- This is the first release to support Ruby 2.7.
+
+## v1.4.1
+- Correct a matching syntax issue with `Ezcater/RubyTimeout` so that it applies in the expected cases.
+
 ## v1.4.0
 - Add `Ezcater/RubyTimeout` cop.
 

data/bin/circle_rubocop.rb

@@ -39,7 +39,7 @@ begin
       run("bundle exec rubocop --force-exclusion #{changed_files}")
     end
   end
-rescue StandardError => ex
-  puts "Error: #{ex.message}"
+rescue StandardError => e
+  puts "Error: #{e.message}"
   rubocop_everything
 end

data/conf/rubocop.yml

@@ -3,10 +3,10 @@ require: ezcater_rubocop
 AllCops:
   DisplayCopNames: true
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
-Layout/IndentArray:
+Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
 Layout/MultilineMethodCallIndentation:
@@ -26,7 +26,7 @@ Metrics/BlockLength:
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
   Exclude:
   - "Gemfile"
@@ -42,7 +42,7 @@ Metrics/PerceivedComplexity:
 Naming/MemoizedInstanceVariableName:
   EnforcedStyleForLeadingUnderscores: required
 
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   AllowedNames:
   - e
   - ex
@@ -89,7 +89,7 @@ Style/EmptyLiteral:
 
 Style/FrozenStringLiteralComment:
   Enabled: true
-  EnforcedStyle: when_needed
+  EnforcedStyle: always
 
 Style/GuardClause:
   Enabled: false
@@ -139,3 +139,28 @@ Style/TrailingCommaInArrayLiteral:
 
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: consistent_comma
+
+### New Cops
+
+# Cops are now introduced in a "pending" state and must be explicitly
+# enabled or disabled. New cops are not enabled by default until the
+# next major release.
+
+#### New cops in v0.81
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+#### New cops in v0.80
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true

data/conf/rubocop_rails.yml

@@ -6,7 +6,7 @@ inherit_mode:
     - Exclude
 
 AllCops:
-  TargetRailsVersion: 5.1
+  TargetRailsVersion: 5.2
   Exclude:
     - tmp/cache/**/*
 
@@ -47,6 +47,11 @@ Rails/UnknownEnv:
     - staging
     - production
 
+Rails/SaveBang:
+  Enabled: true
+  AllowImplicitReturn: false
+  AutoCorrect: False
+
 Ezcater/RailsTopLevelSqlExecute:
   Description: 'Use `execute` instead of `ActiveRecord::Base.connection.execute` in migrations.'
   Enabled: true

data/ezcater_rubocop.gemspec

@@ -42,7 +42,7 @@ Gem::Specification.new do |spec|
   spec.executables << "circle_rubocop.rb"
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.15"
+  spec.add_development_dependency "bundler", "~> 2.1"
   spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "rake", "~> 12.3"
   spec.add_development_dependency "rspec", "~> 3.0"
@@ -50,6 +50,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "simplecov", "< 0.18.0"
 
   spec.add_runtime_dependency "parser", "!= 2.5.1.1"
-  spec.add_runtime_dependency "rubocop", "~> 0.61.1"
-  spec.add_runtime_dependency "rubocop-rspec", "~> 1.30.1"
+  spec.add_runtime_dependency "rubocop", "~> 0.81.0"
+  spec.add_runtime_dependency "rubocop-rails", "~> 2.5.2"
+  spec.add_runtime_dependency "rubocop-rspec", "~> 1.38.1"
 end

data/lib/ezcater_rubocop.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "ezcater_rubocop/version"
+require "rubocop-rails"
 require "rubocop-rspec"
 
 # Because RuboCop doesn't yet support plugins, we have to monkey patch in a

data/lib/ezcater_rubocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EzcaterRubocop
-  VERSION = "1.4.0"
+  VERSION = "2.1.0.pre1"
 end

data/lib/rubocop/cop/ezcater/ruby_timeout.rb

@@ -25,7 +25,7 @@ module RuboCop
         END_MESSAGE
 
         def_node_matcher "timeout", <<-PATTERN
-          (send (const _ :Timeout) :timeout)
+          (send (const _ :Timeout) :timeout ...)
         PATTERN
 
         def on_send(node)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 2.1.0.pre1
 platform: ruby
 authors:
 - ezCater, Inc
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-09 00:00:00.000000000 Z
+date: 2020-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -114,28 +114,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.61.1
+        version: 0.81.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.61.1
+        version: 0.81.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.5.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.5.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.30.1
+        version: 1.38.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.30.1
+        version: 1.38.1
 description: ezCater custom cops and shared configuration
 email:
 - engineering@ezcater.com
@@ -177,7 +191,7 @@ licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -188,12 +202,13 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.6.11
+signing_key:
 specification_version: 4
 summary: ezCater custom cops and shared configuration
 test_files: []