ez 1.9.3 → 1.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ac405024955a31e91958c4f679c63a062ec6d7e
-  data.tar.gz: e57f68f2e1a86b817bb592eac4d014334c512d41
+  metadata.gz: 30a484332a168113613431f7bf0c9206d784bc67
+  data.tar.gz: 0a85d1d5f6902f451321f860f0576a8ee4a65f62
 SHA512:
-  metadata.gz: fa70cc7f7e368952a118ac0c162fb89ae71450589effb6be12917719ae88e2a7831168e36156ada6293b826fed36c0689c937d39b908f38ce936c8fc135bc895
-  data.tar.gz: a0838f2498ca2683405752c7167edeb1ba8ff2a70b8de12ef5042cc67a04a1d41c7f8bf42c3f3aad91e4774b1ba38ddfcca9f0ab82be409fc0b3399dc713e1d4
+  metadata.gz: e812e91ee6e64b30033a35b92ee49d8c20ceca3d63a1f3c5df4eac817317d3ba4f8e7e0e580572f0f55331fcc0b5efebbabb6bb673c7660c1cca896f23d24809
+  data.tar.gz: 3f63336649e577a6ca59d06b44a41b947b488205d66367715300c12153e54ae8f60192adc2a81db86bdd88033c0cd7320b15dbf56d167e88f924e754ec96548e

data/README.md

@@ -2,7 +2,7 @@
 
 Easy domain modeling in Rails without migrations.  
 
-**Version 1.9.3**
+**Version 1.9.4**
 
 *For educational purposes only.*
 
@@ -48,6 +48,17 @@ Alternatively, you can run `rails db:migrate` to generate these files without ru
 |controllers|true|Generates one controller per model with 7 empty methods.
 |views|true|Generates the view folder for each model, with 7 empty views.
 
+## Development vs Production
+
+Renaming a column in `db/models.yml` appear to the gem as if you dropped
+the old column and created a new column.  **You will lose any data you
+had in that column**.  Same goes for renaming models: the old table
+will be dropped.
+
+In production, this could be catastrophic.  Therefore, this gem will
+not delete tables or columns in production, only add tables and add
+columns.  This could be problematic but is hopefully the 1% case.
+
 
 ## Syntax Guide for `db/models.yml`**
 
@@ -136,12 +147,12 @@ Author
 ### Migrations
 
 This gem is expecting that the student will not use database migrations
-to control the schema.  However, it is ok to use a combination of migrations
+to control the schema.  It is ok to use both migrations
 and `models.yml`, but be aware of the following:
 
-* If at least one migration file is detected, this gem will stop
-removing tables that are removed from `models.yml` since
-it's not possible to know if there's a migration for it or not.
+* If at least one migration file is detected, this gem will not
+removing tables that would normally removed via `models.yml` since
+it's not possible to know if the table is supposed to be there or not.
 * Where possible, it's best to translate a migration required for
 a third-party gem (say, for Devise) into an entry in models.yml
 so that everything is managed in one place.

data/lib/ez.rb

@@ -2,9 +2,7 @@ require "ez/version"
 require 'ez/domain_modeler'
 require 'ez/model'
 require 'ez/config'
-require 'ez/rails_updater'
-require 'awesome_print'
-
+require 'awesome_print' if (Rails.env.development? || Rails.env.test?)
 require 'hirb' if (Rails.env.development? || Rails.env.test?)
 
 module EZ
@@ -17,7 +15,7 @@ module EZ
     end
 
     console do |app|
-      AwesomePrint.irb!
+      AwesomePrint.irb! if (Rails.env.development? || Rails.env.test?)
 
       Hirb.enable(pager: false) if (Rails.env.development? || Rails.env.test?) && defined?(Hirb)
 

data/lib/ez/domain_modeler.rb

@@ -1,4 +1,5 @@
 require_relative 'schema_modifier'
+require_relative 'rails_updater'
 
 module EZ
 
@@ -20,16 +21,21 @@ module EZ
       tables.map { |t| t.classify }
     end
 
+    def self.should_migrate?(models_yml)
+      schema_rb = File.join(Rails.root, 'db', 'schema.rb')
+      !(Rails.env.development? || Rails.env.test?) ||
+       (!File.exist?(schema_rb)) ||
+       (File.mtime(schema_rb) < File.mtime(models_yml))
+    end
+
     def self.automigrate
       return unless EZ::Config.models?
 
       begin
         models_yml = File.join(Rails.root, 'db', 'models.yml')
-        schema_rb = File.join(Rails.root, 'db', 'schema.rb')
-
         EZ::DomainModeler.generate_models_yml unless File.exist?(models_yml)
 
-        if !File.exist?(schema_rb) || (File.mtime(schema_rb) < File.mtime(models_yml))
+        if should_migrate?(models_yml)
           old_level = ActiveRecord::Base.logger.level
 
           ActiveRecord::Base.logger.level = Logger::WARN
@@ -37,7 +43,7 @@ module EZ
           dump_schema if (Rails.env.development? || Rails.env.test?)
 
           ActiveRecord::Base.logger.level = old_level
-          EZ::RailsUpdater.update!
+          EZ::RailsUpdater.update! if Rails.env.development?
         end
       rescue => e
         puts "Exception: #{e}"
@@ -65,6 +71,8 @@ module EZ
     end
 
     def self.generate_models_yml
+      return unless Rails.env.development?
+
       filename = Rails.root + "db/models.yml"
       unless File.exist?(filename)
         File.open(filename, "w") do |f|

data/lib/ez/rails_updater.rb

@@ -8,6 +8,8 @@ module EZ
     VIEWS = %w(index show destroy new create edit update)
 
     def self.update!
+      return unless Rails.env.development?
+
       EZ::DomainModeler.tables.each do |table|
         create_controller(table) if EZ::Config.controllers?
         create_view_folder(table) if EZ::Config.views?
@@ -16,6 +18,8 @@ module EZ
     end
 
     def self.create_routes(table)
+      return unless Rails.env.development?
+
       filename = File.join(Rails.root, 'config', 'routes.rb')
       line = "  resources :#{table}"
       routes = File.read(filename)
@@ -28,6 +32,8 @@ module EZ
     end
 
     def self.create_controller(controller)
+      return unless Rails.env.development?
+
       filename = File.join(Rails.root, 'app', 'controllers', "#{controller}_controller.rb")
       if !File.exist?(filename)
         File.open(filename, "w:utf-8") do |file|
@@ -45,6 +51,8 @@ module EZ
     end
 
     def self.create_view_folder(folder)
+      return unless Rails.env.development?
+      
       full_path = File.join(Rails.root, 'app', 'views', folder)
       FileUtils.mkdir_p(full_path)
       VIEWS.each do |view|

data/lib/ez/schema_modifier.rb

@@ -137,6 +137,7 @@ module EZ
 
     def remove_dead_schema
       return unless Rails.env.development? || Rails.env.test?
+      return if Dir[File.join(Rails.root, 'db/migrate/*.rb')].entries.any?
 
       remove_dead_tables
       remove_dead_columns

data/lib/ez/version.rb

@@ -1,3 +1,3 @@
 module EZ
-  VERSION = "1.9.3"
+  VERSION = "1.9.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ez
 version: !ruby/object:Gem::Version
-  version: 1.9.3
+  version: 1.9.4
 platform: ruby
 authors:
 - Jeff Cohen