eyes_selenium 3.12.0 → 3.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1eddd248aaa225506bab9d893b31a5d60b672d1e
-  data.tar.gz: 5e1db39922d01f6a2d1240631c7c8c6b8a2777c2
+  metadata.gz: 3080f6742b4c5a4de35177b9b088d00be1655151
+  data.tar.gz: dc5665a10bb941c5c5c1c10e1053fdc8820c1e11
 SHA512:
-  metadata.gz: bb020ee6d60bc119e4762dec14ee5c370dc1101f4788c65f379d112a44dff544a04a744047278494a51a723fd964b9526fda0ca3b376df8e07b2a38b575065b4
-  data.tar.gz: 494d2cabeebaedf23f3e87a681da7bae543735abbee395e7417288f27aa80e87eafa1a7dc509e894f67a2b10fb25805f073162a6c71f63d8d18dfd541af314df
+  metadata.gz: 57f567158fe47899a4922ed6a82cdb855a96024a572d3f6843f54a3c082132738a6f1ece558a070d5a4a8f79356aba30772b2a98255a46054d7dca6056dfec10
+  data.tar.gz: 3b4be764619aabb6786775cae83a31361a65dfa9fde4cacf9c7151c80c70f371ffea7e0319ee2f2c7bd53793639d0110ece9569ae4e222c1b2c017fe12fb06db

data/lib/applitools/selenium/eyes.rb

@@ -11,6 +11,8 @@ module Applitools::Selenium
 
     USE_DEFAULT_MATCH_TIMEOUT = -1
 
+    DEFAULT_STITCHING_OVERLAP = 50 # Pixels
+
     extend Forwardable
     # @!visibility public
 
@@ -75,7 +77,7 @@ module Applitools::Selenium
 
     attr_accessor :base_agent_id, :screenshot, :force_full_page_screenshot, :hide_scrollbars,
       :wait_before_screenshots, :debug_screenshot, :stitch_mode, :disable_horizontal_scrolling,
-      :disable_vertical_scrolling, :explicit_entire_size, :debug_screenshot_provider
+      :disable_vertical_scrolling, :explicit_entire_size, :debug_screenshot_provider, :stitching_overlap
     attr_reader :driver
 
     def_delegators 'Applitools::EyesLogger', :logger, :log_handler, :log_handler=
@@ -104,6 +106,7 @@ module Applitools::Selenium
       self.disable_vertical_scrolling = false
       self.explicit_entire_size = nil
       self.force_driver_resolution_as_viewport_size = false
+      self.stitching_overlap = DEFAULT_STITCHING_OVERLAP
     end
 
     # Starts a test
@@ -120,10 +123,10 @@ module Applitools::Selenium
     # @return [Applitools::Selenium::Driver] A wrapped web driver which enables Eyes
     #   trigger recording and frame handling
     def open(options = {})
-      driver = options.delete(:driver)
+      original_driver = options.delete(:driver)
       options[:viewport_size] = Applitools::RectangleSize.from_any_argument options[:viewport_size] if
           options[:viewport_size]
-      Applitools::ArgumentGuard.not_nil driver, 'options[:driver]'
+      Applitools::ArgumentGuard.not_nil original_driver, 'options[:driver]'
       Applitools::ArgumentGuard.hash options, 'open(options)', [:app_name, :test_name]
 
       if disabled?
@@ -131,8 +134,8 @@ module Applitools::Selenium
         return driver
       end
 
-      @driver = self.class.eyes_driver(driver, self)
-      perform_driver_specific_settings(driver)
+      @driver = self.class.eyes_driver(original_driver, self)
+      perform_driver_specific_settings(original_driver)
 
       self.device_pixel_ratio = UNKNOWN_DEVICE_PIXEL_RATIO
       self.position_provider = self.class.position_provider(
@@ -152,10 +155,10 @@ module Applitools::Selenium
       @driver
     end
 
-    def perform_driver_specific_settings(driver)
-      modifier = driver.class.to_s.downcase.gsub(/::/, '_')
+    def perform_driver_specific_settings(original_driver)
+      modifier = original_driver.class.to_s.downcase.gsub(/::/, '_')
       method_name = "perform_driver_settings_for_#{modifier}"
-      send(method_name) if respond_to? method_name
+      send(method_name) if respond_to?(method_name, :include_private)
     end
 
     def perform_driver_settings_for_appium_driver
@@ -163,6 +166,9 @@ module Applitools::Selenium
       self.force_driver_resolution_as_viewport_size = true
     end
 
+    private :perform_driver_settings_for_appium_driver
+    private :perform_driver_specific_settings
+
     # Sets the stitch mode.
     #
     # @param [Hash] value The desired type of stitching (:SCROLL is default).
@@ -538,7 +544,8 @@ module Applitools::Selenium
             scale_provider: scale_provider,
             cut_provider: cut_provider,
             wait_before_screenshots: wait_before_screenshots,
-            eyes_screenshot_factory: eyes_screenshot_factory
+            eyes_screenshot_factory: eyes_screenshot_factory,
+            stitching_overlap: stitching_overlap
           )
 
           logger.info 'Building screenshot object...'
@@ -570,7 +577,8 @@ module Applitools::Selenium
                                   scale_provider: scale_provider,
                                   cut_provider: cut_provider,
                                   wait_before_screenshots: wait_before_screenshots,
-                                  eyes_screenshot_factory: eyes_screenshot_factory
+                                  eyes_screenshot_factory: eyes_screenshot_factory,
+                                  stitching_overlap: stitching_overlap
 
           unless driver.frame_chain.empty?
             logger.info 'Switching back to original frame...'

data/lib/applitools/selenium/full_page_capture_algorithm.rb

@@ -36,6 +36,7 @@ module Applitools::Selenium
       cut_provider = options[:cut_provider]
       wait_before_screenshot = options[:wait_before_screenshots]
       eyes_screenshot_factory = options[:eyes_screenshot_factory]
+      stitching_overlap = options[:stitching_overlap] || MAX_SCROLL_BAR_SIZE
 
       logger.info "Region to check: #{region_provider.region}"
       logger.info "Coordinates type: #{region_provider.coordinate_type}"
@@ -100,7 +101,7 @@ module Applitools::Selenium
       end
 
       part_image_size = Applitools::RectangleSize.new image.width,
-        [image.height - MAX_SCROLL_BAR_SIZE, MIN_SCREENSHOT_PART_HEIGHT].max
+        [image.height - stitching_overlap, MIN_SCREENSHOT_PART_HEIGHT].max
 
       logger.info "Total size: #{entire_size}, image_part_size: #{part_image_size}"
 

data/lib/applitools/version.rb

@@ -1,3 +1,3 @@
 module Applitools
-  VERSION = '3.12.0'.freeze
+  VERSION = '3.13.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eyes_selenium
 version: !ruby/object:Gem::Version
-  version: 3.12.0
+  version: 3.13.0
 platform: ruby
 authors:
 - Applitools Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-13 00:00:00.000000000 Z
+date: 2017-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eyes_core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.12.0
+        version: 3.13.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.12.0
+        version: 3.13.0
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement