eyes_selenium 1.6.0 → 1.7.0

data/README.md

@@ -66,7 +66,7 @@ describe 'Applitools', :type=>:feature, :js=>true do
       # Visual validation point #2
       eyes.check_window('Features Page')
 
-      eyes.close()
+      eyes.close
     end
   end
 end

data/lib/eyes_selenium/eyes/driver.rb

@@ -25,12 +25,11 @@ class  Applitools::Driver
     browser_obj = options.delete(:browser) || DEFAULT_DRIVER 
     @browser ||= case browser_obj
                  when Symbol
+                   at_exit { quit rescue nil }
                    Selenium::WebDriver.for browser_obj
                  else
                    browser_obj
                  end
-    # TODO Remove this if all is good. We don't want to call 'quit' everytime the object is destroyed, we might still want to use the underlying driver
-    #at_exit { quit rescue nil }
 
     @user_inputs = []
     @remote_server_url = address_of_remote_server

data/lib/eyes_selenium/eyes/eyes.rb

@@ -4,6 +4,10 @@ class Applitools::Eyes
 
   class << self
     attr_accessor :config
+
+    def log_handler=(handler)
+      EyesLogger.log_handler = handler
+    end
   end
 
   @config = {
@@ -26,7 +30,6 @@ class Applitools::Eyes
 
     @disabled = params[:disabled]
 
-    @driver = create_driver(params)
     return if disabled?
 
     @agent_connector = Applitools::AgentConnector.new(config[:server_url], config[:user], config[:apikey])
@@ -39,6 +42,7 @@ class Applitools::Eyes
   end
 
   def open(params={})
+    @driver = create_driver(params)
     return driver if disabled?
 
     if open?
@@ -73,7 +77,7 @@ class Applitools::Eyes
     if !as_expected
       self.should_match_window_run_once_on_timeout = true
       if !session.new_session?
-        #EyesLogger.info %( "mismatch! #{ tag ? "" : "(#{tag})" } )
+        EyesLogger.info %( "mismatch #{ tag ? "" : "(#{tag})" } )
         if failure_reports.to_i == Applitools::FailureReports::IMMEDIATE
           raise Applitools::TestFailedError.new("Mismatch found in '#{start_info.scenario_id_or_name}'"\
                                                 " of '#{start_info.app_id_or_name}'")
@@ -125,7 +129,6 @@ class Applitools::Eyes
     rescue Applitools::EyesError
     ensure 
       abort_if_not_closed
-      driver.quit
     end
   end
 

data/lib/eyes_selenium/eyes_logger.rb

@@ -1,18 +1,35 @@
 require 'logger'
 
 module EyesLogger
-  def self.logger(to=STDOUT, level=Logger::INFO)
-    return @@log if defined?(@@log)
-    @@log = Logger.new(to)
-    @@log.level = level
-    @@log
+
+  class NullLogger
+    attr_accessor :level
+
+    def info(msg)
+      # do nothing
+    end
+    def debug(msg)
+      #do nothing
+    end 
+  end
+
+  NULL_LOGGER = NullLogger.new
+
+  @@log_handler = NULL_LOGGER
+
+  def self.log_handler=(log_handler)
+    if !log_handler.respond_to?(:info) || !log_handler.respond_to?(:debug)
+      raise Applitools::EyesError.new('log handler must respond to "info" and "debug"!')
+    end
+    @@log_handler = log_handler
   end
 
   def self.info(msg)
-    logger.info(msg)
+    @@log_handler.info(msg)
   end
 
   def self.debug(msg)
-    logger.debug(msg)
+    @@log_handler.debug(msg)
   end
+
 end

data/lib/eyes_selenium/version.rb

@@ -1,3 +1,3 @@
 module Applitools
-  VERSION = "1.6.0"
+  VERSION = "1.7.0"
 end

data/spec/spec_helper.rb

@@ -21,7 +21,7 @@ end
 def init_eyes
   before(:all) do
     Applitools::Eyes.config[:apikey] = 'YOUR_API_KEY'
-    Applitools::Eyes.config[:server_url] = 'http://eyesbeta.cloudapp.net:8080'
+    Applitools::Eyes.config[:server_url] = 'http://eyes.applitools.com'
   end
   let!(:eyes) do
     Applitools::Eyes.new

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eyes_selenium
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-02 00:00:00.000000000 Z
+date: 2013-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
@@ -202,7 +202,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2417852359237807309
+      hash: -1833114255921189206
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -211,7 +211,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2417852359237807309
+      hash: -1833114255921189206
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25