eyes_core 4.0.4 → 4.0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 75034b315f72b3618b3dbf11275415ad4d6b6198
-  data.tar.gz: 141e9a4bda412f6744dfe27a18dd4724c80f07bf
+SHA256:
+  metadata.gz: 0b736b5fc20ded53589a45b2bdcbf90c1dd0a83726ea3e110fb598ec420b8ff2
+  data.tar.gz: 49b2a7d21f04d50104053dd541f5fc48d775cfc180eee0a12fc69f9af7b106c4
 SHA512:
-  metadata.gz: 83ac3e51133c6157ec47cffeba360aa78939a05d6e95afdb82b61e86e21051ac330ecd9aee8de40c1c2cdb69418c4e78388e8052e769fcacdf42bfd0420664ec
-  data.tar.gz: 45035b9600c21207ccc79649949968275d28ae1eddf523c97774a18eb5770eb024c6eea92314270b1bb667af12792dd49779ba26113ac020181b247331246e2e
+  metadata.gz: 0fce3e0e9b5f6592b8fc4bf6fad2296009a3437a1746ea867d64593a6beaef8894080bd1ea8530525bc8b6fc59afcdff10d2c8ffe28f7f79cd6a5b913c948bb1
+  data.tar.gz: ca19317f33509bfff0da465cd6533288a4b12178f707b561cf1d2488643ba2cf3f10492c0de7edece239fc68d6b5a9a4b1afe066bc7563ce3ec040829f3e7119

data/lib/applitools/core/batch_info.rb

@@ -35,7 +35,9 @@ module Applitools
         self.id = PROCESS_DEFAULT_BATCH_ID
       end
       self.properties = properties if properties
-      self.notify_on_completion = 'true'.casecmp(env_notify_on_completion || '') == 0 ? true : false
+      unless env_notify_on_completion.nil?
+        self.notify_on_completion = 'true'.casecmp(env_notify_on_completion || '') == 0 ? true : false
+      end
     end
 
     def json_data

data/lib/applitools/core/classic_runner.rb

@@ -29,7 +29,7 @@ module Applitools
       ensure
         delete_all_batches
       end
-      return all_test_results unless all_test_results.empty?
+      # return all_test_results unless all_test_results.empty?
       all_universal_results = close_all_eyes
       test_result_summary = Applitools::TestResultSummary.new(all_universal_results).old_style_results_array
       return [] if test_result_summary.reject { |tr| tr.aborted? }.empty?

data/lib/applitools/core/eyes_runner.rb

@@ -27,5 +27,23 @@ module Applitools
     def close_all_eyes
       get_universal_eyes_manager.close_all_eyes
     end
+
+    # def close_batch(batch_id)
+    #   if 'true'.casecmp(ENV['APPLITOOLS_DONT_CLOSE_BATCHES'] || '') == 0
+    #     return Applitools::EyesLogger.info(
+    #       'APPLITOOLS_DONT_CLOSE_BATCHES environment variable set to true. Doing nothing.'
+    #     ) && false
+    #   end
+    #   Applitools::ArgumentGuard.not_nil(batch_id, 'batch_id')
+    #   Applitools::EyesLogger.info("Close batch called with #{batch_id}")
+    #
+    #   close_batches_result = universal_client.core_close_batches(batch_id)
+    #   if close_batches_result.is_a?(Hash) && close_batches_result[:message] && close_batches_result[:stack]
+    #     Applitools::EyesLogger.logger.debug "Eyes close Batch: #{close_batches_result[:message]}"
+    #     Applitools::EyesLogger.logger.debug "Stack for #{Applitools::Connectivity::UniversalClient::CORE_CLOSE_BATCHES} : #{close_batches_result[:stack]}"
+    #   else
+    #     Applitools::EyesLogger.info "delete batch is done with #{close_batches_result}"
+    #   end
+    # end
   end
 end

data/lib/applitools/universal_sdk/universal_client.rb

@@ -93,8 +93,15 @@ module Applitools::Connectivity
       await(->(cb) { @socket.request(CORE_SET_VIEWPORT_SIZE, {driver: driver, size: size}, cb) })
     end
 
-    def core_close_batches(close_batch_settings)
+    def core_close_batches(close_batch_settings=nil)
       # batchIds, serverUrl?, apiKey?, proxy?
+      unless close_batch_settings.is_a?(Hash)
+        batch_ids = [@open_config[:batch][:id]]
+        batch_ids = [close_batch_settings] if close_batch_settings.is_a?(String)
+        batch_ids = close_batch_settings if close_batch_settings.is_a?(Array)
+        optional = [:serverUrl, :apiKey, :proxy].map {|k| [k, @open_config[k]] }.to_h
+        close_batch_settings = { settings: ({ batchIds: batch_ids }.merge(optional).compact) }
+      end
       await(->(cb) { @socket.request(CORE_CLOSE_BATCHES, close_batch_settings, cb) })
     end
 

data/lib/applitools/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: false
 
 module Applitools
-  VERSION = '4.0.4'.freeze
-  UNIVERSAL_VERSION = '2.5.7'.freeze
+  VERSION = '4.0.5.2'.freeze
+  UNIVERSAL_VERSION = '2.5.17'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eyes_core
 version: !ruby/object:Gem::Version
-  version: 4.0.4
+  version: 4.0.5.2
 platform: ruby
 authors:
 - Applitools Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-13 00:00:00.000000000 Z
+date: 2022-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.7
+        version: 2.5.17
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.7
+        version: 2.5.17
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -424,8 +424,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.3
+rubygems_version: 3.3.14
 signing_key: 
 specification_version: 4
 summary: Core of the Applitools Ruby SDK