eye-patch 0.5.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 55fcb9ea9eeb35bdedf9cf01f89e807e8c11ecf5
-  data.tar.gz: 451a2aa76f4804825671d64d5b7b9094afb16df2
+  metadata.gz: f040c35d2b8df2e0be5a9c2cdaf839187a438882
+  data.tar.gz: b8966ebf6aff7d2a03f6d34a790010864b6c9491
 SHA512:
-  metadata.gz: 1a832b7eebe66cd52c2b581a25669668c46738646f9878ec90f03389698625cfc504969b8df5cccbf5e0d6232339d7d3fff4c524783b016ff04c36567da02c51
-  data.tar.gz: ba9036e27f9b35a5ab47ad9d382e841ec39a55f9923abf6492434bb29b140237964dada6c11939a2311efc23b6131d53b37cded1727cd0a6e5e1717d7d6f24fc
+  metadata.gz: 833f95e305b8af149028dab3356565e7c302358f6d8d8eab4ef5439786529d3e0de915e5f5da8a9b235c1f45e8b994fa67aaf0104930b8361c03f7de33083474
+  data.tar.gz: 7177aeee067ff241387f13f8dedb3d150b1cced75cf1089171fea952ac68e9edf7a1fd370b352b88f0b90caa701dc1676f51be476bc7000a3d2db279e6e41699

data/.hound.yml

@@ -0,0 +1,2 @@
+rubocop:
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -0,0 +1,46 @@
+AllCops:
+  TargetRubyVersion: 2.4.2
+
+inherit_from: .rubocop_todo.yml
+
+Layout/EmptyLinesAroundClassBody:
+  EnforcedStyle: empty_lines
+
+Layout/EmptyLinesAroundModuleBody:
+  EnforcedStyle: empty_lines
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+Metrics/BlockLength:
+  Exclude:
+    - lib/eye/patch/capistrano.rb
+    - lib/eye/patch/capistrano3.rb
+    - lib/eye/patch/overrides.rb
+    - test/**/*.rb
+
+Metrics/CyclomaticComplexity:
+  Exclude:
+    - lib/eye/patch/overrides.rb
+
+Metrics/PerceivedComplexity:
+  Exclude:
+    - lib/eye/patch/overrides.rb
+
+Style/Documentation:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma

data/.rubocop_todo.yml

@@ -0,0 +1,22 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-04-04 14:04:52 -0600 using RuboCop version 0.54.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 5
+Metrics/AbcSize:
+  Max: 40
+
+# Offense count: 7
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 25
+
+# Offense count: 32
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 183

data/Gemfile

@@ -1,4 +1,6 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
+
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in eye-patch.gemspec
 gemspec

data/Rakefile

@@ -1,4 +1,6 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rake/testtask"
 

data/bin/eye-patch

@@ -1,6 +1,7 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-$:.unshift File.expand_path(File.join(File.dirname(__FILE__), %w[.. lib]))
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), %w[.. lib]))
 require "eye/patch"
 
 Eye::Cli.start

data/bin/eye-patch-loader

@@ -1,33 +1,34 @@
 #!/usr/bin/env ruby
-$:.unshift File.expand_path(File.join(File.dirname(__FILE__), %w[.. lib]))
+# frozen_string_literal: true
+
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), %w[.. lib]))
 require "eye/loader"
 require "optparse"
 require "eye/patch"
 
-options = {:debug => false}
+options = { debug: false }
 
 OptionParser.new do |opts|
-  opts.on( '-h', '--help', 'Display this screen' ) do
+  opts.on("-h", "--help", "Display this screen") do
     puts opts
     exit
   end
 
-  opts.on( '-c', '--config CONFIG', 'load with config' ) do |config_path|
+  opts.on("-c", "--config CONFIG", "load with config") do |config_path|
     options[:config] = config_path
   end
 
-  opts.on( '-s', '--socket SOCKET', 'start listen on socket' ) do |socket_path|
+  opts.on("-s", "--socket SOCKET", "start listen on socket") do |socket_path|
     options[:socket_path] = socket_path
   end
 
-  opts.on( '-l', '--logger LOGGER', 'custom logger' ) do |logger|
+  opts.on("-l", "--logger LOGGER", "custom logger") do |logger|
     options[:logger] = logger
   end
 
-  opts.on( '-d', '--debug', 'debug info to logger' ) do
+  opts.on("-d", "--debug", "debug info to logger") do
     options[:debug] = true
   end
-
 end.parse!
 
 Eye::Local.ensure_eye_dir
@@ -42,7 +43,7 @@ config = options[:config]
 config = File.expand_path(config) if config && !config.empty?
 
 if config
-  res = server.command('load', config)
+  res = server.command("load", config)
   exit if res.values.any? { |r| r[:error] }
 end
 
@@ -50,8 +51,8 @@ Eye::Control.set_proc_line
 
 server.async.run
 
-trap("INT"){ exit }
-trap("USR1"){ Eye::Logger.reopen }
-trap("USR2"){ GC.start }
+trap("INT") { exit }
+trap("USR1") { Eye::Logger.reopen }
+trap("USR2") { GC.start }
 
 sleep

data/eye-patch.gemspec

@@ -1,5 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "eye/patch/version"
 
@@ -9,23 +10,26 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Andrew Horner"]
   spec.email         = ["andrew@tablexi.com"]
   spec.description   = "Easily load your eye configuration from a YAML file."
-  spec.summary       = %q[
+  spec.summary       = "
     Eye::Patch abstracts out the Eye DSL to allow you to load your configuration
     from a structured YAML file, rather than relying on Eye's built-in DSL.
-  ]
+  "
   spec.homepage      = "https://github.com/tablexi/eye-patch"
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^test/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "eye", ">= 0.6.2"
+  spec.required_ruby_version = ">= 2.4.2"
+
   spec.add_dependency "chronic_duration"
+  spec.add_dependency "eye", ">= 0.6.2"
 
   spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "mocha"
   spec.add_development_dependency "minitest"
+  spec.add_development_dependency "mocha"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rubocop"
 end

data/lib/eye/notify/awssdk.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "aws-sdk-core"
 
 begin
@@ -10,8 +11,11 @@ rescue LoadError
 end
 
 module Eye
+
   class Notify
+
     class AWSSDK < Eye::Notify
+
       param :region, String
       param :access_key_id, String
       param :secret_access_key, String
@@ -20,33 +24,35 @@ module Eye
       def execute
         options = { region: "us-east-1" } # default to us-east-1
         options[:region] = region if region
-        if access_key_id && secret_access_key
-          options[:credentials] = Aws::Credentials.new(access_key_id, secret_access_key)
-        end
+        options[:credentials] = Aws::Credentials.new(access_key_id, secret_access_key) if access_key_id && secret_access_key
         client = Aws::SES::Client.new(options)
         client.send_email(message)
       end
 
       def message
-        { source: from,
+        {
+          source: from,
           destination: {
-            to_addresses: [contact]
+            to_addresses: [contact],
           },
           message: {
             subject: {
-              data: message_subject
+              data: message_subject,
             },
             body: {
               text: {
-                data: message_body
+                data: message_body,
               },
               html: {
-                data: message_body
-              }
-            }
-          }
+                data: message_body,
+              },
+            },
+          },
         }
       end
+
     end
+
   end
+
 end

data/lib/eye/notify/datadog.rb

@@ -3,8 +3,11 @@
 require "dogapi"
 
 module Eye
+
   class Notify
+
     class DataDog < Eye::Notify
+
       param :aggregation_key, String
       param :alert_type, String
       param :api_key, String, true
@@ -16,7 +19,7 @@ module Eye
           alert_type: "error",
           aggregation_key: msg_host + msg_full_name,
           source_type: "None",
-          tags: ["eye"]
+          tags: ["eye"],
         }
 
         options[:alert_type] = alert_type if alert_type
@@ -24,20 +27,21 @@ module Eye
         options[:source_type] = source_type if source_type
         options[:tags] = tags if tags
 
-        dog = Dogapi::Client.new(api_key)
-
-        dog.emit_event(
-          Dogapi::Event.new(
-            message_body,
-            aggregation_key: options[:aggregation_key],
-            alert_type: options[:alert_type],
-            msg_title: message_subject,
-            host: msg_host,
-            source_type: options[:source_type],
-            tags: options[:tags]
-          )
+        event = Dogapi::Event.new(
+          message_body,
+          aggregation_key: options[:aggregation_key],
+          alert_type: options[:alert_type],
+          msg_title: message_subject,
+          host: msg_host,
+          source_type: options[:source_type],
+          tags: options[:tags],
         )
+
+        Dogapi::Client.new(api_key).emit_event(event)
       end
+
     end
+
   end
+
 end

data/lib/eye/notify/ses.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "aws/ses"
 
 class Eye::Notify::SES < Eye::Notify
@@ -9,14 +10,18 @@ class Eye::Notify::SES < Eye::Notify
 
   def execute
     AWS::SES::Base.new(
-      access_key_id:     access_key_id,
-      secret_access_key: secret_access_key ).send_email(message)
+      access_key_id: access_key_id,
+      secret_access_key: secret_access_key,
+    ).send_email(message)
   end
 
   def message
-    { to: contact,
+    {
+      to: contact,
       from: from,
       subject: message_subject,
-      text_body: message_body }
+      text_body: message_body,
+    }
   end
+
 end

data/lib/eye/patch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "eye"
 require "eye/patch/overrides"
 
@@ -6,11 +8,15 @@ Eye::Notify::TYPES[:aws_sdk] = "AWSSDK"
 Eye::Notify::TYPES[:datadog] = "DataDog"
 
 module Eye
+
   class Notify
+
     autoload :SES, "eye/notify/ses"
     autoload :AWSSDK, "eye/notify/awssdk"
     autoload :DataDog, "eye/notify/datadog"
+
   end
+
 end
 
 module Eye::Patch
@@ -25,7 +31,8 @@ module Eye::Patch
 
     config = ::Eye::Config.new(
       Config.new(settings),
-      Application.new(settings))
+      Application.new(settings),
+    )
     config.validate!
 
     config.applications.values.each do |application|
@@ -35,4 +42,5 @@ module Eye::Patch
 
     config
   end
+
 end

data/lib/eye/patch/application.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "group_set"
 require_relative "option_set"
 
@@ -25,7 +27,8 @@ module Eye::Patch
         name: @settings[:name],
         notify: notifications,
         triggers: triggers,
-        checks: checks )
+        checks: checks,
+      )
     end
 
     def parse_processes
@@ -45,5 +48,7 @@ module Eye::Patch
     def checks
       OptionSet.new(Eye::Checker, @settings[:checks])
     end
+
   end
+
 end

data/lib/eye/patch/capistrano.rb

@@ -1,5 +1,6 @@
-Capistrano::Configuration.instance.load do
+# frozen_string_literal: true
 
+Capistrano::Configuration.instance.load do
   _cset(:eye_default_hooks) { true }
   _cset(:eye_config) { "config/eye.yml" }
   _cset(:eye_bin) { "bundle exec eye-patch" }
@@ -12,7 +13,6 @@ Capistrano::Configuration.instance.load do
   end
 
   namespace :eye do
-
     desc "Start eye with the desired configuration file"
     task :load_config, roles: -> { fetch(:eye_roles) } do
       run "cd #{current_path} && #{fetch(:eye_bin)} quit"

data/lib/eye/patch/capistrano3.rb

@@ -1,5 +1,6 @@
-namespace :load do
+# frozen_string_literal: true
 
+namespace :load do
   task :defaults do
     set :eye_config, -> { "config/eye.yml" }
     set :eye_bin, -> { "eye-patch" }
@@ -13,7 +14,6 @@ namespace :load do
 end
 
 namespace :eye do
-
   desc "Start eye with the desired configuration file"
   task :load_config do
     on roles(fetch(:eye_roles)) do

data/lib/eye/patch/config.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 class Eye::Patch::Config < Hash
 
   def initialize(settings)
     super()
-    self.merge!(parse(settings))
+    merge!(parse(settings))
   end
 
   private
@@ -29,7 +31,9 @@ class Eye::Patch::Config < Hash
         name: notify[:name].to_s,
         type: notify[:type].to_sym,
         contact: notify[:contact].to_s,
-        opts: {} }
+        opts: {},
+      }
     end
   end
+
 end

data/lib/eye/patch/group_set.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "process_set"
 
 module Eye::Patch
@@ -7,7 +9,7 @@ module Eye::Patch
     def initialize(application, processes)
       @application = application
 
-      Array(processes).group_by{ |item| item[:group] }.each do |group_name, items|
+      Array(processes).group_by { |item| item[:group] }.each do |group_name, items|
         name = group_name || "__default__"
         parse_group(name, items)
       end
@@ -18,9 +20,12 @@ module Eye::Patch
     def parse_group(name, processes)
       self[name] = @application.merge(
         name: name,
-        application: @application[:name])
+        application: @application[:name],
+      )
 
       self[name][:processes] = ProcessSet.new(self[name], processes)
     end
+
   end
+
 end

data/lib/eye/patch/option_set.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 module Eye::Patch
+
   class OptionSet < Hash
 
     def initialize(option_class, options)
@@ -7,5 +10,7 @@ module Eye::Patch
         self[option_data[:name]] = option[:config].merge(type: option_data[:type])
       end
     end
+
   end
+
 end

data/lib/eye/patch/overrides.rb

@@ -1,62 +1,61 @@
+# frozen_string_literal: true
+
 Eye::Cli.class_eval do
   private
 
   def loader_path
     filename = File.expand_path(File.join(File.dirname(__FILE__), %w[.. .. .. bin eye-patch-loader]))
-    File.exists?(filename) ? filename : nil
+    File.exist?(filename) ? filename : nil
   end
 end
 
 require "eye/utils/mini_active_support"
 Eye::Process.class_eval do
-
   def daemonize_process
-    time_before = Time.now
     res = Eye::System.daemonize(self[:start_command], config)
-    start_time = Time.now - time_before
 
     info "daemonizing: `#{self[:start_command]}` with start_grace: #{self[:start_grace].to_f}s, env: #{self[:environment].inspect}, working_dir: #{self[:working_dir]}, <#{res[:pid]}>"
 
     if res[:error]
-
-      if res[:error].message == 'Permission denied - open'
+      if res[:error].message == "Permission denied - open"
         error "daemonize failed with #{res[:error].inspect}; make sure #{[self[:stdout], self[:stderr]]} are writable"
       else
         error "daemonize failed with #{res[:error].inspect}"
       end
 
-      return {:error => res[:error].inspect}
+      return { error: res[:error].inspect }
     end
 
     self.pid = res[:pid]
 
-    unless self.pid
-      error 'no pid was returned'
-      return {:error => :empty_pid}
+    unless pid
+      error "no pid was returned"
+      return { error: :empty_pid }
     end
 
     sleep_grace(:start_grace)
 
     unless process_really_running?
-      error "process <#{self.pid}> not found, it may have crashed (#{check_logs_str})"
-      return {:error => :not_really_running}
+      error "process <#{pid}> not found, it may have crashed (#{check_logs_str})"
+      return { error: :not_really_running }
     end
 
     if !self[:smart_pid] && !failsafe_save_pid
-      error "expected to manage pidfile for process <#{self.pid}>; pidfile is unwritable"
-      return {:error => :cant_write_pid}
+      error "expected to manage pidfile for process <#{pid}>; pidfile is unwritable"
+      return { error: :cant_write_pid }
     end
 
     res
   end
 
   def control_pid?
-    !!self[:daemonize] && !self[:smart_pid]
+    !!self[:daemonize] && !self[:smart_pid] # rubocop:disable Style/DoubleNegation
   end
 end
 
 Eye::System.class_eval do
   class << self
+
     alias_method :daemonize_without_hook, :daemonize
     alias_method :exec_without_hook, :exec
 
@@ -75,11 +74,12 @@ Eye::System.class_eval do
     def spawn_options(config = {})
       options = {
         pgroup: true,
-        chdir: config[:working_dir] || '/',
-        close_others: !config[:preserve_fds] }
+        chdir: config[:working_dir] || "/",
+        close_others: !config[:preserve_fds],
+      }
 
-      options[:out]   = [config[:stdout], 'a'] if config[:stdout]
-      options[:err]   = [config[:stderr], 'a'] if config[:stderr]
+      options[:out]   = [config[:stdout], "a"] if config[:stdout]
+      options[:err]   = [config[:stderr], "a"] if config[:stderr]
       options[:in]    = config[:stdin] if config[:stdin]
       options[:umask] = config[:umask] if config[:umask]
 
@@ -90,17 +90,17 @@ Eye::System.class_eval do
 
       options
     end
+
   end
 end
 
 Eye::Controller.class_eval do
-
   def invoke_spawn_callback
     debug "Attempting before_spawn hook"
-    if respond_to?(:before_spawn)
-      debug "Invoking before_spawn hook"
-      before_spawn
-    end
+    return unless respond_to?(:before_spawn)
+
+    debug "Invoking before_spawn hook"
+    before_spawn
   end
 
   private

data/lib/eye/patch/process_set.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Eye::Patch
 
   class ProcessSet < Hash
@@ -19,7 +21,8 @@ module Eye::Patch
         parse_single_process(
           process[:name],
           process[:config],
-          process_monitors(process))
+          process_monitors(process),
+        )
       end
     end
 
@@ -29,7 +32,8 @@ module Eye::Patch
         parse_single_process(
           name,
           indexed_config(process[:config], index),
-          process_monitors(process))
+          process_monitors(process),
+        )
       end
     end
 
@@ -47,7 +51,8 @@ module Eye::Patch
 
       monitor_options = OptionSet.new(
         Eye::Checker,
-        config[:monitor_children][:checks])
+        config[:monitor_children][:checks],
+      )
 
       self[name][:monitor_children][:checks] = monitor_options
     end
@@ -59,8 +64,12 @@ module Eye::Patch
     end
 
     def process_monitors(config)
-      { triggers: OptionSet.new(Eye::Trigger, config[:triggers]),
-        checks: OptionSet.new(Eye::Checker, config[:checks]) }
+      {
+        triggers: OptionSet.new(Eye::Trigger, config[:triggers]),
+        checks: OptionSet.new(Eye::Checker, config[:checks]),
+      }
     end
+
   end
+
 end

data/lib/eye/patch/settings.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "erb"
 require "forwardable"
 require_relative "value_parser"
@@ -5,6 +7,7 @@ require_relative "value_parser"
 module Eye::Patch
 
   class Settings
+
     extend Forwardable
     def_delegators :parsed, :[], :fetch
 
@@ -13,9 +16,9 @@ module Eye::Patch
       erb = ERB.new(file.read)
       erb.filename = file.path
 
-      @settings = YAML.load(erb.result)
+      @settings = YAML.safe_load(erb.result)
     ensure
-      file.close unless file.nil?  
+      file&.close
     end
 
     private
@@ -38,5 +41,7 @@ module Eye::Patch
         item
       end
     end
+
   end
+
 end

data/lib/eye/patch/value_parser.rb

@@ -1,14 +1,17 @@
+# frozen_string_literal: true
+
 require "chronic_duration"
 
 module Eye::Patch
 
   class ValueParser
 
-    TIME_MATCHER = /\s(?<duration>(?:week|day|hour|minute|second)s?)(?:\s|\Z)/.freeze
-    SIZE_MATCHER = /\s(?<size>(?:tera|giga|mega|kilo)?bytes?)(?:\s|\Z)/.freeze
-    MATCHERS     = {
+    TIME_MATCHER = /\s(?<duration>(?:week|day|hour|minute|second)s?)(?:\s|\Z)/
+    SIZE_MATCHER = /\s(?<size>(?:tera|giga|mega|kilo)?bytes?)(?:\s|\Z)/
+    MATCHERS = {
       time: TIME_MATCHER,
-      size: SIZE_MATCHER }.freeze
+      size: SIZE_MATCHER,
+    }.freeze
 
     def self.parse(value)
       return value unless value.is_a?(String)
@@ -20,8 +23,6 @@ module Eye::Patch
       result || value
     end
 
-    private
-
     def self.parse_time(value)
       ChronicDuration.parse(value)
     end
@@ -30,5 +31,7 @@ module Eye::Patch
       unit = value.match(SIZE_MATCHER)[:size]
       value.gsub(/[^\d.]/, "").to_f.send(unit)
     end
+
   end
+
 end

data/lib/eye/patch/version.rb

@@ -1,5 +1,11 @@
+# frozen_string_literal: true
+
 module Eye
+
   module Patch
-    VERSION = "0.5.1"
+
+    VERSION = "1.0.0"
+
   end
+
 end

data/test/lib/eye/patch/settings_test.rb

@@ -1,8 +1,12 @@
+# frozen_string_literal: true
+
 require_relative "../../../test_helper"
 require "tempfile"
 
 module Eye
+
   module Patch
+
     describe Settings do
       it "evaluates the yaml as ERB" do
         file = Tempfile.new("yaml")
@@ -22,5 +26,7 @@ module Eye
         )
       end
     end
+
   end
+
 end

data/test/lib/eye/patch/value_parser_test.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require_relative "../../../test_helper"
 
 describe Eye::Patch::ValueParser do
-
   it "parses time values" do
     assert_equal 2.weeks, Eye::Patch::ValueParser.parse("2 weeks")
     assert_equal 1.5.hours, Eye::Patch::ValueParser.parse("1.5 hours")

data/test/lib/eye/patch/version_test.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require_relative "../../../test_helper"
 
 describe Eye::Patch do
-
   it "defines a version" do
     assert Eye::Patch::VERSION
   end

data/test/lib/eye/patch_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../../test_helper"
 
 describe Eye::Patch do
@@ -8,7 +10,7 @@ describe Eye::Patch do
   describe ".parse" do
     before do
       @fixture = File.expand_path(File.join(File.dirname(__FILE__), %w[.. .. fixtures test.yml]))
-      @original = YAML.load(File.open(@fixture))
+      @original = YAML.safe_load(File.open(@fixture))
       @parsed = Eye::Patch.parse(@fixture)
 
       @settings = @parsed.settings
@@ -37,7 +39,7 @@ describe Eye::Patch do
       trigger = @original["triggers"].first
       parsed_trigger = @application[:triggers][trigger["name"].to_sym]
 
-      %w(times within).each do |setting|
+      %w[times within].each do |setting|
         assert_equal Eye::Patch::ValueParser.parse(trigger["config"][setting]), parsed_trigger[setting.to_sym]
       end
     end
@@ -46,7 +48,7 @@ describe Eye::Patch do
       check = @original["checks"].first
       parsed_check = @application[:checks][check["name"].to_sym]
 
-      %w(times every below).each do |setting|
+      %w[times every below].each do |setting|
         assert_equal Eye::Patch::ValueParser.parse(check["config"][setting]), parsed_check[setting.to_sym]
       end
     end
@@ -66,9 +68,9 @@ describe Eye::Patch do
     end
 
     it "creates process clusters" do
-      process = @original["processes"].detect { |process| process["count"] }
+      process = @original["processes"].detect { |p| p["count"] }
       process["count"].times do |index|
-        name = "#{process["name"]}-#{index}"
+        name = "#{process['name']}-#{index}"
         parsed_process = @application[:groups][process["group"]][:processes][name]
 
         assert_equal process["group"], parsed_process[:group]
@@ -84,10 +86,11 @@ describe Eye::Patch do
       check = process_config["config"]["monitor_children"]["checks"].first
       parsed_check = process[:monitor_children][:checks][check["name"].to_sym]
 
-      %w(times every below).each do |setting|
+      %w[times every below].each do |setting|
         assert_equal(
           Eye::Patch::ValueParser.parse(check["config"][setting]),
-          parsed_check[setting.to_sym])
+          parsed_check[setting.to_sym],
+        )
       end
     end
 
@@ -97,7 +100,7 @@ describe Eye::Patch do
     end
 
     it "sets :stderr and :stdout options for each process from passed :stdall" do
-      process = @original["processes"].reject { |process| process["group"] }.first
+      process = @original["processes"].reject { |p| p["group"] }.first
       parsed_process = @application[:groups]["__default__"][:processes].values.first
 
       assert_equal process["config"]["stdall"], parsed_process[:stdout]
@@ -108,7 +111,7 @@ describe Eye::Patch do
   describe ".parse with per-process overrides" do
     before do
       @fixture = File.expand_path(File.join(File.dirname(__FILE__), %w[.. .. fixtures overrides.yml]))
-      @original = YAML.load(File.open(@fixture))
+      @original = YAML.safe_load(File.open(@fixture))
       @parsed = Eye::Patch.parse(@fixture)
 
       @settings = @parsed.settings
@@ -121,7 +124,7 @@ describe Eye::Patch do
       trigger = @original["processes"].detect { |p| p["name"] == process[:name] }["triggers"].first
       parsed_trigger = process[:triggers][trigger["name"].to_sym]
 
-      %w(times within).each do |setting|
+      %w[times within].each do |setting|
         assert_equal Eye::Patch::ValueParser.parse(trigger["config"][setting]), parsed_trigger[setting.to_sym]
       end
     end
@@ -131,7 +134,7 @@ describe Eye::Patch do
       check = @original["processes"].detect { |p| p["name"] == process[:name] }["checks"].first
       parsed_check = process[:checks][check["name"].to_sym]
 
-      %w(times every below).each do |setting|
+      %w[times every below].each do |setting|
         assert_equal Eye::Patch::ValueParser.parse(check["config"][setting]), parsed_check[setting.to_sym]
       end
     end

data/test/test_helper.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require "minitest/autorun"
 require "minitest/unit"
 require "mocha/mini_test"
 
-require File.expand_path("../../lib/eye/patch.rb", __FILE__)
+require File.expand_path("../lib/eye/patch.rb", __dir__)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: eye-patch
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Andrew Horner
@@ -11,33 +11,33 @@ cert_chain: []
 date: 2018-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: eye
+  name: chronic_duration
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: chronic_duration
+  name: eye
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -104,6 +118,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hound.yml"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -150,7 +167,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -158,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Eye::Patch abstracts out the Eye DSL to allow you to load your configuration