expressir 1.3.3-x86_64-linux-musl → 1.4.1-x86_64-linux-musl

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fdc4aff53d7a77746059e95286a5d81e6d5c5e6f1d15c93560fd7e5ccddf5c75
-  data.tar.gz: c0b50d97ff5610a5f50b87c092347f4fe8632fe5e226e449f1eb27618d61aa61
+  metadata.gz: ef40390e8b4dab30bc836664c83755698cbe99490e7fb70bf2145efd240517a9
+  data.tar.gz: 8dca4d394056a680e20391a63c339a14ae013509f1e44af988a3aa498d752ff6
 SHA512:
-  metadata.gz: 53db636c4336502dbb03aebaf74c5a9941e9cd6642aed9476d6cc06c6f001114d86ce08470a168692af7930f26191b09551eb9237afe41a6fa10e46f0a647119
-  data.tar.gz: 68999b9a8691fc6640a133cf844d7647cd254cd11ca208a666f678698ed992f10a6e0412911368a0f219a4ef33b13bc51378b36163a0e1790feb9ae53b643224
+  metadata.gz: fd64ed51cba5fbe241d99839fcfcada35a23ce69bfb79ec75657ed64daae8c0b03171a38414a8dbe43ac2941d578b1015e812b23f9364fc7a2216cc889c98e51
+  data.tar.gz: 9ad87b3a5adc08155b7452102e89a03d3cad390991f50d9cde0cad90d7563fa8425146a5855cf04f5fd57179f9381fb058ac478b4c543344dffa4be1ac28e7f1

data/README.adoc

@@ -38,13 +38,22 @@ instructions.
 
 [source, sh]
 ----
-./exe/expressir
+$ expressir
 
 Commands:
+  expressir format PATH     # pretty print EXPRESS schema located at PATH
   expressir help [COMMAND]  # Describe available commands or one specific command
   expressir version         # The Expressir Version
 ----
 
+=== Pretty print
+
+[source, sh]
+----
+expressir format schemas/resources/action_schema/action_schema.exp
+----
+
+
 == Development
 
 We are following Sandi Metz's Rules for this gem, you can read
@@ -66,22 +75,31 @@ Setup your environment.
 [source, sh]
 ----
 bin/setup
+git submodule update --init
+bundle exec rake generate
+bundle exec rake compile
 ----
 
 Run the test suite
 
 [source, sh]
 ----
-bin/rspec
+bundle exec rake
 ----
 
 === Grammar updates
-EXPRESS grammar is lined as git submodule to ext/express-grammar
-Shoudl you update it, run ```rake generate```. This command will generate source code for updated native extension using antlr4-native gem.
-Please note that we create several classes on top of antlr4-native output so using embedded rake task is a real requirement.
 
-When new extension is gnerated and tested plase check in updated C++ files to git (```rake generate``` is NOT a CI step, 
-extension source files are pulled from the repo).
+THe EXPRESS grammar is lined as Git submodule at `ext/express-grammar`.
+
+Should you update it, please run `rake generate`. This command will generate
+source code for updated native extension using the `antlr4-native` gem. Please
+note that we create several classes on top of `antlr4-native` output so using
+embedded rake task is a real requirement.
+
+When a new extension is generated and tested, please check in updated C++ files
+to git (`rake generate` is NOT a CI step, extension source files are pulled from
+the repo).
+
 
 == Installation
 

data/exe/format

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 require "yaml"
-require "expressir/express/parser"
+require "expressir"
 require "expressir/express/formatter"
 require "expressir/express/schema_head_formatter"
 require "expressir/express/hyperlink_formatter"
@@ -9,10 +9,6 @@ require "expressir/express/hyperlink_formatter"
 exp_files = ARGV
 
 repository = Expressir::Express::Parser.from_files(exp_files)
-formatter = Class.new(Expressir::Express::Formatter) do
-  include Expressir::Express::SchemaHeadFormatter
-  include Expressir::Express::HyperlinkFormatter
+repository.schemas.each do |schema|
+  puts schema.to_s(no_remarks: true)
 end
-result = repository.to_hash(formatter: formatter, skip_empty: true)
-
-puts YAML.dump(result)

data/exe/format-test

@@ -75,7 +75,7 @@ formatter = Class.new(Expressir::Express::Formatter) do
   include Expressir::Express::SchemaHeadFormatter
   include Expressir::Express::HyperlinkFormatter
 end
-result = repository.to_hash(formatter: formatter, skip_empty: true)
+result = repository.to_hash(formatter: formatter)
 puts "Repository.to_hash time: #{(Time.now - start).round(2)}s"
 
 # puts YAML.dump(result)

data/lib/expressir/cli.rb

@@ -1,21 +1,73 @@
 require "thor"
-require "expressir/cli/ui"
 
 module Expressir
-  module Cli
-    def self.ui
-      Expressir::Cli::UI
+  class Cli < Thor
+    desc "format PATH", "pretty print EXPRESS schema located at PATH"
+    def format(path)
+      repository = Expressir::Express::Parser.from_file(path)
+      repository.schemas.each do |schema|
+        puts "\n(* Expressir formatted schema: #{schema.id} *)\n"
+        puts schema.to_s(no_remarks: true)
+      end
     end
 
-    def self.start(args)
-      Base.start(args)
+    no_commands do
+      def _validate_schema(path)
+        repository = Expressir::Express::Parser.from_file(path)
+        repository.schemas.inject([]) do |acc, schema|
+          acc << schema.id unless schema.version&.value
+          acc
+        end
+      rescue StandardError => e
+        # pp e
+        nil
+      end
     end
 
-    class Base < Thor
-      desc "version", "The Expressir Version"
-      def version
-        Cli.ui.say("Version #{Expressir::VERSION}")
+    desc "validate *PATH", "validate EXPRESS schema located at PATH"
+    def validate(*paths)
+      no_version = []
+      no_valid = []
+
+      paths.each do |path|
+        x = Pathname.new(path).realpath.relative_path_from(Dir.pwd)
+        puts "Validating #{x}"
+        ret = _validate_schema(path)
+
+        if ret.nil?
+          no_valid << "Failed to parse: #{x}"
+          next
+        end
+
+        if ret.size
+          ret.each do |schema_id|
+            no_version << "Missing version string: schema `#{schema_id}` | #{x}"
+          end
+        end
+      end
+
+      if !no_valid.empty?
+        puts "#{"*" * 20} RESULTS: FAILED TO PARSE #{"*" * 20}"
+        no_valid.each do |msg|
+          puts msg
+        end
       end
+
+      if !no_version.empty?
+        puts "#{"*" * 20} RESULTS: MISSING VERSION STRING #{"*" * 20}"
+        no_version.each do |msg|
+          puts msg
+        end
+      end
+
+      if no_valid.size || no_version.size
+        exit 1
+      end
+    end
+
+    desc "version", "Expressir Version"
+    def version
+      say(Expressir::VERSION)
     end
   end
 end

data/lib/expressir/model/model_element.rb

@@ -104,20 +104,21 @@ module Expressir
           empty = value.nil? || (value.is_a?(Array) && value.count == 0)
 
           # skip empty values
-          if !empty or include_empty
-            hash[variable.to_s] = if value.is_a? Array
-              value.map do |value|
-                if value.is_a? ModelElement
-                  value.to_hash(root_path: root_path, formatter: formatter, include_empty: include_empty)
-                else
-                  value
-                end
+          next unless !empty or include_empty
+
+          hash[variable.to_s] = case value
+          when Array
+            value.map do |value|
+              if value.is_a? ModelElement
+                value.to_hash(root_path: root_path, formatter: formatter, include_empty: include_empty)
+              else
+                value
               end
-            elsif value.is_a? ModelElement
-              value.to_hash(root_path: root_path, formatter: formatter, include_empty: include_empty)
-            else
-              value
             end
+          when ModelElement
+            value.to_hash(root_path: root_path, formatter: formatter, include_empty: include_empty)
+          else
+            value
           end
         end
 
@@ -132,6 +133,19 @@ module Expressir
         hash
       end
 
+      def to_s
+        to_s(no_remarks: false, formatter: nil)
+      end
+
+      def to_s(no_remarks: false, formatter: nil)
+        formatter ||= Class.new(Expressir::Express::Formatter) do
+          if no_remarks
+            def format_remarks(node); []; end
+          end
+        end
+        formatter.format(self)
+      end
+
       # @param [Hash] hash
       # @param [String] root_path
       # @return [ModelElement]
@@ -142,7 +156,8 @@ module Expressir
         node_class.model_attrs.each do |variable|
           value = hash[variable.to_s]
 
-          node_options[variable] = if value.is_a? Array
+          node_options[variable] = case value
+          when Array
             value.map do |value|
               if value.is_a? Hash
                 self.from_hash(value, root_path: root_path)
@@ -150,7 +165,7 @@ module Expressir
                 value
               end
             end
-          elsif value.is_a? Hash
+          when Hash
             self.from_hash(value, root_path: root_path)
           else
             value
@@ -191,13 +206,14 @@ module Expressir
         self.class.model_attrs.each do |variable|
           value = self.send(variable)
 
-          if value.is_a? Array
+          case value
+          when Array
             value.each do |value|
               if value.is_a? ModelElement
                 value.parent = self
               end
             end
-          elsif value.is_a? ModelElement
+          when ModelElement
             value.parent = self
           end
         end

data/lib/expressir/model/repository.rb

@@ -18,6 +18,7 @@ module Expressir
           *schemas
         ]
       end
+
     end
   end
 end

data/lib/expressir/version.rb

@@ -1,3 +1,3 @@
 module Expressir
-  VERSION = "1.3.3".freeze
+  VERSION = "1.4.1".freeze
 end

data/lib/expressir.rb

@@ -3,10 +3,6 @@ require "expressir/version"
 require "expressir/cli"
 require "expressir/config"
 
-Dir[File.join(__dir__, "expressir", "express", "*.rb")].sort.each do |fea|
-  require fea
-end
-
 # ..........................................................
 # https://bugs.ruby-lang.org/issues/19319
 # The issue is that this bug is fixed for 3.1 and above,
@@ -30,10 +26,6 @@ end
 module Expressir
   class Error < StandardError; end
 
-  def self.ui
-    Expressir::Cli::UI
-  end
-
   def self.root
     File.dirname(__dir__)
   end
@@ -42,3 +34,7 @@ module Expressir
     @root_path ||= Pathname.new(Expressir.root)
   end
 end
+
+Dir[File.join(__dir__, "expressir", "express", "*.rb")].sort.each do |fea|
+  require fea
+end

data/spec/acceptance/version_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe "Expressir" do
       print "\n[#{example.description}] "
       command = %w(version)
       output = capture_stdout { Expressir::Cli.start(command) }
-      expect(output).to include("Version #{Expressir::VERSION}")
+      expect(output).to include(Expressir::VERSION)
 
       # Validate Object Space
       GC.start

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: expressir
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.4.1
 platform: x86_64-linux-musl
 authors:
 - Ribose Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-04-18 00:00:00.000000000 Z
+date: 2024-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -240,7 +240,6 @@ files:
 - expressir.gemspec
 - lib/expressir.rb
 - lib/expressir/cli.rb
-- lib/expressir/cli/ui.rb
 - lib/expressir/config.rb
 - lib/expressir/express/2.7/express_parser.so
 - lib/expressir/express/3.0/express_parser.so

data/lib/expressir/cli/ui.rb

@@ -1,36 +0,0 @@
-require "thor"
-
-module Expressir
-  module Cli
-    class UI < Thor
-      def self.ask(message)
-        new.ask(message)
-      end
-
-      def self.say(message)
-        new.say(message)
-      end
-
-      def self.error(message)
-        if log_types.include?("error")
-          new.error(message)
-        end
-      end
-
-      def self.info(message)
-        if log_types.include?("info")
-          new.say(message)
-        end
-      end
-
-      def self.run(command)
-        require "open3"
-        Open3.capture3(command)
-      end
-
-      def self.log_types
-        Expressir.configuration.logs.map(&:to_s) || []
-      end
-    end
-  end
-end