expressir 1.2.8 → 1.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b70df956cbc0e4ee44536099c3ed7ed7cddbde3d25577bd80987055a4d63b18
-  data.tar.gz: 11a05e59bdae6500d9831a1082a5088bfa2e870909befdc261695a556d2999b6
+  metadata.gz: eaa506f3baadfef96b9ea1760f21a32c111a2e14d41be0e61a7794e68075e6e5
+  data.tar.gz: 621683d72768375aba6c302cd245191fed916930aa1c4490ec41ee7263b053e2
 SHA512:
-  metadata.gz: 1b6a97a21b4b623f4e18599858d39df2d22c35f294cc2497c00e7e5be55185b99baa8d5a7ce0f4a863bba9dab6a25ad6c98b0fcb55710dbd9a5615d8eff28492
-  data.tar.gz: 4c19963a05d3b42cf794d4fa50e5d219ec60805a6d9fed0400d6299cdfa0c74752b4c4826569bb246aab698434e9612eb175aee598c75c53b8f3feaa4cdb3e7e
+  metadata.gz: 7ff98f9a3e3ff7f73ea060665e64c63e77bee3030861f36f4a2287ece88498d227b9fd618396813dfe971f326e0c4e0055bde1678338e0df38ec37264d1590d3
+  data.tar.gz: b17547db600a3e6ec9acaa99870ab12d0f5b184d9669eeb0f7ffd3cea9de840fa6daa112160fe06e511394851c9c99259cf451d9733bbd6fa28e9b3a4ea281a5

data/.github/workflows/rake.yml

@@ -83,8 +83,6 @@ jobs:
   # test release workflow
   pack-ruby:
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
     steps:
       - name: Checkout
         uses: actions/checkout@v3

data/.github/workflows/release.yml

@@ -15,24 +15,17 @@ concurrency:
   group: '${{ github.workflow }}-${{ github.job }}-${{ github.head_ref || github.ref_name }}'
   cancel-in-progress: true
 
-env:
-  BUNDLER_VER: 2.3.24
-# Forcing bundler version to ensure that it is consistent everywhere and
-# does not cause bundler gem reinstalls
-# bundler/rubygems 2.3.22 is a minimal requirement to support gnu/musl differentiation
-# https://github.com/rubygems/rubygems/pull/4488
-
 jobs:
   bump:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
 
       - uses: ruby/setup-ruby@master
         with:
-          ruby-version: '3.0'
+          ruby-version: '3.1'
           bundler: ${{ env.BUNDLER_VER }}
 
       - if: ${{ github.event_name == 'workflow_dispatch' }} # unfortunatelly cannot keep this condition on job level
@@ -50,17 +43,16 @@ jobs:
       matrix:
         host: [ linux, windows, darwin ]
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
           ref: main # https://github.com/actions/checkout/issues/439#issuecomment-830862188
 
       - uses: ruby/setup-ruby@master
         with:
-          ruby-version: '3.0'
+          ruby-version: '3.1'
           # bundler-cache: true important to not use cache because it leads to "cannot find -lrice"
           # more info https://github.com/lutaml/expressir/runs/2097658383?check_suite_focus=true#step:7:2126
-          bundler: ${{ env.BUNDLER_VER }}
 
       - run: bundle install --jobs 4 --retry 3
 
@@ -90,7 +82,7 @@ jobs:
           path: pkg/*.gem
 
   publish:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     needs: pack
     steps:
       - uses: actions/download-artifact@v3
@@ -115,8 +107,7 @@ jobs:
 
       - uses: ruby/setup-ruby@master
         with:
-          ruby-version: '3.0'
-          bundler: ${{ env.BUNDLER_VER }}
+          ruby-version: '3.1'
 
       - run: ls -l pkg/
 

data/.rubocop.yml

@@ -3,6 +3,7 @@ inherit_from:
 
 AllCops:
   TargetRubyVersion: 2.7
+  NewCops: enable
   SuggestExtensions: false
   Exclude:
     - 'vendor/**/*'

data/bin/rspec

@@ -15,7 +15,7 @@ ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
 bundle_binstub = File.expand_path("bundle", __dir__)
 
 if File.file?(bundle_binstub)
-  if /This file was generated by Bundler/.match?(File.read(bundle_binstub, 300))
+  if File.read(bundle_binstub, 300).include?("This file was generated by Bundler")
     load(bundle_binstub)
   else
     abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.

data/expressir.gemspec

@@ -41,8 +41,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake-compiler", "~> 1.2"
   spec.add_development_dependency "rake-compiler-dock", "~> 1.2.1"
   spec.add_development_dependency "rspec", "~> 3.11"
-  spec.add_development_dependency "rubocop", "1.5.2"
-  spec.add_development_dependency "rubocop-performance", "~> 1.0"
+  spec.add_development_dependency "rubocop", "1.58"
+  spec.add_development_dependency "rubocop-performance", "~> 1.19"
   spec.add_development_dependency "webrick", "~> 1.7.0"
   spec.add_development_dependency "yard", "~> 0.9.26"
 end

data/lib/expressir/express/visitor.rb

@@ -17,7 +17,7 @@ require "set"
 # - such multi-pass parsing is not implemented yet
 # - xxxRef - merged to SimpleReference
 # - entityConstructor, functionCall - merged to FunctionCall
-# 
+#
 # difference between generalized and instantiable types is not recognized
 # see note in 8.6.2 Parameter data types
 # > A syntactic construct such as ARRAY[1:3] OF REAL satisfies two syntactic productions —
@@ -69,7 +69,7 @@ module Expressir
           default
         end
       end
-    
+
       def visit_if_map(ctx)
         if ctx
           ctx.map{|ctx2| visit(ctx2)}
@@ -77,7 +77,7 @@ module Expressir
           []
         end
       end
-    
+
       def visit_if_map_flatten(ctx)
         if ctx
           ctx.map{|ctx2| visit(ctx2)}.flatten
@@ -111,15 +111,25 @@ module Expressir
         end
       end
 
+      def node_find(node, path)
+        if node.is_a?(Enumerable)
+          target_node = node.find { |item| item.find(path) }
+        else
+          target_node = node.find(path)
+        end
+        target_node
+      end
+
       def find_remark_target(node, path)
-        target_node = node.find(path)
+        target_node = node_find(node, path)
+
         return target_node if target_node
 
         # check if path can create implicit remark item
         # see https://github.com/lutaml/expressir/issues/78
         rest, _, current_path = path.rpartition(".") # get last path part
         _, _, current_path = current_path.rpartition(":") # ignore prefix
-        parent_node = node.find(rest)
+        parent_node = node_find(node, rest)
         if parent_node and parent_node.class.method_defined? :remark_items
           remark_item = Model::Declarations::RemarkItem.new(
             id: current_path
@@ -134,7 +144,7 @@ module Expressir
             parent_node.remark_items << remark_item
           end
           parent_node.reset_children_by_id
-          
+
           remark_item
         end
       end
@@ -427,7 +437,7 @@ module Expressir
         optional = ctx__OPTIONAL && true
         unique = ctx__UNIQUE && true
         base_type = visit_if(ctx__instantiable_type)
-        
+
         Model::DataTypes::Array.new(
           bound1: bound1,
           bound2: bound2,
@@ -495,7 +505,7 @@ module Expressir
         bound1 = visit_if(ctx__bound_spec__bound1)
         bound2 = visit_if(ctx__bound_spec__bound2)
         base_type = visit_if(ctx__instantiable_type)
-        
+
         Model::DataTypes::Bag.new(
           bound1: bound1,
           bound2: bound2,
@@ -830,7 +840,7 @@ module Expressir
         if ctx__type_ref
           ref = visit_if(ctx__type_ref)
           attribute = visit_if(ctx__enumeration_ref)
-  
+
           Model::References::AttributeReference.new(
             ref: ref,
             attribute: attribute
@@ -1030,7 +1040,7 @@ module Expressir
         optional = ctx__OPTIONAL && true
         unique = ctx__UNIQUE && true
         base_type = visit_if(ctx__parameter_type)
-        
+
         Model::DataTypes::Array.new(
           bound1: bound1,
           bound2: bound2,
@@ -1049,7 +1059,7 @@ module Expressir
         bound1 = visit_if(ctx__bound_spec__bound1)
         bound2 = visit_if(ctx__bound_spec__bound2)
         base_type = visit_if(ctx__parameter_type)
-        
+
         Model::DataTypes::Bag.new(
           bound1: bound1,
           bound2: bound2,
@@ -1068,7 +1078,7 @@ module Expressir
         bound2 = visit_if(ctx__bound_spec__bound2)
         unique = ctx__UNIQUE && true
         base_type = visit_if(ctx__parameter_type)
-        
+
         Model::DataTypes::List.new(
           bound1: bound1,
           bound2: bound2,
@@ -1093,7 +1103,7 @@ module Expressir
         bound1 = visit_if(ctx__bound_spec__bound1)
         bound2 = visit_if(ctx__bound_spec__bound2)
         base_type = visit_if(ctx__parameter_type)
-        
+
         Model::DataTypes::Set.new(
           bound1: bound1,
           bound2: bound2,
@@ -1358,7 +1368,7 @@ module Expressir
         bound2 = visit_if(ctx__bound_spec__bound2)
         unique = ctx__UNIQUE && true
         base_type = visit_if(ctx__instantiable_type)
-        
+
         Model::DataTypes::List.new(
           bound1: bound1,
           bound2: bound2,
@@ -1989,7 +1999,7 @@ module Expressir
             end
           end
         end
-        
+
         Model::Declarations::SchemaVersion.new(
           value: value,
           items: items
@@ -2042,7 +2052,7 @@ module Expressir
         bound1 = visit_if(ctx__bound_spec__bound1)
         bound2 = visit_if(ctx__bound_spec__bound2)
         base_type = visit_if(ctx__instantiable_type)
-        
+
         Model::DataTypes::Set.new(
           bound1: bound1,
           bound2: bound2,
@@ -2087,7 +2097,7 @@ module Expressir
       def visit_simple_factor_expression(ctx)
         ctx__expression = ctx.expression
         ctx__primary = ctx.primary
-        
+
         visit_if(ctx__expression || ctx__primary)
       end
 
@@ -2575,4 +2585,4 @@ module Expressir
       end
     end
   end
-end
+end

data/lib/expressir/version.rb

@@ -1,3 +1,3 @@
 module Expressir
-  VERSION = "1.2.8".freeze
+  VERSION = "1.2.9".freeze
 end

data/rakelib/cross-ruby.rake

@@ -126,7 +126,7 @@ CrossRuby = Struct.new(:version, :host) do
 
   def verify_entry_linux(dll)
     nm = `#{["env", "LANG=C", tool("nm"), "-D", dll].shelljoin}`
-    unless / T Init_express_parser/.match?(nm)
+    unless nm.include?(" T Init_express_parser")
       raise "Export function Init_express_parser not in dll #{dll}"
     end
   end
@@ -223,7 +223,7 @@ CrossRuby = Struct.new(:version, :host) do
   end
 
   def actual_dlls_windows(dump)
-    dump.scan(/DLL Name: (.*)$/).map(&:first).map(&:downcase).uniq
+    dump.scan(/DLL Name: (.*)$/).map { |x| x.first.downcase }.uniq
   end
 
   def actual_dlls_darwin(dll)
@@ -272,12 +272,12 @@ CrossRuby = Struct.new(:version, :host) do
   end
 end
 
-CROSS_RUBIES = File.read(".cross_rubies").split("\n").map do |line|
+CROSS_RUBIES = File.read(".cross_rubies").split("\n").filter_map do |line|
   case line
   when /\A([^#]+):([^#]+)/
     CrossRuby.new($1, $2)
   end
-end.compact
+end
 
 ENV["RUBY_CC_VERSION"] = CROSS_RUBIES.map(&:ver).uniq.join(":")
 
@@ -329,7 +329,7 @@ namespace "gem" do
         #{pre_req(plat)} &&
         gem install bundler --no-document &&
         bundle &&
-        bundle exec rake gem:#{plat}:builder MAKE='nice make -j`nproc`'
+        bundle exec rake gem:#{plat}:builder MAKE="nice make -j`nproc`"
       RCD
     end
 

data/spec/syntax/remark.exp

@@ -23,7 +23,9 @@ ENTITY remark_entity;
   DERIVE remark_derived_attribute : STRING := 'xxx';
   INVERSE remark_inverse_attribute : remark_entity FOR remark_attribute;
   UNIQUE UR1: remark_attribute;
-  WHERE WR1: TRUE;
+  WHERE WR1:
+  --"unusual_placement" placed inside WHERE clauses (or other enumerable context)
+  TRUE;
   --"remark_attribute" entity scope - entity attribute
   --"remark_derived_attribute" entity scope - entity derived attribute
   --"remark_inverse_attribute" entity scope - entity inverse attribute
@@ -188,4 +190,4 @@ END_SCHEMA;
 --"remark_schema.remark_procedure.remark_enumeration_item" universal scope - procedure enumeration item, on the same level as the type
 --"remark_schema.remark_procedure.remark_constant" universal scope - procedure constant
 --"remark_schema.remark_procedure.remark_variable" universal scope - procedure variable
---"remark_schema.remark_item" universal scope - schema remark item
+--"remark_schema.remark_item" universal scope - schema remark item

data/spec/syntax/remark.yaml

@@ -133,6 +133,11 @@ schemas:
       - schema scope - entity where, with prefix
       - universal scope - entity where
       - universal scope - entity where, with prefix
+      remark_items:
+      - _class: Expressir::Model::Declarations::RemarkItem
+        id: unusual_placement
+        remarks:
+        - placed inside WHERE clauses (or other enumerable context)
       expression:
         _class: Expressir::Model::Literals::Logical
         value: :TRUE

data/spec/syntax/remark_formatted.exp

@@ -146,6 +146,7 @@ several physical lines.
 --"remark_schema.remark_entity.WR1" schema scope - entity where, with prefix
 --"remark_schema.remark_entity.WR1" universal scope - entity where
 --"remark_schema.remark_entity.WR1" universal scope - entity where, with prefix
+--"remark_schema.remark_entity.WR1.unusual_placement" placed inside WHERE clauses (or other enumerable context)
 --"remark_schema.remark_entity.IP1" entity scope - entity informal proposition
 --"remark_schema.remark_entity.IP1" entity scope - entity informal proposition, with prefix
 --"remark_schema.remark_entity.IP1" schema scope - entity informal proposition

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: expressir
 version: !ruby/object:Gem::Version
-  version: 1.2.8
+  version: 1.2.9
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-10-26 00:00:00.000000000 Z
+date: 2023-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rice
@@ -170,28 +170,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: '1.58'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: '1.58'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.19'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.19'
 - !ruby/object:Gem::Dependency
   name: webrick
   requirement: !ruby/object:Gem::Requirement
@@ -731,7 +731,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
+rubygems_version: 3.3.26
 signing_key: 
 specification_version: 4
 summary: ISO EXPRESS parser and tools in Ruby.