expressir 0.2.21 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58e1bbf9a216e77cfda6594ad7040dba57086b8776c05b884bfcb25174967237
-  data.tar.gz: cf12bb3deef6b060f0d634e894a6bbcf10734cdcb8b3329d79ccb1d569d95a62
+  metadata.gz: b288f91d09464550e2670eab67a4f74fafc792d466b0e4dea25df8a461c2fa38
+  data.tar.gz: c912d8c9cdd4670454e69d41cb0eac9d75e932850a84cb780d79017727872c8a
 SHA512:
-  metadata.gz: eb15652a0cca4901425feea15981e60ce302b55471fcd8b95b2f98df1174f87e9a2eba7c233f97d3678349b5187f2785a7f23cf3bc0845a373bda668c66791c8
-  data.tar.gz: 1a9b788abfc17361421943a7b10c83fa47b0d6653e57b6ffa645175d33354b387de2506b70f271a781d97000c037b122ecab4b383d310293643335e64868bafc
+  metadata.gz: e06cb6104922b279ea63882e01e71f7deaa719cb5329d6f8a466ed5ae209d18f0190adbb4a191a8f09736a9df9366a1c531bea03f14a9b685fab63f0f42b4441
+  data.tar.gz: 3a4d3543f090c0bc7e48a60c2e0a5bf0099a0e03001687dd7c29e59ccef07779e87dee29553c1c5f6cd63df40dc057cd0e5fff633952b977cc8ef5ad05a20ccf

data/.github/workflows/rake.yml

@@ -40,11 +40,12 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
 
-      - run: bundle exec rake compile
+      - uses: actions/cache@v2
+        with:
+          path: lib/expressir/express/express_parser.*
+          key: v4-${{ runner.os }}-${{ matrix.ruby }}-${{ hashFiles('ext/express-parser/extconf.rb', 'ext/express-parser/antlrgen/**', 'ext/express-parser/express_parser.cpp', '.git/modules/ext/express-parser/antlr4-upstream/HEAD') }}
 
-      - run: bundle exec rake
+      - if: hashFiles('lib/expressir/express/express_parser.*') == ''
+        run: bundle exec rake compile
 
-      - uses: actions/upload-artifact@v2
-        with:
-          name: express_parser-${{ matrix.os }}-${{ matrix.ruby }}
-          path: lib/expressir/express_exp/express_parser.so
+      - run: bundle exec rake

data/.github/workflows/release.yml

@@ -12,8 +12,27 @@ on:
     tags: [ v* ]
 
 jobs:
+  bump:
+    runs-on: ubuntu-18.04
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '2.6'
+
+      - if: ${{ github.event_name == 'workflow_dispatch' }} # unfortunatelly cannot keep this condition on job level
+        run: |
+          git config user.name github-actions
+          git config user.email github-actions@github.com
+          gem install gem-release
+          gem bump --version ${{ github.event.inputs.next_version }} --tag --push
+
   pack:
     runs-on: ubuntu-18.04
+    needs: bump
     strategy:
       fail-fast: false
       matrix:
@@ -26,13 +45,10 @@ jobs:
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: '2.6'
-          bundler-cache: true
+          # bundler-cache: true important to not use cache because it leads to "cannot find -lrice"
+          # more info https://github.com/lutaml/expressir/runs/2097658383?check_suite_focus=true#step:7:2126
 
-      - if: ${{ github.event_name == 'workflow_dispatch' }}
-        run: |
-          git config user.name github-actions
-          git config user.email github-actions@github.com
-          gem bump --version ${{ github.event.inputs.next_version }} --tag --push
+      - run: bundle install --jobs 4 --retry 3
 
       # build gem WITHOUT pre-built native extension
       - run: gem build expressir.gemspec

data/.gitignore

@@ -8,8 +8,8 @@
 /tmp/
 /Gemfile.lock
 /.idea
-/lib/expressir/express_exp/express_parser.bundle
-/original/examples/syntax/*-pretty.exp
+/lib/expressir/express/express_parser.bundle
+/spec/syntax/*-pretty.exp
 
 # rspec failure tracking
 .rspec_status

data/demo.rb

@@ -1,18 +1,18 @@
 #!/usr/bin/env ruby
 
 require 'expressir'
-require 'expressir/express_exp/parser'
+require 'expressir/express/parser'
 
 # This file is from:
 # https://github.com/metanorma/annotated-express/blob/master/data/resources/action_schema/action_schema.exp
 file = 'action_schema.exp'
 
-# repo = Expressir::ExpressExp::Parser.from_exp(file)
+# repo = Expressir::Express::Parser.from_exp(file)
 # schema = repo.schemas.find{|schema| schema.id == "support_resource_schema"}
 
-repo = Expressir::ExpressExp::Parser.from_exp(file)
+repo = Expressir::Express::Parser.from_exp(file)
 schema = repo.schemas.find{|schema| schema.id == "action_schema"}
 entity = schema.entities.find{|entity| entity.id == "action_directive_relationship"}
-where = entity.where.find{|where| where.id == "WR1"}
+where_rule = entity.where_rules.find{|where_rule| where_rule.id == "WR1"}
 
-puts where.inspect
+puts where_rule.inspect

data/exe/format

@@ -1,81 +1,18 @@
 #!/usr/bin/env ruby
 
 require "yaml"
-require "tempfile"
-require "expressir/express_exp/parser"
-require "expressir/express_exp/formatter"
-require "expressir/express_exp/schema_head_formatter"
-require "expressir/express_exp/hyperlink_formatter"
-require "expressir/express_exp/cache"
+require "expressir/express/parser"
+require "expressir/express/formatter"
+require "expressir/express/schema_head_formatter"
+require "expressir/express/hyperlink_formatter"
 
-exp_files = [
-  # basic test
-  # '../iso-10303-stepmod/data/resources/action_schema/action_schema_annotated.exp',
-  # '../iso-10303-stepmod/data/resources/basic_attribute_schema/basic_attribute_schema_annotated.exp',
-  # '../iso-10303-stepmod/data/resources/support_resource_schema/support_resource_schema_annotated.exp',
-  # cyclic reference test
-  # '../iso-10303-stepmod/data/modules/analysis/mim_annotated.exp',
-  # '../iso-10303-stepmod/data/modules/analysis_product_relationships/mim_annotated.exp',
-  # cyclic reference test 2
-  # '../iso-10303-stepmod/data/resources/product_property_definition_schema/product_property_definition_schema_annotated.exp',
-  # '../iso-10303-stepmod/data/resources/product_property_representation_schema/product_property_representation_schema_annotated.exp',
-  # renamed reference test (36s)
-  # '../iso-10303-stepmod/ballots/ballots/ap210_wg12/express/resources/mathematical_functions_schema.exp',
-  # '../iso-10303-stepmod/data/resources/iso13584_expressions_schema/iso13584_expressions_schema.exp',
-  # annotated-express test (12s)
-  # see https://github.com/metanorma/annotated-express/blob/master/data/documents/resources/fundamentals_of_product_description_and_support/sections/04-schemas.adoc
-  '../iso-10303-stepmod/data/resources/action_schema/action_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/application_context_schema/application_context_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/approval_schema/approval_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/basic_attribute_schema/basic_attribute_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/certification_schema/certification_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/contract_schema/contract_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/date_time_schema/date_time_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/document_schema/document_schema.exp',
-  '../iso-10303-stepmod/data/resources/effectivity_schema/effectivity_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/experience_schema/experience_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/external_reference_schema/external_reference_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/group_schema/group_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/language_schema/language_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/location_schema/location_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/management_resources_schema/management_resources_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/measure_schema/measure_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/person_organization_schema/person_organization_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/process_property_schema/process_property_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/product_definition_schema/product_definition_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/product_property_definition_schema/product_property_definition_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/product_property_representation_schema/product_property_representation_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/qualifications_schema/qualifications_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/security_classification_schema/security_classification_schema_annotated.exp',
-  '../iso-10303-stepmod/data/resources/support_resource_schema/support_resource_schema_annotated.exp',
-  # full test (6m18s + 8s = 6m26s)
-  # *`bundle exec ../stepmod-utils/exe/stepmod-find-express-files ../iso-10303-stepmod`.strip.split("\n").map{|file| File.exists?(file.sub(/\.exp$/, '_annotated.exp')) ? file.sub(/\.exp$/, '_annotated.exp') : file}
-]
+exp_files = ARGV
 
-start = Time.now
-repository = Expressir::ExpressExp::Parser.from_files(exp_files)
-puts "Parser.from_files time:  #{(Time.now - start).round(2)}s"
-
-temp_file = Tempfile.new
-begin
-  start = Time.now
-  Expressir::ExpressExp::Cache.to_file(temp_file, repository)
-  puts "Cache.to_file time:      #{(Time.now - start).round(2)}s"
-
-  start = Time.now
-  repository = Expressir::ExpressExp::Cache.from_file(temp_file)
-  puts "Cache.from_file time:    #{(Time.now - start).round(2)}s"
-ensure
-  temp_file.close
-  temp_file.unlink
-end
-
-start = Time.now
-formatter = Class.new(Expressir::ExpressExp::Formatter) do
-  include Expressir::ExpressExp::SchemaHeadFormatter
-  include Expressir::ExpressExp::HyperlinkFormatter
+repository = Expressir::Express::Parser.from_files(exp_files)
+formatter = Class.new(Expressir::Express::Formatter) do
+  include Expressir::Express::SchemaHeadFormatter
+  include Expressir::Express::HyperlinkFormatter
 end
 result = repository.to_hash(formatter: formatter, skip_empty: true)
-puts "Repository.to_hash time: #{(Time.now - start).round(2)}s"
 
-# puts YAML.dump(result)
+puts YAML.dump(result)

data/exe/format-test

@@ -0,0 +1,81 @@
+#!/usr/bin/env ruby
+
+require "yaml"
+require "tempfile"
+require "expressir/express/parser"
+require "expressir/express/formatter"
+require "expressir/express/schema_head_formatter"
+require "expressir/express/hyperlink_formatter"
+require "expressir/express/cache"
+
+exp_files = [
+  # basic test
+  # '../iso-10303-stepmod/data/resources/action_schema/action_schema_annotated.exp',
+  # '../iso-10303-stepmod/data/resources/basic_attribute_schema/basic_attribute_schema_annotated.exp',
+  # '../iso-10303-stepmod/data/resources/support_resource_schema/support_resource_schema_annotated.exp',
+  # cyclic reference test
+  # '../iso-10303-stepmod/data/modules/analysis/mim_annotated.exp',
+  # '../iso-10303-stepmod/data/modules/analysis_product_relationships/mim_annotated.exp',
+  # cyclic reference test 2
+  # '../iso-10303-stepmod/data/resources/product_property_definition_schema/product_property_definition_schema_annotated.exp',
+  # '../iso-10303-stepmod/data/resources/product_property_representation_schema/product_property_representation_schema_annotated.exp',
+  # renamed reference test (36s)
+  # '../iso-10303-stepmod/ballots/ballots/ap210_wg12/express/resources/mathematical_functions_schema.exp',
+  # '../iso-10303-stepmod/data/resources/iso13584_expressions_schema/iso13584_expressions_schema.exp',
+  # annotated-express test (12s)
+  # see https://github.com/metanorma/annotated-express/blob/master/data/documents/resources/fundamentals_of_product_description_and_support/sections/04-schemas.adoc
+  '../iso-10303-stepmod/data/resources/action_schema/action_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/application_context_schema/application_context_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/approval_schema/approval_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/basic_attribute_schema/basic_attribute_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/certification_schema/certification_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/contract_schema/contract_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/date_time_schema/date_time_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/document_schema/document_schema.exp',
+  '../iso-10303-stepmod/data/resources/effectivity_schema/effectivity_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/experience_schema/experience_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/external_reference_schema/external_reference_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/group_schema/group_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/language_schema/language_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/location_schema/location_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/management_resources_schema/management_resources_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/measure_schema/measure_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/person_organization_schema/person_organization_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/process_property_schema/process_property_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/product_definition_schema/product_definition_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/product_property_definition_schema/product_property_definition_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/product_property_representation_schema/product_property_representation_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/qualifications_schema/qualifications_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/security_classification_schema/security_classification_schema_annotated.exp',
+  '../iso-10303-stepmod/data/resources/support_resource_schema/support_resource_schema_annotated.exp',
+  # full test (6m18s + 8s = 6m26s)
+  # *`bundle exec ../stepmod-utils/exe/stepmod-find-express-files ../iso-10303-stepmod`.strip.split("\n").map{|file| File.exists?(file.sub(/\.exp$/, '_annotated.exp')) ? file.sub(/\.exp$/, '_annotated.exp') : file}
+]
+
+start = Time.now
+repository = Expressir::Express::Parser.from_files(exp_files)
+puts "Parser.from_files time:  #{(Time.now - start).round(2)}s"
+
+temp_file = Tempfile.new
+begin
+  start = Time.now
+  Expressir::Express::Cache.to_file(temp_file, repository)
+  puts "Cache.to_file time:      #{(Time.now - start).round(2)}s"
+
+  start = Time.now
+  repository = Expressir::Express::Cache.from_file(temp_file)
+  puts "Cache.from_file time:    #{(Time.now - start).round(2)}s"
+ensure
+  temp_file.close
+  temp_file.unlink
+end
+
+start = Time.now
+formatter = Class.new(Expressir::Express::Formatter) do
+  include Expressir::Express::SchemaHeadFormatter
+  include Expressir::Express::HyperlinkFormatter
+end
+result = repository.to_hash(formatter: formatter, skip_empty: true)
+puts "Repository.to_hash time: #{(Time.now - start).round(2)}s"
+
+# puts YAML.dump(result)

data/expressir.gemspec

@@ -30,7 +30,6 @@ Gem::Specification.new do |spec|
 
   spec.extensions = File.join(*%w(ext express-parser extconf.rb))
 
-  spec.add_runtime_dependency "nokogiri", "~> 1.10"
   spec.add_runtime_dependency "thor", "~> 1.0"
   spec.add_runtime_dependency "rice", "~> 3"
   spec.add_development_dependency "antlr4-native", "~> 1.1.0"

data/ext/express-parser/extconf.rb

@@ -56,4 +56,4 @@ src_paths.each do |src_path|
   $srcs.push(*Dir["#{abs_src_path}/*.cpp"])
 end
 
-create_makefile "expressir/express_exp/#{extension_name}"
+create_makefile "expressir/express/#{extension_name}"

data/lib/expressir.rb

@@ -2,7 +2,6 @@ require "expressir/version"
 
 require "expressir/cli"
 require "expressir/config"
-require "expressir/express"
 
 module Expressir
   class Error < StandardError; end

data/lib/expressir/cli.rb

@@ -1,6 +1,5 @@
 require "thor"
 require "expressir/cli/ui"
-require "expressir/express_parser"
 
 module Expressir
   module Cli
@@ -17,11 +16,6 @@ module Expressir
       def version
         Cli.ui.say("Version #{Expressir::VERSION}")
       end
-
-      desc "express-to-owl FILE", "Express to OWL conversion"
-      def express_to_owl(file)
-        Cli.ui.say(ExpressParser.to_owl(file))
-      end
     end
   end
 end

data/lib/expressir/{express_exp → express}/cache.rb

@@ -3,7 +3,7 @@ require 'zlib'
 require 'expressir/model'
 
 module Expressir
-  module ExpressExp
+  module Express
     class Cache
       def self.to_file(file, content, options = {})
         root_path = options[:root_path]
@@ -16,7 +16,7 @@ module Expressir
           content: content
         })
 
-        hash = cache.to_hash(root_path: root_path, skip_empty: true)
+        hash = cache.to_hash(root_path: root_path)
         yaml = YAML.dump(hash)
         yaml_compressed = Zlib::Deflate.deflate(yaml)
 
@@ -35,14 +35,11 @@ module Expressir
         cache = Model::ModelElement.from_hash(hash, root_path: root_path)
 
         if cache.version != version
-          raise CacheLoadError.new("Cache version mismatch, cache version is #{cache.version}, Expressir version is #{VERSION}")
+          raise Error.new("Cache version mismatch, cache version is #{cache.version}, Expressir version is #{version}")
         end
 
         cache.content
       end
     end
-
-    class CacheLoadError < StandardError
-    end
   end
 end

data/lib/expressir/{express_exp → express}/formatter.rb

@@ -1,7 +1,7 @@
 require 'expressir/model'
 
 module Expressir
-  module ExpressExp
+  module Express
     class Formatter
       INDENT_CHAR = ' '
       INDENT_WIDTH = 2
@@ -62,16 +62,18 @@ module Expressir
           format_rule(node)
         elsif node.is_a? Model::Schema
           format_schema(node)
+        elsif node.is_a? Model::SchemaVersion
+          format_schema_version(node)
         elsif node.is_a? Model::SubtypeConstraint
           format_subtype_constraint(node)
         elsif node.is_a? Model::Type
           format_type(node)
-        elsif node.is_a? Model::Unique
-          format_unique(node)
+        elsif node.is_a? Model::UniqueRule
+          format_unique_rule(node)
         elsif node.is_a? Model::Variable
           format_variable(node)
-        elsif node.is_a? Model::Where
-          format_where(node)
+        elsif node.is_a? Model::WhereRule
+          format_where_rule(node)
         elsif node.is_a? Model::Expressions::AggregateInitializer
           format_expressions_aggregate_initializer(node)
         elsif node.is_a? Model::Expressions::AggregateItem
@@ -314,16 +316,16 @@ module Expressir
               indent(inverse_attributes.map{|x| format(x)}.join("\n")),
             ]
           end,
-          *if node.unique.length > 0
+          *if node.unique_rules.length > 0
             [
               'UNIQUE',
-              indent(node.unique.map{|x| format(x)}.join("\n"))
+              indent(node.unique_rules.map{|x| format(x)}.join("\n"))
             ]
           end,
-          *if node.where.length > 0
+          *if node.where_rules.length > 0
             [
               'WHERE',
-              indent(node.where.map{|x| format(x)}.join("\n")),
+              indent(node.where_rules.map{|x| format(x)}.join("\n")),
             ]
           end,
           [
@@ -574,10 +576,10 @@ module Expressir
           *if node.statements.length > 0
             indent(node.statements.map{|x| format(x)}.join("\n"))
           end,
-          *if node.where.length > 0
+          *if node.where_rules.length > 0
             [
               'WHERE',
-              indent(node.where.map{|x| format(x)}.join("\n"))
+              indent(node.where_rules.map{|x| format(x)}.join("\n"))
             ]
           end,
           [
@@ -659,6 +661,14 @@ module Expressir
         ].join("\n")
       end
 
+      def format_schema_version(node)
+        [
+          "'",
+          node.value,
+          "'"
+        ].join('')
+      end
+
       def format_subtype_constraint(node)
         [
           [
@@ -710,13 +720,13 @@ module Expressir
             ' ',
             '=',
             ' ',
-            format(node.type),
+            format(node.underlying_type),
             ';',
           ].join(''),
-          *if node.where.length > 0
+          *if node.where_rules.length > 0
             [
               'WHERE',
-              indent(node.where.map{|x| format(x)}.join("\n"))
+              indent(node.where_rules.map{|x| format(x)}.join("\n"))
             ]
           end,
           [
@@ -726,7 +736,7 @@ module Expressir
         ].join("\n")
       end
 
-      def format_unique(node)
+      def format_unique_rule(node)
         [
           *if node.id
             [
@@ -759,7 +769,7 @@ module Expressir
         ].join('')
       end
 
-      def format_where(node)
+      def format_where_rule(node)
         [
           *if node.id
             [
@@ -1289,38 +1299,41 @@ module Expressir
             ].join('')
           end,
           'ENUMERATION',
-          *if node.items.length > 0
-            item_indent = INDENT_CHAR * '('.length
-            [
-              ' ',
-              'OF',
-              "\n",
-              indent([
-                '(',
-                node.items.map{|x| format(x)}.join(",\n#{item_indent}"),
-                ')'
-              ].join(''))
-            ].join('')
-          end,
-          *if node.extension_type
+          *if node.based_on
             [
               ' ',
               'BASED_ON',
               ' ',
-              format(node.extension_type)
+              format(node.based_on),
+              *if node.items.length > 0
+                item_indent = INDENT_CHAR * '('.length
+                [
+                  ' ',
+                  'WITH',
+                  "\n",
+                  indent([
+                    '(',
+                    node.items.map{|x| format(x)}.join(",\n#{item_indent}"),
+                    ')'
+                  ].join(''))
+                ].join('')
+              end
             ].join('')
-          end,
-          *if node.extension_items.length > 0
-            item_indent = INDENT_CHAR * '('.length
+          else
             [
-              ' ',
-              'WITH',
-              "\n",
-              indent([
-                '(',
-                node.extension_items.map{|x| format(x)}.join(",\n#{item_indent}"),
-                ')'
-              ].join(''))
+              *if node.items.length > 0
+                item_indent = INDENT_CHAR * '('.length
+                [
+                  ' ',
+                  'OF',
+                  "\n",
+                  indent([
+                    '(',
+                    node.items.map{|x| format(x)}.join(",\n#{item_indent}"),
+                    ')'
+                  ].join(''))
+                ].join('')
+              end
             ].join('')
           end
         ].join('')
@@ -1417,36 +1430,39 @@ module Expressir
             ].join('')
           end,
           'SELECT',
-          *if node.items.length > 0
-            item_indent = INDENT_CHAR * '('.length
-            [
-              "\n",
-              indent([
-                '(',
-                node.items.map{|x| format(x)}.join(",\n#{item_indent}"),
-                ')'
-              ].join(''))
-            ].join('')
-          end,
-          *if node.extension_type
+          *if node.based_on
             [
               ' ',
               'BASED_ON',
               ' ',
-              format(node.extension_type)
+              format(node.based_on),
+              *if node.items.length > 0
+                item_indent = INDENT_CHAR * '('.length
+                [
+                  ' ',
+                  'WITH',
+                  "\n",
+                  indent([
+                    '(',
+                    node.items.map{|x| format(x)}.join(",\n#{item_indent}"),
+                    ')'
+                  ].join(''))
+                ].join('')
+              end
             ].join('')
-          end,
-          *if node.extension_items.length > 0
-            item_indent = INDENT_CHAR * '('.length
+          else
             [
-              ' ',
-              'WITH',
-              "\n",
-              indent([
-                '(',
-                node.extension_items.map{|x| format(x)}.join(",\n#{item_indent}"),
-                ')'
-              ].join(''))
+              *if node.items.length > 0
+                item_indent = INDENT_CHAR * '('.length
+                [
+                  "\n",
+                  indent([
+                    '(',
+                    node.items.map{|x| format(x)}.join(",\n#{item_indent}"),
+                    ')'
+                  ].join(''))
+                ].join('')
+              end
             ].join('')
           end
         ].join('')
@@ -1502,7 +1518,7 @@ module Expressir
             [
               '(*',
               '"',
-              node.path,
+              node.path || node.id,
               '"',
             ].join(''),
             remark,
@@ -1512,7 +1528,7 @@ module Expressir
           [
             '--',
             '"',
-            node.path,
+            node.path || node.id,
             '"',
             ' ',
             remark