express_templates 0.11.9 → 0.11.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b662a57e856dd89321c96091431adb2331ce4c0d
-  data.tar.gz: 5f3847dda42dec6989c7e85e86d6afd6f64100f1
+  metadata.gz: ae4b19c45903080f13a98d80b752a4f0454f8d48
+  data.tar.gz: 9459a475d5784d7edaa7f09240b8fed15a01f5e3
 SHA512:
-  metadata.gz: 5461e2ef314e4a4bf8e3d4a291fce3f261ac539baac42ae20b8b36b093355ddb4f4effe60ab61c9d8c5dae9ebb1477c5eed0d401e416612fb9a32bdbdedb30c3
-  data.tar.gz: 23fbaaf48a9ed88fd36d53311a8fd46d0c510110b220fd9d21b39f6df717dc95cea5088029146b50ab01420f6a40d508b6319ca6c3e5cbbda22e5546142dcb9f
+  metadata.gz: 03661034f2894cc14a6270b5d65171225ba590b6edd5f1de2667d3e74b6ede8450bf347cba20c83ec724e6148a43b196c2ce4cd76852756e55dd5261d65e7e79
+  data.tar.gz: f4bbcd6364eaa8f281c59551d8e4c7cf41b839ab7e3cc17d876d282a1d50b77e9417e9f59fc1fb990f751a35d9994a3d72c227cde0d303e2e88a5651bd85e3e8

data/README.md

@@ -52,6 +52,15 @@ Control flow should only be used in Components.  This is currently not enforced
 
 The purpose of express_templates is to provide a foundation for a library of reusable UX components which we can enhance for drag-and-drop style UX construction and template editing.
 
+## Dependencies
+
+To set a label's "for" value, you must use a version of arbre that allows for this. Place this in your app:
+
+```ruby
+gem "arbre", github: "aelogica/arbre", branch: "tag_for"
+```
+
+See https://github.com/activeadmin/arbre/pull/49 for more details.
 
 ## Block Structure
 

data/lib/express_templates/components/forms/radio.rb

@@ -59,7 +59,7 @@ module ExpressTemplates
                 radio_button(resource_name, field_name.to_sym, key, class: 'radio')
                 label({
                   class: config[:label_wrapper_class],
-                  for: "#{resource_name}_#{field_name}_#{key}",
+                  for: [resource_name, field_name, key].join("_").downcase,
                 }) {
                   current_arbre_element.add_child value
                 }

data/lib/express_templates/version.rb

@@ -1,3 +1,3 @@
 module ExpressTemplates
-  VERSION = "0.11.9"
+  VERSION = "0.11.10"
 end

data/test/components/forms/radio_test.rb

@@ -103,7 +103,7 @@ class RadioTest < ActiveSupport::TestCase
   test "label_after is true, options specified is an array - label appears after the input" do
     html = arbre {
       express_form(:person) {
-        radio :subscribed, options: ['Yes', 'No'], label_after: true
+        radio :subscribed, options: ['Yes', 'No', 'IThinkSo'], label_after: true
       }
     }
 
@@ -117,6 +117,11 @@ class RadioTest < ActiveSupport::TestCase
     container_2 = radio_input_containers[1]
     assert_equal "input", container_2.element_children[0].name
     assert_equal "label", container_2.element_children[1].name
+
+    # Label's for value is downcased
+    container_3 = radio_input_containers[2]
+    for_attr = container_3.element_children[1].attributes['for']
+    assert_equal "person_subscribed_ithinkso", for_attr.value
   end
 
   test "label_after is true, options specified is a hash - label appears after the input" do
@@ -136,6 +141,10 @@ class RadioTest < ActiveSupport::TestCase
     container_2 = radio_input_containers[1]
     assert_equal "input", container_2.element_children[0].name
     assert_equal "label", container_2.element_children[1].name
+
+    # Label's for value is downcased
+    for_attr = container_2.element_children[1].attributes['for']
+    assert_equal "person_subscribed_1", for_attr.value
   end
 
   # test "radio supports html options"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: express_templates
 version: !ruby/object:Gem::Version
-  version: 0.11.9
+  version: 0.11.10
 platform: ruby
 authors:
 - Steven Talcott Smith
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-06 00:00:00.000000000 Z
+date: 2016-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport