explicit-parameters 0.0.3 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 95d2d462b480a386d2b59bd71ae9619c09c7906b
-  data.tar.gz: 81a74d049c309d8f2286a8b7f46e2567f765420d
+  metadata.gz: 9a6880bad37cdfc35abc3a08ffd8591df594dfa4
+  data.tar.gz: 4377837d9757eae083a2a20f41ff925066a39f11
 SHA512:
-  metadata.gz: ac43195c730d525dc5c713cca9ca2332528204d785981e734a6668d916aa5d489f3f2f0914ed834a1baace08cb7003ef48690e38ea7eb10df2e99c3d4f39d874
-  data.tar.gz: a837c8cc1181542b576dfc3363a2b45f6544b523c4718f144fc8466f57afcce46a9b140186a5a2cb6d5d5377efd0210c0e860eedc6517eb8ec0ad4754e255e0e
+  metadata.gz: 49b1ac6b9514b4d25351ef8028eec8e24a4468332b6457ddb540c0d46f3171e73a5d7a02fb60e1a8432bb6927eda3e4595c6078a2fa70b983213ae3480de9cb1
+  data.tar.gz: 8e4c49b64a93ef0e0a28d133ac749f15d48024c1c92eb2b128d73c9bdbfc87f29c7dd885ab9ec4645400a8e6f957f634d0dc4920b91e6eb5992308cf49385e56

data/lib/explicit_parameters/parameters.rb

@@ -33,7 +33,16 @@ module ExplicitParameters
       end
 
       def accepts(name, type = nil, options = {}, &block)
-        type = define(name, &block) if block_given?
+        if block_given?
+          subtype = define(name, &block)
+          if type == Array
+            type = Array[subtype]
+          elsif type == nil
+            type = subtype
+          else
+            raise ArgumentError, "`type` argument can only be `nil` or `Array` when a block is provided"
+          end
+        end
         attribute(name, type, options.slice(:default, :required))
         validations = options.except(:default)
         validations[:coercion] = true
@@ -66,7 +75,11 @@ module ExplicitParameters
     end
 
     def validate_attribute_provided!(attribute_name, value)
-      errors.add attribute_name, "is required" unless @original_attributes.key?(attribute_name.to_s)
+      if !@original_attributes.key?(attribute_name.to_s)
+        errors.add attribute_name, 'is required'
+      elsif attribute_set[attribute_name].type.primitive == Array && value == [].freeze
+        errors.add attribute_name, 'is required'
+      end
     end
 
     def validate_attribute_coercion!(attribute_name, value)

data/lib/explicit_parameters/version.rb

@@ -1,3 +1,3 @@
 module ExplicitParameters
-  VERSION = '0.0.3'
+  VERSION = '0.1.0'
 end

data/spec/parameters_spec.rb

@@ -89,4 +89,62 @@ RSpec.describe ExplicitParameters::Parameters do
       }.to raise_error(ExplicitParameters::InvalidParameters, message)
     end
   end
+
+  context 'with list of parameters' do
+    let :definition do
+      ExplicitParameters::Parameters.define(:nested) do
+        accepts :addresses, Array do
+          requires :street, String
+          requires :city, String
+        end
+      end
+    end
+
+    let :parameters do
+      {
+        'addresses' => [
+          {
+            'street' => '3575 St-Laurent',
+            'city' => 'Montréal',
+          }
+        ]
+      }
+    end
+
+    it 'the exposed parameter is an Array' do
+      expect(params.addresses).to be_an Array
+      expect(params.addresses.size).to be == 1
+    end
+
+    it 'parses nested hashes' do
+      expect(params.addresses.first.street).to be == '3575 St-Laurent'
+      expect(params.addresses.first.city).to be == 'Montréal'
+    end
+
+    context 'when required' do
+      let :definition do
+        ExplicitParameters::Parameters.define(:nested) do
+          requires :addresses, Array do
+            requires :street, String
+            requires :city, String
+          end
+        end
+      end
+
+      it 'reports missing attributes' do
+        message = {errors: {addresses: ['is required']}}.to_json
+        expect {
+          definition.parse!({})
+        }.to raise_error(ExplicitParameters::InvalidParameters, message)
+      end
+
+      it 'considers empty arrays as missing' do
+        message = {errors: {addresses: ['is required']}}.to_json
+        expect {
+          params = definition.parse!({'addresses' => []})
+          p params.addresses
+        }.to raise_error(ExplicitParameters::InvalidParameters, message)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: explicit-parameters
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-20 00:00:00.000000000 Z
+date: 2015-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -138,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Explicit parameters validation and casting for Rails APIs