explicit-parameters 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec2817ab57ba4b8b63d011702245fa8114de7a63
-  data.tar.gz: fead56598d7502cf39395af308febc40f148cd0d
+  metadata.gz: 95d2d462b480a386d2b59bd71ae9619c09c7906b
+  data.tar.gz: 81a74d049c309d8f2286a8b7f46e2567f765420d
 SHA512:
-  metadata.gz: 7840be0a953f0ede081f10539d918f2486ee899f86d3075e919a8db0212731f586cf49352b6f5423012938d96b28ba33fe0bf6140a98d2b5a873eef7e2b406d4
-  data.tar.gz: 2f8cfc543b901b3c64c6f41080cbe18f7b76cab75464e11f8741f48af55059eeba1edd451df2c0459eca385d1b6c9351c7e5fc11d2b2f83461f2889758f0d4c0
+  metadata.gz: ac43195c730d525dc5c713cca9ca2332528204d785981e734a6668d916aa5d489f3f2f0914ed834a1baace08cb7003ef48690e38ea7eb10df2e99c3d4f39d874
+  data.tar.gz: a837c8cc1181542b576dfc3363a2b45f6544b523c4718f144fc8466f57afcce46a9b140186a5a2cb6d5d5377efd0210c0e860eedc6517eb8ec0ad4754e255e0e

data/lib/explicit_parameters/parameters.rb

@@ -24,15 +24,16 @@ module ExplicitParameters
         new(params).validate!
       end
 
-      def define(&block)
-        Class.new(self, &block)
+      def define(name = nil, &block)
+        name_class(Class.new(self, &block), name)
       end
 
-      def requires(name, type, options = {}, &block)
-        accepts(name, type, options.merge(required: true))
+      def requires(name, type = nil, options = {}, &block)
+        accepts(name, type, options.merge(required: true), &block)
       end
 
-      def accepts(name, type, options = {}, &block)
+      def accepts(name, type = nil, options = {}, &block)
+        type = define(name, &block) if block_given?
         attribute(name, type, options.slice(:default, :required))
         validations = options.except(:default)
         validations[:coercion] = true
@@ -42,6 +43,16 @@ module ExplicitParameters
       def optional_attributes
         @optional_attributes ||= []
       end
+
+      private
+
+      def name_class(klass, name)
+        if name.present?
+          name = name.to_s.camelize
+          klass.singleton_class.send(:define_method, :name) { name }
+        end
+        klass
+      end
     end
 
     def initialize(attributes = {})
@@ -70,7 +81,7 @@ module ExplicitParameters
       super.except(*missing_attributes)
     end
 
-    delegate :each, to: :to_hash
+    delegate :each, :stringify_keys, to: :to_hash
     delegate :[], to: :@original_attributes
 
     private

data/lib/explicit_parameters/version.rb

@@ -1,3 +1,3 @@
 module ExplicitParameters
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/parameters_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 RSpec.describe ExplicitParameters::Parameters do
-  TestParameters = ExplicitParameters::Parameters.define do
-    requires :id, Integer
-    accepts :name, String
-    accepts :title, String, default: 'Untitled'
-
-    validates :id, numericality: {greater_than: 0}
+  let :definition do
+    ExplicitParameters::Parameters.define(:test) do
+      requires :id, Integer, numericality: {greater_than: 0}
+      accepts :name, String
+      accepts :title, String, default: 'Untitled'
+    end
   end
 
   let :parameters do
@@ -17,7 +17,7 @@ RSpec.describe ExplicitParameters::Parameters do
     }
   end
 
-  let(:params) { TestParameters.parse!(parameters.with_indifferent_access) }
+  let(:params) { definition.parse!(parameters.with_indifferent_access) }
 
   it 'casts parameters to the declared type' do
     expect(params.id).to be == 42
@@ -33,6 +33,15 @@ RSpec.describe ExplicitParameters::Parameters do
     end
   end
 
+  it 'ignores unexpected parameters when converted to hash' do
+    expect(params.to_hash.keys).to be == %i(id name)
+  end
+
+  it 'ignores unexpected parameters when converted to hash with string keys' do
+    expect(params.stringify_keys.keys).to be == %w(id name)
+  end
+
+
   it 'allows access to raw parameters when accessed like a Hash' do
     expect(params[:id]).to be == '42'
     expect(params[:unexpected]).to be == 'parameter'
@@ -41,7 +50,43 @@ RSpec.describe ExplicitParameters::Parameters do
   it 'can perform any type of active model validations' do
     message = {errors: {id: ['must be greater than 0']}}.to_json
     expect {
-      TestParameters.parse!('id' => -1)
+      definition.parse!('id' => -1)
     }.to raise_error(ExplicitParameters::InvalidParameters, message)
   end
+
+  context 'with nested parameters' do
+    let :definition do
+      ExplicitParameters::Parameters.define(:nested) do
+        requires :address do
+          requires :street, String
+          requires :city, String
+        end
+      end
+    end
+
+    let :parameters do
+      {
+        'address' => {
+          'street' => '3575 St-Laurent',
+          'city' => 'Montréal',
+        }
+      }
+    end
+
+    it 'parses expose the nested hash as a `Parameters` instance' do
+      expect(params.address).to be_an ExplicitParameters::Parameters
+    end
+
+    it 'parses nested hashes' do
+      expect(params.address.street).to be == '3575 St-Laurent'
+      expect(params.address.city).to be == 'Montréal'
+    end
+
+    it 'reports missing attributes' do
+      message = {errors: {address: ['is required']}}.to_json
+      expect {
+        definition.parse!({})
+      }.to raise_error(ExplicitParameters::InvalidParameters, message)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: explicit-parameters
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-12 00:00:00.000000000 Z
+date: 2015-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -138,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Explicit parameters validation and casting for Rails APIs