explicit-parameters 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6bd7f4d53421eeef0b59aef942588c4796600ccc
-  data.tar.gz: df62f44750a434068d5ee6dc03d19805a4b736db
+  metadata.gz: ec2817ab57ba4b8b63d011702245fa8114de7a63
+  data.tar.gz: fead56598d7502cf39395af308febc40f148cd0d
 SHA512:
-  metadata.gz: fab71e754354bfb120bd38a17e08f7d16af14e5b6dbc240a55ab3d95b785d83a86d81bf12f293d3ea5dd213d678f6bc1f82ba08d519a94deb32565b9df658836
-  data.tar.gz: 6180cc1a0871ca98b71a40b1f5ab8ce317e558fbe48f28961213981e04f929b5e040dc5e08dc5b4c39d667c62b8637ca5e49b84e544d28ec1aac7b4048cfad28
+  metadata.gz: 7840be0a953f0ede081f10539d918f2486ee899f86d3075e919a8db0212731f586cf49352b6f5423012938d96b28ba33fe0bf6140a98d2b5a873eef7e2b406d4
+  data.tar.gz: 2f8cfc543b901b3c64c6f41080cbe18f7b76cab75464e11f8741f48af55059eeba1edd451df2c0459eca385d1b6c9351c7e5fc11d2b2f83461f2889758f0d4c0

data/README.md

@@ -11,7 +11,7 @@ Explicit parameters validation and casting for Rails APIs.
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'explicit_parameters'
+gem 'explicit-parameters'
 ```
 
 And then execute:

data/lib/explicit_parameters/controller.rb

@@ -9,7 +9,6 @@ module ExplicitParameters
     end
 
     included do
-      self.parameters = {}
       rescue_from ExplicitParameters::InvalidParameters, with: :render_parameters_error
     end
 
@@ -18,6 +17,7 @@ module ExplicitParameters
 
       def method_added(action)
         return unless Controller.last_parameters
+        self.parameters ||= {}
         parameters[action.to_s] = Controller.last_parameters
         const_set("#{action.to_s.camelize}Parameters", Controller.last_parameters)
         Controller.last_parameters = nil
@@ -28,7 +28,7 @@ module ExplicitParameters
       end
 
       def parse_parameters_for(action_name, params)
-        if declaration = parameters[action_name]
+        if declaration = parameters.try!(:[], action_name)
           declaration.parse!(params)
         else
           params
@@ -36,12 +36,20 @@ module ExplicitParameters
       end
     end
 
-    private
-
     def params
       @validated_params ||= self.class.parse_parameters_for(action_name, super)
     end
 
+    private
+
+    def param_error!(parameter, error)
+      raise ExplicitParameters::InvalidParameters.new({errors: {parameter => [error]}}.to_json)
+    end
+
+    def render_param_error(parameter, error)
+      render json: {errors: {parameter => [error]}}, status: :unprocessable_entity
+    end
+
     def render_parameters_error(error)
       render json: error.message, status: :unprocessable_entity
     end

data/lib/explicit_parameters/version.rb

@@ -1,3 +1,3 @@
 module ExplicitParameters
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/spec/controller_spec.rb

@@ -11,6 +11,11 @@ class DummyController < ActionController::Base
     render json: {value: params.page_size, type: params.page_size.class.name}
   end
 
+  def error
+    param_error!(:page_size, "Out of bound")
+    render text: 'OK'
+  end
+
   def no_declaration
     render text: 'OK'
   end
@@ -38,6 +43,11 @@ RSpec.describe DummyController do
     expect(json_response).to be == {errors: {page_size: ['"foobar" is not a valid Integer']}}
   end
 
+  it 'param_error! interupt the request immediately' do
+    get :error
+    expect(json_response).to be == {errors: {page_size: ['Out of bound']}}
+  end
+
   private
 
   attr_reader :response

data/spec/spec_helper.rb

@@ -9,7 +9,6 @@ RSpec.configure do |config|
     mocks.verify_partial_doubles = true
   end
   config.disable_monkey_patching!
-  config.warnings = true
   config.order = :random
   Kernel.srand config.seed
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: explicit-parameters
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-22 00:00:00.000000000 Z
+date: 2015-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack