expiry_calculator 0.1.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad6d87c333e5705c279b6e3748bb04ecf330d800639523d7d74e564b5c489bcf
-  data.tar.gz: 3185b744a8f58e03e2081ab989b830c1408103683c40a5d59e1ca1e7a9af95c6
+  metadata.gz: 20c65ef7789b9298cb92e17c86dc149dea2be400a247b7d834e73112af558daf
+  data.tar.gz: 12978914c8fdce252365e71420b543b0b2d650e105930714905e400507d7154c
 SHA512:
-  metadata.gz: 92c3278652f83e8eb201b5d7c7f52db31fc17025c645ec803127bd08b27c4660a15d4a8582fc29ea26448b188b76b5db5cf768a92ec92b6c11ab5d3bbd509617
-  data.tar.gz: 472bc6e4be4827d1030475a005c7f6fb132f4435a1c5597e5f21d15b5f084533b715f32f03041021439698b0757c72e909af6bf4470a384e876033b6c66b31d4
+  metadata.gz: 31067b24785e34031d86dc973ab10356e0554b8f64b335b0222c22df0153aaa26a29127bd9fed367f0ada84d94d7f6de9df44b22ac93ee931854379bacaf030f
+  data.tar.gz: b88a4065ec7755a7c0f54fa5613a6d4130cb1892aca27f0bf513e3f02b81f62c8d7966097456cd087444707c80f353eef34477b577388029686e8750c9df6c12

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [0.2.0] - 2025-04-04
+
+- Fix: type check bug for ActiveRecord inputs.
+- Tests: add more coverage for parameters support.
+
 ## [0.1.0] - 2025-03-17
 
 - Initial release.

data/README.md

@@ -2,6 +2,8 @@
 
 [![Gem Version](https://badge.fury.io/rb/expiry_calculator.svg)](https://rubygems.org/gems/expiry_calculator)
 [![Build](https://github.com/abarrak/expiry_calculator/actions/workflows/ci.yml/badge.svg)](https://github.com/abarrak/expiry_calculator/actions/workflows/ci.yml)
+[![Code Coverage](https://qlty.sh/badges/26185eb3-29df-401a-b266-ce7123b55fc3/test_coverage.svg)](https://qlty.sh/gh/abarrak/projects/expiry_calculator)
+[![Maintainability](https://qlty.sh/badges/26185eb3-29df-401a-b266-ce7123b55fc3/maintainability.svg)](https://qlty.sh/gh/abarrak/projects/expiry_calculator)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 
 
@@ -68,7 +70,7 @@ The supported objects:
 
 ## API Docs
 
-The gem specs can [be found at RubyDocs.](https://www.rubydoc.info/gems/network-client/)
+The gem specs can [be found at RubyDocs.](https://www.rubydoc.info/gems/expiry_calculator)
 
 ## Contributing
 

data/lib/expiry_calculator/logic.rb

@@ -5,23 +5,26 @@ module ExpiryCalculator
     #
     # == Parameters:
     #
-    # [*record*] +Date|DateTime|ApplicationRecord+: field of date and time to caluclate expiry for. Can be activerecord model containing a date field.
+    # [*record*] +Date|DateTime|String|ApplicationRecord+: field of date and time to caluclate expiry for. Can be activerecord model containing a date field.
     # [*record_attr*] +symbol|string+ The date attribute field in case of active record model is passed in first arguemtn. Default to nil.
     #
     # == Returns:
     #
     # The remaining days till the expiry, or zero if it already past.
     #
+    # == Note:
+    # ref# for AR special check case:
+    # https://github.com/rails/rails/blob/04cda1848cb847c2bdad0bfc12160dc8d5547775/activerecord/lib/active_record/core.rb#L135
     #
     def calculate record, record_attr = nil
       expiry_date = case record
-      when Date
-        record
       when DateTime
         record
+      when Date
+        record
       when String
         DateTime.parse(record)
-      when ->(r) { defined?(ApplicationRecord) && r === ApplicationRecord }
+      when ->(r) { defined?(ActiveRecord::Base) && r.is_a?(ActiveRecord::Base) }
         record[record_attr.to_sym]
       else
         raise ArgumentError, "record type not supported."

data/lib/expiry_calculator/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ExpiryCalculator
-  VERSION = "0.1.0"
+  VERSION = "0.3.0"
 end

data/sig/expiry_calculator.rbs

@@ -1,4 +1,7 @@
 module ExpiryCalculator
   VERSION: String
-  # See the writing guide of rbs: https://github.com/ruby/rbs#guides
+
+  module Logic
+    def calculate: (Date | DateTime | String | ActiveRecord::Base record, String record_attr) -> Integer
+  end
 end

data/sig/manifest.yaml

@@ -0,0 +1,3 @@
+dependencies:
+  - name: date
+  - name: activerecord

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: expiry_calculator
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Abdullah Barrak
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-03-23 00:00:00.000000000 Z
+date: 2025-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -110,6 +110,48 @@ dependencies:
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '7'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '7'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2'
+- !ruby/object:Gem::Dependency
+  name: rbs
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -141,6 +183,7 @@ files:
 - lib/expiry_calculator/logic.rb
 - lib/expiry_calculator/version.rb
 - sig/expiry_calculator.rbs
+- sig/manifest.yaml
 homepage: https://rubygems.org/gems/expiry_calculator
 licenses:
 - MIT