experimental 0.2.5 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bfb5dca3b1f51e5d7c288e7d61c91bdf770b7f8b
-  data.tar.gz: ed36f94920862534016e94a3af96cb450abe69d3
+  metadata.gz: 1cbc23d7d4d559525acef4a4a02acc8f6129dddc
+  data.tar.gz: c90758e9493e4c965af09a9d0dc98c58d7fb4e53
 SHA512:
-  metadata.gz: 8df805c7887851dfe3d08670355b6165b98ce5e6f4afd9d6a850cd61cc4ced9fe5ab5f0f72a12dee77031ad7e4d44eeb5d7a7746038b8ea6943a3c1a276b8c12
-  data.tar.gz: 56bd5327657737cb6400291aafefa48704d6d90c286aea3bdb18c306e4f941cae57c07941326bbd15f02ff38617576860dc3ed3ec5892b9dfa7fefed8ad85452
+  metadata.gz: 8915404bdb3ce651853d2002598b113612561a87414062f97b8a3ef177beeac52cf6d203509c18d0af1ba2ba0506221a9468397f769362a647e9ebe3e1451e3e
+  data.tar.gz: 539a9ba09dc190a9983e1c558efff665f88759badd8e727a767154448f625e4b9d6d04c40597755c1cc44565f1a92ada9cc2ca897f8561ab3452b0622bfdd67f

data/app/models/experimental/experiment.rb

@@ -42,7 +42,7 @@ module Experimental
         winning_bucket
       elsif Experimental.overrides.include?(subject, name)
         Experimental.overrides[subject, name]
-      else
+      elsif started?
         bucket_number(subject)
       end
     end
@@ -63,6 +63,14 @@ module Experimental
       save
     end
 
+    def unstart
+      self.start_date = nil
+      self.end_date = nil
+      self.removed_at = nil
+      self.winning_bucket = nil
+      save
+    end
+
     def restart
       return unless ended?
 
@@ -90,12 +98,16 @@ module Experimental
       !removed_at.nil?
     end
 
+    def started?
+      start_date.present? && start_date <= Time.now
+    end
+
     def ended?
       !end_date.nil? && Time.now > end_date
     end
 
     def active?
-      !removed? && !ended?
+      !removed? && started? && !ended?
     end
 
     def self.available
@@ -103,7 +115,8 @@ module Experimental
     end
 
     def self.active
-      available.where(['end_date IS NULL OR ? <= end_date', Time.now])
+      now = Time.now
+      available.where('start_date < ? AND end_date IS NULL OR ? <= end_date', now, now)
     end
 
     def to_sql_formula(subject_table = "users")

data/lib/experimental/loader.rb

@@ -14,10 +14,17 @@ module Experimental
       Experimental::Experiment.transaction do
         active = Experimental.experiment_data.map do |name, attributes|
           experiment = Experimental::Experiment.find_or_initialize_by_name(name)
-          logger.info "  * #{experiment.id ? 'updating' : 'creating'} #{name}"
+
+          unstarted = attributes.delete('unstarted')
           defaults = {'num_buckets' => nil, 'notes' => nil, 'population' => nil}
           experiment.assign_attributes(defaults.merge(attributes))
-          experiment.start_date ||= Time.now
+          if unstarted
+            experiment.start_date = nil
+          else
+            experiment.start_date ||= Time.current
+          end
+
+          logger.info "  * #{experiment.id ? 'updating' : 'creating'} #{name}"
           experiment.tap(&:save!)
         end
 

data/lib/experimental/middleware.rb

@@ -0,0 +1,11 @@
+module Experimental
+  class Middleware
+    def initialize(app)
+      @app = app
+    end
+
+    def call(env)
+      @app.call(env)
+    end
+  end
+end

data/lib/experimental/version.rb

@@ -1,5 +1,5 @@
 module Experimental
-  VERSION = [0, 2, 5]
+  VERSION = [0, 3, 0]
 
   class << VERSION
     include Comparable

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: experimental
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.3.0
 platform: ruby
 authors:
 - HowAboutWe.com
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-27 00:00:00.000000000 Z
+date: 2014-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -65,6 +65,7 @@ files:
 - lib/experimental/controller_actions.rb
 - lib/experimental/engine.rb
 - lib/experimental/loader.rb
+- lib/experimental/middleware.rb
 - lib/experimental/overrides.rb
 - lib/experimental/railtie.rb
 - lib/experimental/rspec_helpers.rb
@@ -103,7 +104,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Adds support for database-backed AB tests in Rails apps