exlibris-primo 1.1.2 → 1.1.3

Sign up to get free protection for your applications and to get access to all the features.
Files changed (5) hide show
  1. data/lib/exlibris/primo/pnx/frbr.rb +8 -3
  2. data/lib/exlibris/primo/version.rb +1 -1
  3. data/test/pnx/frbr_test.rb +7 -0
  4. data/test/test_helper.rb +178 -0
  5. metadata +12 -12
data/lib/exlibris/primo/pnx/frbr.rb CHANGED
@@ -1,15 +1,20 @@
1
1
  module Exlibris
2
2
  module Primo
3
3
  module Pnx
4
- #
4
+ #
5
5
  # Handle frbr records
6
- #
6
+ #
7
7
  module Frbr
8
8
  #
9
9
  # Is this a frbr'd record
10
10
  #
11
11
  def frbr?
12
- @frbr ||= (respond_to? :facets_frbrgroupid)
12
+ if (respond_to? :facets_frbrgroupid) && (facets_frbrtype != "6")
13
+ @frbr = true
14
+ else
15
+ @frbr = false
16
+ end
17
+ @frbr
13
18
  end
14
19
 
15
20
  #
data/lib/exlibris/primo/version.rb CHANGED
@@ -1,5 +1,5 @@
1
1
  module Exlibris
2
2
  module Primo
3
- VERSION = "1.1.2"
3
+ VERSION = "1.1.3"
4
4
  end
5
5
  end
data/test/pnx/frbr_test.rb CHANGED
@@ -8,5 +8,12 @@ module Pnx
8
8
  assert((not record.frbr_id.blank?))
9
9
  assert_equal "49340863", record.frbr_id
10
10
  end
11
+
12
+ def test_invalid_frbr
13
+ record = Exlibris::Primo::Record.new(:raw_xml => record_invalid_frbr_xml)
14
+ assert_equal false,record.frbr?
15
+ assert_nil record.frbr_id
16
+ assert(record.frbr_id.blank?)
17
+ end
11
18
  end
12
19
  end
data/test/test_helper.rb CHANGED
@@ -559,5 +559,183 @@ class Test::Unit::TestCase
559
559
  "</addata>"+
560
560
  "</record>"
561
561
  end
562
+
563
+ def record_invalid_frbr_xml
564
+ "<record>"+
565
+ "<control>"+
566
+ "<sourcerecordid>000062856</sourcerecordid>"+
567
+ "<sourceid>nyu_aleph</sourceid>"+
568
+ "<recordid>nyu_aleph000062856</recordid>"+
569
+ "<originalsourceid>NYU01</originalsourceid>"+
570
+ "<ilsapiid>NYU01000062856</ilsapiid>"+
571
+ "<sourceformat>MARC21</sourceformat>"+
572
+ "<sourcesystem>Aleph</sourcesystem>"+
573
+ "</control>"+
574
+ "<display>"+
575
+ "<type>book</type>"+
576
+ "<title>Travels with my aunt</title>"+
577
+ "<creator>Graham Greene 1904-1991.</creator>"+
578
+ "<edition>Deluxe ed.</edition>"+
579
+ "<publisher>New York : Penguin Books</publisher>"+
580
+ "<creationdate>2004</creationdate>"+
581
+ "<format>xvi, 254 p. ; 22 cm.</format>"+
582
+ "<identifier>$$Cisbn$$V0143039008; $$Cisbn$$V9780143039006</identifier>"+
583
+ "<subject>British -- Foreign countries -- Fiction; Women travelers -- Fiction; Older women -- Fiction; Travelers -- Fiction; Retirees -- Fiction; Aunts -- Fiction; Humorous stories</subject>"+
584
+ "<language>eng</language>"+
585
+ "<relation>$$Cseries $$VPenguin classics</relation>"+
586
+ "<source>nyu_aleph</source>"+
587
+ "<availlibrary>$$INYU$$LBOBST$$1Main Collection$$2(PR6013.R44 T7 2004 )$$Sunavailable$$31$$41$$5N$$61$$XNYU50$$YBOBST$$ZMAIN</availlibrary>"+
588
+ "<lds02>nyu_aleph000062856</lds02>"+
589
+ "<lds01>NYU</lds01>"+
590
+ "<availinstitution>$$INYU$$Sunavailable</availinstitution>"+
591
+ "<availpnx>unavailable</availpnx>"+
592
+ "</display>"+
593
+ "<links>"+
594
+ "<openurl>$$Topenurl_journal</openurl>"+
595
+ "<backlink>$$Taleph_backlink$$DMore bibliographic information</backlink>"+
596
+ "<thumbnail>$$Tamazon_thumb</thumbnail>"+
597
+ "<linktotoc>$$Tamazon_toc$$DCheck for Amazon Search Inside</linktotoc>"+
598
+ "<openurlfulltext>$$Topenurlfull_journal</openurlfulltext>"+
599
+ "<linktoholdings>$$Taleph_holdings</linktoholdings>"+
600
+ "<linktoreview>$$TpersistentUrl$$DCopy item link</linktoreview>"+
601
+ "<linktouc>$$Tamazon_uc$$DCheck Amazon</linktouc>"+
602
+ "<linktouc>$$Tworldcat_isbn$$DCheck other libraries (WorldCat&#xAE;)</linktouc>"+
603
+ "<linktoexcerpt>$$Tsyndetics_excerpt$$DExcerpt from item</linktoexcerpt>"+
604
+ "</links>"+
605
+ "<search>"+
606
+ "<creatorcontrib>Graham, Greene 1904-1991.</creatorcontrib>"+
607
+ "<creatorcontrib>Greene, Graham, 1904-1991.</creatorcontrib>"+
608
+ "<creatorcontrib>Greene, G</creatorcontrib>"+
609
+ "<creatorcontrib>Graham Greene ; introduction by Gloria Emerson.</creatorcontrib>"+
610
+ "<creatorcontrib>Greene, Henry Graham, 1904-1991</creatorcontrib>"+
611
+ "<creatorcontrib>G&#x16D;rin, G&#x16D;re&#x14F;m, 1904-1991</creatorcontrib>"+
612
+ "<creatorcontrib>Grin, Greham, 1904-1991</creatorcontrib>"+
613
+ "<creatorcontrib>Gr&#x12B;na, Gr&#x101;hama, 1904-1991</creatorcontrib>"+
614
+ "<creatorcontrib>Grin, Gr&#x117;m, 1904-1991</creatorcontrib>"+
615
+ "<creatorcontrib>&#x683C;&#x62C9;&#x59C6;&#x30FB;&#x845B;&#x6797;, 1904-1991</creatorcontrib>"+
616
+ "<creatorcontrib>Gr&#x12B;ns, Greiems, 1904-1991</creatorcontrib>"+
617
+ "<creatorcontrib>Gr&#x12B;ns, G. (Greiems), 1904-1991</creatorcontrib>"+
618
+ "<title>Travels with my aunt /</title>"+
619
+ "<subject>British Foreign countries Fiction</subject>"+
620
+ "<subject>Women travelers Fiction</subject>"+
621
+ "<subject>Older women Fiction</subject>"+
622
+ "<subject>Travelers Fiction</subject>"+
623
+ "<subject>Retirees Fiction</subject>"+
624
+ "<subject>Aunts Fiction</subject>"+
625
+ "<subject>Humorous stories</subject>"+
626
+ "<subject>People, Retired</subject>"+
627
+ "<subject>Retired persons</subject>"+
628
+ "<subject>Retired people</subject>"+
629
+ "<subject>Travelers, Women</subject>"+
630
+ "<subject>Britishers</subject>"+
631
+ "<subject>British people</subject>"+
632
+ "<subject>Britons (British)</subject>"+
633
+ "<subject>Brits</subject>"+
634
+ "<subject>Aged women</subject>"+
635
+ "<general>Penguin Books,</general>"+
636
+ "<general>\"Graham Greene centennial, 1904-2004\"--Cover.</general>"+
637
+ "<sourceid>nyu_aleph</sourceid>"+
638
+ "<recordid>nyu_aleph000062856</recordid>"+
639
+ "<isbn>0143039008</isbn>"+
640
+ "<isbn>9780143039006</isbn>"+
641
+ "<isbn>9780143&quot;0390069</isbn>"+
642
+ "<rsrctype>book</rsrctype>"+
643
+ "<creationdate>2004</creationdate>"+
644
+ "<creationdate>1969</creationdate>"+
645
+ "<addtitle>Penguin classics</addtitle>"+
646
+ "<searchscope>BOBST</searchscope>"+
647
+ "<searchscope>BOBST Main Collection</searchscope>"+
648
+ "<searchscope>nyu_aleph</searchscope>"+
649
+ "<searchscope>NYU</searchscope>"+
650
+ "<scope>BOBST</scope>"+
651
+ "<scope>BOBST Main Collection</scope>"+
652
+ "<scope>nyu_aleph</scope>"+
653
+ "<scope>NYU</scope>"+
654
+ "<lsr01>PR6013.R44 T7 2004</lsr01>"+
655
+ "<lsr01>PR6013 .R44 T7 2004</lsr01>"+
656
+ "<lsr02>Penguin Books,</lsr02>"+
657
+ "</search>"+
658
+ "<sort>"+
659
+ "<title>Travels with my aunt /</title>"+
660
+ "<creationdate>2004</creationdate>"+
661
+ "<author>Greene, Graham, 1904-1991.</author>"+
662
+ "<lso01>2004</lso01>"+
663
+ "</sort>"+
664
+ "<facets>"+
665
+ "<language>eng</language>"+
666
+ "<creationdate>2004</creationdate>"+
667
+ "<topic>British&#x2013;Foreign countries&#x2013;Fiction</topic>"+
668
+ "<topic>Women travelers&#x2013;Fiction</topic>"+
669
+ "<topic>Older women&#x2013;Fiction</topic>"+
670
+ "<topic>Travelers&#x2013;Fiction</topic>"+
671
+ "<topic>Retirees&#x2013;Fiction</topic>"+
672
+ "<topic>Aunts&#x2013;Fiction</topic>"+
673
+ "<collection>BOBST</collection>"+
674
+ "<prefilter>books</prefilter>"+
675
+ "<rsrctype>books</rsrctype>"+
676
+ "<creatorcontrib>Greene, G</creatorcontrib>"+
677
+ "<genre>Fiction</genre>"+
678
+ "<genre>Humorous stories</genre>"+
679
+ "<library>BOBST</library>"+
680
+ "<lfc01>Main Collection</lfc01>"+
681
+ "<classificationlcc>P - Language and literature.&#x2013;English literature</classificationlcc>"+
682
+ "<frbrgroupid>49340863</frbrgroupid>"+
683
+ "<frbrtype>6</frbrtype>"+
684
+ "</facets>"+
685
+ "<dedup>"+
686
+ "<t>1</t>"+
687
+ "<c1>2004559272</c1>"+
688
+ "<c2>0143039008;9780143039006</c2>"+
689
+ "<c3>travelswithmyaunt</c3>"+
690
+ "<c4>2004</c4>"+
691
+ "<f1>2004559272</f1>"+
692
+ "<f3>0143039008;9780143039006</f3>"+
693
+ "<f5>travelswithmyaunt</f5>"+
694
+ "<f6>2004</f6>"+
695
+ "<f7>travels with my aunt</f7>"+
696
+ "<f8>nyu</f8>"+
697
+ "<f9>xvi, 254 p. ;</f9>"+
698
+ "<f10>penguin books</f10>"+
699
+ "<f11>greene graham 1904 1991</f11>"+
700
+ "</dedup>"+
701
+ "<frbr>"+
702
+ "<t>1</t>"+
703
+ "<k1>$$Kgreene graham 1904 1991$$AA</k1>"+
704
+ "<k3>$$Kbooktravels with my aunt$$AT</k3>"+
705
+ "</frbr>"+
706
+ "<delivery>"+
707
+ "<institution>NYU</institution>"+
708
+ "<delcategory>Physical Item</delcategory>"+
709
+ "</delivery>"+
710
+ "<enrichment>"+
711
+ "<classificationlcc>PR6013.R44</classificationlcc>"+
712
+ "</enrichment>"+
713
+ "<ranking>"+
714
+ "<booster1>1</booster1>"+
715
+ "<booster2>1</booster2>"+
716
+ "</ranking>"+
717
+ "<addata>"+
718
+ "<aulast>Greene</aulast>"+
719
+ "<aufirst>Graham,</aufirst>"+
720
+ "<au>Greene, Graham, 1904-1991</au>"+
721
+ "<btitle>Travels with my aunt</btitle>"+
722
+ "<seriestitle>Penguin classics</seriestitle>"+
723
+ "<date>2004</date>"+
724
+ "<risdate>2004.</risdate>"+
725
+ "<isbn>0143039008</isbn>"+
726
+ "<isbn>9780143039006</isbn>"+
727
+ "<format>book</format>"+
728
+ "<genre>book</genre>"+
729
+ "<ristype>BOOK</ristype>"+
730
+ "<notes>Includes bibliographical references (p. xv-xvi).</notes>"+
731
+ "<cop>New York</cop>"+
732
+ "<pub>Penguin Books</pub>"+
733
+ "<oclcid>56781200</oclcid>"+
734
+ "<lccn>2004559272</lccn>"+
735
+ "<lad01>BOBST</lad01>"+
736
+ "<lad01>Physical Item</lad01>"+
737
+ "</addata>"+
738
+ "</record>"
739
+ end
562
740
  end
563
741
 
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: exlibris-primo
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.1.2
4
+ version: 1.1.3
5
5
  prerelease:
6
6
  platform: ruby
7
7
  authors:
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2013-11-20 00:00:00.000000000 Z
12
+ date: 2013-12-17 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: require_all
@@ -32,7 +32,7 @@ dependencies:
32
32
  requirement: !ruby/object:Gem::Requirement
33
33
  none: false
34
34
  requirements:
35
- - - ~>
35
+ - - ! '>='
36
36
  - !ruby/object:Gem::Version
37
37
  version: 3.2.14
38
38
  type: :runtime
@@ -40,7 +40,7 @@ dependencies:
40
40
  version_requirements: !ruby/object:Gem::Requirement
41
41
  none: false
42
42
  requirements:
43
- - - ~>
43
+ - - ! '>='
44
44
  - !ruby/object:Gem::Version
45
45
  version: 3.2.14
46
46
  - !ruby/object:Gem::Dependency
@@ -98,7 +98,7 @@ dependencies:
98
98
  requirements:
99
99
  - - ~>
100
100
  - !ruby/object:Gem::Version
101
- version: 0.1.0
101
+ version: 0.2.0
102
102
  type: :runtime
103
103
  prerelease: false
104
104
  version_requirements: !ruby/object:Gem::Requirement
@@ -106,7 +106,7 @@ dependencies:
106
106
  requirements:
107
107
  - - ~>
108
108
  - !ruby/object:Gem::Version
109
- version: 0.1.0
109
+ version: 0.2.0
110
110
  - !ruby/object:Gem::Dependency
111
111
  name: rake
112
112
  requirement: !ruby/object:Gem::Requirement
@@ -130,7 +130,7 @@ dependencies:
130
130
  requirements:
131
131
  - - ~>
132
132
  - !ruby/object:Gem::Version
133
- version: 2.5.0
133
+ version: 2.8.0
134
134
  type: :development
135
135
  prerelease: false
136
136
  version_requirements: !ruby/object:Gem::Requirement
@@ -138,7 +138,7 @@ dependencies:
138
138
  requirements:
139
139
  - - ~>
140
140
  - !ruby/object:Gem::Version
141
- version: 2.5.0
141
+ version: 2.8.0
142
142
  - !ruby/object:Gem::Dependency
143
143
  name: webmock
144
144
  requirement: !ruby/object:Gem::Requirement
@@ -146,7 +146,7 @@ dependencies:
146
146
  requirements:
147
147
  - - ~>
148
148
  - !ruby/object:Gem::Version
149
- version: 1.13.0
149
+ version: 1.16.0
150
150
  type: :development
151
151
  prerelease: false
152
152
  version_requirements: !ruby/object:Gem::Requirement
@@ -154,7 +154,7 @@ dependencies:
154
154
  requirements:
155
155
  - - ~>
156
156
  - !ruby/object:Gem::Version
157
- version: 1.13.0
157
+ version: 1.16.0
158
158
  - !ruby/object:Gem::Dependency
159
159
  name: pry
160
160
  requirement: !ruby/object:Gem::Requirement
@@ -425,7 +425,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
425
425
  version: '0'
426
426
  segments:
427
427
  - 0
428
- hash: -4257247638652406024
428
+ hash: 2856563247553878909
429
429
  required_rubygems_version: !ruby/object:Gem::Requirement
430
430
  none: false
431
431
  requirements:
@@ -434,7 +434,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
434
434
  version: '0'
435
435
  segments:
436
436
  - 0
437
- hash: -4257247638652406024
437
+ hash: 2856563247553878909
438
438
  requirements: []
439
439
  rubyforge_project:
440
440
  rubygems_version: 1.8.25