exjournal 0.1.0 → 0.1.1

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/lib/exjournal.rb

@@ -2,8 +2,18 @@ require 'action_mailer'
 require 'tmail'
 
 module Exjournal
+  class << self
+    def logger=(l)
+      @logger=l
+    end
+
+    def logger
+      @logger ||= Logger.new($stderr)
+    end
+  end
+
   module_function
-  
+
   # extract the first message/rfc822 attachment from the RFC822 encoded content, and return it as a TMail::Mail
   # if +headers_only+ is true then message content will be discarded, and only headers processed
   def extract_journalled_mail(mail, strip_content=true)
@@ -45,9 +55,17 @@ module Exjournal
     {:name=>address.name, :address=>address.address}
   end
 
-  # parse one or more addresses to hash
+  # parse one or more addresses to hash. failures result in a warning logged
   def parse_addresses(addresses)
-    [*(addresses||[])].map{|a| parse_address(a)}
+    [*(addresses||[])].map do |a| 
+      begin
+        parse_address(a)
+      rescue Exception=>e
+        logger.warn("failure parsing: #{a}")
+        logger.warn(e)
+        nil
+      end
+    end.compact
   end
 
   # turn a TMail::Mail into a has suitable for JSON representation

data/spec/exjournal_spec.rb

@@ -85,6 +85,13 @@ Subject: i can't tell you
       h.should == [{:name=>"foo mcfoo", :address=>"foo@bar.com"},
                    {:name=>"baz mcbaz", :address=>"baz@boo.com"}]
     end
+
+    it "should skip unparseable addresses and log a warning" do
+      mock(Exjournal.logger).warn(anything).times(2)
+      h = Exjournal.parse_addresses(['"foo mcfoo" <foo@bar.com>',
+                                     '"baz mcbaz" <<baz@boo.com>'])
+      h.should == [{:name=>"foo mcfoo", :address=>"foo@bar.com"}]
+    end
   end
 
   describe "mail_to_hash" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: exjournal
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: 
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Trampoline Systems Ltd