exifr 1.3.6 → 1.3.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 74d218b251891a0cf7e748402bc6e357c4ad3dfc3aa5aefa293372f60921a1be
-  data.tar.gz: 3d4d4d8b073067bba935cce965007feed1ce04aff3b0043c31caedd64dd4b6f2
+  metadata.gz: 97fa3270a4d14398a02e6bd725753980ae12b74c2f0a6e3c160b840c59c7febf
+  data.tar.gz: ec8ed547c94ad6dd83c0a07bb78530408d48637b18edfeb68dcb157a55c5c618
 SHA512:
-  metadata.gz: 3c785eff92ad9eb5c05599c6312a927764c602d26adb7e026e00218bdb6a52d98f79f113b7bc2c0784d207c83357ba787354f871edefac1c8ab18017f6b5160f
-  data.tar.gz: 03fe558a81381a3e49c36d1e7bbabe4e8831c1332c191267a7c8a56820dbcc56c478cb0727dd1407ccad64afb0b1ce2f4341218fead72e73fbee8dfe2a49a53a
+  metadata.gz: 3d10126d25f29634c46c8b5dce11ebd9dbc373c02fc892a74cdb8cbf6aa3cef8086e2a6be2eaac2a65bc83fa64a6f517617e22dc47bc4ea56db631b678a3ee3a
+  data.tar.gz: b98ee638dc85ab51c1f86d5b9c34c417047a79d2abb920ee8a13e7decfaf8b66fb484d7d804461de276a3f87fd40f5e30c1a420e3b25e46db51e801f77acc9c3

data/Gemfile

@@ -1,2 +1,2 @@
-source :rubygems
+source "https://rubygems.org"
 gemspec

data/Rakefile

@@ -1,4 +1,4 @@
-# Copyright (c) 2006-2017 - R.W. van 't Veer
+# Copyright (c) 2006-2020 - R.W. van 't Veer
 
 require 'rake/testtask'
 

data/lib/exifr/jpeg.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2006-2017 - R.W. van 't Veer
+# Copyright (c) 2006-2020 - R.W. van 't Veer
 
 require 'exifr'
 require 'exifr/tiff'

data/lib/exifr/tiff.rb

@@ -331,7 +331,9 @@ module EXIFR
 
     class Degrees < Array
       def initialize(arr)
-        raise "expected [degrees, minutes, seconds]" unless arr.length == 3
+        unless arr.length == 3 && arr.all?{|v| Rational === v}
+          raise "expected [degrees, minutes, seconds]; got #{arr.inspect}"
+        end
         super
       end
 
@@ -384,7 +386,12 @@ module EXIFR
         @jpeg_thumbnails = @ifds.map do |v|
           if v.jpeg_interchange_format && v.jpeg_interchange_format_length
             start, length = v.jpeg_interchange_format, v.jpeg_interchange_format_length
-            data[start..(start + length)]
+            if Integer === start && Integer === length
+              data[start..(start + length)]
+            else
+              EXIFR.logger.warn("Non numeric JpegInterchangeFormat data")
+              nil
+            end
           end
         end.compact
       end
@@ -475,24 +482,26 @@ module EXIFR
     end
 
     class IFD # :nodoc:
-      attr_reader :type, :fields, :offset
+      attr_reader :type, :raw_fields, :fields, :offset
 
       def initialize(data, offset = nil, type = :image)
-        @data, @offset, @type, @fields = data, offset, type, {}
+        @data, @offset, @type, @raw_fields, @fields = data, offset, type, {}, {}
 
         pos = offset || @data.readlong(4)
         num = @data.readshort(pos)
-        pos += 2
 
-        num.times do
-          add_field(Field.new(@data, pos))
-          pos += 12
-        end
+        if pos && num
+          pos += 2
 
-        @offset_next = @data.readlong(pos)
+          num.times do
+            add_field(Field.new(@data, pos))
+            pos += 12
+          end
+
+          @offset_next = @data.readlong(pos)
+        end
       rescue => ex
         EXIFR.logger.warn("Badly formed IFD: #{ex}")
-        @offset_next = 0
       end
 
       def method_missing(method, *args)
@@ -520,7 +529,7 @@ module EXIFR
       end
 
       def next?
-        @offset_next != 0 && @offset_next < @data.size
+        @offset_next && @offset_next > 0 && @offset_next < @data.size
       end
 
       def next
@@ -537,15 +546,16 @@ module EXIFR
 
     private
       def add_field(field)
-        return unless tag = TAG_MAPPING[@type][field.tag]
-        return if @fields[tag]
+        return if @raw_fields.include?(field.tag) # first encountered value wins
+        @raw_fields[field.tag] = field.value
 
-        if IFD_TAGS.include? tag
-          @fields[tag] = IFD.new(@data, field.offset, tag)
-        else
-          value = ADAPTERS[tag][field.value]
-          @fields[tag] = value.kind_of?(Array) && value.size == 1 ? value.first : value
-        end
+        return unless tag = TAG_MAPPING[@type][field.tag]
+        @fields[tag] = if IFD_TAGS.include?(tag)
+                         IFD.new(@data, field.offset, tag)
+                       else
+                         value = ADAPTERS[tag][field.value]
+                         value.kind_of?(Array) && value.size == 1 ? value.first : value
+                       end
       end
     end
 
@@ -595,6 +605,12 @@ module EXIFR
             end
             rationals
           end
+        when 11 # float
+          len, pack = count * 4, proc { |d| d.unpack(data.float + '*') }
+        when 12 # double
+          len, pack = count * 8, proc { |d| d.unpack(data.double + '*') }
+        else
+          return
         end
 
         if len && pack && @type != 7
@@ -627,7 +643,7 @@ module EXIFR
     end
 
     class Data #:nodoc:
-      attr_reader :short, :long, :file
+      attr_reader :short, :long, :float, :double, :file
 
       def initialize(file)
         @io = file.respond_to?(:read) ? file : (@file = File.open(file, 'rb'))
@@ -635,8 +651,8 @@ module EXIFR
         @pos = 0
 
         case self[0..1]
-        when 'II'; @short, @long = 'v', 'V'
-        when 'MM'; @short, @long = 'n', 'N'
+        when 'II'; @short, @long, @float, @double = 'v', 'V', 'e', 'E'
+        when 'MM'; @short, @long, @float, @double = 'n', 'N', 'g', 'G'
         else
           raise MalformedTIFF, "no byte order information found"
         end

data/lib/exifr.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2006-2017 - R.W. van 't Veer
+# Copyright (c) 2006-2020 - R.W. van 't Veer
 
 require 'logger'
 

data/tests/jpeg_test.rb

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 #
-# Copyright (c) 2006-2017 - R.W. van 't Veer
+# Copyright (c) 2006-2020 - R.W. van 't Veer
 
 require 'test_helper'
 
@@ -107,7 +107,7 @@ class JPEGTest < TestCase
     j = JPEG.new(f('exif.jpg'))
     assert j.methods.include?(:date_time)
     assert j.methods(true).include?(:date_time)
-    refute j.methods(false).include?(:date_time)
+    assert ! j.methods(false).include?(:date_time)
   end
 
   def test_multiple_app1

data/tests/test_helper.rb

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 #
-# Copyright (c) 2006-2017 - R.W. van 't Veer
+# Copyright (c) 2006-2020 - R.W. van 't Veer
 
 require 'stringio'
 require 'pp'

data/tests/tiff_test.rb

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 #
-# Copyright (c) 2006-2017 - R.W. van 't Veer
+# Copyright (c) 2006-2020 - R.W. van 't Veer
 
 require 'test_helper'
 
@@ -55,7 +55,7 @@ class TIFFTest < TestCase
   end
 
   def test_dates
-    (all_test_tiffs - [f('weird_date.exif'), f('plain.tif'), f('endless-loop.exif')]).each do |fname|
+    (all_test_tiffs - [f('weird_date.exif'), f('plain.tif'), f('endless-loop.exif'), f('truncated.exif')]).each do |fname|
       assert_kind_of Time, TIFF.new(fname).date_time
     end
     assert_nil TIFF.new(f('weird_date.exif')).date_time
@@ -119,6 +119,10 @@ class TIFFTest < TestCase
     end
   end
 
+  def test_bad_gps
+    assert_nil TIFF.new(f('bad_gps.exif')).gps
+  end
+
   def test_lens_model
     t = TIFF.new(f('sony-a7ii.exif'))
     assert_equal('FE 16-35mm F4 ZA OSS', t.lens_model)
@@ -161,7 +165,12 @@ class TIFFTest < TestCase
     all_test_tiffs.each do |fname|
       t = TIFF.new(fname)
       y = YAML.dump(t)
-      assert_literally_equal t.to_hash, YAML.load(y).to_hash
+      v = if YAML.respond_to?(:unsafe_load)
+            YAML.unsafe_load(y)
+          else
+            YAML.load(y)
+          end
+      assert_literally_equal t.to_hash, v.to_hash
     end
   end
 
@@ -184,6 +193,11 @@ class TIFFTest < TestCase
     assert true
   end
 
+  def test_should_read_truncated
+    TIFF.new(f('truncated.exif'))
+    assert true
+  end
+
   def test_user_comment
     assert_equal("Manassas Battlefield", TIFF.new(f('user-comment.exif')).user_comment)
   end
@@ -204,6 +218,10 @@ class TIFFTest < TestCase
     t = TIFF.new(f('gopro_hd2.exif'))
     assert t.methods.include?(:make)
     assert t.methods(true).include?(:make)
-    refute t.methods(false).include?(:make)
+    assert ! t.methods(false).include?(:make)
+  end
+
+  def test_unknow_field
+    assert_equal [1, 1, 1, 1], TIFF.new(f('plain.tif')).first.raw_fields[0x0153] # TIFF Tag SampleFormat
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: exifr
 version: !ruby/object:Gem::Version
-  version: 1.3.6
+  version: 1.3.10
 platform: ruby
 authors:
 - R.W. van 't Veer
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-02-10 00:00:00.000000000 Z
+date: 2022-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: test-unit
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10'
+        version: '12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10'
+        version: '12'
 description: EXIF Reader is a module to read EXIF from JPEG and TIFF images.
 email: exifr@remworks.net
 executables:
@@ -59,6 +59,7 @@ files:
 - tests/data/Trust-DC3500_MINI.exif
 - tests/data/apple-aperture-1.5.exif
 - tests/data/bad-shutter_speed_value.exif
+- tests/data/bad_gps.exif
 - tests/data/canon-g3.exif
 - tests/data/endless-loop.exif
 - tests/data/exif.jpg
@@ -66,6 +67,7 @@ files:
 - tests/data/gps-altitude.jpg
 - tests/data/gps.exif
 - tests/data/image.jpg
+- tests/data/ios-mspix-milliseconds.jpg
 - tests/data/multiple-app1.jpg
 - tests/data/negative-exposure-bias-value.exif
 - tests/data/nikon_d1x.tif
@@ -73,6 +75,7 @@ files:
 - tests/data/plain.tif
 - tests/data/samsung-sc-02b.jpg
 - tests/data/sony-a7ii.exif
+- tests/data/truncated.exif
 - tests/data/user-comment.exif
 - tests/data/weird_date.exif
 - tests/jpeg_test.rb
@@ -81,8 +84,13 @@ files:
 homepage: http://github.com/remvee/exifr/
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  bug_tracker_uri: https://github.com/remvee/exifr/issues
+  changelog_uri: https://github.com/remvee/exifr/blob/master/CHANGELOG
+  documentation_uri: https://remvee.github.io/exifr/api/
+  homepage_uri: https://remvee.github.io/exifr/
+  source_code_uri: https://github.com/remvee/exifr
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -97,9 +105,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Read EXIF from JPEG and TIFF images
 test_files: []