exifr 1.2.4 → 1.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58dd69f23caf259884c52a2a7fdfcb0ea963b197
-  data.tar.gz: e59b53e2bee8394c31890898700f1647646e88ba
+  metadata.gz: d9ac6553d42bb5f17abdd4092b39c4718ef73036
+  data.tar.gz: 481f598f4ac68d65f36a96979c384a9ae630fa54
 SHA512:
-  metadata.gz: 54e2121231c33fa26cf61bbaf291f46d5aaf6fb1cf0da47919ffe0f42c9155c2b5d9feb42cf9f15fdb6d95b57c88bd659a798d3d3edcf3e3c582df73d752ec6e
-  data.tar.gz: c8e6263af3eabf45425860090e3105acc79661a648d335e3f9be719b34768b396f66634e695ab75841f9bb4a0fdeebe94c2b5d6768f3b5293231c77204440298
+  metadata.gz: 8c0e17c14a6c8b458717459c2aa5397c4520b968319bce43c240a56d8963b34225e0064edafeee3decd9dc287329104a4b792e1d34436696ff2df21b382e7849
+  data.tar.gz: 1765feeb043209fa869f2c19f36ce53559e3e021716d576c608f8d41a3e97119dcd78cf43069d6c81cc61ff26806fa5a593c335fc959b00e286a1c6eb92e1e19

data/CHANGELOG

@@ -1,3 +1,7 @@
+EXIF Reader 1.2.5
+* bug fix; "[GH#46] Having stringified methods is not a good idea"; thanks Filipe Costa
+* bug fix; "Fix typo in subsec_time_original key"; thanks Filipe Costa
+
 EXIF Reader 1.2.4
 * bug fix; "[GH#43] Fix `respond_to?` signature"; thanks Pete Johns
 

data/lib/exifr/jpeg.rb

@@ -57,22 +57,22 @@ module EXIFR
     # +method+ does exist for EXIF data +nil+ will be returned.
     def method_missing(method, *args)
       super unless args.empty?
-      super unless methods.include?(method.to_s)
+      super unless methods.include?(method)
       @exif.send method if defined?(@exif) && @exif
     end
 
     def respond_to?(method, include_all = false) # :nodoc:
-      super || methods.include?(method.to_s) || (include_all && private_methods.include?(method))
+      super || methods.include?(method) || (include_all && private_methods.include?(method))
     end
 
     def methods # :nodoc:
-      super + TIFF::TAGS << "gps"
+      super + TIFF::TAGS << :gps
     end
 
     class << self
       alias instance_methods_without_jpeg_extras instance_methods
       def instance_methods(include_super = true) # :nodoc:
-        instance_methods_without_jpeg_extras(include_super) + TIFF::TAGS << "gps"
+        instance_methods_without_jpeg_extras(include_super) + TIFF::TAGS << :gps
       end
     end
 

data/lib/exifr/tiff.rb

@@ -169,7 +169,7 @@ module EXIFR
         0x927c => :maker_note,
         0x9286 => :user_comment,
         0x9290 => :subsec_time,
-        0x9291 => :subsec_time_orginal,
+        0x9291 => :subsec_time_original,
         0x9292 => :subsec_time_digitized,
         0xa000 => :flashpix_version,
         0xa001 => :color_space,
@@ -366,7 +366,7 @@ module EXIFR
                     })
 
     # Names for all recognized TIFF fields.
-    TAGS = ([TAG_MAPPING.keys, TAG_MAPPING.values.map{|v|v.values}].flatten.uniq - IFD_TAGS).map{|v|v.to_s}
+    TAGS = [TAG_MAPPING.keys, TAG_MAPPING.values.map{|v|v.values}].flatten.uniq - IFD_TAGS
 
     # +file+ is a filename or an +IO+ object.  Hint: use +StringIO+ when working with slurped data like blobs.
     def initialize(file)
@@ -407,7 +407,7 @@ module EXIFR
 
       if @ifds.first.respond_to?(method)
         @ifds.first.send(method)
-      elsif TAGS.include?(method.to_s)
+      elsif TAGS.include?(method)
         @ifds.first.to_hash[method]
       else
         super
@@ -417,7 +417,7 @@ module EXIFR
     def respond_to?(method, include_all = false) # :nodoc:
       super ||
         (defined?(@ifds) && @ifds && @ifds.first && @ifds.first.respond_to?(method, include_all)) ||
-        TAGS.include?(method.to_s)
+        TAGS.include?(method)
     end
 
     def methods # :nodoc:
@@ -477,7 +477,7 @@ module EXIFR
       end
 
       def method_missing(method, *args)
-        super unless args.empty? && TAGS.include?(method.to_s)
+        super unless args.empty? && TAGS.include?(method)
         to_hash[method]
       end
 

data/tests/jpeg_test.rb

@@ -78,11 +78,9 @@ class JPEGTest < TestCase
 
   def test_exif_dispatch
     j = JPEG.new(f('exif.jpg'))
-
-    assert JPEG.instance_methods.include?('date_time')
-    assert j.methods.include?('date_time')
+    assert JPEG.instance_methods.include?(:date_time)
+    assert j.methods.include?(:date_time)
     assert j.respond_to?(:date_time)
-    assert j.respond_to?('date_time')
     assert j.date_time
     assert_kind_of Time, j.date_time
 

data/tests/tiff_test.rb

@@ -16,7 +16,7 @@ class TIFFTest < TestCase
       assert TIFF.new(StringIO.new(File.read(fname)))
     end
   end
-  
+
   def test_raises_malformed_tiff
     begin
       TIFF.new(StringIO.new("djibberish"))
@@ -120,9 +120,8 @@ class TIFFTest < TestCase
 
   def test_ifd_dispatch
     assert @t.respond_to?(:f_number)
-    assert @t.respond_to?('f_number')
-    assert @t.methods.include?('f_number')
-    assert TIFF.instance_methods.include?('f_number')
+    assert @t.methods.include?(:f_number)
+    assert TIFF.instance_methods.include?(:f_number)
 
     assert @t.f_number
     assert_kind_of Rational, @t.f_number
@@ -186,7 +185,7 @@ class TIFFTest < TestCase
   def test_handle_out_of_range_offset
     assert_equal 'NIKON', TIFF.new(f('out-of-range.exif')).make
   end
-  
+
   def test_negative_exposure_bias_value
     assert_equal(-1.quo(3), TIFF.new(f('negative-exposure-bias-value.exif')).exposure_bias_value)
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: exifr
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.5
 platform: ruby
 authors:
 - R.W. van 't Veer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-30 00:00:00.000000000 Z
+date: 2016-07-28 00:00:00.000000000 Z
 dependencies: []
 description: EXIF Reader is a module to read EXIF from JPEG and TIFF images.
 email: remco@remvee.net
@@ -75,7 +75,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Read EXIF from JPEG and TIFF images