exel 1.4.0 → 1.5.1

data/spec/exel/providers/local_file_provider_spec.rb

@@ -1,37 +1,34 @@
 # frozen_string_literal: true
-module EXEL
-  module Providers
-    describe LocalFileProvider do
-      let(:file) { instance_double(File, path: '/path/to/file') }
 
-      describe '#upload' do
-        it 'returns a file:// URI for the file' do
-          expect(subject.upload(file)).to eq('file:///path/to/file')
-        end
-      end
+describe EXEL::Providers::LocalFileProvider do
+  let(:file) { instance_double(File, path: '/path/to/file') }
 
-      describe '#download' do
-        it 'returns the file indicated by the URI' do
-          expect(File).to receive(:open).with('/path/to/file').and_return(file)
-          expect(subject.download('file:///path/to/file')).to eq(file)
-        end
+  describe '#upload' do
+    it 'returns a file:// URI for the file' do
+      expect(subject.upload(file)).to eq('file:///path/to/file')
+    end
+  end
 
-        it 'doesn`t accept URIs for schemes other than file://' do
-          expect { subject.download('s3://') }.to raise_error 'URI must begin with "file://"'
-        end
-      end
+  describe '#download' do
+    it 'returns the file indicated by the URI' do
+      expect(File).to receive(:open).with('/path/to/file').and_return(file)
+      expect(subject.download('file:///path/to/file')).to eq(file)
+    end
 
-      describe '.remote?' do
-        it 'returns true for file:// URIs' do
-          expect(LocalFileProvider.remote?('file:///path/to/file')).to be_truthy
-        end
+    it 'doesn`t accept URIs for schemes other than file://' do
+      expect { subject.download('s3://') }.to raise_error 'URI must begin with "file://"'
+    end
+  end
+
+  describe '.remote?' do
+    it 'returns true for file:// URIs' do
+      expect(EXEL::Providers::LocalFileProvider.remote?('file:///path/to/file')).to be_truthy
+    end
 
-        it 'returns false for anything else' do
-          expect(LocalFileProvider.remote?('s3://file')).to be_falsey
-          expect(LocalFileProvider.remote?(1)).to be_falsey
-          expect(LocalFileProvider.remote?(nil)).to be_falsey
-        end
-      end
+    it 'returns false for anything else' do
+      expect(EXEL::Providers::LocalFileProvider.remote?('s3://file')).to be_falsey
+      expect(EXEL::Providers::LocalFileProvider.remote?(1)).to be_falsey
+      expect(EXEL::Providers::LocalFileProvider.remote?(nil)).to be_falsey
     end
   end
 end

data/spec/exel/providers/threaded_async_provider_spec.rb

@@ -1,54 +1,52 @@
 # frozen_string_literal: true
-module EXEL
-  module Providers
-    class ContextMutatingProcessor
-      def initialize(context)
-        @context = context
-      end
 
-      def process(_block)
-        @context[:array] << @context[:arg]
-      end
-    end
+class ContextMutatingProcessor
+  def initialize(context)
+    @context = context
+  end
 
-    describe ThreadedAsyncProvider do
-      subject { described_class.new(context) }
-      let(:context) { EXEL::Context.new }
+  def process(_block)
+    @context[:array] << @context[:arg]
+  end
+end
 
-      describe '#do_async' do
-        let(:dsl_block) { instance_double(ASTNode) }
+describe EXEL::Providers::ThreadedAsyncProvider do
+  subject { described_class.new(context) }
 
-        it 'runs the block in a new thread' do
-          expect(dsl_block).to receive(:start).with(context)
-          expect(Thread).to receive(:new).and_yield
+  let(:context) { EXEL::Context.new }
 
-          subject.do_async(dsl_block)
-        end
+  describe '#do_async' do
+    let(:dsl_block) { instance_double(EXEL::ASTNode) }
 
-        it 'passes a copy of the context to each thread' do
-          context[:array] = []
-          complete = 0
+    it 'runs the block in a new thread' do
+      expect(dsl_block).to receive(:start).with(context)
+      expect(Thread).to receive(:new).and_yield
 
-          EXEL::Job.define :thread_test do
-            async do
-              process with: ContextMutatingProcessor, arg: 1
-              complete += 1
-            end
-
-            async do
-              process with: ContextMutatingProcessor, arg: 2
-              complete += 1
-            end
-          end
+      subject.do_async(dsl_block)
+    end
 
-          EXEL::Job.run(:thread_test, context)
+    it 'passes a copy of the context to each thread' do
+      context[:array] = []
+      complete = 0
 
-          start_time = Time.now
-          sleep 0.1 while complete < 2 && Time.now - start_time < 2
+      EXEL::Job.define :thread_test do
+        async do
+          process with: ContextMutatingProcessor, arg: 1
+          complete += 1
+        end
 
-          expect(context[:array]).to be_empty
+        async do
+          process with: ContextMutatingProcessor, arg: 2
+          complete += 1
         end
       end
+
+      EXEL::Job.run(:thread_test, context)
+
+      start_time = Time.now
+      sleep 0.1 while complete < 2 && Time.now - start_time < 2
+
+      expect(context[:array]).to be_empty
     end
   end
 end

data/spec/exel/sequence_node_spec.rb

@@ -1,18 +1,18 @@
 # frozen_string_literal: true
-module EXEL
-  describe SequenceNode do
-    subject(:node) { described_class.new(instance_double(ASTNode), instance_double(ASTNode)) }
-    let(:context) { instance_double(EXEL::Context) }
 
-    it { is_expected.to be_an(ASTNode) }
+describe EXEL::SequenceNode do
+  subject(:node) { described_class.new(instance_double(EXEL::ASTNode), instance_double(EXEL::ASTNode)) }
 
-    describe '#run' do
-      it 'runs each child node in sequence' do
-        expect(node.children.first).to receive(:run).with(context).once.ordered
-        expect(node.children.last).to receive(:run).with(context).once.ordered
+  let(:context) { instance_double(EXEL::Context) }
 
-        node.run(context)
-      end
+  it { is_expected.to be_an(EXEL::ASTNode) }
+
+  describe '#run' do
+    it 'runs each child node in sequence' do
+      expect(node.children.first).to receive(:run).with(context).once.ordered
+      expect(node.children.last).to receive(:run).with(context).once.ordered
+
+      node.run(context)
     end
   end
 end

data/spec/exel/value_spec.rb

@@ -1,51 +1,50 @@
 # frozen_string_literal: true
-module EXEL
-  describe Value do
-    let(:uri) { 's3://test_file.csv' }
 
-    before { allow(EXEL).to receive(:remote_provider).and_return(EXEL::Providers::DummyRemoteProvider) }
+describe EXEL::Value do
+  let(:uri) { 's3://test_file.csv' }
 
-    describe '.remotize' do
-      context 'when the value is not a file' do
-        it 'returns the value' do
-          expect(Value.remotize('test')).to eq('test')
-        end
+  before { allow(EXEL).to receive(:remote_provider).and_return(EXEL::Providers::DummyRemoteProvider) }
+
+  describe '.remotize' do
+    context 'when the value is not a file' do
+      it 'returns the value' do
+        expect(EXEL::Value.remotize('test')).to eq('test')
       end
+    end
 
-      [File, Tempfile].each do |file_class|
-        context "when the value is an instance of #{file_class}" do
-          let(:file) { instance_double(file_class) }
+    [File, Tempfile].each do |file_class|
+      context "when the value is an instance of #{file_class}" do
+        let(:file) { instance_double(file_class) }
 
-          before { allow(file).to receive(:is_a?) { |klass| klass == file_class } }
+        before { allow(file).to receive(:is_a?) { |klass| klass == file_class } }
 
-          it 'uploads the file using the remote provider' do
-            expect_any_instance_of(EXEL::Providers::DummyRemoteProvider).to receive(:upload).with(file)
-            Value.remotize(file)
-          end
+        it 'uploads the file using the remote provider' do
+          expect_any_instance_of(EXEL::Providers::DummyRemoteProvider).to receive(:upload).with(file)
+          EXEL::Value.remotize(file)
+        end
 
-          it 'returns the URI of the uploaded file' do
-            allow_any_instance_of(EXEL::Providers::DummyRemoteProvider).to receive(:upload).with(file).and_return(uri)
-            expect(Value.remotize(file)).to eq(uri)
-          end
+        it 'returns the URI of the uploaded file' do
+          allow_any_instance_of(EXEL::Providers::DummyRemoteProvider).to receive(:upload).with(file).and_return(uri)
+          expect(EXEL::Value.remotize(file)).to eq(uri)
         end
       end
     end
+  end
 
-    describe '.localize' do
-      context 'with a local value' do
-        it 'returns the value' do
-          expect(Value.localize('test')).to eq('test')
-        end
+  describe '.localize' do
+    context 'with a local value' do
+      it 'returns the value' do
+        expect(EXEL::Value.localize('test')).to eq('test')
       end
+    end
 
-      context 'with a remote file' do
-        it 'returns the downloaded file' do
-          expect(EXEL::Providers::DummyRemoteProvider).to receive(:remote?).with(uri).and_return(true)
-          file = double(:file)
-          expect_any_instance_of(EXEL::Providers::DummyRemoteProvider).to receive(:download).with(uri).and_return(file)
+    context 'with a remote file' do
+      it 'returns the downloaded file' do
+        expect(EXEL::Providers::DummyRemoteProvider).to receive(:remote?).with(uri).and_return(true)
+        file = double(:file)
+        expect_any_instance_of(EXEL::Providers::DummyRemoteProvider).to receive(:download).with(uri).and_return(file)
 
-          expect(Value.localize(uri)).to eq(file)
-        end
+        expect(EXEL::Value.localize(uri)).to eq(file)
       end
     end
   end

data/spec/exel_spec.rb

@@ -1,5 +1,13 @@
 # frozen_string_literal: true
+
 describe EXEL do
+  after :each do
+    EXEL.configure do |config|
+      config.remote_provider = nil # reset providers to default
+      config.async_provider = nil
+    end
+  end
+
   describe '.async_provider' do
     context 'with no async provider set in the configuration' do
       it 'defaults to ThreadedAsyncProvider' do
@@ -39,11 +47,4 @@ describe EXEL do
       end
     end
   end
-
-  after :each do
-    EXEL.configure do |config|
-      config.remote_provider = nil # reset providers to default
-      config.async_provider = nil
-    end
-  end
 end

data/spec/integration/integration_spec.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
+
 describe EXEL do
   let(:context) { EXEL::Context.new(resource: csv_file, email_service: email_service, delete_resource: false) }
   let(:csv_file) { File.open(File.expand_path('../../fixtures/sample.csv', __FILE__)) }
   let(:email_service) { EmailService.new }
 
-  before :all do
+  before :all do # rubocop:disable RSpec/BeforeAfterAll
     EXEL::Job.define :processing_steps do
       process with: RecordLoader
       process with: EmailProcessor

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
-require 'codeclimate-test-reporter'
-CodeClimate::TestReporter.start
+
+require 'simplecov'
+SimpleCov.start
 
 require 'pry'
 

data/spec/support/integration_test_classes.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
-Person = Struct.new(:name, :email)
+
+class Person < Struct.new(:name, :email)
+end
 
 class RecordLoader
   def initialize(context)

metadata

@@ -1,57 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: exel
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.1
 platform: ruby
 authors:
 - yroo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-04 00:00:00.000000000 Z
+date: 2020-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '13'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10'
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '0.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '0.17'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -123,33 +123,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.7.0
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rubocop-airbnb
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.45.0
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.45.0
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec-focused
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -175,6 +161,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_airbnb.yml"
 - ".rubocop_todo.yml"
 - ".travis.yml"
 - Gemfile
@@ -255,8 +242,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: EXEL, the Elastic eXEcution Language