excon 0.63.0 → 0.64.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ecbc78ef3063e8b2dc33d085e83329c3c412a3b30d691b233ce0636bad20afb1
-  data.tar.gz: a4bd845f630fed088995b6049193aa761cf1369c69d12a515b99c50167086efe
+  metadata.gz: '0089e6e20aad3c735ea51b5dae6b90820b31d1379d2159cb01a2d2ab5e1e0fa8'
+  data.tar.gz: f362e1a3bbedfa71887fcd4c53ef3d202cfe7a337a8d1414396787e8eb160733
 SHA512:
-  metadata.gz: c996e65ff59e3e6b35729645a83fdbd168abdf2eb24658207a969f08574e5cfcedb536f10b5890577e3cd2ce4953c4fcf4c2b511293200cda93e3df6cf012bd3
-  data.tar.gz: 306341ebb5c741ae32e16c72e50726e4832b1788538337fd2029756084e1d16ed9e54057ea42e7734fd3758358b3a957e5ef0421167b66946626d8149a0fb5f7
+  metadata.gz: d03f86c4ec2ab00e8190f462cc21e64709be82820898e3d1ce25229ebbe23a3026939b879a07dffb255e4dadf47a59f103cca6035661f7d361164e78a2144efc
+  data.tar.gz: efecb7088b79a9e951cec7af4ae768addb8ed7bee909bfe6ace5cecbcb7d43cbbcb9846a04feebe6b17c545d20eeefbca8d2733865e0613e93f74cbc8b7f1179

data/changelog.txt

@@ -1,3 +1,8 @@
+0.64.0 2019-04-15
+=================
+
+warn, not error on undefined middlewares#valid_parameter keys
+
 0.63.0 2019-04-12
 =================
 

data/lib/excon/connection.rb

@@ -398,7 +398,16 @@ module Excon
     end
 
     def valid_middleware_keys(middlewares)
-      middlewares.flat_map(&:valid_parameter_keys)
+      middlewares.flat_map do |middleware|
+        if middleware.respond_to?(:valid_parameter_keys)
+          middleware.valid_parameter_keys
+        else
+          Excon.display_warning(
+            "Excon middleware #{middleware} does not define #valid_parameter_keys"
+          )
+          []
+        end
+      end
     end
 
     def validate_params(validation, params, middlewares)

data/lib/excon/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Excon
-  VERSION = '0.63.0'
+  VERSION = '0.64.0'
 end

data/tests/middleware_tests.rb

@@ -0,0 +1,27 @@
+Shindo.tests('Excon middleware') do
+
+  with_rackup('basic.ru', '0.0.0.0') do
+    tests('succeeds without defining valid_parameter_keys') do
+      class Middleware
+        def initialize(stack)
+          @stack = stack
+        end
+        def error_call(datum)
+          @stack.error_call(datum)
+        end
+        def request_call(datum)
+          @stack.request_call(datum)
+        end
+        def response_call(datum)
+          @stack.response_call(datum)
+        end
+      end
+      silence_warnings do
+        Excon.get(
+          'http://127.0.0.1:9292/content-length/100',
+          :middlewares => Excon.defaults[:middlewares] + [Middleware]
+        )
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: excon
 version: !ruby/object:Gem::Version
-  version: 0.63.0
+  version: 0.64.0
 platform: ruby
 authors:
 - dpiddy (Dan Peterson)
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-12 00:00:00.000000000 Z
+date: 2019-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -279,6 +279,7 @@ files:
 - tests/error_tests.rb
 - tests/header_tests.rb
 - tests/instrumentors/logging_instrumentor_tests.rb
+- tests/middleware_tests.rb
 - tests/middlewares/canned_response_tests.rb
 - tests/middlewares/capture_cookies_tests.rb
 - tests/middlewares/decompress_tests.rb