excon 0.5.5 → 0.5.6

data/Rakefile

@@ -43,14 +43,10 @@ end
 #
 #############################################################################
 
-task :default => :test
+require 'shindo/rake'
+Shindo::Rake.new
 
-require 'rake/testtask'
-Rake::TestTask.new(:test) do |test|
-  test.libs << 'lib' << 'tests'
-  test.pattern = 'tests/**/test_*.rb'
-  test.verbose = true
-end
+task :default => :tests
 
 desc "Generate RCov test coverage and open in your browser"
 task :coverage do

data/benchmarks/for_vs_array_each.rb

@@ -0,0 +1,27 @@
+require 'rubygems'
+require 'tach'
+
+data = ["some", "var", "goes", "in", :here, 0]
+Tach.meter(1_000_000) do
+  tach('for') do
+    for element in data
+      element == nil
+    end
+  end
+  tach('each') do
+    data.each do |element|
+      element == nil
+    end
+  end
+end
+
+# ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0]
+# 
+# +------+----------+
+# | tach | total    |
+# +------+----------+
+# | for  | 2.958672 |
+# +------+----------+
+# | each | 2.983550 |
+# +------+----------+
+# 

data/benchmarks/for_vs_hash_each.rb

@@ -0,0 +1,27 @@
+require 'rubygems'
+require 'tach'
+
+data = {"some" => "var", "goes" => "in", :here => 0}
+Tach.meter(1_000_000) do
+  tach('for') do
+    for key, values in data
+      key == values
+    end
+  end
+  tach('each') do
+    data.each do |key, values|
+      key == values
+    end
+  end
+end
+
+# ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0]
+# 
+# +------+----------+
+# | tach | total    |
+# +------+----------+
+# | each | 2.748909 |
+# +------+----------+
+# | for  | 2.949512 |
+# +------+----------+
+#

data/changelog.txt

@@ -1,3 +1,11 @@
+0.5.6 02/19/11
+==============
+
+* only split headers by first ':' to allow for values with ':'. Thanks mtodd!
+* check a string instance for force_encoding, not class. Thanks seancribbs!
+* add benchmarks related to for vs each for enumerable. Thanks caius!
+* fix default rake task to run tests
+
 0.5.5 02/18/11
 ==============
 

data/excon.gemspec

@@ -13,8 +13,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'excon'
-  s.version           = '0.5.5'
-  s.date              = '2011-02-18'
+  s.version           = '0.5.6'
+  s.date              = '2011-02-19'
   s.rubyforge_project = 'excon'
 
   ## Make sure your summary is short. The description may be as long
@@ -54,6 +54,7 @@ Gem::Specification.new do |s|
   ## those that are only needed during development
   # s.add_development_dependency('DEVDEPNAME', [">= 1.1.0", "< 2.0.0"])
   s.add_development_dependency('open4')
+  s.add_development_dependency('rake')
   s.add_development_dependency('shindo', '0.2.0')
   s.add_development_dependency('sinatra')
 
@@ -72,6 +73,8 @@ Gem::Specification.new do |s|
     benchmarks/cr_lf.rb
     benchmarks/downcase-eq-eq_vs_casecmp.rb
     benchmarks/excon_vs.rb
+    benchmarks/for_vs_array_each.rb
+    benchmarks/for_vs_hash_each.rb
     benchmarks/has_key-vs-hash[key].rb
     benchmarks/headers_case_sensitivity.rb
     benchmarks/headers_split_vs_match.rb

data/lib/excon.rb

@@ -13,7 +13,7 @@ require 'excon/response'
 
 module Excon
   unless const_defined?(:VERSION)
-    VERSION = '0.5.5'
+    VERSION = '0.5.6'
   end
 
   unless const_defined?(:CHUNK_SIZE)

data/lib/excon/connection.rb

@@ -4,7 +4,7 @@ module Excon
 
     CR_NL     = "\r\n"
     HTTP_1_1  = " HTTP/1.1\r\n"
-    FORCE_ENC = String.respond_to?(:force_encoding)
+    FORCE_ENC = CR_NL.respond_to?(:force_encoding)
 
     # Initializes a new Connection instance
     #   @param [String] url The destination URL
@@ -67,7 +67,7 @@ module Excon
             when nil
               request << key.to_s << '&'
             when Array
-              for value in values
+              values.each do |value|
                 request << key.to_s << '=' << CGI.escape(value.to_s) << '&'
               end
             else

data/lib/excon/response.rb

@@ -13,7 +13,7 @@ module Excon
       block_given = block_given?
 
       until ((data = socket.readline).chop!).empty?
-        key, value = data.split(': ')
+        key, value = data.split(': ', 2)
         response.headers[key] = value
         if key.casecmp('Content-Length') == 0
           content_length = value.to_i

data/tests/basic_tests.rb

@@ -23,14 +23,18 @@ with_rackup('basic.ru') do
         response.headers['Content-Type']
       end
 
-      test("Time.parse(response.headers['Date']).is_a?(Time)") do
+      tests("Time.parse(response.headers['Date']).is_a?(Time)") do
         Time.parse(response.headers['Date']).is_a?(Time)
       end
 
-      test("!!(response.headers['Server'] =~ /^WEBrick/)") do
+      tests("!!(response.headers['Server'] =~ /^WEBrick/)") do
         !!(response.headers['Server'] =~ /^WEBrick/)
       end
 
+      tests("response.headers['Custom']").returns("Foo: bar") do
+        response.headers['Custom']
+      end
+
       tests("response.body").returns('x' * 100) do
         response.body
       end

data/tests/rackups/basic.ru

@@ -2,6 +2,7 @@ require 'sinatra'
 
 class App < Sinatra::Base
   get '/content-length/:value' do |value|
+    headers "Custom" => "Foo: bar"
     'x' * value.to_i
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: excon
 version: !ruby/object:Gem::Version 
-  hash: 1
+  hash: 7
   prerelease: 
   segments: 
   - 0
   - 5
-  - 5
-  version: 0.5.5
+  - 6
+  version: 0.5.6
 platform: ruby
 authors: 
 - geemus (Wesley Beary)
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-18 00:00:00 -08:00
+date: 2011-02-19 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -33,9 +33,23 @@ dependencies:
   type: :development
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
-  name: shindo
+  name: rake
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: shindo
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -47,11 +61,11 @@ dependencies:
         - 0
         version: 0.2.0
   type: :development
-  version_requirements: *id002
+  version_requirements: *id003
 - !ruby/object:Gem::Dependency 
   name: sinatra
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -61,7 +75,7 @@ dependencies:
         - 0
         version: "0"
   type: :development
-  version_requirements: *id003
+  version_requirements: *id004
 description: EXtended http(s) CONnections
 email: geemus@gmail.com
 executables: []
@@ -81,6 +95,8 @@ files:
 - benchmarks/cr_lf.rb
 - benchmarks/downcase-eq-eq_vs_casecmp.rb
 - benchmarks/excon_vs.rb
+- benchmarks/for_vs_array_each.rb
+- benchmarks/for_vs_hash_each.rb
 - benchmarks/has_key-vs-hash[key].rb
 - benchmarks/headers_case_sensitivity.rb
 - benchmarks/headers_split_vs_match.rb
@@ -130,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: excon
-rubygems_version: 1.4.1
+rubygems_version: 1.4.2
 signing_key: 
 specification_version: 2
 summary: speed, persistence, http(s)