excon 0.44.2 → 0.44.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e4440bcb5b85175c1a67c0ea114d9cb05b7c6cd4
-  data.tar.gz: d0abeae0edd39addfb3ebc467376367acb08b60c
+  metadata.gz: 7bab65841deb9f42b9995536b43ba90f2304bd43
+  data.tar.gz: 4aa257ec3673a05e2e8016cc07a4125ae3ec3a1e
 SHA512:
-  metadata.gz: dcdddbfd539ac3604257cf089722a531a8092e9c2239901568be315891b99d971dbc63f056ce61699598f696ab9e493fcd96deac7bee16381b06637acb6174f8
-  data.tar.gz: f6f0a10e3cb51eac7cd63a09d6331c692bd072756022e554e8c3f344f7a71bac63d6f1cc3209ecffa9a3ace6779d2f2d64b1706d798df93c576bf71dbdfe7ef0
+  metadata.gz: a1f36fccc8ef6fb09ff5d03cb58168fdb8c70bf40d859c3c83966b0fa8a075da12db7a78ae1f90f3e0df5a0e5a9217316fe5ff1c7039b3ba6f32db11dd1d7075
+  data.tar.gz: a350f3e660fbb4d8ee724bfca8e8b36107886f9e9127e0cf8418a0c104d1cde8a3c927f6f10d2c4d5983e81952de64c90779d34ca8462297c014832df0d88b04

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    excon (0.44.2)
+    excon (0.44.3)
 
 GEM
   remote: http://rubygems.org/

data/changelog.txt

@@ -1,3 +1,9 @@
+0.44.3 02/24/2015
+=================
+
+don't pass body when following GET redirects
+fix error rescue case to properly reference error object
+
 0.44.2 02/11/2015
 =================
 

data/excon.gemspec

@@ -13,8 +13,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'excon'
-  s.version           = '0.44.2'
-  s.date              = '2015-02-11'
+  s.version           = '0.44.3'
+  s.date              = '2015-02-24'
   s.rubyforge_project = 'excon'
 
   ## Make sure your summary is short. The description may be as long
@@ -145,6 +145,7 @@ Gem::Specification.new do |s|
     tests/rackups/deflater.ru
     tests/rackups/proxy.ru
     tests/rackups/query_string.ru
+    tests/rackups/redirecting.ru
     tests/rackups/request_headers.ru
     tests/rackups/request_methods.ru
     tests/rackups/response_header.ru

data/lib/excon/constants.rb

@@ -1,6 +1,6 @@
 module Excon
 
-  VERSION = '0.44.2'
+  VERSION = '0.44.3'
 
   CR_NL = "\r\n"
 

data/lib/excon/middlewares/redirect_follower.rb

@@ -17,7 +17,11 @@ module Excon
             params = datum.dup
             params.delete(:stack)
             params.delete(:connection)
-            params[:method] = :get if [301, 302, 303].include? response[:status]
+            if [301, 302, 303].include?(response[:status])
+              params[:method] = :get
+              params.delete(:body)
+              params[:headers].delete('Content-Length')
+            end
             params[:headers] = datum[:headers].dup
             params[:headers].delete('Authorization')
             params[:headers].delete('Proxy-Connection')

data/lib/excon/ssl_socket.rb

@@ -52,7 +52,7 @@ module Excon
           begin
             ssl_context.cert_store.add_file(ca_file)
           rescue
-            Excon.display_warning("Excon unable to add file to cert store, ignoring: #{ca_file}\n[#{e.class}] #{e.message}")
+            Excon.display_warning("Excon unable to add file to cert store, ignoring: #{ca_file}\n[#{$!.class}] #{$!.message}")
           end
         end
 

data/tests/middlewares/redirect_follower_tests.rb

@@ -61,3 +61,20 @@ Shindo.tests('Excon redirect support for relative Location headers') do
 
   env_restore
 end
+
+Shindo.tests("Excon redirecting post request") do
+  env_init
+
+  with_rackup('redirecting.ru') do
+    tests("request not have content-length and body").returns('ok') do
+      Excon.post(
+        'http://127.0.0.1:9292',
+        :path         => '/first',
+        :middlewares  => Excon.defaults[:middlewares] + [Excon::Middleware::RedirectFollower],
+        :body => "a=Some_content"
+      ).body
+    end
+  end
+
+  env_restore
+end

data/tests/rackups/redirecting.ru

@@ -0,0 +1,23 @@
+require 'sinatra'
+require 'json'
+require File.join(File.dirname(__FILE__), 'webrick_patch')
+
+class App < Sinatra::Base
+  set :environment, :production
+  enable :dump_errors
+
+  post('/first') do
+    redirect "/second"
+  end
+
+  get('/second') do
+    post_body = request.body.read
+    if post_body == "" && request["CONTENT_LENGTH"].nil?
+      "ok"
+    else
+      JSON.pretty_generate(request.env)
+    end
+  end
+end
+
+run App

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: excon
 version: !ruby/object:Gem::Version
-  version: 0.44.2
+  version: 0.44.3
 platform: ruby
 authors:
 - dpiddy (Dan Peterson)
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-11 00:00:00.000000000 Z
+date: 2015-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -221,6 +221,7 @@ files:
 - tests/rackups/deflater.ru
 - tests/rackups/proxy.ru
 - tests/rackups/query_string.ru
+- tests/rackups/redirecting.ru
 - tests/rackups/request_headers.ru
 - tests/rackups/request_methods.ru
 - tests/rackups/response_header.ru