excon-hypermedia 0.5.3 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6e498dada7c682834913fd4c4267edd45fe744d2
-  data.tar.gz: 7e399ffe806735ccbf5984ab2d74bcf49646fe68
+  metadata.gz: 669bc2a498c87c5ad49049e6748d550769c991db
+  data.tar.gz: 49120d1428699dabc3dcc2c096222bffcb880372
 SHA512:
-  metadata.gz: 558647f962ced9141ee73e82a83e296d3c88f711cf1b3769f0814ae0b6cfd6cc92ce0814c202fa0f450cf1df1d06cf6e91439f3c765432d96cc20b31c12a60eb
-  data.tar.gz: cc3ad5802a30119dbaead138216298cd371bbf664c1679a1f6a6caaaf6939031cde9b3ea357191bb289d2adadaabccba653af3fa73d00f197556fff8620ca24d
+  metadata.gz: 8d6d2fe1929f0817a262594cc6094e30f569de3630bcefc905ce2df56f093ebd224566db2ef2bebaff5e5627a9b497116a7c6305169bee64ea8d4a5baafd4730
+  data.tar.gz: e5330746ac703d144ba260e18fe77e3d812244482c32f1eff557cca72709dd2962fdfe7b656ffb4731c7f1413706d7398e019c96a0be45a0e818f7e8326eb708

data/.rubocop.yml

@@ -10,4 +10,4 @@ Metrics/LineLength:
   Max: 100
 
 Lint/EndAlignment:
-  AlignWith: variable
+  EnforcedStyleAlignWith: variable

data/.wercker.yml

@@ -6,6 +6,14 @@ ruby-latest:
     name: tests
     code: bundle exec rake
 
+ruby-25:
+  box: ruby:2.5
+  steps:
+  - bundle-install
+  - script:
+    name: tests
+    code: bundle exec rake
+
 ruby-23:
   box: ruby:2.3
   steps:

data/Gemfile

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
+
 source 'https://rubygems.org'
 gemspec

data/README.md

@@ -294,7 +294,7 @@ Excon.defaults[:hcp] = true
 ### shortcuts
 
 While the above examples shows the clean separation between the different
-concepts like `response`, `resource`, `links`, `properties` and `emeds`.
+concepts like `response`, `resource`, `links`, `properties` and `embeds`.
 
 Traversing these objects always starts from the response object. To make moving
 around a bit faster, there are several methods available on the

data/Rakefile

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 require 'rubocop/rake_task'
 
 RuboCop::RakeTask.new do |t|
-  t.options = %w(--display-cop-names --extra-details --display-style-guide)
+  t.options = %w[--display-cop-names --extra-details --display-style-guide]
 end
 
 Rake::TestTask.new(:test) do |t|
@@ -13,4 +14,4 @@ Rake::TestTask.new(:test) do |t|
   t.test_files = FileList['test/**/*_test.rb']
 end
 
-task default: %i(test rubocop)
+task default: %i[test rubocop]

data/excon-hypermedia.gemspec

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # encoding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'excon/hypermedia/version'
@@ -7,25 +8,25 @@ require 'excon/hypermedia/version'
 Gem::Specification.new do |spec|
   spec.name          = 'excon-hypermedia'
   spec.version       = Excon::HyperMedia::VERSION
-  spec.authors       = %w(Jean Mertz)
-  spec.email         = %w(jean@mertz.fm)
+  spec.authors       = %w[Jean Mertz]
+  spec.email         = %w[jean@mertz.fm]
 
   spec.summary       = 'Excon, with Hypermedia traversing baked in.'
   spec.description   = 'Excon, with Hypermedia traversing baked in.'
   spec.homepage      = 'https://github.com/JeanMertz/excon-hypermedia'
   spec.license       = 'MIT'
   spec.files         = `git ls-files -z`.split("\x0")
-  spec.require_paths = %w(lib)
+  spec.require_paths = %w[lib]
 
-  spec.add_development_dependency 'bundler', '~> 1.9'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'minitest', '~> 5.0'
-  spec.add_development_dependency 'rubocop', '~> 0.40'
-  spec.add_development_dependency 'pry', '~> 0.10'
+  spec.add_development_dependency 'bundler', '>= 1.15'
   spec.add_development_dependency 'm', '~> 1.5'
+  spec.add_development_dependency 'minitest', '~> 5.11'
   spec.add_development_dependency 'open4', '~> 1.3'
+  spec.add_development_dependency 'pry', '~> 0.11'
+  spec.add_development_dependency 'rake', '~> 12.3'
+  spec.add_development_dependency 'rubocop', '~> 0.52'
 
   spec.add_dependency 'backport_dig' if RUBY_VERSION < '2.3'
-  spec.add_dependency 'excon', '~> 0.49'
-  spec.add_dependency 'excon-addressable', '~> 0.3'
+  spec.add_dependency 'excon', '~> 0.60'
+  spec.add_dependency 'excon-addressable', '~> 0.4'
 end

data/lib/excon/hypermedia/helpers/collection.rb

@@ -45,10 +45,21 @@ module Excon
       # The second notation returns `nil` on missing keys, the first should do
       # as well.
       #
-      def method_missing(_)
+      def method_missing(_) # rubocop:disable Style/MethodMissing
         nil
       end
 
+      # respond_to_missing?
+      #
+      # Checking if a key exists should be possible using `respond_to?`:
+      #
+      #   collection.respond_to?(:hello_world)
+      #   # => false
+      #
+      def respond_to_missing?(_, _ = false)
+        super
+      end
+
       def to_properties
         collection.each do |key, value|
           key = key.downcase

data/lib/excon/hypermedia/middleware.rb

@@ -5,7 +5,15 @@ require 'backport_dig' if RUBY_VERSION < '2.3'
 Excon.defaults[:middlewares].delete(Excon::Addressable::Middleware)
 Excon.defaults[:middlewares].unshift(Excon::Addressable::Middleware)
 
+# Excon
+#
+# We inject the `expand` key to the allowed lists of keys to be used when
+# creating a request, or connection object. Excon does not enforce this yet, but
+# it does print a warning, so this makes things future-proof.
 module Excon
+  VALID_REQUEST_KEYS.push(:hcp, :embedded, :hypermedia)
+  VALID_CONNECTION_KEYS.push(:hcp, :embedded, :hypermedia)
+
   module HyperMedia
     # Middleware
     #

data/lib/excon/hypermedia/middlewares/hypertext_cache_pattern.rb

@@ -31,7 +31,7 @@ module Excon
           end
 
           super
-        rescue => e
+        rescue StandardError => e
           raise unless e.class == Excon::Errors::StubNotFound
 
           # If a request was made to a non-stubbed resource, don't use the Mock

data/lib/excon/hypermedia/resource_object.rb

@@ -11,7 +11,7 @@ module Excon
     # Represents a resource.
     #
     class ResourceObject
-      RESERVED_PROPERTIES = %w(_links _embedded).freeze
+      RESERVED_PROPERTIES = %w[_links _embedded].freeze
 
       def initialize(data)
         @data = data
@@ -60,6 +60,10 @@ module Excon
       def method_missing(method_name, *_)
         _properties.respond_to?(method_name) ? _properties.send(method_name) : super
       end
+
+      def respond_to_missing?(method_name, _ = false)
+        _properties.respond_to?(method_name) || super
+      end
     end
   end
 end

data/lib/excon/hypermedia/version.rb

@@ -2,6 +2,6 @@
 
 module Excon
   module HyperMedia
-    VERSION = '0.5.3'
+    VERSION = '0.6.0'
   end
 end

data/test/excon/edgecase_test.rb

@@ -45,18 +45,22 @@ module Excon
     end
 
     def test_unknown_property
-      assert_equal nil, api.resource._properties.invalid
-      assert_equal nil, api.resource._properties['invalid']
+      assert_nil api.resource._properties.invalid
+      assert_nil api.resource._properties['invalid']
+    end
+
+    def test_unknown_property_respond_to
+      assert_equal false, api.resource._properties.respond_to?(:invalid)
     end
 
     def test_unknown_link
-      assert_equal nil, empty_json_resource._links.invalid
-      assert_equal nil, empty_json_resource._links['invalid']
+      assert_nil empty_json_resource._links.invalid
+      assert_nil empty_json_resource._links['invalid']
     end
 
     def test_unknown_embed
-      assert_equal nil, api.resource._embedded.invalid
-      assert_equal nil, api.resource._embedded['invalid']
+      assert_nil api.resource._embedded.invalid
+      assert_nil api.resource._embedded['invalid']
     end
   end
 end

data/test/excon/hcp_test.rb

@@ -13,7 +13,7 @@ module Excon
     end
 
     def test_non_hcp_response
-      assert_equal nil, response[:hcp]
+      assert_nil response[:hcp]
     end
 
     def test_hcp_response
@@ -27,19 +27,19 @@ module Excon
     def test_hcp_response_with_missing_embedding
       response = api.rel('product', expand: { uid: 'bicycle' }, hcp: true).get
 
-      assert_equal nil, response[:hcp]
+      assert_nil response[:hcp]
     end
 
     def test_hcp_response_with_embedding_but_missing_embed_for_request
       handlebar = response.rel('handlebar', hcp: true).get
 
-      assert_equal nil, handlebar[:hcp]
+      assert_nil handlebar[:hcp]
     end
 
     def test_hcp_response_with_embedded_array
       wheels = response.rel('wheels', hcp: true)
 
-      assert wheels.map(&:get).all? { |res| res[:hcp] }
+      assert(wheels.map(&:get).all? { |res| res[:hcp] })
     end
 
     def test_nested_hcp_responses

data/test/excon/integration_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # rubocop:disable Metrics/AbcSize
 # rubocop:disable Metrics/LineLength
 
@@ -91,3 +92,6 @@ module Excon
     end
   end
 end
+
+# rubocop:enable Metrics/AbcSize
+# rubocop:enable Metrics/LineLength

data/test/excon/link_object_test.rb

@@ -17,7 +17,7 @@ module Excon
     end
 
     def full
-      <<-EOF
+      <<-JSON
         {
           "href": "https://example.org/goodbye/{receiver}",
           "templated": "true",
@@ -28,7 +28,7 @@ module Excon
           "title": "Goodbye!",
           "hreflang": "en-gb"
         }
-      EOF
+      JSON
     end
 
     def data(name)

data/test/excon/links_test.rb

@@ -9,7 +9,7 @@ module Excon
   #
   class LinksTest < Minitest::Test
     def body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "self": {
@@ -20,7 +20,7 @@ module Excon
             }
           }
         }
-      EOF
+      JSON
     end
 
     def data
@@ -36,7 +36,7 @@ module Excon
     end
 
     def test_link_properties
-      assert_equal %w(self parts), links.to_h.keys
+      assert_equal %w[self parts], links.to_h.keys
     end
   end
 end

data/test/excon/properties_test.rb

@@ -9,7 +9,7 @@ module Excon
   #
   class PropertiesTest < Minitest::Test
     def body
-      <<-EOF
+      <<-JSON
         {
           "size": "49CM",
           "bike-type": "Mountain Bike",
@@ -20,7 +20,7 @@ module Excon
           "reflectors": true,
           "BMX": false
         }
-      EOF
+      JSON
     end
 
     def data

data/test/excon/resource_object_test.rb

@@ -9,7 +9,7 @@ module Excon
   #
   class ResourceObjectTest < Minitest::Test
     def body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "hello": {
@@ -19,7 +19,7 @@ module Excon
           "uid": "universe",
           "hello": "world"
         }
-      EOF
+      JSON
     end
 
     def data
@@ -42,11 +42,16 @@ module Excon
       assert_equal 'universe', resource.uid
       assert_equal 'world', resource.hello
       assert_equal 'world', resource['hello']
-      assert_equal nil, resource['invalid']
+      assert_nil resource['invalid']
     end
 
     def test_correctly_raising_no_method_error
       assert_raises(NoMethodError) { resource.invalid }
     end
+
+    def test_correctly_respond_to
+      assert_equal true, resource.respond_to?(:hello)
+      assert_equal false, resource.respond_to?(:invalid)
+    end
   end
 end

data/test/support/responses.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# rubocop:disable Metrics/MethodLength
+
 # rubocop:disable Metrics/ModuleLength
 
 # :no-doc:
@@ -9,7 +9,7 @@ module Test
     module_function
 
     def api_body
-      <<-EOF
+      <<-JSON
        {
          "_links": {
            "self": {
@@ -21,11 +21,11 @@ module Test
            }
          }
        }
-     EOF
+     JSON
     end
 
     def bicycle_body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "self": {
@@ -58,11 +58,11 @@ module Test
             "wheels": [#{front_wheel_body}, #{rear_wheel_body}]
           }
         }
-      EOF
+      JSON
     end
 
     def handlebar_body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "self": {
@@ -73,11 +73,11 @@ module Test
           "reach": "75mm",
           "bend": "compact"
         }
-      EOF
+      JSON
     end
 
     def pump_body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "self": {
@@ -95,11 +95,11 @@ module Test
           }
 
         }
-      EOF
+      JSON
     end
 
     def parts_body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "self": {
@@ -108,11 +108,11 @@ module Test
           },
           "count": 47
         }
-      EOF
+      JSON
     end
 
     def rear_wheel_body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "self": {
@@ -122,11 +122,11 @@ module Test
           "position": "rear",
           "lacing_pattern": "Radial"
         }
-      EOF
+      JSON
     end
 
     def front_wheel_body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "self": {
@@ -136,7 +136,9 @@ module Test
           "position": "front",
           "lacing_pattern": "Radial/2-Cross"
         }
-      EOF
+      JSON
     end
   end
 end
+
+# rubocop:enable Metrics/ModuleLength

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: excon-hypermedia
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.6.0
 platform: ruby
 authors:
 - Jean
@@ -9,134 +9,134 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-29 00:00:00.000000000 Z
+date: 2018-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '1.15'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '1.15'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: m
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.11'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: open4
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.40'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.40'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
 - !ruby/object:Gem::Dependency
-  name: m
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
-  name: open4
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.52'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.52'
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: '0.60'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: '0.60'
 - !ruby/object:Gem::Dependency
   name: excon-addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.4'
 description: Excon, with Hypermedia traversing baked in.
 email:
 - jean@mertz.fm
@@ -197,7 +197,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Excon, with Hypermedia traversing baked in.