excon-hypermedia 0.5.0 → 0.7.0

data/test/excon/integration_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # rubocop:disable Metrics/AbcSize
 # rubocop:disable Metrics/LineLength
 
@@ -10,20 +11,16 @@ module Excon
   # Verifies the Excon connection consuming HyperMedia APIs.
   #
   class IntegrationTest < HyperMediaTest
-    def api
-      Excon.get('https://www.example.org/api.json')
-    end
-
     def test_request
       response = api.rel('product', expand: { uid: 'bicycle' }).get
 
-      assert response.body.include?('https://www.example.org/product/bicycle')
+      assert response.body.include?('/product/bicycle')
     end
 
     def test_request_using_link_rel
       response = api.resource._links.product.rel(expand: { uid: 'bicycle' }).get
 
-      assert response.body.include?('https://www.example.org/product/bicycle')
+      assert response.body.include?('/product/bicycle')
     end
 
     def test_nested_request
@@ -45,7 +42,7 @@ module Excon
     def test_expand_in_get
       response = api.rel('product').get(expand: { uid: 'bicycle' })
 
-      assert response.body.include?('https://www.example.org/product/bicycle')
+      assert response.body.include?('/product/bicycle')
     end
 
     def test_link
@@ -89,14 +86,12 @@ module Excon
     end
 
     def test_request_with_json_content_type
-      api      = Excon.get('https://www.example.org/api_v2.json', hypermedia: true)
-      response = api.rel('product', expand: { uid: 'bicycle' }).get
+      response = api_v2.rel('product', expand: { uid: 'bicycle' }).get
 
-      assert response.body.include?('https://www.example.org/product/bicycle')
-    end
-
-    def teardown
-      Excon.stubs.clear
+      assert response.body.include?('/product/bicycle')
     end
   end
 end
+
+# rubocop:enable Metrics/AbcSize
+# rubocop:enable Metrics/LineLength

data/test/excon/link_object_test.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:disable Metrics/MethodLength
 
 require_relative '../test_helper'
 
@@ -10,17 +9,17 @@ module Excon
   #
   class LinkTest < Minitest::Test
     def self
-      '{ "href": "https://www.example.org/hello" }'
+      '{ "href": "https://example.org/hello" }'
     end
 
     def templated
-      '{ "href": "https://www.example.org/hello/{receiver}", "templated": "true" }'
+      '{ "href": "https://example.org/hello/{receiver}", "templated": "true" }'
     end
 
     def full
-      <<-EOF
+      <<-JSON
         {
-          "href": "https://www.example.org/goodbye/{receiver}",
+          "href": "https://example.org/goodbye/{receiver}",
           "templated": "true",
           "type": "json",
           "deprecation": true,
@@ -29,7 +28,7 @@ module Excon
           "title": "Goodbye!",
           "hreflang": "en-gb"
         }
-      EOF
+      JSON
     end
 
     def data(name)

data/test/excon/links_test.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:disable Metrics/MethodLength
 
 require_relative '../test_helper'
 
@@ -10,18 +9,18 @@ module Excon
   #
   class LinksTest < Minitest::Test
     def body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "self": {
-              "href": "https://www.example.org/product/bicycle"
+              "href": "https://example.org/product/bicycle"
             },
             "parts": {
-              "href": "https://www.example.org/product/bicycle/parts"
+              "href": "https://example.org/product/bicycle/parts"
             }
           }
         }
-      EOF
+      JSON
     end
 
     def data
@@ -37,7 +36,7 @@ module Excon
     end
 
     def test_link_properties
-      assert_equal %w(self parts), links.to_h.keys
+      assert_equal %w[self parts], links.to_h.keys
     end
   end
 end

data/test/excon/middleware_test.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/AbcSize
+# rubocop:disable Metrics/LineLength
+
+require_relative '../test_helper'
+
+module Excon
+  class MiddlewareTest < Minitest::Test
+    def setup
+      Excon.defaults[:mock] = true
+      Excon.stub(
+        { :path => '/lowercase-content-type' },
+        {
+          headers: { 'content-type' => 'application/hal+json' },
+          body:    '{}',
+          status:  200
+        }
+      )
+      Excon.stub(
+        { :path => '/uppercase-content-type' },
+        {
+          headers: { 'Content-Type' => 'application/hal+json' },
+          body:    '{}',
+          status:  200
+        }
+      )
+    end
+
+    def test_request_with_lowercase_content_type
+      test = Excon.get(
+        'http://example.com',
+        path: '/lowercase-content-type',
+        middlewares: Excon.defaults[:middlewares] + [Excon::HyperMedia::Middleware]
+      )
+
+      assert test.data[:hypermedia]
+    end
+
+    def test_request_with_uppercase_content_type
+      test = Excon.get(
+        'http://example.com',
+        path: '/uppercase-content-type',
+        middlewares: Excon.defaults[:middlewares] + [Excon::HyperMedia::Middleware]
+      )
+
+      assert test.data[:hypermedia]
+    end
+
+    def teardown
+      Excon.stubs.clear
+      Excon.defaults[:mock] = false
+    end
+  end
+end
+
+# rubocop:enable Metrics/AbcSize
+# rubocop:enable Metrics/LineLength

data/test/excon/properties_test.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:disable Metrics/MethodLength
 
 require_relative '../test_helper'
 
@@ -10,7 +9,7 @@ module Excon
   #
   class PropertiesTest < Minitest::Test
     def body
-      <<-EOF
+      <<-JSON
         {
           "size": "49CM",
           "bike-type": "Mountain Bike",
@@ -21,7 +20,7 @@ module Excon
           "reflectors": true,
           "BMX": false
         }
-      EOF
+      JSON
     end
 
     def data

data/test/excon/resource_object_test.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:disable Metrics/MethodLength
 
 require_relative '../test_helper'
 
@@ -10,17 +9,17 @@ module Excon
   #
   class ResourceObjectTest < Minitest::Test
     def body
-      <<-EOF
+      <<-JSON
         {
           "_links": {
             "hello": {
-              "href": "http://www.example.com/hello/{location}"
+              "href": "https://example.org/hello/{location}"
             }
           },
           "uid": "universe",
           "hello": "world"
         }
-      EOF
+      JSON
     end
 
     def data
@@ -43,7 +42,16 @@ module Excon
       assert_equal 'universe', resource.uid
       assert_equal 'world', resource.hello
       assert_equal 'world', resource['hello']
-      assert_equal nil, resource['invalid']
+      assert_nil resource['invalid']
+    end
+
+    def test_correctly_raising_no_method_error
+      assert_raises(NoMethodError) { resource.invalid }
+    end
+
+    def test_correctly_respond_to
+      assert_equal true, resource.respond_to?(:hello)
+      assert_equal false, resource.respond_to?(:invalid)
     end
   end
 end

data/test/excon/response_test.rb

@@ -9,7 +9,7 @@ module Excon
   #
   class ResponseTest < HyperMediaTest
     def response
-      @response ||= Excon.get('https://example.org/product/bicycle')
+      bicycle
     end
 
     def test_response

data/test/support/responses.rb

@@ -0,0 +1,144 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/ModuleLength
+
+# :no-doc:
+module Test
+  # :no-doc:
+  module Response
+    module_function
+
+    def api_body
+      <<-JSON
+       {
+         "_links": {
+           "self": {
+             "href": "http://localhost:8000/api.json"
+           },
+           "product": {
+             "href": "http://localhost:8000/product/{uid}",
+             "templated": true
+           }
+         }
+       }
+     JSON
+    end
+
+    def bicycle_body
+      <<-JSON
+        {
+          "_links": {
+            "self": {
+              "href": "http://localhost:8000/product/bicycle"
+            },
+            "handlebar": {
+              "href": "http://localhost:8000/product/handlebar"
+            },
+            "object_id": {
+              "href": "http://localhost:8000/product/bicycle/object_id_as_text"
+            },
+            "pump": {
+              "href": "http://localhost:8000/product/pump"
+            },
+            "wheels": [
+              { "href": "http://localhost:8000/product/bicycle/wheels/front" },
+              { "href": "http://localhost:8000/product/bicycle/wheels/rear" }
+            ]
+          },
+          "bike-type": "Mountain Bike",
+          "BMX": false,
+          "derailleurs": {
+            "back": 7,
+            "front": 3
+          },
+          "name": "bicycle",
+          "reflectors": true,
+          "_embedded": {
+            "pump": #{pump_body},
+            "wheels": [#{front_wheel_body}, #{rear_wheel_body}]
+          }
+        }
+      JSON
+    end
+
+    def handlebar_body
+      <<-JSON
+        {
+          "_links": {
+            "self": {
+              "href": "http://localhost:8000/product/handlebar"
+            }
+          },
+          "material": "Carbon fiber",
+          "reach": "75mm",
+          "bend": "compact"
+        }
+      JSON
+    end
+
+    def pump_body
+      <<-JSON
+        {
+          "_links": {
+            "self": {
+              "href": "http://localhost:8000/product/pump"
+            },
+            "parts": {
+              "href": "http://localhost:8000/product/pump/parts"
+            }
+          },
+          "weight": "2kg",
+          "type": "Floor Pump",
+          "valve-type": "Presta",
+          "_embedded": {
+            "parts": #{parts_body}
+          }
+
+        }
+      JSON
+    end
+
+    def parts_body
+      <<-JSON
+        {
+          "_links": {
+            "self": {
+              "href": "http://localhost:8000/product/pump/parts"
+            }
+          },
+          "count": 47
+        }
+      JSON
+    end
+
+    def rear_wheel_body
+      <<-JSON
+        {
+          "_links": {
+            "self": {
+              "href": "http://localhost:8000/product/bicycle/wheels/rear"
+            }
+          },
+          "position": "rear",
+          "lacing_pattern": "Radial"
+        }
+      JSON
+    end
+
+    def front_wheel_body
+      <<-JSON
+        {
+          "_links": {
+            "self": {
+              "href": "http://localhost:8000/product/bicycle/wheels/front"
+            }
+          },
+          "position": "front",
+          "lacing_pattern": "Radial/2-Cross"
+        }
+      JSON
+    end
+  end
+end
+
+# rubocop:enable Metrics/ModuleLength

data/test/support/server.rb

@@ -0,0 +1,35 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require 'webrick'
+require 'logger'
+require_relative 'responses'
+
+server = WEBrick::HTTPServer.new(Port: 8000, Logger: Logger.new(STDERR))
+
+def body(name)
+  Test::Response.send("#{name}_body")
+end
+
+endpoints = {
+  '/empty_json' => { body: '{}' },
+  '/api.json' => { body: body(:api) },
+  '/product/bicycle' => { body: body(:bicycle) },
+  '/product/bicycle/wheels/front' => { body: body(:front_wheel) },
+  '/product/bicycle/wheels/rear' => { body: body(:rear_wheel) },
+  '/product/pump' => { body: body(:pump) },
+  '/product/pump/parts' => { body: body(:parts) },
+  '/product/handlebar' => { body: body(:handlebar) },
+  '/api_v2.json' => { body: body(:api), headers: { 'Content-Type' => 'application/json' } }
+}
+
+endpoints.each do |path, params|
+  server.mount_proc(path) do |_, response|
+    response['Content-Type'] = 'application/hal+json'
+    params[:headers].to_h.each { |k, v| response[k] = v }
+
+    response.body = params[:body]
+  end
+end
+
+server.start